gerrit-hooks has posted comments on this change.
Change subject: hooks: ovs: fix getVdsCaps and getVdsStats
..
Patch Set 2:
* #1234867::Update tracker: OK
* Check Bug-Url::OK
* Check Public Bug::#1234867::OK, public bug
* Check
Petr Horáček has posted comments on this change.
Change subject: hooks: ovs: use six.iteritems and six.itervalues
..
Patch Set 2: Verified+1
passed ovs tests without a regression
--
To view, visit https://gerrit.ovirt.org/496
Nir Soffer has posted comments on this change.
Change subject: VolumeMetadata: Move recheckIfLeaf into *Metadata class
..
Patch Set 24: Code-Review-1
Missing redirection tests
--
To view, visit https://gerrit.ovirt.org/41850
Nir Soffer has posted comments on this change.
Change subject: VolumeMetadata: Move isLeaf, setLeaf and dependencies
..
Patch Set 27:
Adam, can you ack this?
--
To view, visit https://gerrit.ovirt.org/41849
To unsubscribe, vi
Nir Soffer has posted comments on this change.
Change subject: VolumeMetadata: Move isLeaf, setLeaf and dependencies
..
Patch Set 27: Code-Review+2 Continuous-Integration+1 Verified+1
CI failure is not relevant.
Verified on rh
gerrit-hooks has posted comments on this change.
Change subject: hooks: ovs: add script name to log
..
Patch Set 2:
* #1234867::Update tracker: OK
* Check Bug-Url::OK
* Check Public Bug::#1234867::OK, public bug
* Check Product
gerrit-hooks has posted comments on this change.
Change subject: hooks: ovs: use six.iteritems and six.itervalues
..
Patch Set 2:
* #1234867::Update tracker: OK
* Check Bug-Url::OK
* Check Public Bug::#1234867::OK, public bug
*
Petr Horáček has posted comments on this change.
Change subject: hooks: ovs: add script name to log
..
Patch Set 2: Verified+1
passed ovs tests without a regression
--
To view, visit https://gerrit.ovirt.org/49696
To unsubscr
gerrit-hooks has posted comments on this change.
Change subject: VolumeMetadata: Move recheckIfLeaf into *Metadata class
..
Patch Set 24:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make
gerrit-hooks has posted comments on this change.
Change subject: VolumeMetadata: Move isLeaf, setLeaf and dependencies
..
Patch Set 27:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make su
Nir Soffer has posted comments on this change.
Change subject: coverage: Add vdsm-coverage sub package
..
Patch Set 1: Verified+1
Tested on rhel 7.2.
Debian build not updated yet, planned for future patch.
--
To view, visit
gerrit-hooks has posted comments on this change.
Change subject: coverage: Add vdsm-coverage sub package
..
Patch Set 1:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header match
Nir Soffer has uploaded a new change for review.
Change subject: coverage: Add vdsm-coverage sub package
..
coverage: Add vdsm-coverage sub package
Add vdsm-coverage package installing support files for creating code
coverage re
gerrit-hooks has posted comments on this change.
Change subject: Introduce VolumeArtifacts
..
Patch Set 4:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: '
Nir Soffer has posted comments on this change.
Change subject: VolumeMetadata: Move recheckIfLeaf into *Metadata class
..
Patch Set 23: Code-Review-1
Version 23 uploaded by mistake, need to upload version 22 again.
--
To view
Nir Soffer has posted comments on this change.
Change subject: VolumeMetadata: Move isLeaf, setLeaf and dependencies
..
Patch Set 26: Code-Review-1
Version 26 uploaded by mistake, need to upload version 25 again.
--
To view,
gerrit-hooks has posted comments on this change.
Change subject: storage: Split newMetadata into makeMetadata and createMetadata
..
Patch Set 7:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found
gerrit-hooks has posted comments on this change.
Change subject: Introduce VolumeArtifacts
..
Patch Set 3:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: '
gerrit-hooks has posted comments on this change.
Change subject: fileVolume: refactor _putMetadata to support volume artifacts
..
Patch Set 2:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found,
gerrit-hooks has posted comments on this change.
Change subject: fileVolume: define file extension for volume artifacts metadata
..
Patch Set 2:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found
gerrit-hooks has posted comments on this change.
Change subject: StorageDomain: Add get_manifest
..
Patch Set 8:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-
gerrit-hooks has posted comments on this change.
Change subject: VolumeMetadata: Move getParentVolume
..
Patch Set 11:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches
gerrit-hooks has posted comments on this change.
Change subject: VolumeMetadata: volume share utilities
..
Patch Set 22:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header match
gerrit-hooks has posted comments on this change.
Change subject: VolumeMetadata: Move getImageVolumes
..
Patch Set 11:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches
Adam Litke has posted comments on this change.
Change subject: VolumeMetadata: move refreshVolume
..
Patch Set 21:
(1 comment)
https://gerrit.ovirt.org/#/c/42003/21/vdsm/storage/blockVolume.py
File vdsm/storage/blockVolume.py:
gerrit-hooks has posted comments on this change.
Change subject: VolumeMetadata: move getVolumeSize
..
Patch Set 22:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches '
gerrit-hooks has posted comments on this change.
Change subject: VolumeMetadata: Move isLeaf, setLeaf and dependencies
..
Patch Set 26:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make su
gerrit-hooks has posted comments on this change.
Change subject: VolumeMetadata: Move simple metadata getters and setters
..
Patch Set 21:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make
gerrit-hooks has posted comments on this change.
Change subject: VolumeMetadata: move newMetadata
..
Patch Set 22:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bu
gerrit-hooks has posted comments on this change.
Change subject: VolumeMetadata: Move recheckIfLeaf into *Metadata class
..
Patch Set 23:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make
gerrit-hooks has posted comments on this change.
Change subject: VolumeMetadata: move newVolumeLease
..
Patch Set 22:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches
gerrit-hooks has posted comments on this change.
Change subject: VolumeMetadata: move validateDelete
..
Patch Set 22:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches
gerrit-hooks has posted comments on this change.
Change subject: VolumeMetadata: Move getInfo and getVolumeParams
..
Patch Set 22:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure he
gerrit-hooks has posted comments on this change.
Change subject: VolumeMetadata: move refreshVolume
..
Patch Set 22:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches '
Adam Litke has posted comments on this change.
Change subject: StorageDomain: Add get_manifest
..
Patch Set 7:
(1 comment)
https://gerrit.ovirt.org/#/c/44566/7/vdsm/storage/sd.py
File vdsm/storage/sd.py:
Line 504
Line 505
Lin
Nir Soffer has submitted this change and it was merged.
Change subject: sdm: Create the storage/sdm directory
..
sdm: Create the storage/sdm directory
New SDM code including the verbs and supporting utility functions need
an or
gerrit-hooks has posted comments on this change.
Change subject: sdm: Create the storage/sdm directory
..
Patch Set 3:
* Update tracker: IGNORE, no Bug-Url found
* Set MODIFIED::IGNORE, no Bug-Url found.
--
To view, visit htt
Nir Soffer has posted comments on this change.
Change subject: sdm: Create the storage/sdm directory
..
Patch Set 2: Code-Review+2
--
To view, visit https://gerrit.ovirt.org/49686
To unsubscribe, visit https://gerrit.ovirt.org
Nir Soffer has submitted this change and it was merged.
Change subject: StorageDomainManifest: Manifest objects produce VolumeMetadata
objects
..
StorageDomainManifest: Manifest objects produce VolumeMetadata objects
StorageDo
gerrit-hooks has posted comments on this change.
Change subject: StorageDomainManifest: Manifest objects produce VolumeMetadata
objects
..
Patch Set 10:
* Update tracker: IGNORE, no Bug-Url found
* Set MODIFIED::IGNORE, no Bug
Adam Litke has posted comments on this change.
Change subject: StorageDomainManifest: Manifest objects produce VolumeMetadata
objects
..
Patch Set 9: Verified+1
Verified by testing LSM and live merge with a patched vdsm.
--
Petr Horáček has posted comments on this change.
Change subject: net: ovs: remove initial nic ip, dont touch unchanged networks
..
Patch Set 2: Verified+1
passed ovs tests without a regression
--
To view, visit https://gerrit
gerrit-hooks has posted comments on this change.
Change subject: net: ovs: remove initial nic ip, dont touch unchanged networks
..
Patch Set 2:
* #1234867::Update tracker: OK
* Check Bug-Url::OK
* Check Public Bug::#1234867::OK
gerrit-hooks has posted comments on this change.
Change subject: Adding python3 run for nosetests
..
Patch Set 22:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bu
Petr Horáček has posted comments on this change.
Change subject: net: Mapping bonding option value names to numerics
..
Patch Set 12: Code-Review-1
(8 comments)
nit
https://gerrit.ovirt.org/#/c/49390/12/init/vdsmd_init_common
Petr Horáček has posted comments on this change.
Change subject: hooks: ovs: pass ip configuration as a namedtuple
..
Patch Set 2: Verified+1
passed ovs tests without a regression
--
To view, visit https://gerrit.ovirt.org/49
Nir Soffer has posted comments on this change.
Change subject: StorageDomainManifest: Manifest objects produce VolumeMetadata
objects
..
Patch Set 9: Code-Review+2
--
To view, visit https://gerrit.ovirt.org/44040
To unsubscri
gerrit-hooks has posted comments on this change.
Change subject: hooks: ovs: pass ip configuration as a namedtuple
..
Patch Set 2:
* #1234867::Update tracker: OK
* Check Bug-Url::OK
* Check Public Bug::#1234867::OK, public bug
Nir Soffer has posted comments on this change.
Change subject: lib: executor: report worker status in __repr__
..
Patch Set 1:
(1 comment)
https://gerrit.ovirt.org/#/c/49722/1/lib/vdsm/executor.py
File lib/vdsm/executor.py:
L
Petr Horáček has posted comments on this change.
Change subject: hooks: ovs: better rollback
..
Patch Set 2: Verified+1
passed ovs tests without a regression, testSetupNetworksConnectivityCheck
passes now
--
To view, visit h
gerrit-hooks has posted comments on this change.
Change subject: hooks: ovs: better rollback
..
Patch Set 2:
* #1234867::Update tracker: OK
* Check Bug-Url::OK
* Check Public Bug::#1234867::OK, public bug
* Check Product::#1234
gerrit-hooks has posted comments on this change.
Change subject: StorageDomainManifest: Manifest objects produce VolumeMetadata
objects
..
Patch Set 9:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug u
Adam Litke has posted comments on this change.
Change subject: StorageDomainManifest: Manifest objects produce VolumeMetadata
objects
..
Patch Set 8: Verified-1
Oops. Have to fix up the sdm_indirection_tests.
--
To view, vi
Petr Horáček has posted comments on this change.
Change subject: hooks: ovs: remove unused parameter
..
Patch Set 2: Verified+1
passed network and OVS tests without a regression
--
To view, visit https://gerrit.ovirt.org/4969
Petr Horáček has posted comments on this change.
Change subject: hooks: ovs: move libvirt configuration into a separate module
..
Patch Set 2: Verified+1
passed network and OVS tests without a regression
--
To view, visit htt
Nir Soffer has posted comments on this change.
Change subject: StorageDomainManifest: Manifest objects produce VolumeMetadata
objects
..
Patch Set 8: Code-Review+2
Thanks! can you check and report why jenkins is not happy?
--
Francesco Romani has posted comments on this change.
Change subject: lib: executor: report worker status in __repr__
..
Patch Set 1:
Rerun-Hooks: all
--
To view, visit https://gerrit.ovirt.org/49722
To unsubscribe, visit http
gerrit-hooks has posted comments on this change.
Change subject: lib: executor: report worker status in __repr__
..
Patch Set 1:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure head
Francesco Romani has posted comments on this change.
Change subject: lib: executor: report worker status in __repr__
..
Patch Set 1:
bogus jenkins failure, retrying:
00:08:56.214
==
Francesco Romani has posted comments on this change.
Change subject: vdsm: introduce cpuinfo module
..
Patch Set 15:
few comments to improve
--
To view, visit https://gerrit.ovirt.org/46912
To unsubscribe, visit https://gerri
Francesco Romani has posted comments on this change.
Change subject: vdsm: introduce cpuinfo module
..
Patch Set 15:
(2 comments)
https://gerrit.ovirt.org/#/c/46912/15/lib/vdsm/cpuarch.py
File lib/vdsm/cpuarch.py:
Line 74: ta
Adam Litke has posted comments on this change.
Change subject: StorageDomainManifest: Manifest objects produce VolumeMetadata
objects
..
Patch Set 7:
(1 comment)
https://gerrit.ovirt.org/#/c/44040/7//COMMIT_MSG
Commit Message
gerrit-hooks has posted comments on this change.
Change subject: StorageDomainManifest: Manifest objects produce VolumeMetadata
objects
..
Patch Set 8:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug u
gerrit-hooks has posted comments on this change.
Change subject: hooks: ovs: move libvirt configuration into a separate module
..
Patch Set 2:
* #1234867::Update tracker: OK
* Check Bug-Url::OK
* Check Public Bug::#1234867::OK,
gerrit-hooks has posted comments on this change.
Change subject: lib: executor: log pool status on discard
..
Patch Set 7:
* #1250839::Update tracker: OK
* Check Bug-Url::OK
* Check Public Bug::#1250839::OK, public bug
* Check
Francesco Romani has uploaded a new change for review.
Change subject: lib: executor: report worker status in __repr__
..
lib: executor: report worker status in __repr__
To make the troubleshooting of stuck workers
easier, we ex
gerrit-hooks has posted comments on this change.
Change subject: lib: executor: report worker status in __repr__
..
Patch Set 1:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure head
gerrit-hooks has posted comments on this change.
Change subject: hooks: ovs: remove unused parameter
..
Patch Set 2:
* #1234867::Update tracker: OK
* Check Bug-Url::OK
* Check Public Bug::#1234867::OK, public bug
* Check Produc
Petr Horáček has posted comments on this change.
Change subject: hooks: Open vSwitch configurator
..
Patch Set 2: Verified+1
Passed network tests OK, OVS tests passed with a few expected fails.
--
To view, visit https://gerri
gerrit-hooks has posted comments on this change.
Change subject: net: multicast snooping is not supported by ovs until 2.4.0
..
Patch Set 2:
* #1234867::Update tracker: OK
* Check Bug-Url::OK
* Check Public Bug::#1234867::OK, p
Petr Horáček has posted comments on this change.
Change subject: net: multicast snooping is not supported by ovs until 2.4.0
..
Patch Set 2: Verified+1
Just a comment
--
To view, visit https://gerrit.ovirt.org/49690
To unsubs
gerrit-hooks has posted comments on this change.
Change subject: hooks: Open vSwitch configurator
..
Patch Set 2:
* #1234867::Update tracker: OK
* Check Bug-Url::OK
* Check Public Bug::#1234867::OK, public bug
* Check Product::
Petr Horáček has posted comments on this change.
Change subject: licenses: update license years in changed files
..
Patch Set 1:
used script https://github.com/phoracek/droids/blob/master/happy_new_year.sh
--
To view, visit h
Francesco Romani has abandoned this change.
Change subject: vm: add support for "Crashed" event
..
Abandoned
on hold, not sure we want to fix this on 3.5.x/x86
--
To view, visit https://gerrit.ovirt.org/49674
To unsubscribe,
gerrit-hooks has posted comments on this change.
Change subject: vm: more robust support of event strings
..
Patch Set 2:
* #1288513::Update tracker: OK
--
To view, visit https://gerrit.ovirt.org/49675
To unsubscribe, visit h
Petr Horáček has posted comments on this change.
Change subject: licenses: rename Hat and RedHat to Red Hat
..
Patch Set 1:
used script https://github.com/phoracek/droids/blob/master/we_are_red_hat.sh
--
To view, visit https:
Francesco Romani has posted comments on this change.
Change subject: lib: executor: log pool status on discard
..
Patch Set 6:
Nir, it's a neat idea. Will post a new patch to implement this.
--
To view, visit https://gerrit.o
Francesco Romani has abandoned this change.
Change subject: vm: reformat _EVENT_STRINGS
..
Abandoned
on hold, not sure we want to fix this on 3.5.x/x86
--
To view, visit https://gerrit.ovirt.org/49673
To unsubscribe, visit ht
Francesco Romani has abandoned this change.
Change subject: vm: more robust support of event strings
..
Abandoned
on hold, not sure we want to fix this on 3.5.x/x86
--
To view, visit https://gerrit.ovirt.org/49675
To unsubscr
gerrit-hooks has posted comments on this change.
Change subject: vm: reformat _EVENT_STRINGS
..
Patch Set 2:
* #1288513::Update tracker: OK
--
To view, visit https://gerrit.ovirt.org/49673
To unsubscribe, visit https://gerrit
gerrit-hooks has posted comments on this change.
Change subject: vm: add support for "Crashed" event
..
Patch Set 2:
* #1288513::Update tracker: OK
--
To view, visit https://gerrit.ovirt.org/49674
To unsubscribe, visit https:
gerrit-hooks has posted comments on this change.
Change subject: licenses: update license years in changed files
..
Patch Set 1:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure head
gerrit-hooks has posted comments on this change.
Change subject: licenses: rename Hat and RedHat to Red Hat
..
Patch Set 1:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header ma
Petr Horáček has uploaded a new change for review.
Change subject: licenses: rename Hat and RedHat to Red Hat
..
licenses: rename Hat and RedHat to Red Hat
Tell me if Hat is another company.
Change-Id: Ib719089dd9a8172e8005de3b
Nir Soffer has posted comments on this change.
Change subject: lib: executor: log pool status on discard
..
Patch Set 6:
Francesco, I think we should show the state of the worker in its __repr__ -
when you see the set of worke
Nir Soffer has posted comments on this change.
Change subject: lib: executor: log pool status on discard
..
Patch Set 6:
Waiting for Dan
--
To view, visit https://gerrit.ovirt.org/48333
To unsubscribe, visit https://gerrit.ov
Nir Soffer has posted comments on this change.
Change subject: lib: executor: log pool status on discard
..
Patch Set 6: Code-Review+2
--
To view, visit https://gerrit.ovirt.org/48333
To unsubscribe, visit https://gerrit.ovirt
Francesco Romani has posted comments on this change.
Change subject: lib: executor: log pool status on discard
..
Patch Set 6: Verified+1
here's how it looks:
vdsm.Scheduler::DEBUG::2015-12-04
15:35:19,223::executor::215::Exe
Adam Litke has posted comments on this change.
Change subject: sdm: Create the storage/sdm directory
..
Patch Set 2: Verified+1
--
To view, visit https://gerrit.ovirt.org/49686
To unsubscribe, visit https://gerrit.ovirt.org/se
Adam Litke has posted comments on this change.
Change subject: sdm: Create the storage/sdm directory
..
Patch Set 1:
(1 comment)
https://gerrit.ovirt.org/#/c/49686/1/vdsm/storage/sdm/__init__.py
File vdsm/storage/sdm/__init__.
gerrit-hooks has posted comments on this change.
Change subject: sdm: Create the storage/sdm directory
..
Patch Set 2:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches
Petr Horáček has posted comments on this change.
Change subject: hooks: after_network_setup_fail
..
Patch Set 1: Verified+1
Passed network tests plus verified with hook:
#!/bin/python
import hooking
with open('/tmp
Petr Horáček has posted comments on this change.
Change subject: net: sysctl: enable ipv6
..
Patch Set 1: Verified+1
Passed network tests. Jenkins' 'JsonRpcNoResponseError: [-32605] No response
for JSON-RPC echo request.' is o
gerrit-hooks has posted comments on this change.
Change subject: VolumeMetadata: Move recheckIfLeaf into *Metadata class
..
Patch Set 22:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make
gerrit-hooks has posted comments on this change.
Change subject: vm: more robust support of event strings
..
Patch Set 2:
* #1288513::Update tracker: OK
* Check Bug-Url::OK
* Check Public Bug::#1288513::OK, public bug
* Check P
gerrit-hooks has posted comments on this change.
Change subject: vm: add support for "Crashed" event
..
Patch Set 2:
* #1288513::Update tracker: OK
* Check Bug-Url::OK
* Check Public Bug::#1288513::OK, public bug
* Check Produc
gerrit-hooks has posted comments on this change.
Change subject: vm: reformat _EVENT_STRINGS
..
Patch Set 2:
* #1288513::Update tracker: OK
* Check Bug-Url::OK
* Check Public Bug::#1288513::OK, public bug
* Check Product::#1288
Nir Soffer has posted comments on this change.
Change subject: VolumeMetadata: Move isLeaf, setLeaf and dependencies
..
Patch Set 25:
This version adds the missing redirection tests.
--
To view, visit https://gerrit.ovirt.org
gerrit-hooks has posted comments on this change.
Change subject: VolumeMetadata: Move isLeaf, setLeaf and dependencies
..
Patch Set 25:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make su
Francesco Romani has posted comments on this change.
Change subject: vdsm: introduce cpuinfo module
..
Patch Set 15:
Michal, good point. One thing we should document is where and why we follow
libvirt's or Engine's convention
1 - 100 of 151 matches
Mail list logo
