Dan Kenigsberg has posted comments on this change.
Change subject: hooks: ovs: skip non-vNic device's XML
..
Patch Set 6: Code-Review+2
--
To view, visit https://gerrit.ovirt.org/49183
To unsubscribe, visit
Dan Kenigsberg has submitted this change and it was merged.
Change subject: hooks: ovs: skip non-vNic device's XML
..
hooks: ovs: skip non-vNic device's XML
If other than a vNic device is passed to OVS hook's
Dan Kenigsberg has posted comments on this change.
Change subject: hooks: ovs: run ovs _configure only if there are changes to do
..
Patch Set 2: Code-Review+2
--
To view, visit https://gerrit.ovirt.org/49245
To unsubscribe,
gerrit-hooks has posted comments on this change.
Change subject: hooks: ovs: skip non-vNic device's XML
..
Patch Set 7:
* Update tracker: IGNORE, no Bug-Url found
* Set MODIFIED::IGNORE, no Bug-Url found.
--
To view, visit
Edward Haas has posted comments on this change.
Change subject: tests: modprobe validation handle failure
..
Patch Set 3: Verified+1
--
To view, visit https://gerrit.ovirt.org/49538
To unsubscribe, visit
gerrit-hooks has posted comments on this change.
Change subject: tests: modprobe validation handle failure
..
Patch Set 3:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header
Dan Kenigsberg has submitted this change and it was merged.
Change subject: net: split netinfo module
..
net: split netinfo module
netinfo module is now split into several submodules and converted into a
package. A few major
Dan Kenigsberg has posted comments on this change.
Change subject: net: split netinfo module
..
Patch Set 14: Code-Review+2
--
To view, visit https://gerrit.ovirt.org/49198
To unsubscribe, visit
gerrit-hooks has posted comments on this change.
Change subject: net: split netinfo module
..
Patch Set 15:
* Update tracker: IGNORE, no Bug-Url found
* Set MODIFIED::IGNORE, no Bug-Url found.
--
To view, visit
Edward Haas has posted comments on this change.
Change subject: tests: modprobe validation handle failure
..
Patch Set 2: Verified+1
(1 comment)
https://gerrit.ovirt.org/#/c/49538/2/tests/modprobe.py
File tests/modprobe.py:
gerrit-hooks has posted comments on this change.
Change subject: vm: adding xpath property to device Base class
..
Patch Set 2:
* #1134256::Update tracker: OK
--
To view, visit https://gerrit.ovirt.org/49554
To unsubscribe,
Marcin Mirecki has abandoned this change.
Change subject: vm: adding xpath property to device Base class
..
Abandoned
No longer needed.
--
To view, visit https://gerrit.ovirt.org/49554
To unsubscribe, visit
Dan Kenigsberg has submitted this change and it was merged.
Change subject: hooks: ovs: run ovs _configure only if there are changes to do
..
hooks: ovs: run ovs _configure only if there are changes to do
Change-Id:
gerrit-hooks has posted comments on this change.
Change subject: hooks: ovs: run ovs _configure only if there are changes to do
..
Patch Set 3:
* Update tracker: IGNORE, no Bug-Url found
* Set MODIFIED::IGNORE, no Bug-Url
Dan Kenigsberg has posted comments on this change.
Change subject: hooks: ovs: remove removed tests from 'does_not_use_ovs'
dictionary
..
Patch Set 2: Code-Review+2
--
To view, visit https://gerrit.ovirt.org/49334
To
Dan Kenigsberg has submitted this change and it was merged.
Change subject: hooks: ovs: remove removed tests from 'does_not_use_ovs'
dictionary
..
hooks: ovs: remove removed tests from 'does_not_use_ovs' dictionary
A few
gerrit-hooks has posted comments on this change.
Change subject: hooks: ovs: remove removed tests from 'does_not_use_ovs'
dictionary
..
Patch Set 3:
* Update tracker: IGNORE, no Bug-Url found
* Set MODIFIED::IGNORE, no
Francesco Romani has posted comments on this change.
Change subject: virt: run hook before_device_create on every device
..
Patch Set 2: Code-Review-1
-1 for visibility, I don't actually have strong feelings against this
Francesco Romani has abandoned this change.
Change subject: virt: cosmetic fixes
..
Abandoned
will post focused patches later
--
To view, visit https://gerrit.ovirt.org/44797
To unsubscribe, visit
gerrit-hooks has posted comments on this change.
Change subject: vm: add test for nic unplug wait
..
Patch Set 2:
* #1134256::Update tracker: OK
* Check Bug-Url::OK
* Check Public Bug::#1134256::OK, public bug
* Check
gerrit-hooks has posted comments on this change.
Change subject: vm: move device attached check to device itself
..
Patch Set 2:
* #1134256::Update tracker: OK
* Check Bug-Url::OK
* Check Public Bug::#1134256::OK, public bug
*
Marcin Mirecki has posted comments on this change.
Change subject: vm: add test for nic unplug wait
..
Patch Set 2:
Reordered.
The order in master was first moving the device_attached, and then the nic
tests.
--
To view,
gerrit-hooks has posted comments on this change.
Change subject: virt: cosmetic fixes
..
Patch Set 32:
* Update tracker: IGNORE, no Bug-Url found
--
To view, visit https://gerrit.ovirt.org/44797
To unsubscribe, visit
gerrit-hooks has posted comments on this change.
Change subject: DONTMERGE virt: use "run_async" helper
..
Patch Set 2:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header
gerrit-hooks has posted comments on this change.
Change subject: virt: add run_async helper
..
Patch Set 3:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url:
Petr Horáček has posted comments on this change.
Change subject: net: move network library under lib/vdsm
..
Patch Set 11:
(2 comments)
nit and a question. i guess dan's -1 in not relevant anymore
Nir Soffer has posted comments on this change.
Change subject: vm: add test for nic unplug wait
..
Patch Set 2: Code-Review+1
--
To view, visit https://gerrit.ovirt.org/49671
To unsubscribe, visit
Milan Zamazal has posted comments on this change.
Change subject: virt: add run_async helper
..
Patch Set 3:
(5 comments)
Documentation better now, I still suggest some fixes run_async docstring, see
the comments.
gerrit-hooks has posted comments on this change.
Change subject: net: move tc library under lib/vdsm
..
Patch Set 11:
* Update tracker: IGNORE, no Bug-Url found
* Set MODIFIED::IGNORE, no Bug-Url found.
--
To view, visit
gerrit-hooks has posted comments on this change.
Change subject: net: move network library under lib/vdsm
..
Patch Set 11:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header
Dan Kenigsberg has submitted this change and it was merged.
Change subject: net: move tc library under lib/vdsm
..
net: move tc library under lib/vdsm
Since most of the changed code is import statements, a few lines were
moved
Francesco Romani has posted comments on this change.
Change subject: nettestlib: add ppc64le TUNSETIFF value
..
Patch Set 8: Code-Review+1
still looks OK
--
To view, visit https://gerrit.ovirt.org/46955
To unsubscribe, visit
gerrit-hooks has posted comments on this change.
Change subject: sampling: HostStatsThread as periodic operation
..
Patch Set 35:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure
gerrit-hooks has posted comments on this change.
Change subject: VolumeMetadata: Move isLeaf, setLeaf and dependencies
..
Patch Set 24:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make
Francesco Romani has posted comments on this change.
Change subject: sampling: HostStatsThread as periodic operation
..
Patch Set 35: Verified+1
verified that Vdsm stops cleanly (it does).
All changes tested.
Dan, Nir, I think
Michal Skrivanek has posted comments on this change.
Change subject: vdsm: introduce cpuinfo module
..
Patch Set 13:
are the Arch naming changes aligned with https://gerrit.ovirt.org/#/c/49299/ ?
--
To view, visit
Milan Zamazal has posted comments on this change.
Change subject: migration: make status field private
..
Patch Set 2: Code-Review-1
(1 comment)
https://gerrit.ovirt.org/#/c/49522/2/vdsm/virt/migration.py
File
Francesco Romani has posted comments on this change.
Change subject: vdsm: introduce cpuinfo module
..
Patch Set 15:
Michal, good point. One thing we should document is where and why we follow
libvirt's or Engine's convention
Nir Soffer has submitted this change and it was merged.
Change subject: getAllImages: Use manifest attributes when constructing glob
pattern
..
getAllImages: Use manifest attributes when constructing glob pattern
getAllImages
gerrit-hooks has posted comments on this change.
Change subject: getAllImages: Use manifest attributes when constructing glob
pattern
..
Patch Set 3:
* Update tracker: IGNORE, no Bug-Url found
* Set MODIFIED::IGNORE, no
Milan Zamazal has posted comments on this change.
Change subject: sampling: HostStatsThread as periodic operation
..
Patch Set 35: Code-Review+1
--
To view, visit https://gerrit.ovirt.org/40431
To unsubscribe, visit
Francesco Romani has posted comments on this change.
Change subject: vdsm: introduce cpuinfo module
..
Patch Set 15:
I think we could split this patch in two:
1. add and use cpuarch
2. add and use cpuinfo
I doubt further
Ramesh N has posted comments on this change.
Change subject: gluster: fix brick devices are created with incorrect data
alignment
..
Patch Set 2:
(1 comment)
https://gerrit.ovirt.org/#/c/47959/2/vdsm/gluster/storagedev.py
Nir Soffer has posted comments on this change.
Change subject: vm: move device attached check to device itself
..
Patch Set 2: Code-Review+1
We dont need this patch, but it will be easier to maintain the code with it, so
I
gerrit-hooks has posted comments on this change.
Change subject: migration: don't mess up with _status fields
..
Patch Set 3:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header
gerrit-hooks has posted comments on this change.
Change subject: migration: make status field private
..
Patch Set 3:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches
gerrit-hooks has posted comments on this change.
Change subject: migration: return copy of internal status
..
Patch Set 3:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header
gerrit-hooks has posted comments on this change.
Change subject: virt: enhance migration.SourceThread.stop()
..
Patch Set 15:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header
gerrit-hooks has posted comments on this change.
Change subject: migration: track and report abort reason
..
Patch Set 3:
* #1154397::Update tracker: OK
* Check Bug-Url::OK
* Check Public Bug::#1154397::OK, public bug
* Check
gerrit-hooks has posted comments on this change.
Change subject: virt: do not use status after getStat()
..
Patch Set 13:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header
Francesco Romani has posted comments on this change.
Change subject: v2v: add try/except to get_external_vms
..
Patch Set 5: Code-Review+1
(1 comment)
+1 and not +2 because of a question. Looks good to me, however.
gerrit-hooks has posted comments on this change.
Change subject: net: move tc library under lib/vdsm
..
Patch Set 10:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches
Nir Soffer has posted comments on this change.
Change subject: lib: executor: log pool status on discard
..
Patch Set 6:
Waiting for Dan
--
To view, visit https://gerrit.ovirt.org/48333
To unsubscribe, visit
Petr Horáček has posted comments on this change.
Change subject: net: multicast snooping is not supported by ovs until 2.4.0
..
Patch Set 2: Verified+1
Just a comment
--
To view, visit https://gerrit.ovirt.org/49690
To
gerrit-hooks has posted comments on this change.
Change subject: net: multicast snooping is not supported by ovs until 2.4.0
..
Patch Set 2:
* #1234867::Update tracker: OK
* Check Bug-Url::OK
* Check Public Bug::#1234867::OK,
Nir Soffer has posted comments on this change.
Change subject: lib: executor: log pool status on discard
..
Patch Set 6:
Francesco, I think we should show the state of the worker in its __repr__ -
when you see the set of
Francesco Romani has uploaded a new change for review.
Change subject: lib: executor: report worker status in __repr__
..
lib: executor: report worker status in __repr__
To make the troubleshooting of stuck workers
easier, we
gerrit-hooks has posted comments on this change.
Change subject: lib: executor: log pool status on discard
..
Patch Set 7:
* #1250839::Update tracker: OK
* Check Bug-Url::OK
* Check Public Bug::#1250839::OK, public bug
* Check
gerrit-hooks has posted comments on this change.
Change subject: hooks: ovs: move libvirt configuration into a separate module
..
Patch Set 2:
* #1234867::Update tracker: OK
* Check Bug-Url::OK
* Check Public
Nir Soffer has posted comments on this change.
Change subject: lib: executor: log pool status on discard
..
Patch Set 6: Code-Review+2
--
To view, visit https://gerrit.ovirt.org/48333
To unsubscribe, visit
gerrit-hooks has posted comments on this change.
Change subject: hooks: Open vSwitch configurator
..
Patch Set 2:
* #1234867::Update tracker: OK
* Check Bug-Url::OK
* Check Public Bug::#1234867::OK, public bug
* Check
Petr Horáček has posted comments on this change.
Change subject: hooks: Open vSwitch configurator
..
Patch Set 2: Verified+1
Passed network tests OK, OVS tests passed with a few expected fails.
--
To view, visit
Francesco Romani has posted comments on this change.
Change subject: lib: executor: report worker status in __repr__
..
Patch Set 1:
Rerun-Hooks: all
--
To view, visit https://gerrit.ovirt.org/49722
To unsubscribe, visit
Francesco Romani has posted comments on this change.
Change subject: lib: executor: report worker status in __repr__
..
Patch Set 1:
bogus jenkins failure, retrying:
00:08:56.214
gerrit-hooks has posted comments on this change.
Change subject: lib: executor: report worker status in __repr__
..
Patch Set 1:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure
gerrit-hooks has posted comments on this change.
Change subject: licenses: update license years in changed files
..
Patch Set 1:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure
gerrit-hooks has posted comments on this change.
Change subject: licenses: rename Hat and RedHat to Red Hat
..
Patch Set 1:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header
gerrit-hooks has posted comments on this change.
Change subject: vm: add support for "Crashed" event
..
Patch Set 2:
* #1288513::Update tracker: OK
--
To view, visit https://gerrit.ovirt.org/49674
To unsubscribe, visit
gerrit-hooks has posted comments on this change.
Change subject: StorageDomainManifest: Manifest objects produce VolumeMetadata
objects
..
Patch Set 8:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug
Adam Litke has posted comments on this change.
Change subject: StorageDomainManifest: Manifest objects produce VolumeMetadata
objects
..
Patch Set 7:
(1 comment)
https://gerrit.ovirt.org/#/c/44040/7//COMMIT_MSG
Commit
Francesco Romani has posted comments on this change.
Change subject: vdsm: introduce cpuinfo module
..
Patch Set 15:
(2 comments)
https://gerrit.ovirt.org/#/c/46912/15/lib/vdsm/cpuarch.py
File lib/vdsm/cpuarch.py:
Line 74:
Petr Horáček has uploaded a new change for review.
Change subject: licenses: rename Hat and RedHat to Red Hat
..
licenses: rename Hat and RedHat to Red Hat
Tell me if Hat is another company.
Change-Id:
Petr Horáček has posted comments on this change.
Change subject: licenses: update license years in changed files
..
Patch Set 1:
used script https://github.com/phoracek/droids/blob/master/happy_new_year.sh
--
To view, visit
Petr Horáček has posted comments on this change.
Change subject: licenses: rename Hat and RedHat to Red Hat
..
Patch Set 1:
used script https://github.com/phoracek/droids/blob/master/we_are_red_hat.sh
--
To view, visit
Francesco Romani has posted comments on this change.
Change subject: lib: executor: log pool status on discard
..
Patch Set 6:
Nir, it's a neat idea. Will post a new patch to implement this.
--
To view, visit
Francesco Romani has abandoned this change.
Change subject: vm: add support for "Crashed" event
..
Abandoned
on hold, not sure we want to fix this on 3.5.x/x86
--
To view, visit https://gerrit.ovirt.org/49674
To unsubscribe,
gerrit-hooks has posted comments on this change.
Change subject: vm: reformat _EVENT_STRINGS
..
Patch Set 2:
* #1288513::Update tracker: OK
--
To view, visit https://gerrit.ovirt.org/49673
To unsubscribe, visit
Francesco Romani has abandoned this change.
Change subject: vm: reformat _EVENT_STRINGS
..
Abandoned
on hold, not sure we want to fix this on 3.5.x/x86
--
To view, visit https://gerrit.ovirt.org/49673
To unsubscribe, visit
gerrit-hooks has posted comments on this change.
Change subject: vm: more robust support of event strings
..
Patch Set 2:
* #1288513::Update tracker: OK
--
To view, visit https://gerrit.ovirt.org/49675
To unsubscribe, visit
Francesco Romani has abandoned this change.
Change subject: vm: more robust support of event strings
..
Abandoned
on hold, not sure we want to fix this on 3.5.x/x86
--
To view, visit https://gerrit.ovirt.org/49675
To
gerrit-hooks has posted comments on this change.
Change subject: lib: executor: report worker status in __repr__
..
Patch Set 1:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure
gerrit-hooks has posted comments on this change.
Change subject: hooks: ovs: remove unused parameter
..
Patch Set 2:
* #1234867::Update tracker: OK
* Check Bug-Url::OK
* Check Public Bug::#1234867::OK, public bug
* Check
Francesco Romani has posted comments on this change.
Change subject: vdsm: introduce cpuinfo module
..
Patch Set 15:
few comments to improve
--
To view, visit https://gerrit.ovirt.org/46912
To unsubscribe, visit
gerrit-hooks has posted comments on this change.
Change subject: VolumeMetadata: Move recheckIfLeaf into *Metadata class
..
Patch Set 22:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make
Francesco Romani has posted comments on this change.
Change subject: lib: executor: log pool status on discard
..
Patch Set 6: Verified+1
here's how it looks:
vdsm.Scheduler::DEBUG::2015-12-04
Nir Soffer has posted comments on this change.
Change subject: VolumeMetadata: Move isLeaf, setLeaf and dependencies
..
Patch Set 25:
This version adds the missing redirection tests.
--
To view, visit
gerrit-hooks has posted comments on this change.
Change subject: VolumeMetadata: Move isLeaf, setLeaf and dependencies
..
Patch Set 25:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make
gerrit-hooks has posted comments on this change.
Change subject: sdm: Create the storage/sdm directory
..
Patch Set 2:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header
Adam Litke has posted comments on this change.
Change subject: sdm: Create the storage/sdm directory
..
Patch Set 1:
(1 comment)
https://gerrit.ovirt.org/#/c/49686/1/vdsm/storage/sdm/__init__.py
File
Adam Litke has posted comments on this change.
Change subject: sdm: Create the storage/sdm directory
..
Patch Set 2: Verified+1
--
To view, visit https://gerrit.ovirt.org/49686
To unsubscribe, visit
Petr Horáček has posted comments on this change.
Change subject: net: sysctl: enable ipv6
..
Patch Set 1: Verified+1
Passed network tests. Jenkins' 'JsonRpcNoResponseError: [-32605] No response
for JSON-RPC echo request.' is
gerrit-hooks has posted comments on this change.
Change subject: vm: reformat _EVENT_STRINGS
..
Patch Set 2:
* #1288513::Update tracker: OK
* Check Bug-Url::OK
* Check Public Bug::#1288513::OK, public bug
* Check
gerrit-hooks has posted comments on this change.
Change subject: vm: add support for "Crashed" event
..
Patch Set 2:
* #1288513::Update tracker: OK
* Check Bug-Url::OK
* Check Public Bug::#1288513::OK, public bug
* Check
gerrit-hooks has posted comments on this change.
Change subject: vm: more robust support of event strings
..
Patch Set 2:
* #1288513::Update tracker: OK
* Check Bug-Url::OK
* Check Public Bug::#1288513::OK, public bug
* Check
Petr Horáček has posted comments on this change.
Change subject: hooks: after_network_setup_fail
..
Patch Set 1: Verified+1
Passed network tests plus verified with hook:
#!/bin/python
import hooking
with
Nir Soffer has posted comments on this change.
Change subject: StorageDomainManifest: Manifest objects produce VolumeMetadata
objects
..
Patch Set 9: Code-Review+2
--
To view, visit https://gerrit.ovirt.org/44040
To
Petr Horáček has posted comments on this change.
Change subject: hooks: ovs: remove unused parameter
..
Patch Set 2: Verified+1
passed network and OVS tests without a regression
--
To view, visit
Petr Horáček has posted comments on this change.
Change subject: hooks: ovs: move libvirt configuration into a separate module
..
Patch Set 2: Verified+1
passed network and OVS tests without a regression
--
To view, visit
Adam Litke has posted comments on this change.
Change subject: StorageDomainManifest: Manifest objects produce VolumeMetadata
objects
..
Patch Set 8: Verified-1
Oops. Have to fix up the sdm_indirection_tests.
--
To view,
gerrit-hooks has posted comments on this change.
Change subject: StorageDomainManifest: Manifest objects produce VolumeMetadata
objects
..
Patch Set 9:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug
1 - 100 of 151 matches
Mail list logo
