gerrit-hooks has posted comments on this change.
Change subject: Adding to vdsm automation lago env setup for functional tests
..
Patch Set 17:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url
Freddy Rolland has posted comments on this change.
Change subject: VolumeMetadata: move refreshVolume
..
Patch Set 22: Code-Review+1
--
To view, visit https://gerrit.ovirt.org/42003
To unsubscribe, visit
gerrit-hooks has posted comments on this change.
Change subject: net: consolidate nics.py naming
..
Patch Set 4:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches
Ido Barkan has posted comments on this change.
Change subject: hooks: ovs: better rollback
..
Patch Set 2: Code-Review+1
--
To view, visit https://gerrit.ovirt.org/49693
To unsubscribe, visit https://gerrit.ovirt.org/settings
Sagi Shnaidman has posted comments on this change.
Change subject: Include vmfex-dev-hook in vdsm install
..
Patch Set 3: Verified+1
--
To view, visit https://gerrit.ovirt.org/49566
To unsubscribe, visit
Nir Soffer has posted comments on this change.
Change subject: Adding python3 run for nosetests
..
Patch Set 23:
Jenkins error is not available now, can you retrigger?
--
To view, visit https://gerrit.ovirt.org/48051
To
Ido Barkan has posted comments on this change.
Change subject: vdsm.spec typo in package description
..
Patch Set 1: Verified+1
--
To view, visit https://gerrit.ovirt.org/49661
To unsubscribe, visit
Ido Barkan has posted comments on this change.
Change subject: net: Compare kernel vs running bond config opt vals
..
Patch Set 1: Code-Review+1
--
To view, visit https://gerrit.ovirt.org/49579
To unsubscribe, visit
Nir Soffer has posted comments on this change.
Change subject: virt: vm: Update time on VM after resume
..
Patch Set 4:
(1 comment)
https://gerrit.ovirt.org/#/c/48860/4/vdsm/virt/vm.py
File vdsm/virt/vm.py:
Line 2802:
gerrit-hooks has posted comments on this change.
Change subject: v2v: support for importing Xen VMs via libvirt on RHEL hosts
..
Patch Set 4:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found,
gerrit-hooks has posted comments on this change.
Change subject: v2v: revactory ImportVM with commnad classes
..
Patch Set 2:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header
Ido Barkan has posted comments on this change.
Change subject: licenses: update license years in changed files
..
Patch Set 1: Code-Review+1
yea but does it pass the functional tests? :P
--
To view, visit
Ido Barkan has posted comments on this change.
Change subject: shell-helper: stop using service command
..
Patch Set 1:
(1 comment)
https://gerrit.ovirt.org/#/c/49215/1/contrib/shell_helper
File contrib/shell_helper:
Line
Nir Soffer has posted comments on this change.
Change subject: Introduce VolumeArtifacts
..
Patch Set 4:
Lets discuss first how this should work, before implementing it.
--
To view, visit https://gerrit.ovirt.org/48097
To
Nir Soffer has posted comments on this change.
Change subject: Introduce VolumeArtifacts
..
Patch Set 4: Code-Review-1
(14 comments)
https://gerrit.ovirt.org/#/c/48097/4/vdsm/storage/sdm/volumeartifacts.py
File
gerrit-hooks has posted comments on this change.
Change subject: v2v: revactory ImportVM with commnad classes
..
Patch Set 1:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header
Shahar Havivi has uploaded a new change for review.
Change subject: v2v: revactory ImportVM with commnad classes
..
v2v: revactory ImportVM with commnad classes
We are handling a lot of inputs for ImportVM (libvirt VM, ova) and
gerrit-hooks has posted comments on this change.
Change subject: v2v: externalVMList Xen+Kvm support
..
Patch Set 16:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches
Yeela Kaplan has uploaded a new change for review.
Change subject: Makefile: use tox to run make pep8 and pyflakes
..
Makefile: use tox to run make pep8 and pyflakes
Restrict the version vdsm uses to validate the code by
pep8
gerrit-hooks has posted comments on this change.
Change subject: Makefile: use tox to run make pep8 and pyflakes
..
Patch Set 1:
* #1182088::Update tracker: OK
* Check Bug-Url::OK
* Check Public Bug::#1182088::OK, public bug
*
gerrit-hooks has posted comments on this change.
Change subject: v2v: refactor get_external_vms
..
Patch Set 2:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches
Nir Soffer has posted comments on this change.
Change subject: virt: vm: Update time on VM after resume
..
Patch Set 4: Code-Review-1
--
To view, visit https://gerrit.ovirt.org/48860
To unsubscribe, visit
Nir Soffer has posted comments on this change.
Change subject: virt: vm: Update time on VM after resume
..
Patch Set 4:
(4 comments)
https://gerrit.ovirt.org/#/c/48860/4/tests/vmTests.py
File tests/vmTests.py:
Line 987:
Ido Barkan has posted comments on this change.
Change subject: net: Mapping bonding option value names to numerics
..
Patch Set 12:
(1 comment)
https://gerrit.ovirt.org/#/c/49390/12/lib/vdsm/netinfo.py
File
Ido Barkan has posted comments on this change.
Change subject: net: consolidate nics.py naming
..
Patch Set 6: Verified+1
--
To view, visit https://gerrit.ovirt.org/49624
To unsubscribe, visit
Ido Barkan has uploaded a new change for review.
Change subject: net: canonify netinfo.vlans.py name
..
net: canonify netinfo.vlans.py name
Vlans.py names made relative, pep8'ed and parameter names are now
consistent.
gerrit-hooks has posted comments on this change.
Change subject: net: canonify netinfo.vlans.py name
..
Patch Set 1:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches
Ido Barkan has posted comments on this change.
Change subject: netinfo: replace an annoying (and misleading) log message
..
Patch Set 5: Code-Review+1
--
To view, visit https://gerrit.ovirt.org/49389
To unsubscribe, visit
Ido Barkan has posted comments on this change.
Change subject: tests: modprobe validation handle failure
..
Patch Set 3: Code-Review-1
(1 comment)
https://gerrit.ovirt.org/#/c/49538/3/tests/modprobe.py
File tests/modprobe.py:
Ido Barkan has posted comments on this change.
Change subject: netinfo: assess DHCP on devices from cmdlines of dhclients
..
Patch Set 11:
(5 comments)
Petr, Can you review the ovs hooks change part?
Nir Soffer has posted comments on this change.
Change subject: host stats: Collect stats from online cpu cores only
..
Patch Set 13: Code-Review-1
(7 comments)
https://gerrit.ovirt.org/#/c/46269/13/tests/hoststatsTests.py
Ido Barkan has posted comments on this change.
Change subject: net: consolidate _BRIDGING_OPT_PATH and BRIDGING_OPT
..
Patch Set 5: Verified+1
failed in CI because of unrelated error:
Arik Hadas has posted comments on this change.
Change subject: vm: Support for non-ascii vm name
..
Patch Set 1: Code-Review+1
The engine does not use the name in VDSM and all interactions between the
engine and VDSM
Freddy Rolland has posted comments on this change.
Change subject: StorageDomain: Add get_manifest
..
Patch Set 8: Code-Review+1
--
To view, visit https://gerrit.ovirt.org/44566
To unsubscribe, visit
Freddy Rolland has posted comments on this change.
Change subject: fileVolume: define file extension for volume artifacts metadata
..
Patch Set 2: Code-Review+1
--
To view, visit https://gerrit.ovirt.org/49544
To unsubscribe,
gerrit-hooks has posted comments on this change.
Change subject: net: remove unused constant
..
Patch Set 5:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches
Dan Kenigsberg has posted comments on this change.
Change subject: net: remove unused constant
..
Patch Set 5: Code-Review+2
--
To view, visit https://gerrit.ovirt.org/49621
To unsubscribe, visit
Dan Kenigsberg has posted comments on this change.
Change subject: net: consolidate _BRIDGING_OPT_PATH and BRIDGING_OPT
..
Patch Set 4: Code-Review-1
(1 comment)
gerrit-hooks has posted comments on this change.
Change subject: Adding python3 run for nosetests
..
Patch Set 23:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches
gerrit-hooks has posted comments on this change.
Change subject: v2v: add try/except to get_external_vms
..
Patch Set 6:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header
Dan Kenigsberg has posted comments on this change.
Change subject: hooks: after_network_setup_fail
..
Patch Set 1: Code-Review+2 Continuous-Integration+1
aren't we done with "ovirt-vmconsole" missing from repo?
--
To view,
Sandro Bonazzola has posted comments on this change.
Change subject: coverage: Add vdsm-coverage sub package
..
Patch Set 4:
(5 comments)
See inline comments
https://gerrit.ovirt.org/#/c/49807/4/coverage/README.md
File
gerrit-hooks has posted comments on this change.
Change subject: Include vmfex-dev-hook in vdsm install
..
Patch Set 3:
* #1286997::Update tracker: OK
* Check Bug-Url::OK
* Check Public Bug::#1286997::OK, public bug
* Check
Freddy Rolland has posted comments on this change.
Change subject: VolumeMetadata: move newMetadata
..
Patch Set 22: Code-Review+1
--
To view, visit https://gerrit.ovirt.org/42001
To unsubscribe, visit
Dan Kenigsberg has submitted this change and it was merged.
Change subject: licenses: rename Hat and RedHat to Red Hat
..
licenses: rename Hat and RedHat to Red Hat
Tell me if Hat is another company.
Change-Id:
gerrit-hooks has posted comments on this change.
Change subject: licenses: rename Hat and RedHat to Red Hat
..
Patch Set 2:
* Update tracker: IGNORE, no Bug-Url found
* Set MODIFIED::IGNORE, no Bug-Url found.
--
To view,
Dan Kenigsberg has posted comments on this change.
Change subject: licenses: rename Hat and RedHat to Red Hat
..
Patch Set 1: Code-Review+2 Verified+1
--
To view, visit https://gerrit.ovirt.org/49718
To unsubscribe, visit
Yaniv Bronhaim has posted comments on this change.
Change subject: Remove koji build flag and use specific one for vhostmd
..
Patch Set 3: Verified+1
(1 comment)
Ido Barkan has posted comments on this change.
Change subject: hooks: ovs: remove unused parameter
..
Patch Set 2: Code-Review+1
--
To view, visit https://gerrit.ovirt.org/49692
To unsubscribe, visit
Ido Barkan has posted comments on this change.
Change subject: hooks: ovs: move libvirt configuration into a separate module
..
Patch Set 2: Code-Review+1
--
To view, visit https://gerrit.ovirt.org/49691
To unsubscribe, visit
Ido Barkan has posted comments on this change.
Change subject: net: move qos reporting to netinfo
..
Patch Set 4: Verified+1
--
To view, visit https://gerrit.ovirt.org/49620
To unsubscribe, visit
gerrit-hooks has posted comments on this change.
Change subject: net: publicise misc._visible_devs
..
Patch Set 6:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches
gerrit-hooks has posted comments on this change.
Change subject: net: consolidate _BRIDGING_OPT_PATH and BRIDGING_OPT
..
Patch Set 5:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make
gerrit-hooks has posted comments on this change.
Change subject: net: consolidate bondings.py naming
..
Patch Set 6:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches
gerrit-hooks has posted comments on this change.
Change subject: net: consolidate nics.py naming
..
Patch Set 6:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches
gerrit-hooks has posted comments on this change.
Change subject: net: move qos reporting to netinfo
..
Patch Set 5:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches
gerrit-hooks has posted comments on this change.
Change subject: net: remove unused constant
..
Patch Set 6:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches
gerrit-hooks has posted comments on this change.
Change subject: net: consolidate bridges.py names
..
Patch Set 6:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches
Dan Kenigsberg has posted comments on this change.
Change subject: net: sysctl: enable ipv6
..
Patch Set 1: Code-Review+2 Continuous-Integration+1
'JsonRpcNoResponseError: [-32605] No response for JSON-RPC echo request.' is
Freddy Rolland has posted comments on this change.
Change subject: storage: Split newMetadata into makeMetadata and createMetadata
..
Patch Set 7: Code-Review+1
--
To view, visit https://gerrit.ovirt.org/44045
To unsubscribe,
Dan Kenigsberg has posted comments on this change.
Change subject: net: move network library under lib/vdsm
..
Patch Set 11: Code-Review+1
--
To view, visit https://gerrit.ovirt.org/49239
To unsubscribe, visit
gerrit-hooks has posted comments on this change.
Change subject: net: consolidate nics.py naming
..
Patch Set 3:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches
gerrit-hooks has posted comments on this change.
Change subject: net: consolidate nics.py naming
..
Patch Set 3:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches
gerrit-hooks has posted comments on this change.
Change subject: net: remove unused constant
..
Patch Set 3:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches
Dan Kenigsberg has posted comments on this change.
Change subject: net: privatize IFCFG_ZERO_SUFFIXED
..
Patch Set 4: Code-Review+2
--
To view, visit https://gerrit.ovirt.org/49623
To unsubscribe, visit
Nir Soffer has posted comments on this change.
Change subject: Remove koji build flag and use specific one for vhostmd
..
Patch Set 3:
(1 comment)
https://gerrit.ovirt.org/#/c/49427/3/contrib/koji_build_fedora.sh
File
Dan Kenigsberg has posted comments on this change.
Change subject: net: consolidate nics.py naming
..
Patch Set 5: Code-Review+2
(1 comment)
https://gerrit.ovirt.org/#/c/49624/5/lib/vdsm/netinfo/__init__.py
File
gerrit-hooks has posted comments on this change.
Change subject: coverage: Add vdsm-coverage sub package
..
Patch Set 5:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header
Dan Kenigsberg has posted comments on this change.
Change subject: net: consolidate bondings.py naming
..
Patch Set 5: Code-Review+2
--
To view, visit https://gerrit.ovirt.org/49626
To unsubscribe, visit
Ido Barkan has posted comments on this change.
Change subject: hooks: ovs: fix getVdsCaps and getVdsStats
..
Patch Set 2: Code-Review+1
--
To view, visit https://gerrit.ovirt.org/49698
To unsubscribe, visit
Nir Soffer has posted comments on this change.
Change subject: coverage: Add vdsm-coverage sub package
..
Patch Set 5: Verified+1
README changes, not code change.
--
To view, visit https://gerrit.ovirt.org/49807
To
Freddy Rolland has posted comments on this change.
Change subject: VolumeMetadata: Move isLeaf, setLeaf and dependencies
..
Patch Set 27: Code-Review+1
--
To view, visit https://gerrit.ovirt.org/41849
To unsubscribe, visit
Dan Kenigsberg has posted comments on this change.
Change subject: virt: vm: Update time on VM after resume
..
Patch Set 4: Code-Review+2
--
To view, visit https://gerrit.ovirt.org/48860
To unsubscribe, visit
Ido Barkan has posted comments on this change.
Change subject: hooks: Open vSwitch configurator
..
Patch Set 2: Code-Review+1
(1 comment)
https://gerrit.ovirt.org/#/c/49689/2/vdsm_hooks/Makefile.am
File
Ido Barkan has posted comments on this change.
Change subject: net: multicast snooping is not supported by ovs until 2.4.0
..
Patch Set 2: Code-Review+1
--
To view, visit https://gerrit.ovirt.org/49690
To unsubscribe, visit
Ido Barkan has abandoned this change.
Change subject: net: consolidate nics.py naming
..
Abandoned
--
To view, visit https://gerrit.ovirt.org/49625
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType:
gerrit-hooks has posted comments on this change.
Change subject: net: consolidate nics.py naming
..
Patch Set 3:
* Update tracker: IGNORE, no Bug-Url found
--
To view, visit https://gerrit.ovirt.org/49625
To unsubscribe,
Ido Barkan has posted comments on this change.
Change subject: net: consolidate _BRIDGING_OPT_PATH and BRIDGING_OPT
..
Patch Set 4:
(1 comment)
https://gerrit.ovirt.org/#/c/49622/4/lib/vdsm/network/configurators/iproute2.py
Jenkins CI has posted comments on this change.
Change subject: net: remove unused constant
..
Patch Set 5: Continuous-Integration+1
Propagate review hook: Continuous Integration value inherited from patch 4
--
To view, visit
Nir Soffer has posted comments on this change.
Change subject: startup: Change system default encoding to utf8
..
Patch Set 5:
ping
--
To view, visit https://gerrit.ovirt.org/48661
To unsubscribe, visit
Nir Soffer has restored this change.
Change subject: contrib: Add tool for getting repoStats statistics
..
Restored
Needed
--
To view, visit https://gerrit.ovirt.org/38749
To unsubscribe, visit
Nir Soffer has restored this change.
Change subject: contrib: Add tool for getting hsm stats
..
Restored
Needed
--
To view, visit https://gerrit.ovirt.org/38748
To unsubscribe, visit https://gerrit.ovirt.org/settings
gerrit-hooks has posted comments on this change.
Change subject: net: consolidate _BRIDGING_OPT_PATH and BRIDGING_OPT
..
Patch Set 3:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make
gerrit-hooks has posted comments on this change.
Change subject: net: publicise misc._visible_devs
..
Patch Set 3:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches
gerrit-hooks has posted comments on this change.
Change subject: net: consolidate bondings.py naming
..
Patch Set 3:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches
gerrit-hooks has posted comments on this change.
Change subject: net: consolidate bridges.py names
..
Patch Set 3:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches
gerrit-hooks has posted comments on this change.
Change subject: net: privatize IFCFG_ZERO_SUFFIXED
..
Patch Set 3:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches
gerrit-hooks has posted comments on this change.
Change subject: net: move qos reporting to netinfo
..
Patch Set 3:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches
gerrit-hooks has posted comments on this change.
Change subject: net: consolidate bondings.py naming
..
Patch Set 5:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches
gerrit-hooks has posted comments on this change.
Change subject: net: consolidate _BRIDGING_OPT_PATH and BRIDGING_OPT
..
Patch Set 4:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make
gerrit-hooks has posted comments on this change.
Change subject: net: remove unused constant
..
Patch Set 4:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches
gerrit-hooks has posted comments on this change.
Change subject: net: publicise misc._visible_devs
..
Patch Set 5:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches
gerrit-hooks has posted comments on this change.
Change subject: net: privatize IFCFG_ZERO_SUFFIXED
..
Patch Set 4:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches
gerrit-hooks has posted comments on this change.
Change subject: net: move qos reporting to netinfo
..
Patch Set 4:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches
Dan Kenigsberg has posted comments on this change.
Change subject: net: move qos reporting to netinfo
..
Patch Set 4: Code-Review+2
--
To view, visit https://gerrit.ovirt.org/49620
To unsubscribe, visit
Ido Barkan has posted comments on this change.
Change subject: hooks: after_network_setup_fail
..
Patch Set 1: Code-Review+1
--
To view, visit https://gerrit.ovirt.org/49688
To unsubscribe, visit
Ido Barkan has posted comments on this change.
Change subject: net: sysctl: enable ipv6
..
Patch Set 1: Code-Review+1
--
To view, visit https://gerrit.ovirt.org/49687
To unsubscribe, visit https://gerrit.ovirt.org/settings
gerrit-hooks has posted comments on this change.
Change subject: net: privatize IFCFG_ZERO_SUFFIXED
..
Patch Set 5:
* Update tracker: IGNORE, no Bug-Url found
* Set MODIFIED::IGNORE, no Bug-Url found.
--
To view, visit
Dan Kenigsberg has submitted this change and it was merged.
Change subject: net: privatize IFCFG_ZERO_SUFFIXED
..
net: privatize IFCFG_ZERO_SUFFIXED
Only used inside netinfo.misc
Change-Id:
Roy Golan has posted comments on this change.
Change subject: sp: Allow attaching of monitored domain
..
Patch Set 1: Code-Review+1
--
To view, visit https://gerrit.ovirt.org/49597
To unsubscribe, visit
1 - 100 of 165 matches
Mail list logo