Change in vdsm[master]: storage: add get_volume_artifacts_class to the domain manifest

2015-12-11 Thread automation
gerrit-hooks has posted comments on this change. Change subject: storage: add get_volume_artifacts_class to the domain manifest .. Patch Set 2: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url

Change in vdsm[master]: fileVolume: refactor _putMetadata to support volume artifacts

2015-12-11 Thread automation
gerrit-hooks has posted comments on this change. Change subject: fileVolume: refactor _putMetadata to support volume artifacts .. Patch Set 4: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found,

Change in vdsm[master]: XXX: Add _getDeletedImagePath until patch merged

2015-12-11 Thread automation
gerrit-hooks has posted comments on this change. Change subject: XXX: Add _getDeletedImagePath until patch merged .. Patch Set 2: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure

Change in vdsm[master]: Introduce VolumeArtifacts

2015-12-11 Thread automation
gerrit-hooks has posted comments on this change. Change subject: Introduce VolumeArtifacts .. Patch Set 8: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url:

Change in vdsm[master]: fileVolume: define file extension for volume artifacts metadata

2015-12-11 Thread automation
gerrit-hooks has posted comments on this change. Change subject: fileVolume: define file extension for volume artifacts metadata .. Patch Set 3: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url

Change in vdsm[master]: jobs: Add error property

2015-12-11 Thread automation
gerrit-hooks has posted comments on this change. Change subject: jobs: Add error property .. Patch Set 2: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: '

Change in vdsm[master]: sdm: add create_volume_container API stub

2015-12-11 Thread automation
gerrit-hooks has posted comments on this change. Change subject: sdm: add create_volume_container API stub .. Patch Set 3: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header

Change in vdsm[master]: jobs: Only report progress if set

2015-12-11 Thread automation
gerrit-hooks has posted comments on this change. Change subject: jobs: Only report progress if set .. Patch Set 2: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches

Change in vdsm[master]: virt: vm: Update time on VM after resume

2015-12-11 Thread mzamazal
Milan Zamazal has posted comments on this change. Change subject: virt: vm: Update time on VM after resume .. Patch Set 9: (5 comments) https://gerrit.ovirt.org/#/c/48860/9/tests/vmTests.py File tests/vmTests.py: Line 1564:

Change in vdsm[master]: virt: vm: Update time on VM after resume

2015-12-11 Thread automation
gerrit-hooks has posted comments on this change. Change subject: virt: vm: Update time on VM after resume .. Patch Set 8: * #1156194::Update tracker: OK * Check Bug-Url::OK * Check Public Bug::#1156194::OK, public bug * Check

Change in vdsm[master]: virt: vm: Update time on VM after resume

2015-12-11 Thread mzamazal
Milan Zamazal has posted comments on this change. Change subject: virt: vm: Update time on VM after resume .. Patch Set 8: Delay documented in the commit message + TODO in the migration path updated + rebased. -- To view,

Change in vdsm[master]: virt: vm: Update time on VM after resume

2015-12-11 Thread automation
gerrit-hooks has posted comments on this change. Change subject: virt: vm: Update time on VM after resume .. Patch Set 9: * #1156194::Update tracker: OK * Check Bug-Url::OK * Check Public Bug::#1156194::OK, public bug * Check

Change in vdsm[master]: vdsm standard CI arrangement

2015-12-11 Thread nsoffer
Nir Soffer has posted comments on this change. Change subject: vdsm standard CI arrangement .. Patch Set 26: Code-Review-1 -- To view, visit https://gerrit.ovirt.org/48268 To unsubscribe, visit

Change in vdsm[master]: service: change vdsm KillMode to mixed

2015-12-11 Thread dougsland
Douglas Schilling Landgraf has posted comments on this change. Change subject: service: change vdsm KillMode to mixed .. Patch Set 6: if this patch is not needed anymore, please abandon. -- To view, visit

Change in vdsm[master]: vm: report "MigrationSource" only if transferring

2015-12-11 Thread automation
gerrit-hooks has posted comments on this change. Change subject: vm: report "MigrationSource" only if transferring .. Patch Set 3: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure

Change in vdsm[master]: virt: do not use status after getStat()

2015-12-11 Thread automation
gerrit-hooks has posted comments on this change. Change subject: virt: do not use status after getStat() .. Patch Set 17: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header

Change in vdsm[master]: migration: rename method

2015-12-11 Thread automation
gerrit-hooks has posted comments on this change. Change subject: migration: rename method .. Patch Set 3: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: '

Change in vdsm[master]: migration: make status field private

2015-12-11 Thread automation
gerrit-hooks has posted comments on this change. Change subject: migration: make status field private .. Patch Set 7: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches

Change in vdsm[master]: schema: Fix asserts that had side effect

2015-12-11 Thread automation
gerrit-hooks has posted comments on this change. Change subject: schema: Fix asserts that had side effect .. Patch Set 3: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header

Change in vdsm[master]: migration: return copy of internal status

2015-12-11 Thread automation
gerrit-hooks has posted comments on this change. Change subject: migration: return copy of internal status .. Patch Set 7: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header

Change in vdsm[master]: migration: track and report abort reason

2015-12-11 Thread automation
gerrit-hooks has posted comments on this change. Change subject: migration: track and report abort reason .. Patch Set 8: * #1154397::Update tracker: OK * Check Bug-Url::OK * Check Public Bug::#1154397::OK, public bug * Check

Change in vdsm[master]: virt: enhance migration.SourceThread.stop()

2015-12-11 Thread automation
gerrit-hooks has posted comments on this change. Change subject: virt: enhance migration.SourceThread.stop() .. Patch Set 19: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header

Change in vdsm[master]: storage: Split newMetadata into makeMetadata and createMetadata

2015-12-11 Thread alitke
Adam Litke has posted comments on this change. Change subject: storage: Split newMetadata into makeMetadata and createMetadata .. Patch Set 7: Code-Review-1 (1 comment)

Change in vdsm[ovirt-3.5]: Handle empty QoS section with no cpu limit information

2015-12-11 Thread fromani
Francesco Romani has posted comments on this change. Change subject: Handle empty QoS section with no cpu limit information .. Patch Set 2: seems fine, and solves the issue seen on 49655. Waiting until monday if Martin wants

Change in vdsm[ovirt-3.5]: Handle empty QoS section with no cpu limit information

2015-12-11 Thread fromani
Francesco Romani has posted comments on this change. Change subject: Handle empty QoS section with no cpu limit information .. Patch Set 2: Verified+1 -- To view, visit https://gerrit.ovirt.org/50341 To unsubscribe, visit

Change in vdsm[ovirt-3.5]: Add an empty metadata qos element to the created domain

2015-12-11 Thread fromani
Francesco Romani has posted comments on this change. Change subject: Add an empty metadata qos element to the created domain .. Patch Set 3: seems fine now. Waiting until monday because 50341, otherwise fine. -- To view,

Change in vdsm[ovirt-3.5]: Add an empty metadata qos element to the created domain

2015-12-11 Thread fromani
Francesco Romani has posted comments on this change. Change subject: Add an empty metadata qos element to the created domain .. Patch Set 3: Code-Review+2 -- To view, visit https://gerrit.ovirt.org/49655 To unsubscribe, visit

Change in vdsm[master]: migration: don't mess up with _status fields

2015-12-11 Thread automation
gerrit-hooks has posted comments on this change. Change subject: migration: don't mess up with _status fields .. Patch Set 7: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header

Change in vdsm[master]: migration: add 'transferring' property

2015-12-11 Thread automation
gerrit-hooks has posted comments on this change. Change subject: migration: add 'transferring' property .. Patch Set 3: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header

Change in vdsm[master]: sdm: add create_volume_container API stub

2015-12-11 Thread nsoffer
Nir Soffer has posted comments on this change. Change subject: sdm: add create_volume_container API stub .. Patch Set 2: Code-Review-1 (7 comments) Mostly great, need little fix in api.

Change in vdsm[master]: schema: Fix asserts that had side effect

2015-12-11 Thread nsoffer
Nir Soffer has posted comments on this change. Change subject: schema: Fix asserts that had side effect .. Patch Set 3: Verified+1 -- To view, visit https://gerrit.ovirt.org/34362 To unsubscribe, visit

Change in vdsm[master]: schema: Fix asserts that had side effect

2015-12-11 Thread alitke
Adam Litke has posted comments on this change. Change subject: schema: Fix asserts that had side effect .. Patch Set 2: Code-Review+2 -- To view, visit https://gerrit.ovirt.org/34362 To unsubscribe, visit

Change in vdsm[master]: vdsm standard CI arrangement

2015-12-11 Thread automation
gerrit-hooks has posted comments on this change. Change subject: vdsm standard CI arrangement .. Patch Set 26: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches

Change in vdsm[master]: sdm: add create_volume_container API stub

2015-12-11 Thread alitke
Adam Litke has posted comments on this change. Change subject: sdm: add create_volume_container API stub .. Patch Set 2: (7 comments) https://gerrit.ovirt.org/#/c/50220/2/client/vdsClient.py File client/vdsClient.py: Line

Change in vdsm[master]: clean refrences inorder to save memory.

2015-12-11 Thread nsoffer
Nir Soffer has posted comments on this change. Change subject: clean refrences inorder to save memory. .. Patch Set 1: Code-Review-2 - This path is full of unrelated changes - We don't have any tests - We don't have any reason

Change in vdsm[master]: clean refrences inorder to save memory.

2015-12-11 Thread nsoffer
Nir Soffer has posted comments on this change. Change subject: clean refrences inorder to save memory. .. Patch Set 1: (1 comment) https://gerrit.ovirt.org/#/c/49346/1/vdsm/storage/misc.py File vdsm/storage/misc.py: Line

Change in vdsm[master]: deleting references due to memory leaks in the following mod...

2015-12-11 Thread nsoffer
Nir Soffer has posted comments on this change. Change subject: deleting references due to memory leaks in the following modules. adding GC thread every 30sec to vdsm .. Patch Set 4: (4 comments) There is no chance that

Change in vdsm[master]: deleting references due to memory leaks in the following mod...

2015-12-11 Thread nsoffer
Nir Soffer has posted comments on this change. Change subject: deleting references due to memory leaks in the following modules. adding GC thread every 30sec to vdsm .. Patch Set 4: (3 comments)

Change in vdsm[master]: deleting references due to memory leaks in the following mod...

2015-12-11 Thread nsoffer
Nir Soffer has posted comments on this change. Change subject: deleting references due to memory leaks in the following modules. adding GC thread every 30sec to vdsm .. Patch Set 4: Code-Review-2 Please provide information

Change in vdsm[master]: virt: Add support for vgamem attribute

2015-12-11 Thread vfeenstr
Vinzenz Feenstra has posted comments on this change. Change subject: virt: Add support for vgamem attribute .. Patch Set 3: Code-Review+1 (1 comment) https://gerrit.ovirt.org/#/c/50091/3/tests/deviceTests.py File

Change in vdsm[master]: virt: Add support for vgamem attribute

2015-12-11 Thread mzamazal
Milan Zamazal has posted comments on this change. Change subject: virt: Add support for vgamem attribute .. Patch Set 3: (1 comment) https://gerrit.ovirt.org/#/c/50091/3/tests/deviceTests.py File tests/deviceTests.py: Line

Change in vdsm[master]: storage: Split newMetadata into makeMetadata and createMetadata

2015-12-11 Thread automation
gerrit-hooks has posted comments on this change. Change subject: storage: Split newMetadata into makeMetadata and createMetadata .. Patch Set 8: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url

Change in vdsm[master]: XXX: All outstanding VolumeMetadata changes squashed

2015-12-11 Thread automation
gerrit-hooks has posted comments on this change. Change subject: XXX: All outstanding VolumeMetadata changes squashed .. Patch Set 1: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make

Change in vdsm[master]: storagefakelib: Add FakeResourceManager

2015-12-11 Thread automation
gerrit-hooks has posted comments on this change. Change subject: storagefakelib: Add FakeResourceManager .. Patch Set 2: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header

Change in vdsm[master]: sdm: Create the storage/sdm directory

2015-12-11 Thread automation
gerrit-hooks has posted comments on this change. Change subject: sdm: Create the storage/sdm directory .. Patch Set 1: * Update tracker: IGNORE, no Bug-Url found -- To view, visit https://gerrit.ovirt.org/50219 To

Change in vdsm[master]: sdm: Create the storage/sdm directory

2015-12-11 Thread alitke
Adam Litke has abandoned this change. Change subject: sdm: Create the storage/sdm directory .. Abandoned Already merged. -- To view, visit https://gerrit.ovirt.org/50219 To unsubscribe, visit

Change in vdsm[master]: jobs: Add error property

2015-12-11 Thread alitke
Adam Litke has uploaded a new change for review. Change subject: jobs: Add error property .. jobs: Add error property When a Job encounters an error, there should be a standardized way for that error to be stored so that code

Change in vdsm[master]: jobs: Only report progress if set

2015-12-11 Thread automation
gerrit-hooks has posted comments on this change. Change subject: jobs: Only report progress if set .. Patch Set 1: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches

Change in vdsm[master]: jobs: Add error property

2015-12-11 Thread automation
gerrit-hooks has posted comments on this change. Change subject: jobs: Add error property .. Patch Set 1: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: '

Change in vdsm[master]: jobs: Only report progress if set

2015-12-11 Thread alitke
Adam Litke has uploaded a new change for review. Change subject: jobs: Only report progress if set .. jobs: Only report progress if set Not all Jobs have deterministic progress and some jobs will complete so quickly that

Change in vdsm[master]: sdm: Add create_volume job

2015-12-11 Thread alitke
Adam Litke has posted comments on this change. Change subject: sdm: Add create_volume job .. Patch Set 2: (7 comments) https://gerrit.ovirt.org/#/c/50221/2/vdsm/storage/sdm/api/create_volume.py File

<    1   2