Change in vdsm[ovirt-3.5]: Add an empty metadata qos element to the created domain

2015-12-14 Thread automation
gerrit-hooks has posted comments on this change. Change subject: Add an empty metadata qos element to the created domain .. Patch Set 4: * #1289007::Update tracker: OK * Set MODIFIED::bug 1289007#1289007IGNORE, not oVir

Change in vdsm[ovirt-3.5]: Handle empty QoS section with no cpu limit information

2015-12-14 Thread automation
gerrit-hooks has posted comments on this change. Change subject: Handle empty QoS section with no cpu limit information .. Patch Set 3: * #1289007::Update tracker: OK * Set MODIFIED::bug 1289007#1289007IGNORE, not oVirt

Change in vdsm[ovirt-3.5]: Add an empty metadata qos element to the created domain

2015-12-14 Thread fromani
Francesco Romani has submitted this change and it was merged. Change subject: Add an empty metadata qos element to the created domain .. Add an empty metadata qos element to the created domain Libvirt reports an error every tim

Change in vdsm[ovirt-3.5]: Handle empty QoS section with no cpu limit information

2015-12-14 Thread fromani
Francesco Romani has submitted this change and it was merged. Change subject: Handle empty QoS section with no cpu limit information .. Handle empty QoS section with no cpu limit information The 3.5 stats collecting code expect

Change in vdsm[ovirt-3.6]: vm: add test for nic unplug wait

2015-12-14 Thread fromani
Francesco Romani has submitted this change and it was merged. Change subject: vm: add test for nic unplug wait .. vm: add test for nic unplug wait Change-Id: I4603efa0739c9bd50777a157c946da3ba8544729 Signed-off-by: Marcin Mirec

Change in vdsm[ovirt-3.6]: vm: add test for nic unplug wait

2015-12-14 Thread automation
gerrit-hooks has posted comments on this change. Change subject: vm: add test for nic unplug wait .. Patch Set 3: * #1134256::Update tracker: OK * Set MODIFIED::bug 1134256#1134256IGNORE, not oVirt classification but R

Change in vdsm[ovirt-3.6]: vm: move device attached check to device itself

2015-12-14 Thread fromani
Francesco Romani has posted comments on this change. Change subject: vm: move device attached check to device itself .. Patch Set 2: please verify -- To view, visit https://gerrit.ovirt.org/49670 To unsubscribe, visit https:/

Change in vdsm[ovirt-3.6]: vm: check operation result for vm nic hotunplug

2015-12-14 Thread fromani
Francesco Romani has submitted this change and it was merged. Change subject: vm: check operation result for vm nic hotunplug .. vm: check operation result for vm nic hotunplug After detaching a device we need to verify that th

Change in vdsm[ovirt-3.6]: vm: check operation result for vm nic hotunplug

2015-12-14 Thread automation
gerrit-hooks has posted comments on this change. Change subject: vm: check operation result for vm nic hotunplug .. Patch Set 2: * #1134256::Update tracker: OK * #1199782::Update tracker: OK * Set MODIFIED::bug 1134256#1134

Change in vdsm[master]: schema: Fix asserts that had side effect

2015-12-14 Thread piotr . kliczewski
Piotr Kliczewski has posted comments on this change. Change subject: schema: Fix asserts that had side effect .. Patch Set 3: Code-Review+2 -- To view, visit https://gerrit.ovirt.org/34362 To unsubscribe, visit https://gerrit.

Change in vdsm[ovirt-3.6]: vm: unit test for vm._waitForDriveRemoval

2015-12-14 Thread automation
gerrit-hooks has posted comments on this change. Change subject: vm: unit test for vm._waitForDriveRemoval .. Patch Set 2: * #1134256::Update tracker: OK * Set MODIFIED::bug 1134256#1134256IGNORE, not oVirt classificati

Change in vdsm[ovirt-3.6]: vm: unit test for vm._waitForDriveRemoval

2015-12-14 Thread fromani
Francesco Romani has submitted this change and it was merged. Change subject: vm: unit test for vm._waitForDriveRemoval .. vm: unit test for vm._waitForDriveRemoval Added unit tests for vm._waitForDriveRemoval, in preparation t

Change in vdsm[ovirt-3.6]: gluster: Warn instead of failing for unsupported gluster rep...

2015-12-14 Thread fromani
Francesco Romani has posted comments on this change. Change subject: gluster: Warn instead of failing for unsupported gluster replica modes .. Patch Set 2: Code-Review+2 -- To view, visit https://gerrit.ovirt.org/50258 To uns

Change in vdsm[ovirt-3.6]: gluster: Warn instead of failing for unsupported gluster rep...

2015-12-14 Thread automation
gerrit-hooks has posted comments on this change. Change subject: gluster: Warn instead of failing for unsupported gluster replica modes .. Patch Set 3: * #1286565::Update tracker: OK * Set MODIFIED::bug 1286565#1286565

Change in vdsm[ovirt-3.6]: gluster: Warn instead of failing for unsupported gluster rep...

2015-12-14 Thread fromani
Francesco Romani has submitted this change and it was merged. Change subject: gluster: Warn instead of failing for unsupported gluster replica modes .. gluster: Warn instead of failing for unsupported gluster replica modes A p

Change in vdsm[ovirt-3.6]: vm: enabling memory snapshot without disks

2015-12-14 Thread automation
gerrit-hooks has posted comments on this change. Change subject: vm: enabling memory snapshot without disks .. Patch Set 2: * #1287066::Update tracker: OK * Set MODIFIED::bug 1287066#1287066OK -- To view, visit https:

Change in vdsm[ovirt-3.6]: vm: enabling memory snapshot without disks

2015-12-14 Thread fromani
Francesco Romani has submitted this change and it was merged. Change subject: vm: enabling memory snapshot without disks .. vm: enabling memory snapshot without disks Taking a memory snapshot of a VM without disks should be sup

Change in vdsm[ovirt-3.6]: vm: enabling memory snapshot without disks

2015-12-14 Thread fromani
Francesco Romani has posted comments on this change. Change subject: vm: enabling memory snapshot without disks .. Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.ovirt.org/50199 To unsubscribe, visit https://gerri

Change in vdsm[ovirt-3.6]: Include vmfex-dev-hook in vdsm install

2015-12-14 Thread fromani
Francesco Romani has submitted this change and it was merged. Change subject: Include vmfex-dev-hook in vdsm install .. Include vmfex-dev-hook in vdsm install Force installation of vmfex-dev hook together with VDSM main package

Change in vdsm[ovirt-3.6]: Include vmfex-dev-hook in vdsm install

2015-12-14 Thread fromani
Francesco Romani has posted comments on this change. Change subject: Include vmfex-dev-hook in vdsm install .. Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.ovirt.org/50378 To unsubscribe, visit https://gerrit.ov

Change in vdsm[ovirt-3.6]: Include vmfex-dev-hook in vdsm install

2015-12-14 Thread automation
gerrit-hooks has posted comments on this change. Change subject: Include vmfex-dev-hook in vdsm install .. Patch Set 2: * #1286997::Update tracker: OK * Set MODIFIED::bug 1286997#1286997OK -- To view, visit https://ge

Change in vdsm[ovirt-3.6]: Add vmfex-dev hook to default RPMs for install

2015-12-14 Thread fromani
Francesco Romani has submitted this change and it was merged. Change subject: Add vmfex-dev hook to default RPMs for install .. Add vmfex-dev hook to default RPMs for install Add vmfex-dev hook RPM to default ones in shell_help

Change in vdsm[ovirt-3.6]: Add vmfex-dev hook to default RPMs for install

2015-12-14 Thread automation
gerrit-hooks has posted comments on this change. Change subject: Add vmfex-dev hook to default RPMs for install .. Patch Set 3: * #1286997::Update tracker: OK * Set MODIFIED::bug 1286997#1286997IGNORE, not all related p

Change in vdsm[ovirt-3.6]: Add vmfex-dev hook to default RPMs for install

2015-12-14 Thread fromani
Francesco Romani has posted comments on this change. Change subject: Add vmfex-dev hook to default RPMs for install .. Patch Set 2: Code-Review+2 -- To view, visit https://gerrit.ovirt.org/50270 To unsubscribe, visit https://g

Change in vdsm[ovirt-3.6]: v2v: add try/except to get_external_vms

2015-12-14 Thread fromani
Francesco Romani has submitted this change and it was merged. Change subject: v2v: add try/except to get_external_vms .. v2v: add try/except to get_external_vms Single domain error causes get_external_vms to fail. Bug-Url: htt

Change in vdsm[ovirt-3.6]: v2v: add try/except to get_external_vms

2015-12-14 Thread automation
gerrit-hooks has posted comments on this change. Change subject: v2v: add try/except to get_external_vms .. Patch Set 5: * #1284412::Update tracker: OK * Set MODIFIED::bug 1284412#1284412OK -- To view, visit https://g

Change in vdsm[ovirt-3.6]: v2v: add try/except to get_external_vms

2015-12-14 Thread fromani
Francesco Romani has posted comments on this change. Change subject: v2v: add try/except to get_external_vms .. Patch Set 4: Code-Review+2 -- To view, visit https://gerrit.ovirt.org/49438 To unsubscribe, visit https://gerrit.o

Change in vdsm[ovirt-3.6]: clientIF: add logs during the recovery

2015-12-14 Thread fromani
Francesco Romani has submitted this change and it was merged. Change subject: clientIF: add logs during the recovery .. clientIF: add logs during the recovery The recovery flow is supposed to be sporadic, but it is nevertheless

Change in vdsm[ovirt-3.6]: spec: Align RHEL and CentOS qemu* requiments

2015-12-14 Thread automation
gerrit-hooks has posted comments on this change. Change subject: spec: Align RHEL and CentOS qemu* requiments .. Patch Set 2: * #1248400::Update tracker: OK * Set MODIFIED::bug 1248400#1248400OK -- To view, visit http

Change in vdsm[ovirt-3.6]: clientIF: add logs during the recovery

2015-12-14 Thread automation
gerrit-hooks has posted comments on this change. Change subject: clientIF: add logs during the recovery .. Patch Set 5: * #1285236::Update tracker: OK * Set MODIFIED::bug 1285236#1285236OK -- To view, visit https://ge

Change in vdsm[ovirt-3.6]: spec: Align RHEL and CentOS qemu* requiments

2015-12-14 Thread fromani
Francesco Romani has submitted this change and it was merged. Change subject: spec: Align RHEL and CentOS qemu* requiments .. spec: Align RHEL and CentOS qemu* requiments Since qemu-kvm-ev-2.3 is now build by the oVirt project,

Change in vdsm[ovirt-3.6]: spec: Align RHEL and CentOS qemu* requiments

2015-12-14 Thread fromani
Francesco Romani has posted comments on this change. Change subject: spec: Align RHEL and CentOS qemu* requiments .. Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.ovirt.org/50368 To unsubscribe, visit https://ger

Change in vdsm[ovirt-3.6]: vm: add test for nic unplug wait

2015-12-14 Thread fromani
Francesco Romani has posted comments on this change. Change subject: vm: add test for nic unplug wait .. Patch Set 2: Code-Review+2 -- To view, visit https://gerrit.ovirt.org/49671 To unsubscribe, visit https://gerrit.ovirt.or

Change in vdsm[ovirt-3.6]: vm: check operation result for vm nic hotunplug

2015-12-14 Thread fromani
Francesco Romani has posted comments on this change. Change subject: vm: check operation result for vm nic hotunplug .. Patch Set 1: Code-Review+2 raising (my) score -- To view, visit https://gerrit.ovirt.org/49669 To unsubsc

Change in vdsm[master]: vdsm.conf: Add drop-in dir

2015-12-14 Thread automation
gerrit-hooks has posted comments on this change. Change subject: vdsm.conf: Add drop-in dir .. Patch Set 7: * #1279555::Update tracker: OK * Check Bug-Url::OK * Check Public Bug::#1279555::OK, public bug * Check Product::#12795

Change in vdsm[ovirt-3.6]: vm: move device attached check to device itself

2015-12-14 Thread fromani
Francesco Romani has posted comments on this change. Change subject: vm: move device attached check to device itself .. Patch Set 2: Code-Review+1 I agree, we should try to make things easier to maintain. I also want it. -- T

Change in vdsm[ovirt-3.6]: vm: unit test for vm._waitForDriveRemoval

2015-12-14 Thread fromani
Francesco Romani has posted comments on this change. Change subject: vm: unit test for vm._waitForDriveRemoval .. Patch Set 1: Code-Review+2 raising (my) score -- To view, visit https://gerrit.ovirt.org/49668 To unsubscribe,

Change in vdsm[master]: vdsm.conf: Add drop-in dir

2015-12-14 Thread fabiand
Fabian Deutsch has posted comments on this change. Change subject: vdsm.conf: Add drop-in dir .. Patch Set 6: (8 comments) https://gerrit.ovirt.org/#/c/48317/6/lib/vdsm/config.py.in File lib/vdsm/config.py.in: Line 21: from _

Change in vdsm[ovirt-3.6]: clientIF: add logs during the recovery

2015-12-14 Thread fromani
Francesco Romani has posted comments on this change. Change subject: clientIF: add logs during the recovery .. Patch Set 4: Verified+1 we can merge now -- To view, visit https://gerrit.ovirt.org/49140 To unsubscribe, visit ht

Change in vdsm[ovirt-3.6]: v2v: add try/except to get_external_vms

2015-12-14 Thread mzamazal
Milan Zamazal has posted comments on this change. Change subject: v2v: add try/except to get_external_vms .. Patch Set 4: Code-Review+1 -- To view, visit https://gerrit.ovirt.org/49438 To unsubscribe, visit https://gerrit.ovir

Change in vdsm[master]: Makefile: use tox to run make pep8 and pyflakes

2015-12-14 Thread ybronhei
Yaniv Bronhaim has posted comments on this change. Change subject: Makefile: use tox to run make pep8 and pyflakes .. Patch Set 4: Code-Review-1 for visibility -- To view, visit https://gerrit.ovirt.org/49952 To unsubscribe,

Change in vdsm[master]: Makefile: use tox to run make pep8 and pyflakes

2015-12-14 Thread ybronhei
Yaniv Bronhaim has posted comments on this change. Change subject: Makefile: use tox to run make pep8 and pyflakes .. Patch Set 4: (6 comments) https://gerrit.ovirt.org/#/c/49952/4/tox.ini File tox.ini: Line 3: skipsdist = tr

<    1   2   3