Edward Haas has posted comments on this change.
Change subject: net: IP DHCP detection
..
Patch Set 5: Verified+1
--
To view, visit https://gerrit.ovirt.org/53076
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit
gerrit-hooks has posted comments on this change.
Change subject: net: IP DHCP detection
..
Patch Set 5:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: '
a
gerrit-hooks has posted comments on this change.
Change subject: net: IP DHCP detection
..
Patch Set 4:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: '
a
Dan Kenigsberg has abandoned this change.
Change subject: code coverage: change approach how to enable it
..
Abandoned
3.6.1 is long gone
--
To view, visit https://gerrit.ovirt.org/50795
To unsubscribe, visit https://gerrit.o
gerrit-hooks has posted comments on this change.
Change subject: code coverage: change approach how to enable it
..
Patch Set 1:
* Update tracker: IGNORE, no Bug-Url found
--
To view, visit https://gerrit.ovirt.org/50795
To u
Dan Kenigsberg has posted comments on this change.
Change subject: Hook: ide2sata: To switch IDE disks to SATA
..
Patch Set 7: Code-Review-1
(2 comments)
a doc nit, and a question
https://gerrit.ovirt.org/#/c/48450/7/vdsm_hoo
Dan Kenigsberg has posted comments on this change.
Change subject: hooks: ovs: fix bonded network change problem
..
Patch Set 3: Code-Review+2
--
To view, visit https://gerrit.ovirt.org/52346
To unsubscribe, visit https://gerr
Dan Kenigsberg has posted comments on this change.
Change subject: net: IP DHCP detection
..
Patch Set 3: Code-Review-1
./lib/vdsm/netinfo/addresses.py:125:40: W292 no newline at end of file
Makefile:991: recipe for target 'pep
Dan Kenigsberg has posted comments on this change.
Change subject: virt: Fix of uninitialized variable access in
Vm.setLinkAndNetwork()
..
Patch Set 1: Code-Review+2
(1 comment)
https://gerrit.ovirt.org/#/c/53061/1/vdsm/virt/
Dan Kenigsberg has posted comments on this change.
Change subject: hooks: ovs: fix tests (waitForState and vdsProxy)
..
Patch Set 4: Code-Review-1
(1 comment)
https://gerrit.ovirt.org/#/c/52360/4//COMMIT_MSG
Commit Message:
L
gerrit-hooks has posted comments on this change.
Change subject: net: IP DHCP detection
..
Patch Set 3:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: '
a
Dan Kenigsberg has posted comments on this change.
Change subject: v2v: move v2v module to /var/lib/
..
Patch Set 1: Code-Review-1
(2 comments)
https://gerrit.ovirt.org/#/c/53084/1/lib/vdsm/v2v.py
File lib/vdsm/v2v.py:
Line 2
gerrit-hooks has posted comments on this change.
Change subject: Live Merge: Skip initial extension when base is raw
..
Patch Set 1: Verified-1
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::ERROR, At least one bu
Adam Litke has uploaded a new change for review.
Change subject: Live Merge: Skip initial extension when base is raw
..
Live Merge: Skip initial extension when base is raw
When starting a live merge we pre-extend the base volume
Dan Kenigsberg has posted comments on this change.
Change subject: net: Clean netinfo.__init__ and migrate to cache
..
Patch Set 4: Code-Review+2
--
To view, visit https://gerrit.ovirt.org/53007
To unsubscribe, visit https://g
gerrit-hooks has posted comments on this change.
Change subject: net: Clean netinfo.__init__ and migrate to cache
..
Patch Set 5:
* Update tracker: IGNORE, no Bug-Url found
* Set MODIFIED::IGNORE, no Bug-Url found.
--
To view
Dan Kenigsberg has submitted this change and it was merged.
Change subject: net: Clean netinfo.__init__ and migrate to cache
..
net: Clean netinfo.__init__ and migrate to cache
When stand alone modules under the netinfo package
Dan Kenigsberg has posted comments on this change.
Change subject: virt: add load() method to the recovery.File class
..
Patch Set 13:
(2 comments)
https://gerrit.ovirt.org/#/c/51389/13/vdsm/virt/recovery.py
File vdsm/virt/rec
Sagi Shnaidman has posted comments on this change.
Change subject: Advertise aggregator ID in bonding interfaces
..
Patch Set 5: Verified-1
WIP
--
To view, visit https://gerrit.ovirt.org/53100
To unsubscribe, visit https://ge
Dan Kenigsberg has posted comments on this change.
Change subject: Advertise aggregator ID in bonding interfaces
..
Patch Set 5:
(5 comments)
https://gerrit.ovirt.org/#/c/53100/5/lib/vdsm/netinfo/bonding.py
File lib/vdsm/netin
gerrit-hooks has posted comments on this change.
Change subject: Advertise aggregator ID in bonding interfaces
..
Patch Set 5:
* #1281666::Update tracker: OK
* Check Bug-Url::OK
* Check Public Bug::#1281666::OK, public bug
* Ch
gerrit-hooks has posted comments on this change.
Change subject: Advertise aggregator ID in bonding interfaces
..
Patch Set 2:
* #1281666::Update tracker: OK
* Check Bug-Url::OK
* Check Public Bug::#1281666::OK, public bug
* Ch
gerrit-hooks has posted comments on this change.
Change subject: Advertise aggregator ID in bonding interfaces
..
Patch Set 4:
* #1281666::Update tracker: OK
* Check Bug-Url::OK
* Check Public Bug::#1281666::OK, public bug
* Ch
gerrit-hooks has posted comments on this change.
Change subject: Advertise aggregator ID in bonding interfaces
..
Patch Set 3:
* #1281666::Update tracker: OK
* Check Bug-Url::OK
* Check Public Bug::#1281666::OK, public bug
* Ch
Sagi Shnaidman has posted comments on this change.
Change subject: Advertise aggregator ID in bonding interfaces
..
Patch Set 3:
Waiting for real bond setup to check this on.
--
To view, visit https://gerrit.ovirt.org/53100
T
gerrit-hooks has posted comments on this change.
Change subject: WIP: lib: clientIF: move vmContainer away
..
Patch Set 1:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header mat
gerrit-hooks has posted comments on this change.
Change subject: hooks: ovs: two networks cannot share one tag
..
Patch Set 5:
* Update tracker: IGNORE, no Bug-Url found
* Set MODIFIED::IGNORE, no Bug-Url found.
--
To view, v
Dan Kenigsberg has submitted this change and it was merged.
Change subject: hooks: ovs: two networks cannot share one tag
..
hooks: ovs: two networks cannot share one tag
testSetupNetworksNetCompatibilityMultipleNetsSameNic
ass
Dan Kenigsberg has posted comments on this change.
Change subject: hooks: ovs: two networks cannot share one tag
..
Patch Set 4: Code-Review+2
--
To view, visit https://gerrit.ovirt.org/52361
To unsubscribe, visit https://gerr
Dan Kenigsberg has posted comments on this change.
Change subject: Adding vdsm functional tests
..
Patch Set 49: Code-Review-1
(5 comments)
https://gerrit.ovirt.org/#/c/48268/49/automation/build-artifacts.sh
File automation/bu
gerrit-hooks has posted comments on this change.
Change subject: Adding vdsm functional tests
..
Patch Set 49:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Ur
gerrit-hooks has posted comments on this change.
Change subject: Advertise aggregator ID in bonding interfaces
..
Patch Set 1:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header
Piotr Kliczewski has posted comments on this change.
Change subject: xmlrpc: retry when flushing socket
..
Patch Set 5:
(1 comment)
https://gerrit.ovirt.org/#/c/47637/5//COMMIT_MSG
Commit Message:
Line 8:
Line 9: m2crypto re
gerrit-hooks has posted comments on this change.
Change subject: network: don't log missing brif files
..
Patch Set 2:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches
gerrit-hooks has posted comments on this change.
Change subject: network: don't log missing brif files
..
Patch Set 1:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches
gerrit-hooks has posted comments on this change.
Change subject: numa: only use libvirt for memory info
..
Patch Set 1:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matche
Martin Polednik has uploaded a new change for review.
Change subject: numa: only use libvirt for memory info
..
numa: only use libvirt for memory info
Current code queries memory usage via libvirt or /proc/meminfo,
depending on
Yaniv Bronhaim has posted comments on this change.
Change subject: xmlrpc: retry when flushing socket
..
Patch Set 5:
(1 comment)
https://gerrit.ovirt.org/#/c/47637/5//COMMIT_MSG
Commit Message:
Line 8:
Line 9: m2crypto requ
Piotr Kliczewski has posted comments on this change.
Change subject: xmlrpc: retry when flushing socket
..
Patch Set 5:
(2 comments)
https://gerrit.ovirt.org/#/c/47637/5//COMMIT_MSG
Commit Message:
Line 8:
Line 9: m2crypto r
Yaniv Bronhaim has posted comments on this change.
Change subject: xmlrpc: retry when flushing socket
..
Patch Set 5:
(2 comments)
https://gerrit.ovirt.org/#/c/47637/5//COMMIT_MSG
Commit Message:
Line 8:
Line 9: m2crypto req
Martin Sivák has posted comments on this change.
Change subject: Apply storage QoS on running VM
..
Patch Set 4:
(5 comments)
https://gerrit.ovirt.org/#/c/52746/4/lib/api/vdsmapi-schema.json
File lib/api/vdsmapi-schema.json:
Piotr Kliczewski has posted comments on this change.
Change subject: Adding vdsm functional tests
..
Patch Set 48:
(1 comment)
https://gerrit.ovirt.org/#/c/48268/48/automation/check-patch.repos.fc22
File automation/check-patch
Yaniv Bronhaim has posted comments on this change.
Change subject: Adding vdsm functional tests
..
Patch Set 48:
I want to remove the call from check-patch to check-merge and take this patch
as is . please review and see the o
Dan Kenigsberg has posted comments on this change.
Change subject: net: IP DHCP detection
..
Patch Set 2: Code-Review-1
(2 comments)
tiny comments. please have phoracek review his hook code
https://gerrit.ovirt.org/#/c/53076/
Francesco Romani has posted comments on this change.
Change subject: v2v: move v2v module to /var/lib/
..
Patch Set 1: Code-Review-1
(1 comment)
please correct the commit message summary!
Everything else seems OK
-1 for visibi
gerrit-hooks has posted comments on this change.
Change subject: WIP: DONTMERGE: better saveState
..
Patch Set 2:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug
gerrit-hooks has posted comments on this change.
Change subject: WIP DONTMERGE: migrationLimit retry
..
Patch Set 6:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches '
gerrit-hooks has posted comments on this change.
Change subject: WIP: DONTMERGE: do not leave leftovers if migrationCreate fails
..
Patch Set 2:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found
Edward Haas has posted comments on this change.
Change subject: net: Clean netinfo.__init__ and migrate to cache
..
Patch Set 4: Verified+1
--
To view, visit https://gerrit.ovirt.org/53007
To unsubscribe, visit https://gerrit.
gerrit-hooks has posted comments on this change.
Change subject: v2v: move v2v module to /var/lib/
..
Patch Set 1:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bu
Shahar Havivi has uploaded a new change for review.
Change subject: v2v: move v2v module to /var/lib/
..
v2v: move v2v module to /var/lib/
Change-Id: I5becf47fb1f139bd246d8853f2c890aa90eb4c7a
Signed-off-by: Shahar Havivi
---
M
gerrit-hooks has posted comments on this change.
Change subject: net: Clean netinfo.__init__ and migrate to cache
..
Patch Set 4:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure hea
David Caro has posted comments on this change.
Change subject: Adding vdsm functional tests
..
Patch Set 48:
The issue when extracting the tests xml is fixed here:
https://github.com/lago-project/lago/commit/24f83bf87249f
Edward Haas has posted comments on this change.
Change subject: net: Clean netinfo.__init__ and migrate to cache
..
Patch Set 3:
(1 comment)
https://gerrit.ovirt.org/#/c/53007/3/lib/vdsm/netinfo/cache.py
File lib/vdsm/netinfo/
Francesco Romani has posted comments on this change.
Change subject: migration: added support for convergance schedule
..
Patch Set 12:
(1 comment)
Well it is a suggestion, so if you think it doesn't make sense this is fine as
Francesco Romani has posted comments on this change.
Change subject: migration: added support for convergance schedule
..
Patch Set 12: Code-Review+1
partial ack
--
To view, visit https://gerrit.ovirt.org/46940
To unsubscribe
gerrit-hooks has posted comments on this change.
Change subject: Adding vdsm functional tests
..
Patch Set 48:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Ur
Piotr Kliczewski has posted comments on this change.
Change subject: xmlrpc: retry when flushing socket
..
Patch Set 5: Verified+1
Rebase only
--
To view, visit https://gerrit.ovirt.org/47637
To unsubscribe, visit https://ger
gerrit-hooks has posted comments on this change.
Change subject: xmlrpc: retry when flushing socket
..
Patch Set 5:
* #1261255::Update tracker: OK
* Check Bug-Url::OK
* Check Public Bug::#1261255::OK, public bug
* Check Product
gerrit-hooks has posted comments on this change.
Change subject: Adding vdsm functional tests
..
Patch Set 47:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Ur
gerrit-hooks has posted comments on this change.
Change subject: Adding vdsm functional tests
..
Patch Set 46:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Ur
Edward Haas has posted comments on this change.
Change subject: virt: Fix of uninitialized variable access in
Vm.setLinkAndNetwork()
..
Patch Set 1: Code-Review+1
--
To view, visit https://gerrit.ovirt.org/53061
To unsubscrib
Edward Haas has posted comments on this change.
Change subject: net: Canonize dhcpv6 on API input
..
Patch Set 1: Verified+1
--
To view, visit https://gerrit.ovirt.org/52989
To unsubscribe, visit https://gerrit.ovirt.org/setti
Edward Haas has posted comments on this change.
Change subject: net: Clean netinfo.__init__ and migrate to cache
..
Patch Set 3: Verified+1
--
To view, visit https://gerrit.ovirt.org/53007
To unsubscribe, visit https://gerrit.
Edward Haas has posted comments on this change.
Change subject: net: Clean netinfo.__init__ and migrate to cache
..
Patch Set 3:
(1 comment)
https://gerrit.ovirt.org/#/c/53007/3/lib/vdsm/netinfo/cache.py
File lib/vdsm/netinfo/
gerrit-hooks has posted comments on this change.
Change subject: hooks: make sure to handle vdsm exception in the bridge
..
Patch Set 2:
* #1295778::Update tracker: OK
* Set MODIFIED::bug 1295778#1295778IGNORE, not all
gerrit-hooks has posted comments on this change.
Change subject: exception: Make VdsmException reusable
..
Patch Set 2:
* Update tracker: IGNORE, no Bug-Url found
* Set MODIFIED::IGNORE, no Bug-Url found.
--
To view, visit ht
gerrit-hooks has posted comments on this change.
Change subject: hooks: moving hook error to exception module
..
Patch Set 2:
* Update tracker: IGNORE, no Bug-Url found
* Set MODIFIED::IGNORE, no Bug-Url found.
--
To view, vi
Yaniv Bronhaim has submitted this change and it was merged.
Change subject: hooks: make sure to handle vdsm exception in the bridge
..
hooks: make sure to handle vdsm exception in the bridge
We need to make sure to handle hook
Yaniv Bronhaim has submitted this change and it was merged.
Change subject: exception: Make VdsmException reusable
..
exception: Make VdsmException reusable
VdsmException was initializing code and message to default values if
c
Yaniv Bronhaim has submitted this change and it was merged.
Change subject: hooks: moving hook error to exception module
..
hooks: moving hook error to exception module
Required-For: https://bugzilla.redhat.com/1295778
Change-
Yaniv Bronhaim has posted comments on this change.
Change subject: hooks: make sure to handle vdsm exception in the bridge
..
Patch Set 1: Code-Review+2
--
To view, visit https://gerrit.ovirt.org/52984
To unsubscribe, visit ht
Yaniv Bronhaim has posted comments on this change.
Change subject: hooks: moving hook error to exception module
..
Patch Set 1: Code-Review+2
--
To view, visit https://gerrit.ovirt.org/52983
To unsubscribe, visit https://gerri
Yaniv Bronhaim has posted comments on this change.
Change subject: exception: Make VdsmException reusable
..
Patch Set 1: Code-Review+2
--
To view, visit https://gerrit.ovirt.org/52982
To unsubscribe, visit https://gerrit.ovir
gerrit-hooks has posted comments on this change.
Change subject: net: IP DHCP detection
..
Patch Set 2:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: '
a
Edward Haas has posted comments on this change.
Change subject: net: IP DHCP detection
..
Patch Set 2: Verified+1
--
To view, visit https://gerrit.ovirt.org/53076
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit
Edward Haas has posted comments on this change.
Change subject: net: IP DHCP detection
..
Patch Set 1:
(1 comment)
https://gerrit.ovirt.org/#/c/53076/1/lib/vdsm/netinfo/dhcp.py
File lib/vdsm/netinfo/dhcp.py:
Line 71: def _par
Dan Kenigsberg has submitted this change and it was merged.
Change subject: setupNetworks: moving nics between bonds
..
setupNetworks: moving nics between bonds
This patch fixes a problem where a slave removed from
one bond cou
gerrit-hooks has posted comments on this change.
Change subject: setupNetworks: moving nics between bonds
..
Patch Set 12:
* #1269175::Update tracker: OK
* Set MODIFIED::bug 1269175#1269175OK
--
To view, visit https:/
Dan Kenigsberg has submitted this change and it was merged.
Change subject: net: Fixing old netinfo access
..
net: Fixing old netinfo access
netinfo has been split into individual modules some time ago, this patch
fixes some le
Dan Kenigsberg has posted comments on this change.
Change subject: net: Fixing old netinfo access
..
Patch Set 2: Code-Review+2
--
To view, visit https://gerrit.ovirt.org/53011
To unsubscribe, visit https://gerrit.ovirt.org/se
gerrit-hooks has posted comments on this change.
Change subject: net: Fixing old netinfo access
..
Patch Set 3:
* Update tracker: IGNORE, no Bug-Url found
* Set MODIFIED::IGNORE, no Bug-Url found.
--
To view, visit https://ge
Dan Kenigsberg has posted comments on this change.
Change subject: net: Clean netinfo.__init__ and migrate to cache
..
Patch Set 3:
(1 comment)
https://gerrit.ovirt.org/#/c/53007/3/lib/vdsm/netinfo/cache.py
File lib/vdsm/netin
Dan Kenigsberg has posted comments on this change.
Change subject: net: Clean netinfo.__init__ and migrate to cache
..
Patch Set 3: Code-Review-1
--
To view, visit https://gerrit.ovirt.org/53007
To unsubscribe, visit https://g
Dan Kenigsberg has posted comments on this change.
Change subject: net: IP DHCP detection
..
Patch Set 1:
(1 comment)
partial review
https://gerrit.ovirt.org/#/c/53076/1/lib/vdsm/netinfo/dhcp.py
File lib/vdsm/netinfo/dhcp.py:
gerrit-hooks has posted comments on this change.
Change subject: net: Clean netinfo.__init__ and migrate to cache
..
Patch Set 3:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure hea
gerrit-hooks has posted comments on this change.
Change subject: net: Fixing old netinfo access
..
Patch Set 2:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-U
Edward Haas has posted comments on this change.
Change subject: net: Clean netinfo.__init__ and migrate to cache
..
Patch Set 2:
(2 comments)
https://gerrit.ovirt.org/#/c/53007/2/lib/vdsm/netinfo/__init__.py
File lib/vdsm/neti
Edward Haas has posted comments on this change.
Change subject: net: Fixing old netinfo access
..
Patch Set 1:
(1 comment)
https://gerrit.ovirt.org/#/c/53011/1/vdsm/virt/vmdevices/graphics.py
File vdsm/virt/vmdevices/graphics.
Marcin Mirecki has posted comments on this change.
Change subject: setupNetworks: moving nics between bonds
..
Patch Set 11: Verified+1
--
To view, visit https://gerrit.ovirt.org/50596
To unsubscribe, visit https://gerrit.ovir
Francesco Romani has posted comments on this change.
Change subject: virt: Fix of uninitialized variable access in
Vm.setLinkAndNetwork()
..
Patch Set 1: Code-Review+1
Fine, let's hear from the network folks. Partial ACK.
--
91 matches
Mail list logo
