Change in vdsm[master]: Removing generationID from clientIF

Nir Soffer has posted comments on this change. Change subject: Removing generationID from clientIF .. Patch Set 6: Yaniv, is this verified? -- To view, visit https://gerrit.ovirt.org/56475 To unsubscribe, visit

Change in vdsm[master]: automation: update glusterfs repos

gerrit-hooks has posted comments on this change. Change subject: automation: update glusterfs repos .. Patch Set 2: * Update tracker: IGNORE, no Bug-Url found * Set MODIFIED::IGNORE, no Bug-Url found. -- To view, visit

Change in vdsm[master]: automation: update glusterfs repos

Nir Soffer has posted comments on this change. Change subject: automation: update glusterfs repos .. Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.ovirt.org/56813 To unsubscribe, visit

Change in vdsm[master]: automation: update glusterfs repos

Nir Soffer has submitted this change and it was merged. Change subject: automation: update glusterfs repos .. automation: update glusterfs repos - dropped Gluster community repo for Fedora23 (reposync included): the repo is

Change in vdsm[master]: virt: Don't fail when existingConnAction is unset for a SPIC...

Nir Soffer has posted comments on this change. Change subject: virt: Don't fail when existingConnAction is unset for a SPICE device .. Patch Set 2: (3 comments) https://gerrit.ovirt.org/#/c/56836/2//COMMIT_MSG Commit

Change in vdsm[master]: storage: extend drives name to allow sata interface

Nir Soffer has posted comments on this change. Change subject: storage: extend drives name to allow sata interface .. Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.ovirt.org/56803 To unsubscribe, visit

Change in vdsm[master]: storage: Don't produce block volumes with TEMP_VOL_LVTAG

Nir Soffer has posted comments on this change. Change subject: storage: Don't produce block volumes with TEMP_VOL_LVTAG .. Patch Set 1: Code-Review-1 (1 comment) Looks like good idea, I wonder how many other places we should

Change in vdsm[master]: tests: add validate_domain_has_garbage helper

Nir Soffer has submitted this change and it was merged. Change subject: tests: add validate_domain_has_garbage helper .. tests: add validate_domain_has_garbage helper Many of the VolumeArtifacts failure case tests check that

Change in vdsm[master]: tests: add validate_domain_has_garbage helper

Nir Soffer has posted comments on this change. Change subject: tests: add validate_domain_has_garbage helper .. Patch Set 1: Verified+1 Jenkins is happy, so it must be verified. -- To view, visit

Change in vdsm[master]: tests: add validate_domain_has_garbage helper

gerrit-hooks has posted comments on this change. Change subject: tests: add validate_domain_has_garbage helper .. Patch Set 2: * Update tracker: IGNORE, no Bug-Url found * Set MODIFIED::IGNORE, no Bug-Url found. -- To view,

Change in vdsm[master]: tests: add validate_domain_has_garbage helper

Nir Soffer has posted comments on this change. Change subject: tests: add validate_domain_has_garbage helper .. Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.ovirt.org/56864 To unsubscribe, visit

Change in vdsm[master]: tests: Share failure function

Nir Soffer has posted comments on this change. Change subject: tests: Share failure function .. Patch Set 1: Code-Review-1 (2 comments) https://gerrit.ovirt.org/#/c/56863/1/tests/storage_volume_artifacts_test.py File

Change in vdsm[master]: storage: Add basic BlockVolumeArtifacts

Nir Soffer has posted comments on this change. Change subject: storage: Add basic BlockVolumeArtifacts .. Patch Set 18: Code-Review-1 (8 comments) https://gerrit.ovirt.org/#/c/55987/18/tests/storage_volume_artifacts_test.py

Change in vdsm[master]: v2v: small test improvement

Nir Soffer has posted comments on this change. Change subject: v2v: small test improvement .. Patch Set 1: (2 comments) https://gerrit.ovirt.org/#/c/56694/1/tests/v2vTests.py File tests/v2vTests.py: Line 377:

Change in vdsm[master]: v2v: Detect VM with snapshots

Nir Soffer has posted comments on this change. Change subject: v2v: Detect VM with snapshots .. Patch Set 4: (2 comments) https://gerrit.ovirt.org/#/c/56574/4/lib/vdsm/v2v.py File lib/vdsm/v2v.py: Line 897:

Change in vdsm[master]: v2v: Detect VM with snapshots

Nir Soffer has posted comments on this change. Change subject: v2v: Detect VM with snapshots .. Patch Set 4: (1 comment) https://gerrit.ovirt.org/#/c/56574/1/tests/v2vTests.py File tests/v2vTests.py: Line 75:

Change in vdsm[master]: v2v: small test improvement

Nir Soffer has posted comments on this change. Change subject: v2v: small test improvement .. Patch Set 1: (2 comments) https://gerrit.ovirt.org/#/c/56694/1/tests/v2vTests.py File tests/v2vTests.py: Line 377:

Change in vdsm[master]: tests: add validate_domain_has_garbage helper

gerrit-hooks has posted comments on this change. Change subject: tests: add validate_domain_has_garbage helper .. Patch Set 1: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure

Change in vdsm[master]: storage: Don't produce block volumes with TEMP_VOL_LVTAG

gerrit-hooks has posted comments on this change. Change subject: storage: Don't produce block volumes with TEMP_VOL_LVTAG .. Patch Set 1: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make

Change in vdsm[master]: cow wip

gerrit-hooks has posted comments on this change. Change subject: cow wip .. Patch Set 11: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid

Change in vdsm[master]: tests: Prepare for COW_FORMAT test permutations

gerrit-hooks has posted comments on this change. Change subject: tests: Prepare for COW_FORMAT test permutations .. Patch Set 8: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure

Change in vdsm[master]: Support initial_size parameter

gerrit-hooks has posted comments on this change. Change subject: Support initial_size parameter .. Patch Set 11: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches

Change in vdsm[master]: tests: Share failure function

gerrit-hooks has posted comments on this change. Change subject: tests: Share failure function .. Patch Set 1: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches

Change in vdsm[master]: tests: Share failure function

Adam Litke has uploaded a new change for review. Change subject: tests: Share failure function .. tests: Share failure function Tests that want to check failures replace VolumeArtifacts functions with the failure() function.

Change in vdsm[master]: tests: add validate_domain_has_garbage helper

Adam Litke has uploaded a new change for review. Change subject: tests: add validate_domain_has_garbage helper .. tests: add validate_domain_has_garbage helper Many of the VolumeArtifacts failure case tests check that the

Change in vdsm[master]: storage: Add basic BlockVolumeArtifacts

gerrit-hooks has posted comments on this change. Change subject: storage: Add basic BlockVolumeArtifacts .. Patch Set 18: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header

Change in vdsm[master]: storage: Don't produce block volumes with TEMP_VOL_LVTAG

Adam Litke has uploaded a new change for review. Change subject: storage: Don't produce block volumes with TEMP_VOL_LVTAG .. storage: Don't produce block volumes with TEMP_VOL_LVTAG LVs with the tag TEMP_VOL_LVTAG are not

Change in vdsm[master]: AUTHORS: adding Dominik Holler

gerrit-hooks has posted comments on this change. Change subject: AUTHORS: adding Dominik Holler .. Patch Set 1: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches

Change in vdsm[master]: netinfo: improve the detection if device has VLAN devices on...

gerrit-hooks has posted comments on this change. Change subject: netinfo: improve the detection if device has VLAN devices on top. .. Patch Set 1: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url

Change in vdsm[master]: yml: generate api doc from the schema

Piotr Kliczewski has posted comments on this change. Change subject: yml: generate api doc from the schema .. Patch Set 4: Verified+1 -- To view, visit https://gerrit.ovirt.org/56387 To unsubscribe, visit

Change in vdsm[master]: Removing generationID from clientIF

Piotr Kliczewski has posted comments on this change. Change subject: Removing generationID from clientIF .. Patch Set 6: Code-Review+2 I checked engine code and not found it being used. Fake vdsm is sending it as well but

Change in vdsm[master]: storage: add block device naming tests

Martin Polednik has posted comments on this change. Change subject: storage: add block device naming tests .. Patch Set 1: (2 comments) https://gerrit.ovirt.org/#/c/56802/1/tests/vmStorageTests.py File

Change in vdsm[master]: automation: Run make check over el7 in automation CI

Piotr Kliczewski has posted comments on this change. Change subject: automation: Run make check over el7 in automation CI .. Patch Set 6: Code-Review+1 -- To view, visit https://gerrit.ovirt.org/56122 To unsubscribe, visit

Change in vdsm[master]: yml: generate api doc from the schema

gerrit-hooks has posted comments on this change. Change subject: yml: generate api doc from the schema .. Patch Set 4: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header

Change in vdsm[master]: automation: update glusterfs repos

Piotr Kliczewski has posted comments on this change. Change subject: automation: update glusterfs repos .. Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.ovirt.org/56813 To unsubscribe, visit

Change in vdsm[master]: virt: graphics: enforce spice default mode

Michal Skrivanek has posted comments on this change. Change subject: virt: graphics: enforce spice default mode .. Patch Set 3: Code-Review+1 (1 comment) https://gerrit.ovirt.org/#/c/56746/3/vdsm/virt/vmdevices/graphics.py

Change in vdsm[master]: mkimage: mk_sysprep_floppy to supervdsm

Michal Skrivanek has posted comments on this change. Change subject: mkimage: mk_sysprep_floppy to supervdsm .. Patch Set 2: I'd much rather see it go away instead. We want to eliminate floppy and forget about it;) sysprep

Change in vdsm[master]: virt: graphics: open nontls port only if requested

Michal Skrivanek has posted comments on this change. Change subject: virt: graphics: open nontls port only if requested .. Patch Set 2: Code-Review+1 nice 4.0 change. Docs need to be updated because now we have twice as many

Change in vdsm[master]: mkimage: mk_sysprep_floppy to supervdsm

gerrit-hooks has posted comments on this change. Change subject: mkimage: mk_sysprep_floppy to supervdsm .. Patch Set 3: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header

Change in vdsm[master]: mkimage: extract mkfloppy helper

gerrit-hooks has posted comments on this change. Change subject: mkimage: extract mkfloppy helper .. Patch Set 1: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches

Change in vdsm[master]: mkimage: extract mkfloppy helper

Francesco Romani has uploaded a new change for review. Change subject: mkimage: extract mkfloppy helper .. mkimage: extract mkfloppy helper A future patch wants to add a different way to create a floppy image, so we extract the

Change in vdsm[master]: rpc: Make Bridge#_type_fixup more robust

Piotr Kliczewski has posted comments on this change. Change subject: rpc: Make Bridge#_type_fixup more robust .. Patch Set 1: (1 comment) https://gerrit.ovirt.org/#/c/56811/1/lib/vdsm/rpc/Bridge.py File

Change in vdsm[master]: require NetworkManager-config-server

Piotr Kliczewski has posted comments on this change. Change subject: require NetworkManager-config-server .. Patch Set 3: Code-Review+2 -- To view, visit https://gerrit.ovirt.org/56622 To unsubscribe, visit

Change in vdsm[master]: bridge: data verification

gerrit-hooks has posted comments on this change. Change subject: bridge: data verification .. Patch Set 25: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url:

Change in vdsm[master]: schema: externalize api_strict_mode

gerrit-hooks has posted comments on this change. Change subject: schema: externalize api_strict_mode .. Patch Set 3: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches

Change in vdsm[master]: vdsmapi: prepare for event naming

gerrit-hooks has posted comments on this change. Change subject: vdsmapi: prepare for event naming .. Patch Set 8: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches

Change in vdsm[master]: contrib: schema converter

gerrit-hooks has posted comments on this change. Change subject: contrib: schema converter .. Patch Set 37: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url:

Change in vdsm[master]: yml: generate api doc from the schema

gerrit-hooks has posted comments on this change. Change subject: yml: generate api doc from the schema .. Patch Set 3: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header

Change in vdsm[master]: Using pkgutil instead of redundant private funcs in configur...

Piotr Kliczewski has posted comments on this change. Change subject: Using pkgutil instead of redundant private funcs in configurator .. Patch Set 11: (1 comment)

Change in vdsm[master]: contrib: schema converter

Piotr Kliczewski has posted comments on this change. Change subject: contrib: schema converter .. Patch Set 37: Verified+1 Rebased and yaml schema updated. Verified by updating a host and seeing that communication works. --

Change in vdsm[master]: yml: generate api doc from the schema

Piotr Kliczewski has posted comments on this change. Change subject: yml: generate api doc from the schema .. Patch Set 3: Verified+1 Rebased, added changes to build-artifacts.sh ask Yaniv requested. Verified by updating a

Change in vdsm[master]: schema: externalize api_strict_mode

Piotr Kliczewski has posted comments on this change. Change subject: schema: externalize api_strict_mode .. Patch Set 3: Verified+1 Rebased, no code changes. Verified by updating a host and seeing that communication works.

Change in vdsm[master]: events: introduction of schema

Piotr Kliczewski has posted comments on this change. Change subject: events: introduction of schema .. Patch Set 17: Verified+1 Rebased, no code changes. Verified by updating a host and seeing that communication works. --

Change in vdsm[master]: json: removal of old schemas

Piotr Kliczewski has posted comments on this change. Change subject: json: removal of old schemas .. Patch Set 21: Verified+1 Rebased, no code changes. Verified by updating a host and seeing that communication works. -- To

Change in vdsm[master]: bridge: data verification

Piotr Kliczewski has posted comments on this change. Change subject: bridge: data verification .. Patch Set 25: Verified+1 Rebased, no code changes. Verified by updating a host and seeing that communication works. -- To

Change in vdsm[master]: bridge: usage of yaml schema

Piotr Kliczewski has posted comments on this change. Change subject: bridge: usage of yaml schema .. Patch Set 20: Verified+1 Rebased, no code changes. Verified by updating a host and seeing that communication works. -- To

Change in vdsm[master]: events: introduction of schema

gerrit-hooks has posted comments on this change. Change subject: events: introduction of schema .. Patch Set 17: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches

Change in vdsm[master]: events: verify data before sending

gerrit-hooks has posted comments on this change. Change subject: events: verify data before sending .. Patch Set 7: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches

Change in vdsm[master]: json: removal of old schemas

gerrit-hooks has posted comments on this change. Change subject: json: removal of old schemas .. Patch Set 21: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches

Change in vdsm[master]: bridge: usage of yaml schema

gerrit-hooks has posted comments on this change. Change subject: bridge: usage of yaml schema .. Patch Set 20: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches

Change in vdsm[master]: virt: graphics: open nontls port only if requested

gerrit-hooks has posted comments on this change. Change subject: virt: graphics: open nontls port only if requested .. Patch Set 2: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure

Change in vdsm[master]: mkimage: mk_sysprep_floppy to supervdsm

gerrit-hooks has posted comments on this change. Change subject: mkimage: mk_sysprep_floppy to supervdsm .. Patch Set 2: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header

Change in vdsm[master]: mkimage: mk_sysprep_floppy to supervdsm

gerrit-hooks has posted comments on this change. Change subject: mkimage: mk_sysprep_floppy to supervdsm .. Patch Set 1: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header

Change in vdsm[master]: net: netinfo/cache.py handles only legacy nets

gerrit-hooks has posted comments on this change. Change subject: net: netinfo/cache.py handles only legacy nets .. Patch Set 1: * #1195208::Update tracker: OK * Check Bug-Url::OK * Check Public Bug::#1195208::OK, public bug *

Change in vdsm[master]: virt: Don't fail when existingConnAction is unset for a SPIC...

Francesco Romani has posted comments on this change. Change subject: virt: Don't fail when existingConnAction is unset for a SPICE device .. Patch Set 2: Code-Review+2 looks fine. I'd like to have another look at the tests

Change in vdsm[master]: net: netinfo/cache.py handles only legacy nets

Petr Horáček has uploaded a new change for review. Change subject: net: netinfo/cache.py handles only legacy nets .. net: netinfo/cache.py handles only legacy nets netinfo/cache.py fails while trying to _getNetInfo on OVS

Change in vdsm[master]: virt: graphics: enforce spice default mode

gerrit-hooks has posted comments on this change. Change subject: virt: graphics: enforce spice default mode .. Patch Set 3: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header

Change in vdsm[master]: virt: graphics: open nontls port only if requested

gerrit-hooks has posted comments on this change. Change subject: virt: graphics: open nontls port only if requested .. Patch Set 1: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure

Change in vdsm[master]: virt: graphics: open nontls port only if requested

Francesco Romani has uploaded a new change for review. Change subject: virt: graphics: open nontls port only if requested .. virt: graphics: open nontls port only if requested The best practices about configuring the SPICE

Change in vdsm[master]: net: get network switch type from libvirt

gerrit-hooks has posted comments on this change. Change subject: net: get network switch type from libvirt .. Patch Set 1: * #1195208::Update tracker: OK * Check Bug-Url::OK * Check Public Bug::#1195208::OK, public bug * Check

Change in vdsm[master]: net: get network switch type from libvirt

Petr Horáček has uploaded a new change for review. Change subject: net: get network switch type from libvirt .. net: get network switch type from libvirt Until now we reported switch type as 'legacy'. Now we get actual switch

Change in vdsm[master]: net: add vlan tag to libvirt network def

gerrit-hooks has posted comments on this change. Change subject: net: add vlan tag to libvirt network def .. Patch Set 4: * #1195208::Update tracker: OK * Check Bug-Url::OK * Check Public Bug::#1195208::OK, public bug * Check

Change in vdsm[master]: net: add virtual port to libvirt network def

gerrit-hooks has posted comments on this change. Change subject: net: add virtual port to libvirt network def .. Patch Set 3: * #1195208::Update tracker: OK * Check Bug-Url::OK * Check Public Bug::#1195208::OK, public bug *

Change in vdsm[master]: virt: Don't fail when existingConnAction is unset for a SPIC...

gerrit-hooks has posted comments on this change. Change subject: virt: Don't fail when existingConnAction is unset for a SPICE device .. Patch Set 2: * #1060573::Update tracker: OK * Check Bug-Url::OK * Check Public

Change in vdsm[master]: virt: Don't set connected attribute in if already...

Milan Zamazal has abandoned this change. Change subject: virt: Don't set connected attribute in if already set .. Abandoned Abandoned in favor of https://gerrit.ovirt.org/56836 + some Engine side solution. -- To view,

Change in vdsm[master]: virt: Don't set connected attribute in if already...

gerrit-hooks has posted comments on this change. Change subject: virt: Don't set connected attribute in if already set .. Patch Set 4: * #1060573::Update tracker: OK -- To view, visit https://gerrit.ovirt.org/56224 To

Change in vdsm[master]: virt: Don't fail when existingConnAction is unset for a SPIC...

Milan Zamazal has uploaded a new change for review. Change subject: virt: Don't fail when existingConnAction is unset for a SPICE device .. virt: Don't fail when existingConnAction is unset for a SPICE device When a ticket for

Change in vdsm[master]: automation: update glusterfs repos

Nadav Goldin has posted comments on this change. Change subject: automation: update glusterfs repos .. Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.ovirt.org/56813 To unsubscribe, visit

Change in vdsm[master]: automation: update glusterfs repos

Sahina Bose has posted comments on this change. Change subject: automation: update glusterfs repos .. Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.ovirt.org/56813 To unsubscribe, visit