Nir Soffer has posted comments on this change.
Change subject: Removing generationID from clientIF
..
Patch Set 6:
Yaniv, is this verified?
--
To view, visit https://gerrit.ovirt.org/56475
To unsubscribe, visit https://gerrit
gerrit-hooks has posted comments on this change.
Change subject: automation: update glusterfs repos
..
Patch Set 2:
* Update tracker: IGNORE, no Bug-Url found
* Set MODIFIED::IGNORE, no Bug-Url found.
--
To view, visit https:
Nir Soffer has posted comments on this change.
Change subject: automation: update glusterfs repos
..
Patch Set 1: Code-Review+2
--
To view, visit https://gerrit.ovirt.org/56813
To unsubscribe, visit https://gerrit.ovirt.org/se
Nir Soffer has submitted this change and it was merged.
Change subject: automation: update glusterfs repos
..
automation: update glusterfs repos
- dropped Gluster community repo for Fedora23 (reposync included):
the repo is e
Nir Soffer has posted comments on this change.
Change subject: virt: Don't fail when existingConnAction is unset for a SPICE
device
..
Patch Set 2:
(3 comments)
https://gerrit.ovirt.org/#/c/56836/2//COMMIT_MSG
Commit Message:
Nir Soffer has posted comments on this change.
Change subject: storage: extend drives name to allow sata interface
..
Patch Set 1: Code-Review+1
--
To view, visit https://gerrit.ovirt.org/56803
To unsubscribe, visit https://ge
Nir Soffer has posted comments on this change.
Change subject: storage: Don't produce block volumes with TEMP_VOL_LVTAG
..
Patch Set 1: Code-Review-1
(1 comment)
Looks like good idea, I wonder how many other places we should c
Nir Soffer has submitted this change and it was merged.
Change subject: tests: add validate_domain_has_garbage helper
..
tests: add validate_domain_has_garbage helper
Many of the VolumeArtifacts failure case tests check that th
Nir Soffer has posted comments on this change.
Change subject: tests: add validate_domain_has_garbage helper
..
Patch Set 1: Verified+1
Jenkins is happy, so it must be verified.
--
To view, visit https://gerrit.ovirt.org/5686
gerrit-hooks has posted comments on this change.
Change subject: tests: add validate_domain_has_garbage helper
..
Patch Set 2:
* Update tracker: IGNORE, no Bug-Url found
* Set MODIFIED::IGNORE, no Bug-Url found.
--
To view, v
Nir Soffer has posted comments on this change.
Change subject: tests: add validate_domain_has_garbage helper
..
Patch Set 1: Code-Review+2
--
To view, visit https://gerrit.ovirt.org/56864
To unsubscribe, visit https://gerrit.o
Nir Soffer has posted comments on this change.
Change subject: tests: Share failure function
..
Patch Set 1: Code-Review-1
(2 comments)
https://gerrit.ovirt.org/#/c/56863/1/tests/storage_volume_artifacts_test.py
File tests/sto
Nir Soffer has posted comments on this change.
Change subject: storage: Add basic BlockVolumeArtifacts
..
Patch Set 18: Code-Review-1
(8 comments)
https://gerrit.ovirt.org/#/c/55987/18/tests/storage_volume_artifacts_test.py
Fi
Nir Soffer has posted comments on this change.
Change subject: v2v: small test improvement
..
Patch Set 1:
(2 comments)
https://gerrit.ovirt.org/#/c/56694/1/tests/v2vTests.py
File tests/v2vTests.py:
Line 377: self
Nir Soffer has posted comments on this change.
Change subject: v2v: Detect VM with snapshots
..
Patch Set 4:
(2 comments)
https://gerrit.ovirt.org/#/c/56574/4/lib/vdsm/v2v.py
File lib/vdsm/v2v.py:
Line 897: i['mod
Nir Soffer has posted comments on this change.
Change subject: v2v: Detect VM with snapshots
..
Patch Set 4:
(1 comment)
https://gerrit.ovirt.org/#/c/56574/1/tests/v2vTests.py
File tests/v2vTests.py:
Line 75: self._uu
Nir Soffer has posted comments on this change.
Change subject: v2v: small test improvement
..
Patch Set 1:
(2 comments)
https://gerrit.ovirt.org/#/c/56694/1/tests/v2vTests.py
File tests/v2vTests.py:
Line 377: self
gerrit-hooks has posted comments on this change.
Change subject: tests: add validate_domain_has_garbage helper
..
Patch Set 1:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header
gerrit-hooks has posted comments on this change.
Change subject: cow wip
..
Patch Set 11:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: '
and is a valid
gerrit-hooks has posted comments on this change.
Change subject: storage: Don't produce block volumes with TEMP_VOL_LVTAG
..
Patch Set 1:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make
gerrit-hooks has posted comments on this change.
Change subject: Support initial_size parameter
..
Patch Set 11:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-
gerrit-hooks has posted comments on this change.
Change subject: tests: Prepare for COW_FORMAT test permutations
..
Patch Set 8:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure head
gerrit-hooks has posted comments on this change.
Change subject: tests: Share failure function
..
Patch Set 1:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Ur
Adam Litke has uploaded a new change for review.
Change subject: tests: Share failure function
..
tests: Share failure function
Tests that want to check failures replace VolumeArtifacts functions with
the failure() function. Mo
Adam Litke has uploaded a new change for review.
Change subject: tests: add validate_domain_has_garbage helper
..
tests: add validate_domain_has_garbage helper
Many of the VolumeArtifacts failure case tests check that the domain
gerrit-hooks has posted comments on this change.
Change subject: storage: Add basic BlockVolumeArtifacts
..
Patch Set 18:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matc
Adam Litke has uploaded a new change for review.
Change subject: storage: Don't produce block volumes with TEMP_VOL_LVTAG
..
storage: Don't produce block volumes with TEMP_VOL_LVTAG
LVs with the tag TEMP_VOL_LVTAG are not volume
gerrit-hooks has posted comments on this change.
Change subject: AUTHORS: adding Dominik Holler
..
Patch Set 1:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'B
gerrit-hooks has posted comments on this change.
Change subject: netinfo: improve the detection if device has VLAN devices on
top.
..
Patch Set 1:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url fo
Piotr Kliczewski has posted comments on this change.
Change subject: yml: generate api doc from the schema
..
Patch Set 4: Verified+1
--
To view, visit https://gerrit.ovirt.org/56387
To unsubscribe, visit https://gerrit.ovirt.
Piotr Kliczewski has posted comments on this change.
Change subject: Removing generationID from clientIF
..
Patch Set 6: Code-Review+2
I checked engine code and not found it being used. Fake vdsm is sending it as
well but this
Martin Polednik has posted comments on this change.
Change subject: storage: add block device naming tests
..
Patch Set 1:
(2 comments)
https://gerrit.ovirt.org/#/c/56802/1/tests/vmStorageTests.py
File tests/vmStorageTests.py:
Piotr Kliczewski has posted comments on this change.
Change subject: automation: Run make check over el7 in automation CI
..
Patch Set 6: Code-Review+1
--
To view, visit https://gerrit.ovirt.org/56122
To unsubscribe, visit htt
gerrit-hooks has posted comments on this change.
Change subject: yml: generate api doc from the schema
..
Patch Set 4:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches
Piotr Kliczewski has posted comments on this change.
Change subject: automation: update glusterfs repos
..
Patch Set 1: Code-Review+1
--
To view, visit https://gerrit.ovirt.org/56813
To unsubscribe, visit https://gerrit.ovirt.
Michal Skrivanek has posted comments on this change.
Change subject: virt: graphics: enforce spice default mode
..
Patch Set 3: Code-Review+1
(1 comment)
https://gerrit.ovirt.org/#/c/56746/3/vdsm/virt/vmdevices/graphics.py
Fil
Michal Skrivanek has posted comments on this change.
Change subject: mkimage: mk_sysprep_floppy to supervdsm
..
Patch Set 2:
I'd much rather see it go away instead. We want to eliminate floppy and forget
about it;)
sysprep sho
Michal Skrivanek has posted comments on this change.
Change subject: virt: graphics: open nontls port only if requested
..
Patch Set 2: Code-Review+1
nice 4.0 change. Docs need to be updated because now we have twice as many
p
gerrit-hooks has posted comments on this change.
Change subject: mkimage: mk_sysprep_floppy to supervdsm
..
Patch Set 3:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header match
gerrit-hooks has posted comments on this change.
Change subject: mkimage: extract mkfloppy helper
..
Patch Set 1:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug
Francesco Romani has uploaded a new change for review.
Change subject: mkimage: extract mkfloppy helper
..
mkimage: extract mkfloppy helper
A future patch wants to add a different way
to create a floppy image, so we extract the
Piotr Kliczewski has posted comments on this change.
Change subject: rpc: Make Bridge#_type_fixup more robust
..
Patch Set 1:
(1 comment)
https://gerrit.ovirt.org/#/c/56811/1/lib/vdsm/rpc/Bridge.py
File lib/vdsm/rpc/Bridge.py:
Piotr Kliczewski has posted comments on this change.
Change subject: require NetworkManager-config-server
..
Patch Set 3: Code-Review+2
--
To view, visit https://gerrit.ovirt.org/56622
To unsubscribe, visit https://gerrit.ovir
gerrit-hooks has posted comments on this change.
Change subject: bridge: data verification
..
Patch Set 25:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url:
gerrit-hooks has posted comments on this change.
Change subject: schema: externalize api_strict_mode
..
Patch Set 3:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches '
gerrit-hooks has posted comments on this change.
Change subject: vdsmapi: prepare for event naming
..
Patch Set 8:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bu
gerrit-hooks has posted comments on this change.
Change subject: contrib: schema converter
..
Patch Set 37:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url:
gerrit-hooks has posted comments on this change.
Change subject: yml: generate api doc from the schema
..
Patch Set 3:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches
Piotr Kliczewski has posted comments on this change.
Change subject: Using pkgutil instead of redundant private funcs in configurator
..
Patch Set 11:
(1 comment)
https://gerrit.ovirt.org/#/c/53214/11/lib/vdsm/tool/configurato
Piotr Kliczewski has posted comments on this change.
Change subject: contrib: schema converter
..
Patch Set 37: Verified+1
Rebased and yaml schema updated. Verified by updating a host and seeing that
communication works.
--
Piotr Kliczewski has posted comments on this change.
Change subject: yml: generate api doc from the schema
..
Patch Set 3: Verified+1
Rebased, added changes to build-artifacts.sh ask Yaniv requested. Verified by
updating a hos
Piotr Kliczewski has posted comments on this change.
Change subject: schema: externalize api_strict_mode
..
Patch Set 3: Verified+1
Rebased, no code changes. Verified by updating a host and seeing that
communication works.
--
Piotr Kliczewski has posted comments on this change.
Change subject: events: introduction of schema
..
Patch Set 17: Verified+1
Rebased, no code changes. Verified by updating a host and seeing that
communication works.
--
To
Piotr Kliczewski has posted comments on this change.
Change subject: json: removal of old schemas
..
Patch Set 21: Verified+1
Rebased, no code changes. Verified by updating a host and seeing that
communication works.
--
To v
Piotr Kliczewski has posted comments on this change.
Change subject: bridge: data verification
..
Patch Set 25: Verified+1
Rebased, no code changes. Verified by updating a host and seeing that
communication works.
--
To view
Piotr Kliczewski has posted comments on this change.
Change subject: bridge: usage of yaml schema
..
Patch Set 20: Verified+1
Rebased, no code changes. Verified by updating a host and seeing that
communication works.
--
To v
gerrit-hooks has posted comments on this change.
Change subject: events: introduction of schema
..
Patch Set 17:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-
gerrit-hooks has posted comments on this change.
Change subject: events: verify data before sending
..
Patch Set 7:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'B
gerrit-hooks has posted comments on this change.
Change subject: json: removal of old schemas
..
Patch Set 21:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Ur
gerrit-hooks has posted comments on this change.
Change subject: bridge: usage of yaml schema
..
Patch Set 20:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Ur
gerrit-hooks has posted comments on this change.
Change subject: virt: graphics: open nontls port only if requested
..
Patch Set 2:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure h
gerrit-hooks has posted comments on this change.
Change subject: mkimage: mk_sysprep_floppy to supervdsm
..
Patch Set 2:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header match
gerrit-hooks has posted comments on this change.
Change subject: mkimage: mk_sysprep_floppy to supervdsm
..
Patch Set 1:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header match
gerrit-hooks has posted comments on this change.
Change subject: net: netinfo/cache.py handles only legacy nets
..
Patch Set 1:
* #1195208::Update tracker: OK
* Check Bug-Url::OK
* Check Public Bug::#1195208::OK, public bug
* C
Francesco Romani has posted comments on this change.
Change subject: virt: Don't fail when existingConnAction is unset for a SPICE
device
..
Patch Set 2: Code-Review+2
looks fine. I'd like to have another look at the tests (to
Petr Horáček has uploaded a new change for review.
Change subject: net: netinfo/cache.py handles only legacy nets
..
net: netinfo/cache.py handles only legacy nets
netinfo/cache.py fails while trying to _getNetInfo on OVS networ
gerrit-hooks has posted comments on this change.
Change subject: virt: graphics: enforce spice default mode
..
Patch Set 3:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header ma
gerrit-hooks has posted comments on this change.
Change subject: virt: graphics: open nontls port only if requested
..
Patch Set 1:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure h
Francesco Romani has uploaded a new change for review.
Change subject: virt: graphics: open nontls port only if requested
..
virt: graphics: open nontls port only if requested
The best practices about configuring the SPICE conne
gerrit-hooks has posted comments on this change.
Change subject: net: get network switch type from libvirt
..
Patch Set 1:
* #1195208::Update tracker: OK
* Check Bug-Url::OK
* Check Public Bug::#1195208::OK, public bug
* Check
Petr Horáček has uploaded a new change for review.
Change subject: net: get network switch type from libvirt
..
net: get network switch type from libvirt
Until now we reported switch type as 'legacy'. Now we get actual
switch ty
gerrit-hooks has posted comments on this change.
Change subject: net: add vlan tag to libvirt network def
..
Patch Set 4:
* #1195208::Update tracker: OK
* Check Bug-Url::OK
* Check Public Bug::#1195208::OK, public bug
* Check P
gerrit-hooks has posted comments on this change.
Change subject: net: add virtual port to libvirt network def
..
Patch Set 3:
* #1195208::Update tracker: OK
* Check Bug-Url::OK
* Check Public Bug::#1195208::OK, public bug
* Che
gerrit-hooks has posted comments on this change.
Change subject: virt: Don't fail when existingConnAction is unset for a SPICE
device
..
Patch Set 2:
* #1060573::Update tracker: OK
* Check Bug-Url::OK
* Check Public Bug::#1060
Milan Zamazal has abandoned this change.
Change subject: virt: Don't set connected attribute in if already set
..
Abandoned
Abandoned in favor of https://gerrit.ovirt.org/56836 + some Engine side
solution.
--
To view, visit
gerrit-hooks has posted comments on this change.
Change subject: virt: Don't set connected attribute in if already set
..
Patch Set 4:
* #1060573::Update tracker: OK
--
To view, visit https://gerrit.ovirt.org/56224
To unsubs
Milan Zamazal has uploaded a new change for review.
Change subject: virt: Don't fail when existingConnAction is unset for a SPICE
device
..
virt: Don't fail when existingConnAction is unset for a SPICE device
When a ticket for
Nadav Goldin has posted comments on this change.
Change subject: automation: update glusterfs repos
..
Patch Set 1: Code-Review+1
--
To view, visit https://gerrit.ovirt.org/56813
To unsubscribe, visit https://gerrit.ovirt.org/
Sahina Bose has posted comments on this change.
Change subject: automation: update glusterfs repos
..
Patch Set 1: Code-Review+1
--
To view, visit https://gerrit.ovirt.org/56813
To unsubscribe, visit https://gerrit.ovirt.org/s
79 matches
Mail list logo