Francesco Romani has posted comments on this change.
Change subject: virt: add device setup and teardown
..
Patch Set 14:
(2 comments)
partial review
https://gerrit.ovirt.org/#/c/55135/14/tests/vmTests.py
File tests/vmTests.p
Milan Zamazal has posted comments on this change.
Change subject: vmtests: use assertXMLEqual in assertBuildCmdline
..
Patch Set 1: Code-Review+1
--
To view, visit https://gerrit.ovirt.org/56973
To unsubscribe, visit https://g
Francesco Romani has posted comments on this change.
Change subject: rpc: Make Bridge#_type_fixup more robust
..
Patch Set 3: Code-Review+1
--
To view, visit https://gerrit.ovirt.org/56811
To unsubscribe, visit https://gerrit.
Francesco Romani has posted comments on this change.
Change subject: cdrom: API change: require index
..
Patch Set 1:
(1 comment)
https://gerrit.ovirt.org/#/c/56805/1/lib/api/vdsmapi-schema.json
File lib/api/vdsmapi-schema.jso
Shahar Havivi has posted comments on this change.
Change subject: v2v: Detect VM with snapshots
..
Patch Set 5: Code-Review+1
--
To view, visit https://gerrit.ovirt.org/56574
To unsubscribe, visit https://gerrit.ovirt.org/sett
Francesco Romani has posted comments on this change.
Change subject: vmdevices: make disk's makeName public
..
Patch Set 2: Code-Review+2
please make sure the jenkins failure is bogus
--
To view, visit https://gerrit.ovirt.or
Francesco Romani has posted comments on this change.
Change subject: storage: extend drives name to allow sata interface
..
Patch Set 2: Code-Review+2
please try to make jenkins happy!
--
To view, visit https://gerrit.ovirt.o
Francesco Romani has posted comments on this change.
Change subject: storage: add block device naming tests
..
Patch Set 2: Code-Review+2
--
To view, visit https://gerrit.ovirt.org/56802
To unsubscribe, visit https://gerrit.ov
Nir Soffer has posted comments on this change.
Change subject: blkid: Remove leftovers
..
Patch Set 1:
Engine never used this feaure, and it was already removed - this only remove
leftovers that should have been removed in the
Francesco Romani has posted comments on this change.
Change subject: blkid: Remove leftovers
..
Patch Set 1: Code-Review+1
fine for me as long as this doesn't brake backward compatibility (just asking)
--
To view, visit https
Edward Haas has posted comments on this change.
Change subject: net: don't handle OVS networks in netinfo
..
Patch Set 2: Code-Review-1
(1 comment)
Just a nit
https://gerrit.ovirt.org/#/c/56838/2/lib/vdsm/netinfo/__init__.py
Francesco Romani has posted comments on this change.
Change subject: v2v: Detect VM with snapshots
..
Patch Set 5:
I'm a bit surprised this is not working on RHEL5. Just for my understanding,
you mean the API is not available
Francesco Romani has posted comments on this change.
Change subject: v2v: Detect VM with snapshots
..
Patch Set 4:
(1 comment)
https://gerrit.ovirt.org/#/c/56574/4/lib/vdsm/v2v.py
File lib/vdsm/v2v.py:
Line 897: i
Tomas Golembiovsky has posted comments on this change.
Change subject: v2v: Detect VM with snapshots
..
Patch Set 5: Verified-1
The API is not supported in libvirt+Xen on RHEL5. Wi will have to make the
check for VMware only.
Edward Haas has posted comments on this change.
Change subject: net: add vlan tag to libvirt network def
..
Patch Set 5: Code-Review-1
Basically the same comments as in https://gerrit.ovirt.org/#/c/56828
There is however a gen
Idan Shaby has posted comments on this change.
Change subject: storage: add support for blkdiscard command
..
Patch Set 6: Verified+1
(1 comment)
https://gerrit.ovirt.org/#/c/35629/5/tests/Makefile.am
File tests/Makefile.am:
gerrit-hooks has posted comments on this change.
Change subject: storage: add support for blkdiscard command
..
Patch Set 6:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header m
Nir Soffer has posted comments on this change.
Change subject: monitor: Convert valid to read-only property
..
Patch Set 6: Continuous-Integration+1
Jenkins failed to build this after rebase - ignoring it.
--
To view, visit h
Nir Soffer has posted comments on this change.
Change subject: bridge: data verification
..
Patch Set 26:
Piotr, did you check this?
https://pypi.python.org/pypi/jsonschema
https://github.com/Julian/jsonschema
Looks like popul
Nir Soffer has posted comments on this change.
Change subject: blkid: Remove leftovers
..
Patch Set 1: Verified+1
--
To view, visit https://gerrit.ovirt.org/56992
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit
gerrit-hooks has posted comments on this change.
Change subject: monitor: Convert valid to read-only property
..
Patch Set 6:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header
gerrit-hooks has posted comments on this change.
Change subject: monitor: Detach read delay from storage domain
..
Patch Set 5:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure heade
gerrit-hooks has posted comments on this change.
Change subject: monitor: Use module logger
..
Patch Set 4:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url:
gerrit-hooks has posted comments on this change.
Change subject: tests: Rename storage.monitor test module
..
Patch Set 2:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header mat
gerrit-hooks has posted comments on this change.
Change subject: monitor: Eliminate nextStatus instance variable
..
Patch Set 2:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure head
Nir Soffer has posted comments on this change.
Change subject: cdrom: API change: require index
..
Patch Set 1:
(1 comment)
https://gerrit.ovirt.org/#/c/56805/1/vdsm/API.py
File vdsm/API.py:
Line 112: def __init__(self, U
gerrit-hooks has posted comments on this change.
Change subject: blkid: Remove leftovers
..
Patch Set 1:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: '
Nir Soffer has uploaded a new change for review.
Change subject: blkid: Remove leftovers
..
blkid: Remove leftovers
We removed support for local disks using disk UUID in commit
160de740e766 (drop unused blkid external binary), b
gerrit-hooks has posted comments on this change.
Change subject: net: report ovs network with nics, vlan tag and bond
..
Patch Set 1:
* #1195208::Update tracker: OK
* Check Bug-Url::OK
* Check Public Bug::#1195208::OK, public b
Petr Horáček has uploaded a new change for review.
Change subject: net: report ovs network with nics, vlan tag and bond
..
net: report ovs network with nics, vlan tag and bond
Report nics, bond and vlan tag connected with networ
Nir Soffer has posted comments on this change.
Change subject: vmdevices: make disk's makeName public
..
Patch Set 2: Code-Review+1
--
To view, visit https://gerrit.ovirt.org/56804
To unsubscribe, visit https://gerrit.ovirt.or
Nir Soffer has posted comments on this change.
Change subject: storage: extend drives name to allow sata interface
..
Patch Set 2: Code-Review+1
--
To view, visit https://gerrit.ovirt.org/56803
To unsubscribe, visit https://ge
Nir Soffer has posted comments on this change.
Change subject: storage: add block device naming tests
..
Patch Set 2: Code-Review+1
--
To view, visit https://gerrit.ovirt.org/56802
To unsubscribe, visit https://gerrit.ovirt.or
Nir Soffer has posted comments on this change.
Change subject: v2v: Detect VM with snapshots
..
Patch Set 5: Code-Review+1
Waiting for Francesco ack.
--
To view, visit https://gerrit.ovirt.org/56574
To unsubscribe, visit http
Edward Haas has posted comments on this change.
Change subject: net: add virtual port to libvirt network def
..
Patch Set 5: Code-Review-1
(3 comments)
Sorry for not raising these in the last review.
https://gerrit.ovirt.org/
Yaniv Bronhaim has posted comments on this change.
Change subject: contrib: schema converter
..
Patch Set 38: Code-Review+1
--
To view, visit https://gerrit.ovirt.org/52864
To unsubscribe, visit https://gerrit.ovirt.org/settin
Yaniv Bronhaim has posted comments on this change.
Change subject: json: removal of old schemas
..
Patch Set 22: Code-Review+1
--
To view, visit https://gerrit.ovirt.org/54548
To unsubscribe, visit https://gerrit.ovirt.org/set
Nir Soffer has posted comments on this change.
Change subject: storage: add support for blkdiscard command
..
Patch Set 5:
(1 comment)
https://gerrit.ovirt.org/#/c/35629/5/tests/Makefile.am
File tests/Makefile.am:
Line 69:
L
Nir Soffer has posted comments on this change.
Change subject: v2v: add support for importing kvm based vms from libvirt
..
Patch Set 4: Code-Review+1
Waiting for Francesco ack.
--
To view, visit https://gerrit.ovirt.org/5645
Nir Soffer has posted comments on this change.
Change subject: kvm2ovirt: tool for copying images from libvirt
..
Patch Set 7: Code-Review+1
Waiting for Francesco ack.
--
To view, visit https://gerrit.ovirt.org/55797
To unsub
Ondřej Svoboda has posted comments on this change.
Change subject: tests: let VDSM consume a bond created by nmcli
..
Patch Set 9:
(7 comments)
I addressed some of the comments and I am leaving two of them for the patch set
1
gerrit-hooks has posted comments on this change.
Change subject: tests: let VDSM consume a bond created by NetworkManager
..
Patch Set 10:
* #1304509::Update tracker: OK
* Check Bug-Url::OK
* Check Public Bug::#1304509::OK, pub
Ondřej Svoboda has uploaded a new change for review.
Change subject: tests: generalize wait_for_ipv6() into wait_for_address()
..
tests: generalize wait_for_ipv6() into wait_for_address()
Change-Id: Iefe2632973e13db07309bdedde20
gerrit-hooks has posted comments on this change.
Change subject: tests: generalize wait_for_ipv6() into wait_for_address()
..
Patch Set 1:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make
gerrit-hooks has posted comments on this change.
Change subject: net: fake bridgeless networks
..
Patch Set 10:
* #1195208::Update tracker: OK
* Check Bug-Url::OK
* Check Public Bug::#1195208::OK, public bug
* Check Product::#1
gerrit-hooks has posted comments on this change.
Change subject: net: map OVS Info to Vdsm Netinfo logic
..
Patch Set 9:
* #1195208::Update tracker: OK
* Check Bug-Url::OK
* Check Public Bug::#1195208::OK, public bug
* Check Pr
gerrit-hooks has posted comments on this change.
Change subject: net: include OVS Netinfo in netinfo/cache.py:_get()
..
Patch Set 3:
* #1195208::Update tracker: OK
* Check Bug-Url::OK
* Check Public Bug::#1195208::OK, public bu
gerrit-hooks has posted comments on this change.
Change subject: net: fake bridgeless networks
..
Patch Set 9:
* #1195208::Update tracker: OK
* Check Bug-Url::OK
* Check Public Bug::#1195208::OK, public bug
* Check Product::#11
gerrit-hooks has posted comments on this change.
Change subject: net: fake OVS as bridgeless in caps
..
Patch Set 6:
* #1195208::Update tracker: OK
--
To view, visit https://gerrit.ovirt.org/56979
To unsubscribe, visit https:
Petr Horáček has abandoned this change.
Change subject: net: fake OVS as bridgeless in caps
..
Abandoned
--
To view, visit https://gerrit.ovirt.org/56979
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageT
gerrit-hooks has posted comments on this change.
Change subject: net: fake OVS as bridgeless in caps
..
Patch Set 6:
* #1195208::Update tracker: OK
* Check Bug-Url::OK
* Check Public Bug::#1195208::OK, public bug
* Check Produc
gerrit-hooks has posted comments on this change.
Change subject: net: include OVS Netinfo in netinfo/cache.py:_get()
..
Patch Set 2:
* #1195208::Update tracker: OK
* Check Bug-Url::OK
* Check Public Bug::#1195208::OK, public bu
gerrit-hooks has posted comments on this change.
Change subject: net: fake bridgeless networks
..
Patch Set 8:
* #1195208::Update tracker: OK
* Check Bug-Url::OK
* Check Public Bug::#1195208::OK, public bug
* Check Product::#11
Nir Soffer has posted comments on this change.
Change subject: v2v: get_external_vms return format for KVM images
..
Patch Set 2:
(1 comment)
https://gerrit.ovirt.org/#/c/56912/2/lib/vdsm/v2v.py
File lib/vdsm/v2v.py:
Line 935
Petr Horáček has uploaded a new change for review.
Change subject: net: include OVS Netinfo in netinfo/cache.py:_get()
..
net: include OVS Netinfo in netinfo/cache.py:_get()
Change-Id: Ib823273a47c07b879591520237bfe122f9b9f1b5
B
gerrit-hooks has posted comments on this change.
Change subject: net: fake OVS as bridgeless in caps
..
Patch Set 5:
* #1195208::Update tracker: OK
* Check Bug-Url::OK
* Check Public Bug::#1195208::OK, public bug
* Check Produc
gerrit-hooks has posted comments on this change.
Change subject: net: include OVS Netinfo in netinfo/cache.py:_get()
..
Patch Set 1:
* #1195208::Update tracker: OK
* Check Bug-Url::OK
* Check Public Bug::#1195208::OK, public bu
gerrit-hooks has posted comments on this change.
Change subject: net: fake bridgeless networks
..
Patch Set 7:
* #1195208::Update tracker: OK
* Check Bug-Url::OK
* Check Public Bug::#1195208::OK, public bug
* Check Product::#11
gerrit-hooks has posted comments on this change.
Change subject: net: map OVS Info to Vdsm Netinfo logic
..
Patch Set 8:
* #1195208::Update tracker: OK
* Check Bug-Url::OK
* Check Public Bug::#1195208::OK, public bug
* Check Pr
gerrit-hooks has posted comments on this change.
Change subject: net: OVS Info
..
Patch Set 13:
* #1195208::Update tracker: OK
* Check Bug-Url::OK
* Check Public Bug::#1195208::OK, public bug
* Check Product::#1195208::OK, Corr
Nir Soffer has posted comments on this change.
Change subject: virt: add device setup and teardown
..
Patch Set 14:
(5 comments)
https://gerrit.ovirt.org/#/c/55135/14/tests/vmTests.py
File tests/vmTests.py:
Line 1114:
Line 1
Petr Horáček has abandoned this change.
Change subject: net: native ovs: store constants in __init__
..
Abandoned
--
To view, visit https://gerrit.ovirt.org/56451
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit
gerrit-hooks has posted comments on this change.
Change subject: net: fake bridgeless networks
..
Patch Set 6:
* #1195208::Update tracker: OK
* Check Bug-Url::OK
* Check Public Bug::#1195208::OK, public bug
* Check Product::#11
gerrit-hooks has posted comments on this change.
Change subject: net: OVS networks info
..
Patch Set 12:
* #1195208::Update tracker: OK
* Check Bug-Url::OK
* Check Public Bug::#1195208::OK, public bug
* Check Product::#1195208:
gerrit-hooks has posted comments on this change.
Change subject: net: native ovs: reserve ovsbr0 network name
..
Patch Set 8:
* #1195208::Update tracker: OK
--
To view, visit https://gerrit.ovirt.org/56452
To unsubscribe, vis
gerrit-hooks has posted comments on this change.
Change subject: net: native ovs: store constants in __init__
..
Patch Set 10:
* #1195208::Update tracker: OK
--
To view, visit https://gerrit.ovirt.org/56451
To unsubscribe, vi
gerrit-hooks has posted comments on this change.
Change subject: net: report OVS networks in caps
..
Patch Set 4:
* #1195208::Update tracker: OK
* Check Bug-Url::OK
* Check Public Bug::#1195208::OK, public bug
* Check Product::
gerrit-hooks has posted comments on this change.
Change subject: net: map OVS netinfo to Vdsm network logic
..
Patch Set 7:
* #1195208::Update tracker: OK
* Check Bug-Url::OK
* Check Public Bug::#1195208::OK, public bug
* Check
Petr Horáček has abandoned this change.
Change subject: net: native ovs: reserve ovsbr0 network name
..
Abandoned
--
To view, visit https://gerrit.ovirt.org/56452
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit
gerrit-hooks has posted comments on this change.
Change subject: net: native ovs: use Transaction for rollback triggering
..
Patch Set 3:
* #1195208::Update tracker: OK
* Check Bug-Url::OK
* Check Public Bug::#1195208::OK, publ
gerrit-hooks has posted comments on this change.
Change subject: net: add virtual port to libvirt network def
..
Patch Set 5:
* #1195208::Update tracker: OK
* Check Bug-Url::OK
* Check Public Bug::#1195208::OK, public bug
* Che
gerrit-hooks has posted comments on this change.
Change subject: net: report OVS networks in caps
..
Patch Set 2:
* #1195208::Update tracker: OK
* Check Bug-Url::OK
* Check Public Bug::#1195208::OK, public bug
* Check Product::
gerrit-hooks has posted comments on this change.
Change subject: net: report OVS networks in caps
..
Patch Set 3:
* #1195208::Update tracker: OK
* Check Bug-Url::OK
* Check Public Bug::#1195208::OK, public bug
* Check Product::
gerrit-hooks has posted comments on this change.
Change subject: net: fake bridgeless networks
..
Patch Set 5:
* #1195208::Update tracker: OK
* Check Bug-Url::OK
* Check Public Bug::#1195208::OK, public bug
* Check Product::#11
gerrit-hooks has posted comments on this change.
Change subject: net: fake bridgeless networks
..
Patch Set 4:
* #1195208::Update tracker: OK
* Check Bug-Url::OK
* Check Public Bug::#1195208::OK, public bug
* Check Product::#11
gerrit-hooks has posted comments on this change.
Change subject: net: report OVS networks in caps
..
Patch Set 1:
* #1195208::Update tracker: OK
* Check Bug-Url::OK
* Check Public Bug::#1195208::OK, public bug
* Check Product::
gerrit-hooks has posted comments on this change.
Change subject: net: fake bridgeless networks
..
Patch Set 3:
* #1195208::Update tracker: OK
* Check Bug-Url::OK
* Check Public Bug::#1195208::OK, public bug
* Check Product::#11
gerrit-hooks has posted comments on this change.
Change subject: net: map OVS netinfo to Vdsm network logic
..
Patch Set 6:
* #1195208::Update tracker: OK
* Check Bug-Url::OK
* Check Public Bug::#1195208::OK, public bug
* Check
gerrit-hooks has posted comments on this change.
Change subject: net: OVS networks info
..
Patch Set 11:
* #1195208::Update tracker: OK
* Check Bug-Url::OK
* Check Public Bug::#1195208::OK, public bug
* Check Product::#1195208:
gerrit-hooks has posted comments on this change.
Change subject: net: map OVS netinfo to Vdsm network logic
..
Patch Set 5:
* #1195208::Update tracker: OK
* Check Bug-Url::OK
* Check Public Bug::#1195208::OK, public bug
* Check
gerrit-hooks has posted comments on this change.
Change subject: net: fake bridgeless networks
..
Patch Set 2:
* #1195208::Update tracker: OK
* Check Bug-Url::OK
* Check Public Bug::#1195208::OK, public bug
* Check Product::#11
gerrit-hooks has posted comments on this change.
Change subject: virt: add device setup and teardown
..
Patch Set 14:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches
gerrit-hooks has posted comments on this change.
Change subject: hostdev/sr-iov: use device setup instead of detach
..
Patch Set 16:
* #1234283::Update tracker: OK
* Check Bug-Url::OK
* Check Public Bug::#1234283::OK, public bu
gerrit-hooks has posted comments on this change.
Change subject: hostdev: add support for hotunplug
..
Patch Set 22:
* #1234283::Update tracker: OK
* Check Bug-Url::OK
* Check Public Bug::#1234283::OK, public bug
* Check Produc
gerrit-hooks has posted comments on this change.
Change subject: hostdev: expose hotplug via vdsClient
..
Patch Set 20:
* #1234283::Update tracker: OK
* Check Bug-Url::OK
* Check Public Bug::#1234283::OK, public bug
* Check Pro
gerrit-hooks has posted comments on this change.
Change subject: hostdev: expose parameters needed to support hotunplug
..
Patch Set 20:
* #1234283::Update tracker: OK
* Check Bug-Url::OK
* Check Public Bug::#1234283::OK, publi
gerrit-hooks has posted comments on this change.
Change subject: hostdev: add vdsClient hotunplug command
..
Patch Set 20:
* #1234283::Update tracker: OK
* Check Bug-Url::OK
* Check Public Bug::#1234283::OK, public bug
* Check
gerrit-hooks has posted comments on this change.
Change subject: net: map OVS netinfo to Vdsm network logic
..
Patch Set 4:
* #1195208::Update tracker: OK
* Check Bug-Url::OK
* Check Public Bug::#1195208::OK, public bug
* Check
gerrit-hooks has posted comments on this change.
Change subject: net: OVS networks info
..
Patch Set 10:
* #1195208::Update tracker: OK
* Check Bug-Url::OK
* Check Public Bug::#1195208::OK, public bug
* Check Product::#1195208:
gerrit-hooks has posted comments on this change.
Change subject: net: fake bridgeless
..
Patch Set 1:
* #1195208::Update tracker: OK
* Check Bug-Url::OK
* Check Public Bug::#1195208::OK, public bug
* Check Product::#1195208::OK
Martin Polednik has uploaded a new change for review.
Change subject: hostdev: disable hyperv for gpu passthrough
..
hostdev: disable hyperv for gpu passthrough
We know that NVIDIA GPUs work fine in passthrough for Linux guests,
gerrit-hooks has posted comments on this change.
Change subject: hostdev: disable hyperv for gpu passthrough
..
Patch Set 1:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header m
gerrit-hooks has posted comments on this change.
Change subject: vmtests: use assertXMLEqual in assertBuildCmdline
..
Patch Set 1:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure he
gerrit-hooks has posted comments on this change.
Change subject: virt: delay appendFeatures and appendClock
..
Patch Set 1:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header ma
Martin Polednik has uploaded a new change for review.
Change subject: virt: delay appendFeatures and appendClock
..
virt: delay appendFeatures and appendClock
This patch itself does not provide much value, but it is a preparatio
Martin Polednik has uploaded a new change for review.
Change subject: vmtests: use assertXMLEqual in assertBuildCmdline
..
vmtests: use assertXMLEqual in assertBuildCmdline
Test method assertBuildCmdline worked around whitespace
gerrit-hooks has posted comments on this change.
Change subject: net: map OVS netinfo to Vdsm network logic
..
Patch Set 3:
* #1195208::Update tracker: OK
* Check Bug-Url::OK
* Check Public Bug::#1195208::OK, public bug
* Check
gerrit-hooks has posted comments on this change.
Change subject: net: map OVS netinfo to Vdsm network logic
..
Patch Set 2:
* #1195208::Update tracker: OK
* Check Bug-Url::OK
* Check Public Bug::#1195208::OK, public bug
* Check
gerrit-hooks has posted comments on this change.
Change subject: gluster: add gluster heal info verb
..
Patch Set 2:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches '
gerrit-hooks has posted comments on this change.
Change subject: gluster: fix python-blivet dependency issue for python3
..
Patch Set 2:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make s
1 - 100 of 125 matches
Mail list logo