Petr Horáček has posted comments on this change.
Change subject: net: common and legacy CachingNetInfo
..
Patch Set 5:
(1 comment)
https://gerrit.ovirt.org/#/c/57441/5/lib/vdsm/netinfo/cache.py
File lib/vdsm/netinfo/cache.py:
gerrit-hooks has posted comments on this change.
Change subject: net: report OVS netinfo in caps
..
Patch Set 14:
* #1195208::Update tracker: OK
* Check Bug-Url::OK
* Check Public Bug::#1195208::OK, public bug
* Check Product::
gerrit-hooks has posted comments on this change.
Change subject: virt: track domain business
..
Patch Set 2:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url:
gerrit-hooks has posted comments on this change.
Change subject: virt: track domain business
..
Patch Set 1:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url:
Francesco Romani has uploaded a new change for review.
Change subject: virt: track domain business
..
virt: track domain business
Looks like we can't rely for long on virDomainGetControlInfo
Change-Id: If214784618aaa07a2f3b6a14
Dan Kenigsberg has posted comments on this change.
Change subject: net: Ignore noqueue queuing discipline
..
Patch Set 1:
https://repos.fedorapeople.org/repos/openstack/openstack-kilo/el7/ is suddenly
not found (404).
Petr/Ed
Jenkins CI has posted comments on this change.
Change subject: infra tests: moved infra tests to tests directory
..
Patch Set 3: Continuous-Integration-1
Propagate review hook: Continuous Integration value inherited from patch
gerrit-hooks has posted comments on this change.
Change subject: sdm: Remove circular dependency
..
Patch Set 1:
* Update tracker: IGNORE, no Bug-Url found
--
To view, visit https://gerrit.ovirt.org/57483
To unsubscribe, visi
Nir Soffer has abandoned this change.
Change subject: sdm: Remove circular dependency
..
Abandoned
This is a better approach:
https://gerrit.ovirt.org/#/q/status:open+project:vdsm+branch:master+topic:storage-constants
--
To v
Nir Soffer has posted comments on this change.
Change subject: infra tests: moved infra tests to tests directory
..
Patch Set 3:
(1 comment)
https://gerrit.ovirt.org/#/c/57562/3/lib/vdsm/infra/eventfd/Makefile.am
File lib/vdsm
Nir Soffer has posted comments on this change.
Change subject: Move Volume MD fields to storage constants
..
Patch Set 1:
Nice!
--
To view, visit https://gerrit.ovirt.org/57582
To unsubscribe, visit https://gerrit.ovirt.org/s
Nir Soffer has posted comments on this change.
Change subject: Move blockVolume constants to storage constants
..
Patch Set 1:
(1 comment)
https://gerrit.ovirt.org/#/c/57583/1/vdsm/storage/sdm/volume_artifacts.py
File vdsm/sto
gerrit-hooks has posted comments on this change.
Change subject: tests: Add monitor thread tests
..
Patch Set 4:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-
Nir Soffer has uploaded a new change for review.
Change subject: tests: Add monitor thread tests
..
tests: Add monitor thread tests
Add basic tests before we refactor MonitorThread for new monitoring
infrastructure.
Change-Id:
Nir Soffer has posted comments on this change.
Change subject: utils: Properly handle int argument in tobool().
..
Patch Set 4: Code-Review-1
(7 comments)
https://gerrit.ovirt.org/#/c/57511/4//COMMIT_MSG
Commit Message:
Line
gerrit-hooks has posted comments on this change.
Change subject: tests: Add monitor thread tests
..
Patch Set 3:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-
Nir Soffer has posted comments on this change.
Change subject: tests: Add monitor thread tests
..
Patch Set 1:
This version includes initial infrastructure, and two partial tests.
--
To view, visit https://gerrit.ovirt.org/57
gerrit-hooks has posted comments on this change.
Change subject: tests: Add monitor thread tests
..
Patch Set 2:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-
gerrit-hooks has posted comments on this change.
Change subject: tests: Add monitor thread tests
..
Patch Set 1:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-
Dan Kenigsberg has posted comments on this change.
Change subject: utils: Properly handle int argument in tobool().
..
Patch Set 4: Code-Review+2
--
To view, visit https://gerrit.ovirt.org/57511
To unsubscribe, visit https://g
Dan Kenigsberg has posted comments on this change.
Change subject: Adapting to latest lago 0.17
..
Patch Set 5:
Please place your revert plans in the commit message. I must admit that I do
not understand the motivation for thi
gerrit-hooks has posted comments on this change.
Change subject: Move blockVolume constants to storage constants
..
Patch Set 1:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure head
gerrit-hooks has posted comments on this change.
Change subject: Import storage constants as sc
..
Patch Set 1:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-U
gerrit-hooks has posted comments on this change.
Change subject: Move Volume MD fields to storage constants
..
Patch Set 1:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header ma
gerrit-hooks has posted comments on this change.
Change subject: Move volume type constants to constants module
..
Patch Set 1:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure heade
Nir Soffer has posted comments on this change.
Change subject: test: xmlrpc server timeout
..
Patch Set 1:
(1 comment)
https://gerrit.ovirt.org/#/c/57559/1/tests/vdscliTests.py
File tests/vdscliTests.py:
Line 64: self
gerrit-hooks has posted comments on this change.
Change subject: lvm: Simplify locking, increasing concurrency
..
Patch Set 9:
* #1081962::Update tracker: OK
* Check Bug-Url::OK
* Check Public Bug::#1081962::OK, public bug
* Ch
gerrit-hooks has posted comments on this change.
Change subject: misc: Remove unused readspeed function
..
Patch Set 11:
* #1081962::Update tracker: OK
* Check Bug-Url::OK
* Check Public Bug::#1081962::OK, public bug
* Check Pr
gerrit-hooks has posted comments on this change.
Change subject: monitor: Separate path status and domain status
..
Patch Set 10:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure hea
gerrit-hooks has posted comments on this change.
Change subject: monitor: Simplify Status class
..
Patch Set 10:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-
gerrit-hooks has posted comments on this change.
Change subject: monitoring: Port vdsm.storage.check to python 3
..
Patch Set 17:
* #1081962::Update tracker: OK
* Check Bug-Url::OK
* Check Public Bug::#1081962::OK, public bug
*
gerrit-hooks has posted comments on this change.
Change subject: monitor: Eliminate nextStatus instance variable
..
Patch Set 14:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure hea
gerrit-hooks has posted comments on this change.
Change subject: monitoring: Use new monitoring infrastructure
..
Patch Set 13:
* #1081962::Update tracker: OK
* Check Bug-Url::OK
* Check Public Bug::#1081962::OK, public bug
* C
gerrit-hooks has posted comments on this change.
Change subject: monitoring: Introduce the check module
..
Patch Set 47:
* #1081962::Update tracker: OK
* Check Bug-Url::OK
* Check Public Bug::#1081962::OK, public bug
* Check Pr
gerrit-hooks has posted comments on this change.
Change subject: monitor: Detach read delay from storage domain
..
Patch Set 17:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure head
gerrit-hooks has posted comments on this change.
Change subject: monitor: Separate setup from monitor loop
..
Patch Set 14:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header ma
gerrit-hooks has posted comments on this change.
Change subject: monitoring: Add process helpers
..
Patch Set 17:
* #1081962::Update tracker: OK
* Check Bug-Url::OK
* Check Public Bug::#1081962::OK, public bug
* Check Product::
gerrit-hooks has posted comments on this change.
Change subject: monitoring: Introduce the asyncevent module
..
Patch Set 29:
* #1081962::Update tracker: OK
* Check Bug-Url::OK
* Check Public Bug::#1081962::OK, public bug
* Che
gerrit-hooks has posted comments on this change.
Change subject: blockSD: Fix busy loop when zeroing image volumes
..
Patch Set 3:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure he
Nir Soffer has submitted this change and it was merged.
Change subject: storage: move hba.py to vdsm storage lib
..
storage: move hba.py to vdsm storage lib
This patch moves the module vdsm/storage/hba.py to
lib/vdsm/storage/hb
gerrit-hooks has posted comments on this change.
Change subject: storage: move hba.py to vdsm storage lib
..
Patch Set 6:
* Update tracker: IGNORE, no Bug-Url found
* Set MODIFIED::IGNORE, no Bug-Url found.
--
To view, visit
Nir Soffer has posted comments on this change.
Change subject: storage: move hba.py to vdsm storage lib
..
Patch Set 5: Verified+1
--
To view, visit https://gerrit.ovirt.org/56889
To unsubscribe, visit https://gerrit.ovirt.org
Nir Soffer has posted comments on this change.
Change subject: monitoring: Port vdsm.storage.check to python 3
..
Patch Set 16: Continuous-Integration+1
Jenkins succeeded, but decided to -1 this.
--
To view, visit https://ger
gerrit-hooks has posted comments on this change.
Change subject: lvm: Simplify locking, increasing concurrency
..
Patch Set 8:
* #1081962::Update tracker: OK
* Check Bug-Url::OK
* Check Public Bug::#1081962::OK, public bug
* Ch
Nir Soffer has posted comments on this change.
Change subject: monitoring: Port vdsm.storage.check to python 3
..
Patch Set 16: Verified+1
This version unblacklist the tests, now compatible with py 3.
--
To view, visit https:
gerrit-hooks has posted comments on this change.
Change subject: misc: Remove unused readspeed function
..
Patch Set 10:
* #1081962::Update tracker: OK
* Check Bug-Url::OK
* Check Public Bug::#1081962::OK, public bug
* Check Pr
gerrit-hooks has posted comments on this change.
Change subject: monitoring: Use new monitoring infrastructure
..
Patch Set 12:
* #1081962::Update tracker: OK
* Check Bug-Url::OK
* Check Public Bug::#1081962::OK, public bug
* C
gerrit-hooks has posted comments on this change.
Change subject: monitoring: Port vdsm.storage.check to python 3
..
Patch Set 16:
* #1081962::Update tracker: OK
* Check Bug-Url::OK
* Check Public Bug::#1081962::OK, public bug
*
gerrit-hooks has posted comments on this change.
Change subject: infra tests: moved infra tests to tests directory
..
Patch Set 3:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure he
Nir Soffer has posted comments on this change.
Change subject: monitoring: Introduce the check module
..
Patch Set 46: Verified+1
This version blacklist the new check tests, cannot be used on python 3 because
of cpopen depende
gerrit-hooks has posted comments on this change.
Change subject: monitoring: Introduce the check module
..
Patch Set 46:
* #1081962::Update tracker: OK
* Check Bug-Url::OK
* Check Public Bug::#1081962::OK, public bug
* Check Pr
gerrit-hooks has posted comments on this change.
Change subject: lvm: Simplify locking, increasing concurrency
..
Patch Set 7:
* #1081962::Update tracker: OK
* Check Bug-Url::OK
* Check Public Bug::#1081962::OK, public bug
* Ch
gerrit-hooks has posted comments on this change.
Change subject: monitoring: Use new monitoring infrastructure
..
Patch Set 11:
* #1081962::Update tracker: OK
* Check Bug-Url::OK
* Check Public Bug::#1081962::OK, public bug
* C
gerrit-hooks has posted comments on this change.
Change subject: misc: Remove unused readspeed function
..
Patch Set 9:
* #1081962::Update tracker: OK
* Check Bug-Url::OK
* Check Public Bug::#1081962::OK, public bug
* Check Pro
gerrit-hooks has posted comments on this change.
Change subject: monitoring: Port vdsm.storage.check to python 3
..
Patch Set 15:
* #1081962::Update tracker: OK
* Check Bug-Url::OK
* Check Public Bug::#1081962::OK, public bug
*
Nir Soffer has posted comments on this change.
Change subject: infra tests: moved infra tests to tests directory
..
Patch Set 2:
Thanks for this cleanup!
--
To view, visit https://gerrit.ovirt.org/57562
To unsubscribe, visit
Nir Soffer has posted comments on this change.
Change subject: storage: move hba.py to vdsm storage lib
..
Patch Set 5: Code-Review+2
This is a rebase on master, fixing minor conflicts since this module does not
depend on devi
gerrit-hooks has posted comments on this change.
Change subject: storage: move hba.py to vdsm storage lib
..
Patch Set 5:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matc
gerrit-hooks has posted comments on this change.
Change subject: infra tests: moved infra tests to tests directory
..
Patch Set 2:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure he
gerrit-hooks has posted comments on this change.
Change subject: dhclient: consider NetworkManager lease files for DUID too
..
Patch Set 4:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, mak
gerrit-hooks has posted comments on this change.
Change subject: tests: generalize wait_for_ipv6() into wait_for_ip()
..
Patch Set 7:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure
gerrit-hooks has posted comments on this change.
Change subject: ifcfg: restore MAC addresses of bonded NICs when adopting a bond
..
Patch Set 5:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url foun
gerrit-hooks has posted comments on this change.
Change subject: tests: introduce the networkmanager module, with integration
tests
..
Patch Set 14:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url
gerrit-hooks has posted comments on this change.
Change subject: tests: let VDSM consume bonds created by NetworkManager
..
Patch Set 24:
* #1304509::Update tracker: OK
* Check Bug-Url::OK
* Check Public Bug::#1304509::OK, publ
gerrit-hooks has posted comments on this change.
Change subject: tests: verify that a bond gets the same address once adopted
from NM
..
Patch Set 5:
* Update tracker: IGNORE, no Bug-Url found
--
To view, visit https://gerri
Ondřej Svoboda has abandoned this change.
Change subject: tests: verify that a bond gets the same address once adopted
from NM
..
Abandoned
Merged into the commit extending the original integration test into a
functional one.
Ondřej Svoboda has posted comments on this change.
Change subject: tests: generalize wait_for_ipv6() into wait_for_address()
..
Patch Set 6:
(3 comments)
https://gerrit.ovirt.org/#/c/56983/6/tests/network/nettestlib.py
File te
Nir Soffer has posted comments on this change.
Change subject: monitor: Separate path status and domain status
..
Patch Set 9:
This version simplify actual so we don't need any comments, similar to the
previous implementation.
gerrit-hooks has posted comments on this change.
Change subject: monitor: Separate path status and domain status
..
Patch Set 9:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure head
gerrit-hooks has posted comments on this change.
Change subject: monitoring: Port vdsm.storage.check to python 3
..
Patch Set 14:
* #1081962::Update tracker: OK
* Check Bug-Url::OK
* Check Public Bug::#1081962::OK, public bug
*
gerrit-hooks has posted comments on this change.
Change subject: misc: Remove unused readspeed function
..
Patch Set 8:
* #1081962::Update tracker: OK
* Check Bug-Url::OK
* Check Public Bug::#1081962::OK, public bug
* Check Pro
gerrit-hooks has posted comments on this change.
Change subject: monitoring: Introduce the asyncevent module
..
Patch Set 28:
* #1081962::Update tracker: OK
* Check Bug-Url::OK
* Check Public Bug::#1081962::OK, public bug
* Che
gerrit-hooks has posted comments on this change.
Change subject: monitor: Separate setup from monitor loop
..
Patch Set 13:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header ma
gerrit-hooks has posted comments on this change.
Change subject: monitor: Simplify Status class
..
Patch Set 9:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-U
gerrit-hooks has posted comments on this change.
Change subject: monitoring: Introduce the check module
..
Patch Set 45:
* #1081962::Update tracker: OK
* Check Bug-Url::OK
* Check Public Bug::#1081962::OK, public bug
* Check Pr
gerrit-hooks has posted comments on this change.
Change subject: blockSD: Fix busy loop when zeroing image volumes
..
Patch Set 2:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure he
gerrit-hooks has posted comments on this change.
Change subject: monitor: Eliminate nextStatus instance variable
..
Patch Set 13:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure hea
gerrit-hooks has posted comments on this change.
Change subject: monitoring: Use new monitoring infrastructure
..
Patch Set 10:
* #1081962::Update tracker: OK
* Check Bug-Url::OK
* Check Public Bug::#1081962::OK, public bug
* C
gerrit-hooks has posted comments on this change.
Change subject: lvm: Simplify locking, increasing concurrency
..
Patch Set 6:
* #1081962::Update tracker: OK
* Check Bug-Url::OK
* Check Public Bug::#1081962::OK, public bug
* Ch
gerrit-hooks has posted comments on this change.
Change subject: monitor: Detach read delay from storage domain
..
Patch Set 16:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure head
gerrit-hooks has posted comments on this change.
Change subject: monitoring: Add process helpers
..
Patch Set 16:
* #1081962::Update tracker: OK
* Check Bug-Url::OK
* Check Public Bug::#1081962::OK, public bug
* Check Product::
gerrit-hooks has posted comments on this change.
Change subject: storage: Organize imports in storage.sdc
..
Patch Set 6:
* Update tracker: IGNORE, no Bug-Url found
* Set MODIFIED::IGNORE, no Bug-Url found.
--
To view, visit
gerrit-hooks has posted comments on this change.
Change subject: storage: Organize imports in storage.outOfProcess
..
Patch Set 6:
* Update tracker: IGNORE, no Bug-Url found
* Set MODIFIED::IGNORE, no Bug-Url found.
--
To vie
gerrit-hooks has posted comments on this change.
Change subject: storage: Move threadLocal module to vdsm storage lib
..
Patch Set 7:
* Update tracker: IGNORE, no Bug-Url found
* Set MODIFIED::IGNORE, no Bug-Url found.
--
To
gerrit-hooks has posted comments on this change.
Change subject: storage: Organize imports in storage.imagetickets
..
Patch Set 6:
* Update tracker: IGNORE, no Bug-Url found
* Set MODIFIED::IGNORE, no Bug-Url found.
--
To vie
Nir Soffer has submitted this change and it was merged.
Change subject: storage: Organize imports in storage.threadPool
..
storage: Organize imports in storage.threadPool
Change-Id: If7e96ac259029aa12ee548a8113c1fbcbf82d26c
Sig
Nir Soffer has submitted this change and it was merged.
Change subject: storage: Move threadLocal module to vdsm storage lib
..
storage: Move threadLocal module to vdsm storage lib
Move storage.threadLocal to vdsm.storage.thr
Nir Soffer has submitted this change and it was merged.
Change subject: storage: Organize imports in storage.sdc
..
storage: Organize imports in storage.sdc
Change-Id: Id949a69853e2c97a4f1177cd3e717b9c956d03c8
Signed-off-by: Ni
Nir Soffer has posted comments on this change.
Change subject: storage: Organize imports in storage.sdc
..
Patch Set 5: Continuous-Integration+1
--
To view, visit https://gerrit.ovirt.org/55260
To unsubscribe, visit https://ge
gerrit-hooks has posted comments on this change.
Change subject: storage: Organize imports in storage.threadPool
..
Patch Set 6:
* Update tracker: IGNORE, no Bug-Url found
* Set MODIFIED::IGNORE, no Bug-Url found.
--
To view,
gerrit-hooks has posted comments on this change.
Change subject: storage: Organize imports in storage.iscsiadm
..
Patch Set 6:
* Update tracker: IGNORE, no Bug-Url found
* Set MODIFIED::IGNORE, no Bug-Url found.
--
To view, v
Nir Soffer has submitted this change and it was merged.
Change subject: storage: Organize imports in storage.iscsiadm
..
storage: Organize imports in storage.iscsiadm
Change-Id: Ie6a356824572c14da5baa862cf20e872767fb52e
Signed-
gerrit-hooks has posted comments on this change.
Change subject: storage: Fix copyright years in storage.imagetickets
..
Patch Set 6:
* Update tracker: IGNORE, no Bug-Url found
* Set MODIFIED::IGNORE, no Bug-Url found.
--
To
Nir Soffer has submitted this change and it was merged.
Change subject: storage: Fix copyright years in storage.imagetickets
..
storage: Fix copyright years in storage.imagetickets
This module does not cotain any code from 2009
Nir Soffer has submitted this change and it was merged.
Change subject: storage: Organize imports in storage.imagetickets
..
storage: Organize imports in storage.imagetickets
3rd party libraries such as ovirt_image_daemon shoul
Nir Soffer has submitted this change and it was merged.
Change subject: storage: Organize imports in storage.outOfProcess
..
storage: Organize imports in storage.outOfProcess
Change-Id: I723200491287229da72edf5179e1646df9f40195
Nir Soffer has posted comments on this change.
Change subject: sdm: Remove circular dependency
..
Patch Set 1:
(3 comments)
Thanks for quickly reviewing this.
I don't like this solution, it is just the quickest way I could so
Nir Soffer has posted comments on this change.
Change subject: storage: move hba.py to vdsm storage lib
..
Patch Set 4:
This probably just need rebase and testing that nothing was broken by the
rebase.
If you don't need it no
Adam Litke has posted comments on this change.
Change subject: storage: Organize imports in storage.iscsiadm
..
Patch Set 5: Code-Review+2
--
To view, visit https://gerrit.ovirt.org/55261
To unsubscribe, visit https://gerrit.o
Adam Litke has posted comments on this change.
Change subject: storage: Organize imports in storage.sdc
..
Patch Set 5: Code-Review+2
--
To view, visit https://gerrit.ovirt.org/55260
To unsubscribe, visit https://gerrit.ovirt.
1 - 100 of 337 matches
Mail list logo