Change in vdsm[master]: v2v: Log detailed output of virt-v2v

Francesco Romani has posted comments on this change. Change subject: v2v: Log detailed output of virt-v2v .. Patch Set 6: Code-Review-1 (3 comments) This version is an improvement, I'm not still completely happy about doing s

Change in vdsm[ovirt-4.0]: virt: Pass missing parameter on desktopLogoff

gerrit-hooks has posted comments on this change. Change subject: virt: Pass missing parameter on desktopLogoff .. Patch Set 1: * #1349383::Update tracker: OK * Check Bug-Url::OK * Check Public Bug::#1349383::OK, public bug * Ch

Change in vdsm[ovirt-4.0]: virt: Ensure uncaught exceptions on disconnect events are ca...

Hello Francesco Romani, I'd like you to do a code review. Please visit https://gerrit.ovirt.org/60455 to review the following change. Change subject: virt: Ensure uncaught exceptions on disconnect events are caught .. vir

Change in vdsm[ovirt-4.0]: virt: Ensure uncaught exceptions on disconnect events are ca...

gerrit-hooks has posted comments on this change. Change subject: virt: Ensure uncaught exceptions on disconnect events are caught .. Patch Set 1: * #1349383::Update tracker: OK * Check Bug-Url::OK * Check Public Bug::#1349383::

Change in vdsm[ovirt-4.0]: virt: Pass missing parameter on desktopLogoff

Hello Francesco Romani, Milan Zamazal, I'd like you to do a code review. Please visit https://gerrit.ovirt.org/60454 to review the following change. Change subject: virt: Pass missing parameter on desktopLogoff .. virt: P

Change in vdsm[master]: Moving vmstatus to vdsm.common.virt

Francesco Romani has posted comments on this change. Change subject: Moving vmstatus to vdsm.common.virt .. Patch Set 6: Code-Review+2 -- To view, visit https://gerrit.ovirt.org/57820 To unsubscribe, visit https://gerrit.ovirt

Change in vdsm[ovirt-4.0]: api: fixing default value for GlusterHost.createBrick

Ramesh N has posted comments on this change. Change subject: api: fixing default value for GlusterHost.createBrick .. Patch Set 1: @Dan Kenigsberg, Can you merge this patch ? -- To view, visit https://gerrit.ovirt.org/60379 T

Change in vdsm[master]: net: call address.flush explicitly after dhclient.kill

gerrit-hooks has posted comments on this change. Change subject: net: call address.flush explicitly after dhclient.kill .. Patch Set 3: * #1195208::Update tracker: OK * Set MODIFIED::bug 1195208#1195208OK, already on MO

Change in vdsm[master]: net: call address.flush explicitly after dhclient.kill

Dan Kenigsberg has submitted this change and it was merged. Change subject: net: call address.flush explicitly after dhclient.kill .. net: call address.flush explicitly after dhclient.kill Change-Id: I7c03ce4917174a78fc97f216ce

Change in vdsm[master]: net: call address.flush explicitly after dhclient.kill

Dan Kenigsberg has posted comments on this change. Change subject: net: call address.flush explicitly after dhclient.kill .. Patch Set 2: Code-Review+2 raising -- To view, visit https://gerrit.ovirt.org/60155 To unsubscribe,

Change in vdsm[master]: net: add address.flush family argument

gerrit-hooks has posted comments on this change. Change subject: net: add address.flush family argument .. Patch Set 3: * #1195208::Update tracker: OK * Set MODIFIED::bug 1195208#1195208OK, already on MODIFIED -- To v

Change in vdsm[master]: ovs hook: fix dhclient imports

gerrit-hooks has posted comments on this change. Change subject: ovs hook: fix dhclient imports .. Patch Set 3: * Update tracker: IGNORE, no Bug-Url found * Set MODIFIED::IGNORE, no Bug-Url found. -- To view, visit https://ge

Change in vdsm[master]: ovs hook: fix dhclient imports

Dan Kenigsberg has submitted this change and it was merged. Change subject: ovs hook: fix dhclient imports .. ovs hook: fix dhclient imports Change-Id: Ie13c017538750902713831bbcb07a30c885abd7d Signed-off-by: Petr Horáček Revi

Change in vdsm[master]: net: add address.flush family argument

Dan Kenigsberg has posted comments on this change. Change subject: net: add address.flush family argument .. Patch Set 2: Code-Review+2 -- To view, visit https://gerrit.ovirt.org/60153 To unsubscribe, visit https://gerrit.ovir

Change in vdsm[master]: net: add address.flush family argument

Dan Kenigsberg has submitted this change and it was merged. Change subject: net: add address.flush family argument .. net: add address.flush family argument Add family argument to address.flush to be able to flush just IP addre

Change in vdsm[master]: Remove deathSignal usages in sync execCmd calls

Nir Soffer has posted comments on this change. Change subject: Remove deathSignal usages in sync execCmd calls .. Patch Set 6: Code-Review+2 Verifying this patch: - blkdiscard - unit tests are enough - curlimgWarp - if we have

Change in vdsm[master]: storage: Add inplace virt-sparsify support

gerrit-hooks has posted comments on this change. Change subject: storage: Add inplace virt-sparsify support .. Patch Set 7: * #734120::Update tracker: OK * Check Bug-Url::OK * Check Public Bug::#734120::OK, public bug * Check P

Change in vdsm[master]: storage: Add inplace virt-sparsify support

Shmuel Leib Melamud has posted comments on this change. Change subject: storage: Add inplace virt-sparsify support .. Patch Set 6: (18 comments) https://gerrit.ovirt.org/#/c/57347/5/client/vdsClient.py File client/vdsClient.py

Change in vdsm[master]: storage: Add inplace virt-sparsify support

gerrit-hooks has posted comments on this change. Change subject: storage: Add inplace virt-sparsify support .. Patch Set 6: * #734120::Update tracker: OK * Check Bug-Url::OK * Check Public Bug::#734120::OK, public bug * Check P

Change in vdsm[master]: Remove deathSignal usages in sync execCmd calls

Yaniv Bronhaim has posted comments on this change. Change subject: Remove deathSignal usages in sync execCmd calls .. Patch Set 6: yes. please suggest how to verify . all are storage related parts -- To view, visit https://ge

Change in vdsm[master]: Modify reports to metrics

gerrit-hooks has posted comments on this change. Change subject: Modify reports to metrics .. Patch Set 1: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: '

Change in vdsm[master]: Modify reports to metrics

Yaniv Bronhaim has uploaded a new change for review. Change subject: Modify reports to metrics .. Modify reports to metrics Reports is more about the output graphs. The idea behind this module is to send metrics information. Thi

Change in vdsm[master]: ovs: acquire external ifaces

Edward Haas has posted comments on this change. Change subject: ovs: acquire external ifaces .. Patch Set 12: (1 comment) https://gerrit.ovirt.org/#/c/60404/12/lib/vdsm/network/netswitch.py File lib/vdsm/network/netswitch.py:

Change in vdsm[master]: Remove deathSignal usages in sync execCmd calls

Nir Soffer has posted comments on this change. Change subject: Remove deathSignal usages in sync execCmd calls .. Patch Set 6: Yaniv, did you address the comments in version 5? -- To view, visit https://gerrit.ovirt.org/52646

Change in vdsm[master]: ovs: use Setup class directly

Edward Haas has posted comments on this change. Change subject: ovs: use Setup class directly .. Patch Set 2: (1 comment) https://gerrit.ovirt.org/#/c/60405/2/lib/vdsm/network/netswitch.py File lib/vdsm/network/netswitch.py:

Change in vdsm[master]: tox: fail make process if required tox version isn't installed.

Nir Soffer has posted comments on this change. Change subject: tox: fail make process if required tox version isn't installed. .. Patch Set 21: Code-Review+1 Piotr, can you ack this? -- To view, visit https://gerrit.ovirt.org

Change in vdsm[master]: ovs: use Setup class directly

Edward Haas has posted comments on this change. Change subject: ovs: use Setup class directly .. Patch Set 2: (1 comment) https://gerrit.ovirt.org/#/c/60405/2/lib/vdsm/network/netswitch.py File lib/vdsm/network/netswitch.py:

Change in vdsm[master]: Moving vmstatus to vdsm.common.virt

gerrit-hooks has posted comments on this change. Change subject: Moving vmstatus to vdsm.common.virt .. Patch Set 6: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches '

Change in vdsm[master]: ovs: set mtu

Edward Haas has posted comments on this change. Change subject: ovs: set mtu .. Patch Set 1: (1 comment) https://gerrit.ovirt.org/#/c/60372/1/lib/vdsm/network/netswitch.py File lib/vdsm/network/netswitch.py: Line 256: Line 2

Change in vdsm[master]: ovs: early IP+link setup

Edward Haas has posted comments on this change. Change subject: ovs: early IP+link setup .. Patch Set 1: I think we should follow the vdsm-restore-net-config pattern here. (file location, how it is called... etc) It must also

Change in vdsm[master]: ovs: flush IP config from attached ifaces

Edward Haas has posted comments on this change. Change subject: ovs: flush IP config from attached ifaces .. Patch Set 11: Code-Review-1 (8 comments) https://gerrit.ovirt.org/#/c/59958/11/lib/vdsm/network/ovs/switch.py File li

Change in vdsm[ovirt-4.0]: vdsm: adding handling for NGN in osinfo.py

Eli Mesika has posted comments on this change. Change subject: vdsm: adding handling for NGN in osinfo.py .. Patch Set 1: Verified+1 -- To view, visit https://gerrit.ovirt.org/60433 To unsubscribe, visit https://gerrit.ovirt.o

Change in vdsm[ovirt-4.0]: vdsm: adding handling for NGN in osinfo.py

gerrit-hooks has posted comments on this change. Change subject: vdsm: adding handling for NGN in osinfo.py .. Patch Set 1: Verified-1 * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::ERROR, At least one bug-url is

Change in vdsm[ovirt-4.0]: vdsm: adding handling for NGN in osinfo.py

Hello Piotr Kliczewski, I'd like you to do a code review. Please visit https://gerrit.ovirt.org/60433 to review the following change. Change subject: vdsm: adding handling for NGN in osinfo.py .. vdsm: adding handling for

Change in vdsm[master]: tox: fail make process if required tox version isn't installed.

Irit Goihman has posted comments on this change. Change subject: tox: fail make process if required tox version isn't installed. .. Patch Set 21: > Irit, did you address the comments in version 7? version 7 is very old, are yo

Change in vdsm[master]: vdscli: added DeprecationWarning to module

Irit Goihman has posted comments on this change. Change subject: vdscli: added DeprecationWarning to module .. Patch Set 5: Verified+1 -- To view, visit https://gerrit.ovirt.org/60318 To unsubscribe, visit https://gerrit.ovirt

Change in vdsm[master]: net address: ignore not existing iface on flush

Edward Haas has posted comments on this change. Change subject: net address: ignore not existing iface on flush .. Patch Set 3: Code-Review-1 Just reflecting Dan comment on the silent failure. -- To view, visit https://gerrit

Change in vdsm[master]: net: add address.flush family argument

Edward Haas has posted comments on this change. Change subject: net: add address.flush family argument .. Patch Set 2: Code-Review+1 -- To view, visit https://gerrit.ovirt.org/60153 To unsubscribe, visit https://gerrit.ovirt.o

Change in vdsm[master]: vdscli: added DeprecationWarning to module

gerrit-hooks has posted comments on this change. Change subject: vdscli: added DeprecationWarning to module .. Patch Set 5: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header ma