Change in vdsm[master]: storage: add getDeviceList discard related fields

2016-07-13 Thread ishaby
Idan Shaby has posted comments on this change. Change subject: storage: add getDeviceList discard related fields .. Patch Set 1: (1 comment) https://gerrit.ovirt.org/#/c/60628/1/vdsm/storage/multipath.py File vdsm/storage/mult

Change in vdsm[master]: vm: graphics: report display info from device

2016-07-13 Thread danken
Dan Kenigsberg has posted comments on this change. Change subject: vm: graphics: report display info from device .. Patch Set 4: Code-Review+2 -- To view, visit https://gerrit.ovirt.org/60320 To unsubscribe, visit https://gerr

Change in vdsm[master]: vmxml: move metadata handling into helpers

2016-07-13 Thread automation
gerrit-hooks has posted comments on this change. Change subject: vmxml: move metadata handling into helpers .. Patch Set 9: * Update tracker: IGNORE, no Bug-Url found * Set MODIFIED::IGNORE, no Bug-Url found. -- To view, visi

Change in vdsm[master]: vmxml: move metadata handling into helpers

2016-07-13 Thread danken
Dan Kenigsberg has submitted this change and it was merged. Change subject: vmxml: move metadata handling into helpers .. vmxml: move metadata handling into helpers to make room for future users of the `metadata' section, we sp

Change in vdsm[master]: tests: Introduce qemu-io pattern verification utils

2016-07-13 Thread alitke
Adam Litke has posted comments on this change. Change subject: tests: Introduce qemu-io pattern verification utils .. Patch Set 2: Verified+1 -- To view, visit https://gerrit.ovirt.org/60615 To unsubscribe, visit https://gerri

Change in vdsm[master]: tests: Introduce qemu-io pattern verification utils

2016-07-13 Thread automation
gerrit-hooks has posted comments on this change. Change subject: tests: Introduce qemu-io pattern verification utils .. Patch Set 2: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure

Change in vdsm[master]: Define the SDM.copy_data API

2016-07-13 Thread automation
gerrit-hooks has posted comments on this change. Change subject: Define the SDM.copy_data API .. Patch Set 4: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url

Change in vdsm[master]: tests: Add make_volume to FakeEnv

2016-07-13 Thread alitke
Adam Litke has posted comments on this change. Change subject: tests: Add make_volume to FakeEnv .. Patch Set 4: Verified+1 -- To view, visit https://gerrit.ovirt.org/60417 To unsubscribe, visit https://gerrit.ovirt.org/settin

Change in vdsm[master]: Define the SDM.copy_data API

2016-07-13 Thread alitke
Adam Litke has posted comments on this change. Change subject: Define the SDM.copy_data API .. Patch Set 4: Verified+1 -- To view, visit https://gerrit.ovirt.org/60419 To unsubscribe, visit https://gerrit.ovirt.org/settings G

Change in vdsm[master]: qemuimg: Move wait_for_completion inside QemuImgOperation

2016-07-13 Thread automation
gerrit-hooks has posted comments on this change. Change subject: qemuimg: Move wait_for_completion inside QemuImgOperation .. Patch Set 1: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make

Change in vdsm[master]: tests: Add make_volume to FakeEnv

2016-07-13 Thread automation
gerrit-hooks has posted comments on this change. Change subject: tests: Add make_volume to FakeEnv .. Patch Set 4: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bu

Change in vdsm[master]: Implement SDM.copy_data

2016-07-13 Thread automation
gerrit-hooks has posted comments on this change. Change subject: Implement SDM.copy_data .. Patch Set 4: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: '

Change in vdsm[master]: qemuimg: Move wait_for_completion inside QemuImgOperation

2016-07-13 Thread alitke
Adam Litke has uploaded a new change for review. Change subject: qemuimg: Move wait_for_completion inside QemuImgOperation .. qemuimg: Move wait_for_completion inside QemuImgOperation The Image class implemented logic to wait fo

Change in vdsm[master]: Modify reports to metrics

2016-07-13 Thread ybronhei
Yaniv Bronhaim has posted comments on this change. Change subject: Modify reports to metrics .. Patch Set 3: (1 comment) https://gerrit.ovirt.org/#/c/60450/3/lib/vdsm/config.py.in File lib/vdsm/config.py.in: Line 449:

Change in vdsm[master]: storage: add getDeviceList discard related fields

2016-07-13 Thread tnisan
Tal Nisan has posted comments on this change. Change subject: storage: add getDeviceList discard related fields .. Patch Set 1: (1 comment) https://gerrit.ovirt.org/#/c/60628/1/vdsm/storage/multipath.py File vdsm/storage/multi

Change in vdsm[master]: core: containers: add the container support module

2016-07-13 Thread automation
gerrit-hooks has posted comments on this change. Change subject: core: containers: add the container support module .. Patch Set 14: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure

Change in vdsm[master]: tests: containers: add testsuite

2016-07-13 Thread automation
gerrit-hooks has posted comments on this change. Change subject: tests: containers: add testsuite .. Patch Set 1: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug

Change in vdsm[master]: tests: containers: add testsuite

2016-07-13 Thread fromani
Francesco Romani has uploaded a new change for review. Change subject: tests: containers: add testsuite .. tests: containers: add testsuite Change-Id: I27ba3cecbd71b7bbba94992d6bc63ca29333e313 WIP: more tests are being ported Si

Change in vdsm[master]: Implement SDM.copy_data

2016-07-13 Thread alitke
Adam Litke has posted comments on this change. Change subject: Implement SDM.copy_data .. Patch Set 3: (16 comments) https://gerrit.ovirt.org/#/c/60420/3/vdsm/storage/sdm/api/copy_data.py File vdsm/storage/sdm/api/copy_data.py

Change in vdsm[master]: tests: Add make_volume to FakeEnv

2016-07-13 Thread nsoffer
Nir Soffer has posted comments on this change. Change subject: tests: Add make_volume to FakeEnv .. Patch Set 3: Code-Review-1 Adam, can you fix the failing test so we can merge this and the next patch? -- To view, visit http

Change in vdsm[master]: Define the SDM.copy_data API

2016-07-13 Thread nsoffer
Nir Soffer has posted comments on this change. Change subject: Define the SDM.copy_data API .. Patch Set 3: Code-Review+2 -- To view, visit https://gerrit.ovirt.org/60419 To unsubscribe, visit https://gerrit.ovirt.org/settings

Change in vdsm[master]: Modify reports to metrics

2016-07-13 Thread nsoffer
Nir Soffer has posted comments on this change. Change subject: Modify reports to metrics .. Patch Set 3: (1 comment) https://gerrit.ovirt.org/#/c/60450/3/lib/vdsm/config.py.in File lib/vdsm/config.py.in: Line 449: ('c

Change in vdsm[master]: cmdutils: enhance systemd_run

2016-07-13 Thread automation
gerrit-hooks has posted comments on this change. Change subject: cmdutils: enhance systemd_run .. Patch Set 15: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-U

Change in vdsm[master]: network: supervdsm: configure container networks

2016-07-13 Thread automation
gerrit-hooks has posted comments on this change. Change subject: network: supervdsm: configure container networks .. Patch Set 27: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure he

Change in vdsm[master]: vmxml: export container metadata

2016-07-13 Thread automation
gerrit-hooks has posted comments on this change. Change subject: vmxml: export container metadata .. Patch Set 6: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug

Change in vdsm[master]: vm: reorder operations in _domDependentInit

2016-07-13 Thread automation
gerrit-hooks has posted comments on this change. Change subject: vm: reorder operations in _domDependentInit .. Patch Set 11: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header

Change in vdsm[master]: supervdsm: expose systemd utilities

2016-07-13 Thread automation
gerrit-hooks has posted comments on this change. Change subject: supervdsm: expose systemd utilities .. Patch Set 15: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches

Change in vdsm[master]: core: containers: add the container support module

2016-07-13 Thread automation
gerrit-hooks has posted comments on this change. Change subject: core: containers: add the container support module .. Patch Set 13: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure

Change in vdsm[master]: vmxml: move namespace declaration

2016-07-13 Thread automation
gerrit-hooks has posted comments on this change. Change subject: vmxml: move namespace declaration .. Patch Set 8: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bu

Change in vdsm[master]: virt: utils: add is_kvm helper

2016-07-13 Thread automation
gerrit-hooks has posted comments on this change. Change subject: virt: utils: add is_kvm helper .. Patch Set 19: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-

Change in vdsm[master]: vdsm: virt: add optional container support

2016-07-13 Thread automation
gerrit-hooks has posted comments on this change. Change subject: vdsm: virt: add optional container support .. Patch Set 34: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header m

Change in vdsm[master]: vm: reorder sampling initialization

2016-07-13 Thread automation
gerrit-hooks has posted comments on this change. Change subject: vm: reorder sampling initialization .. Patch Set 10: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches

Change in vdsm[master]: vmxml: move metadata handling into helpers

2016-07-13 Thread automation
gerrit-hooks has posted comments on this change. Change subject: vmxml: move metadata handling into helpers .. Patch Set 8: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header ma

Change in vdsm[master]: vm: split guest agent init from domDependentInit

2016-07-13 Thread automation
gerrit-hooks has posted comments on this change. Change subject: vm: split guest agent init from domDependentInit .. Patch Set 11: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure he

Change in vdsm[master]: vm: split device init from domDependentInit

2016-07-13 Thread automation
gerrit-hooks has posted comments on this change. Change subject: vm: split device init from domDependentInit .. Patch Set 11: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header

Change in vdsm[master]: vm: split vcpu settings from domDependentInit

2016-07-13 Thread automation
gerrit-hooks has posted comments on this change. Change subject: vm: split vcpu settings from domDependentInit .. Patch Set 10: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure heade

Change in vdsm[master]: hostdev: move usb device code to separate class

2016-07-13 Thread automation
gerrit-hooks has posted comments on this change. Change subject: hostdev: move usb device code to separate class .. Patch Set 11: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure hea

Change in vdsm[master]: hostdev: cleanup udev files after PCI host devices

2016-07-13 Thread automation
gerrit-hooks has posted comments on this change. Change subject: hostdev: cleanup udev files after PCI host devices .. Patch Set 8: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure h

Change in vdsm[master]: hostdev: move pci device code to separate class

2016-07-13 Thread automation
gerrit-hooks has posted comments on this change. Change subject: hostdev: move pci device code to separate class .. Patch Set 11: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure hea

Change in vdsm[master]: hostdev: improve robustness of libvirt SCSI access

2016-07-13 Thread automation
gerrit-hooks has posted comments on this change. Change subject: hostdev: improve robustness of libvirt SCSI access .. Patch Set 10: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure

Change in vdsm[master]: hostdev: use specific device classes in HostDevice

2016-07-13 Thread automation
gerrit-hooks has posted comments on this change. Change subject: hostdev: use specific device classes in HostDevice .. Patch Set 11: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure

Change in vdsm[master]: hostdev: properly detect attached scsi devices

2016-07-13 Thread automation
gerrit-hooks has posted comments on this change. Change subject: hostdev: properly detect attached scsi devices .. Patch Set 3: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure heade

Change in vdsm[master]: hostdev: move scsi device code to separate class

2016-07-13 Thread automation
gerrit-hooks has posted comments on this change. Change subject: hostdev: move scsi device code to separate class .. Patch Set 11: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure he

Change in vdsm[master]: network/sr-iov: use device teardown to reattach device

2016-07-13 Thread automation
gerrit-hooks has posted comments on this change. Change subject: network/sr-iov: use device teardown to reattach device .. Patch Set 2: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make su

Change in vdsm[master]: hostdev: use proper scsi address

2016-07-13 Thread automation
gerrit-hooks has posted comments on this change. Change subject: hostdev: use proper scsi address .. Patch Set 3: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug

Change in vdsm[master]: storage: add getDeviceList discard related fields

2016-07-13 Thread ykaul
Yaniv Kaul has posted comments on this change. Change subject: storage: add getDeviceList discard related fields .. Patch Set 1: Code-Review-1 (1 comment) I'm quite positive the key queried should be discard_max_hw_bytes and n

Change in vdsm[master]: tests: Introduce qemu-io pattern verification utils

2016-07-13 Thread alitke
Adam Litke has posted comments on this change. Change subject: tests: Introduce qemu-io pattern verification utils .. Patch Set 1: (4 comments) https://gerrit.ovirt.org/#/c/60615/1/tests/storagetestlib.py File tests/storagetes

Change in vdsm[master]: vm: graphics: drop legacy configuration support

2016-07-13 Thread mzamazal
Milan Zamazal has posted comments on this change. Change subject: vm: graphics: drop legacy configuration support .. Patch Set 4: Code-Review+1 I see, it's removed in the followup patches. -- To view, visit https://gerrit.ovi

Change in vdsm[master]: hostdev: cleanup udev files after PCI host devices

2016-07-13 Thread automation
gerrit-hooks has posted comments on this change. Change subject: hostdev: cleanup udev files after PCI host devices .. Patch Set 7: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure h

Change in vdsm[master]: network/sr-iov: use device teardown to reattach device

2016-07-13 Thread automation
gerrit-hooks has posted comments on this change. Change subject: network/sr-iov: use device teardown to reattach device .. Patch Set 1: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make su

Change in vdsm[master]: hostdev: move usb device code to separate class

2016-07-13 Thread automation
gerrit-hooks has posted comments on this change. Change subject: hostdev: move usb device code to separate class .. Patch Set 10: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure hea

Change in vdsm[master]: hostdev: move scsi device code to separate class

2016-07-13 Thread automation
gerrit-hooks has posted comments on this change. Change subject: hostdev: move scsi device code to separate class .. Patch Set 10: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure he

Change in vdsm[master]: hostdev: improve robustness of libvirt SCSI access

2016-07-13 Thread automation
gerrit-hooks has posted comments on this change. Change subject: hostdev: improve robustness of libvirt SCSI access .. Patch Set 9: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure h

Change in vdsm[master]: hostdev: use proper scsi address

2016-07-13 Thread automation
gerrit-hooks has posted comments on this change. Change subject: hostdev: use proper scsi address .. Patch Set 2: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug

Change in vdsm[master]: tests: Add make_volume to FakeEnv

2016-07-13 Thread alitke
Adam Litke has posted comments on this change. Change subject: tests: Add make_volume to FakeEnv .. Patch Set 3: (1 comment) https://gerrit.ovirt.org/#/c/60417/3/tests/storagetestlib.py File tests/storagetestlib.py: Line 52:

Change in vdsm[master]: hostdev: move pci device code to separate class

2016-07-13 Thread automation
gerrit-hooks has posted comments on this change. Change subject: hostdev: move pci device code to separate class .. Patch Set 10: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure hea

Change in vdsm[master]: hostdev: use specific device classes in HostDevice

2016-07-13 Thread automation
gerrit-hooks has posted comments on this change. Change subject: hostdev: use specific device classes in HostDevice .. Patch Set 10: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure

Change in vdsm[master]: hostdev: properly detect attached scsi devices

2016-07-13 Thread automation
gerrit-hooks has posted comments on this change. Change subject: hostdev: properly detect attached scsi devices .. Patch Set 2: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure heade

Change in vdsm[master]: network/sr-iov: use device teardown to reattach device

2016-07-13 Thread mpolednik
Martin Polednik has uploaded a new change for review. Change subject: network/sr-iov: use device teardown to reattach device .. network/sr-iov: use device teardown to reattach device Change-Id: I2ff3299e4a9baaf02a3b96cd94cdf9871

Change in vdsm[master]: hostdev: report device MMIO numa node

2016-07-13 Thread automation
gerrit-hooks has posted comments on this change. Change subject: hostdev: report device MMIO numa node .. Patch Set 2: * #1356161::Update tracker: OK * Check Bug-Url::OK * Check Public Bug::#1356161::OK, public bug * Check Prod

Change in vdsm[master]: hostdev: prefer numa nodes close to device MMIO

2016-07-13 Thread automation
gerrit-hooks has posted comments on this change. Change subject: hostdev: prefer numa nodes close to device MMIO .. Patch Set 2: * #1356161::Update tracker: OK * Check Bug-Url::OK * Check Public Bug::#1356161::OK, public bug *

Change in vdsm[master]: utils: add utlity to generate positive cpuset notation

2016-07-13 Thread automation
gerrit-hooks has posted comments on this change. Change subject: utils: add utlity to generate positive cpuset notation .. Patch Set 2: * #1356161::Update tracker: OK * Check Bug-Url::OK * Check Public Bug::#1356161::OK, public

Change in vdsm[master]: hostdev: expose numa_node in host device

2016-07-13 Thread automation
gerrit-hooks has posted comments on this change. Change subject: hostdev: expose numa_node in host device .. Patch Set 2: * #1356161::Update tracker: OK * Check Bug-Url::OK * Check Public Bug::#1356161::OK, public bug * Check P

Change in vdsm[master]: vm: graphics: drop legacy configuration support

2016-07-13 Thread fromani
Francesco Romani has posted comments on this change. Change subject: vm: graphics: drop legacy configuration support .. Patch Set 4: I'd say looks good: 1099 15:46:57 fromani@musashi ~/Projects/upstream/vdsm $ git co virt-dev-

Change in vdsm[master]: vm: graphics: drop legacy configuration support

2016-07-13 Thread mzamazal
Milan Zamazal has posted comments on this change. Change subject: vm: graphics: drop legacy configuration support .. Patch Set 4: Great, thanks. Would you like to check also places in deviceTests.py where isLegacy is used? --

Change in vdsm[master]: v2v: dup commands.execCmd to allow redirection

2016-07-13 Thread automation
gerrit-hooks has posted comments on this change. Change subject: v2v: dup commands.execCmd to allow redirection .. Patch Set 2: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure heade

Change in vdsm[master]: v2v: dup commands.execCmd to allow redirection

2016-07-13 Thread fromani
Francesco Romani has posted comments on this change. Change subject: v2v: dup commands.execCmd to allow redirection .. Patch Set 1: Code-Review-1 (1 comment) https://gerrit.ovirt.org/#/c/60660/1/lib/vdsm/v2v.py File lib/vdsm/v

Change in vdsm[master]: virt: Limit the number of workers in executor

2016-07-13 Thread mzamazal
Milan Zamazal has posted comments on this change. Change subject: virt: Limit the number of workers in executor .. Patch Set 19: Verified+1 Verified by injecting time.sleep(10) into _RunnableOnVm.__call__, printing the num

Change in vdsm[master]: v2v: dup commands.execCmd to allow redirection

2016-07-13 Thread automation
gerrit-hooks has posted comments on this change. Change subject: v2v: dup commands.execCmd to allow redirection .. Patch Set 1: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure heade

Change in vdsm[master]: virt: Add docstrings about Executor parameters and behavior

2016-07-13 Thread automation
gerrit-hooks has posted comments on this change. Change subject: virt: Add docstrings about Executor parameters and behavior .. Patch Set 15: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, m

Change in vdsm[master]: Define the SDM.copy_data API

2016-07-13 Thread frolland
Freddy Rolland has posted comments on this change. Change subject: Define the SDM.copy_data API .. Patch Set 3: Code-Review+1 -- To view, visit https://gerrit.ovirt.org/60419 To unsubscribe, visit https://gerrit.ovirt.org/sett

Change in vdsm[master]: Define the SDM.copy_data API

2016-07-13 Thread frolland
Freddy Rolland has posted comments on this change. Change subject: Define the SDM.copy_data API .. Patch Set 3: Endpoint has a network connotation for me, but I don't have a better proposition. -- To view, visit https://gerr

Change in vdsm[master]: virt: Limit the number of workers in executor

2016-07-13 Thread automation
gerrit-hooks has posted comments on this change. Change subject: virt: Limit the number of workers in executor .. Patch Set 19: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure heade

Change in vdsm[master]: tox: Exclude .ropeproject from pep8 check

2016-07-13 Thread mzamazal
Milan Zamazal has posted comments on this change. Change subject: tox: Exclude .ropeproject from pep8 check .. Patch Set 4: Verified+1 Verified by running `make check' in a Vdsm tree with .ropeproject and checking that it brea

Change in vdsm[master]: Define the SDM.copy_data API

2016-07-13 Thread laravot
Liron Aravot has posted comments on this change. Change subject: Define the SDM.copy_data API .. Patch Set 3: Code-Review+1 -- To view, visit https://gerrit.ovirt.org/60419 To unsubscribe, visit https://gerrit.ovirt.org/settin

Change in vdsm[master]: vm: graphics: drop legacy configuration support

2016-07-13 Thread fromani
Francesco Romani has posted comments on this change. Change subject: vm: graphics: drop legacy configuration support .. Patch Set 4: Verified+1 since last verification dropped more stale tests, copied score. -- To view, visit

Change in vdsm[master]: vm: graphics: drop legacy configuration support

2016-07-13 Thread fromani
Francesco Romani has posted comments on this change. Change subject: vm: graphics: drop legacy configuration support .. Patch Set 3: (1 comment) https://gerrit.ovirt.org/#/c/60321/3//COMMIT_MSG Commit Message: Line 5: CommitD

Change in vdsm[master]: vm: storage: drop legacy network config support

2016-07-13 Thread automation
gerrit-hooks has posted comments on this change. Change subject: vm: storage: drop legacy network config support .. Patch Set 4: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure head

Change in vdsm[master]: vm: storage: drop legacy graphics config support

2016-07-13 Thread automation
gerrit-hooks has posted comments on this change. Change subject: vm: storage: drop legacy graphics config support .. Patch Set 4: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure hea

Change in vdsm[master]: vm: graphics: report display info from device

2016-07-13 Thread automation
gerrit-hooks has posted comments on this change. Change subject: vm: graphics: report display info from device .. Patch Set 4: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header

Change in vdsm[master]: vm: always expect Vm devices to be sent

2016-07-13 Thread automation
gerrit-hooks has posted comments on this change. Change subject: vm: always expect Vm devices to be sent .. Patch Set 4: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header match

Change in vdsm[master]: vm: graphics: drop legacy configuration support

2016-07-13 Thread automation
gerrit-hooks has posted comments on this change. Change subject: vm: graphics: drop legacy configuration support .. Patch Set 4: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure head

Change in vdsm[master]: vm: drop legacy device config support

2016-07-13 Thread automation
gerrit-hooks has posted comments on this change. Change subject: vm: drop legacy device config support .. Patch Set 4: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches

Change in vdsm[master]: vm: storage: drop legacy drive config support

2016-07-13 Thread automation
gerrit-hooks has posted comments on this change. Change subject: vm: storage: drop legacy drive config support .. Patch Set 4: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header

Change in vdsm[master]: Send vm info report each sampling interval from HostMonitor

2016-07-13 Thread fromani
Francesco Romani has posted comments on this change. Change subject: Send vm info report each sampling interval from HostMonitor .. Patch Set 2: (1 comment) https://gerrit.ovirt.org/#/c/59523/2/lib/vdsm/virt/sampling.py File l

Change in vdsm[master]: hostdev: improve robustness of libvirt SCSI access

2016-07-13 Thread mpolednik
Martin Polednik has posted comments on this change. Change subject: hostdev: improve robustness of libvirt SCSI access .. Patch Set 8: I don't think we have proper testing framework for these methods, but since this one is iso

Change in vdsm[master]: Adding report_stats to virt.stats

2016-07-13 Thread fromani
Francesco Romani has posted comments on this change. Change subject: Adding report_stats to virt.stats .. Patch Set 7: (5 comments) looks generally ok, few comments inside. -1 for visibility. https://gerrit.ovirt.org/#/c/5906

Change in vdsm[master]: hostdev: move pci device code to separate class

2016-07-13 Thread mpolednik
Martin Polednik has posted comments on this change. Change subject: hostdev: move pci device code to separate class .. Patch Set 9: (1 comment) https://gerrit.ovirt.org/#/c/57956/9/vdsm/virt/vmdevices/hostdevice.py File vdsm/v

Change in vdsm[master]: vm: storage: drop legacy network config support

2016-07-13 Thread edwardh
Edward Haas has posted comments on this change. Change subject: vm: storage: drop legacy network config support .. Patch Set 3: Code-Review+1 -- To view, visit https://gerrit.ovirt.org/60324 To unsubscribe, visit https://gerri

Change in vdsm[master]: hostdev: cleanup udev files after PCI host devices

2016-07-13 Thread mpolednik
Martin Polednik has posted comments on this change. Change subject: hostdev: cleanup udev files after PCI host devices .. Patch Set 6: Code-Review-1 (1 comment) https://gerrit.ovirt.org/#/c/59042/6//COMMIT_MSG Commit Message:

Change in vdsm[master]: utils: add utlity to generate positive cpuset notation

2016-07-13 Thread automation
gerrit-hooks has posted comments on this change. Change subject: utils: add utlity to generate positive cpuset notation .. Patch Set 1: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make su

Change in vdsm[master]: hostdev: prefer numa nodes close to device MMIO

2016-07-13 Thread automation
gerrit-hooks has posted comments on this change. Change subject: hostdev: prefer numa nodes close to device MMIO .. Patch Set 1: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure head

Change in vdsm[master]: hostdev: expose numa_node in host device

2016-07-13 Thread automation
gerrit-hooks has posted comments on this change. Change subject: hostdev: expose numa_node in host device .. Patch Set 1: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matc

Change in vdsm[master]: hostdev: report device MMIO numa node

2016-07-13 Thread automation
gerrit-hooks has posted comments on this change. Change subject: hostdev: report device MMIO numa node .. Patch Set 1: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches

Change in vdsm[master]: sos report: added full module name to _importVdsmPylibModule

2016-07-13 Thread automation
gerrit-hooks has posted comments on this change. Change subject: sos report: added full module name to _importVdsmPylibModule .. Patch Set 3: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, m

Change in vdsm[master]: hostdev: properly detect attached scsi devices

2016-07-13 Thread fromani
Francesco Romani has posted comments on this change. Change subject: hostdev: properly detect attached scsi devices .. Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.ovirt.org/60601 To unsubscribe, visit https://g

Change in vdsm[master]: hostdev: improve robustness of libvirt SCSI access

2016-07-13 Thread fromani
Francesco Romani has posted comments on this change. Change subject: hostdev: improve robustness of libvirt SCSI access .. Patch Set 8: Code-Review-1 how hard is to add some tests? -1 for visibility -- To view, visit https://

Change in vdsm[master]: hostdev: use proper scsi address

2016-07-13 Thread fromani
Francesco Romani has posted comments on this change. Change subject: hostdev: use proper scsi address .. Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.ovirt.org/60600 To unsubscribe, visit https://gerrit.ovirt.or

Change in vdsm[master]: hostdev: move scsi device code to separate class

2016-07-13 Thread fromani
Francesco Romani has posted comments on this change. Change subject: hostdev: move scsi device code to separate class .. Patch Set 9: Code-Review+1 I don't see any obvious issue if we go down this route. -- To view, visit htt

Change in vdsm[master]: hostdev: use specific device classes in HostDevice

2016-07-13 Thread fromani
Francesco Romani has posted comments on this change. Change subject: hostdev: use specific device classes in HostDevice .. Patch Set 9: Code-Review+1 copied score -- To view, visit https://gerrit.ovirt.org/57963 To unsubscrib

  1   2   >