Idan Shaby has posted comments on this change.
Change subject: storage: add getDeviceList discard related fields
..
Patch Set 1:
(1 comment)
https://gerrit.ovirt.org/#/c/60628/1/vdsm/storage/multipath.py
File vdsm/storage/mult
Dan Kenigsberg has posted comments on this change.
Change subject: vm: graphics: report display info from device
..
Patch Set 4: Code-Review+2
--
To view, visit https://gerrit.ovirt.org/60320
To unsubscribe, visit https://gerr
gerrit-hooks has posted comments on this change.
Change subject: vmxml: move metadata handling into helpers
..
Patch Set 9:
* Update tracker: IGNORE, no Bug-Url found
* Set MODIFIED::IGNORE, no Bug-Url found.
--
To view, visi
Dan Kenigsberg has submitted this change and it was merged.
Change subject: vmxml: move metadata handling into helpers
..
vmxml: move metadata handling into helpers
to make room for future users of the `metadata' section,
we sp
Adam Litke has posted comments on this change.
Change subject: tests: Introduce qemu-io pattern verification utils
..
Patch Set 2: Verified+1
--
To view, visit https://gerrit.ovirt.org/60615
To unsubscribe, visit https://gerri
gerrit-hooks has posted comments on this change.
Change subject: tests: Introduce qemu-io pattern verification utils
..
Patch Set 2:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure
gerrit-hooks has posted comments on this change.
Change subject: Define the SDM.copy_data API
..
Patch Set 4:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url
Adam Litke has posted comments on this change.
Change subject: tests: Add make_volume to FakeEnv
..
Patch Set 4: Verified+1
--
To view, visit https://gerrit.ovirt.org/60417
To unsubscribe, visit https://gerrit.ovirt.org/settin
Adam Litke has posted comments on this change.
Change subject: Define the SDM.copy_data API
..
Patch Set 4: Verified+1
--
To view, visit https://gerrit.ovirt.org/60419
To unsubscribe, visit https://gerrit.ovirt.org/settings
G
gerrit-hooks has posted comments on this change.
Change subject: qemuimg: Move wait_for_completion inside QemuImgOperation
..
Patch Set 1:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make
gerrit-hooks has posted comments on this change.
Change subject: tests: Add make_volume to FakeEnv
..
Patch Set 4:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bu
gerrit-hooks has posted comments on this change.
Change subject: Implement SDM.copy_data
..
Patch Set 4:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: '
Adam Litke has uploaded a new change for review.
Change subject: qemuimg: Move wait_for_completion inside QemuImgOperation
..
qemuimg: Move wait_for_completion inside QemuImgOperation
The Image class implemented logic to wait fo
Yaniv Bronhaim has posted comments on this change.
Change subject: Modify reports to metrics
..
Patch Set 3:
(1 comment)
https://gerrit.ovirt.org/#/c/60450/3/lib/vdsm/config.py.in
File lib/vdsm/config.py.in:
Line 449:
Tal Nisan has posted comments on this change.
Change subject: storage: add getDeviceList discard related fields
..
Patch Set 1:
(1 comment)
https://gerrit.ovirt.org/#/c/60628/1/vdsm/storage/multipath.py
File vdsm/storage/multi
gerrit-hooks has posted comments on this change.
Change subject: core: containers: add the container support module
..
Patch Set 14:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure
gerrit-hooks has posted comments on this change.
Change subject: tests: containers: add testsuite
..
Patch Set 1:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug
Francesco Romani has uploaded a new change for review.
Change subject: tests: containers: add testsuite
..
tests: containers: add testsuite
Change-Id: I27ba3cecbd71b7bbba94992d6bc63ca29333e313
WIP: more tests are being ported
Si
Adam Litke has posted comments on this change.
Change subject: Implement SDM.copy_data
..
Patch Set 3:
(16 comments)
https://gerrit.ovirt.org/#/c/60420/3/vdsm/storage/sdm/api/copy_data.py
File vdsm/storage/sdm/api/copy_data.py
Nir Soffer has posted comments on this change.
Change subject: tests: Add make_volume to FakeEnv
..
Patch Set 3: Code-Review-1
Adam, can you fix the failing test so we can merge this and the next patch?
--
To view, visit http
Nir Soffer has posted comments on this change.
Change subject: Define the SDM.copy_data API
..
Patch Set 3: Code-Review+2
--
To view, visit https://gerrit.ovirt.org/60419
To unsubscribe, visit https://gerrit.ovirt.org/settings
Nir Soffer has posted comments on this change.
Change subject: Modify reports to metrics
..
Patch Set 3:
(1 comment)
https://gerrit.ovirt.org/#/c/60450/3/lib/vdsm/config.py.in
File lib/vdsm/config.py.in:
Line 449: ('c
gerrit-hooks has posted comments on this change.
Change subject: cmdutils: enhance systemd_run
..
Patch Set 15:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-U
gerrit-hooks has posted comments on this change.
Change subject: network: supervdsm: configure container networks
..
Patch Set 27:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure he
gerrit-hooks has posted comments on this change.
Change subject: vmxml: export container metadata
..
Patch Set 6:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug
gerrit-hooks has posted comments on this change.
Change subject: vm: reorder operations in _domDependentInit
..
Patch Set 11:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header
gerrit-hooks has posted comments on this change.
Change subject: supervdsm: expose systemd utilities
..
Patch Set 15:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches
gerrit-hooks has posted comments on this change.
Change subject: core: containers: add the container support module
..
Patch Set 13:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure
gerrit-hooks has posted comments on this change.
Change subject: vmxml: move namespace declaration
..
Patch Set 8:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bu
gerrit-hooks has posted comments on this change.
Change subject: virt: utils: add is_kvm helper
..
Patch Set 19:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-
gerrit-hooks has posted comments on this change.
Change subject: vdsm: virt: add optional container support
..
Patch Set 34:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header m
gerrit-hooks has posted comments on this change.
Change subject: vm: reorder sampling initialization
..
Patch Set 10:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches
gerrit-hooks has posted comments on this change.
Change subject: vmxml: move metadata handling into helpers
..
Patch Set 8:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header ma
gerrit-hooks has posted comments on this change.
Change subject: vm: split guest agent init from domDependentInit
..
Patch Set 11:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure he
gerrit-hooks has posted comments on this change.
Change subject: vm: split device init from domDependentInit
..
Patch Set 11:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header
gerrit-hooks has posted comments on this change.
Change subject: vm: split vcpu settings from domDependentInit
..
Patch Set 10:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure heade
gerrit-hooks has posted comments on this change.
Change subject: hostdev: move usb device code to separate class
..
Patch Set 11:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure hea
gerrit-hooks has posted comments on this change.
Change subject: hostdev: cleanup udev files after PCI host devices
..
Patch Set 8:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure h
gerrit-hooks has posted comments on this change.
Change subject: hostdev: move pci device code to separate class
..
Patch Set 11:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure hea
gerrit-hooks has posted comments on this change.
Change subject: hostdev: improve robustness of libvirt SCSI access
..
Patch Set 10:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure
gerrit-hooks has posted comments on this change.
Change subject: hostdev: use specific device classes in HostDevice
..
Patch Set 11:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure
gerrit-hooks has posted comments on this change.
Change subject: hostdev: properly detect attached scsi devices
..
Patch Set 3:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure heade
gerrit-hooks has posted comments on this change.
Change subject: hostdev: move scsi device code to separate class
..
Patch Set 11:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure he
gerrit-hooks has posted comments on this change.
Change subject: network/sr-iov: use device teardown to reattach device
..
Patch Set 2:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make su
gerrit-hooks has posted comments on this change.
Change subject: hostdev: use proper scsi address
..
Patch Set 3:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug
Yaniv Kaul has posted comments on this change.
Change subject: storage: add getDeviceList discard related fields
..
Patch Set 1: Code-Review-1
(1 comment)
I'm quite positive the key queried should be discard_max_hw_bytes and n
Adam Litke has posted comments on this change.
Change subject: tests: Introduce qemu-io pattern verification utils
..
Patch Set 1:
(4 comments)
https://gerrit.ovirt.org/#/c/60615/1/tests/storagetestlib.py
File tests/storagetes
Milan Zamazal has posted comments on this change.
Change subject: vm: graphics: drop legacy configuration support
..
Patch Set 4: Code-Review+1
I see, it's removed in the followup patches.
--
To view, visit https://gerrit.ovi
gerrit-hooks has posted comments on this change.
Change subject: hostdev: cleanup udev files after PCI host devices
..
Patch Set 7:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure h
gerrit-hooks has posted comments on this change.
Change subject: network/sr-iov: use device teardown to reattach device
..
Patch Set 1:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make su
gerrit-hooks has posted comments on this change.
Change subject: hostdev: move usb device code to separate class
..
Patch Set 10:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure hea
gerrit-hooks has posted comments on this change.
Change subject: hostdev: move scsi device code to separate class
..
Patch Set 10:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure he
gerrit-hooks has posted comments on this change.
Change subject: hostdev: improve robustness of libvirt SCSI access
..
Patch Set 9:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure h
gerrit-hooks has posted comments on this change.
Change subject: hostdev: use proper scsi address
..
Patch Set 2:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug
Adam Litke has posted comments on this change.
Change subject: tests: Add make_volume to FakeEnv
..
Patch Set 3:
(1 comment)
https://gerrit.ovirt.org/#/c/60417/3/tests/storagetestlib.py
File tests/storagetestlib.py:
Line 52:
gerrit-hooks has posted comments on this change.
Change subject: hostdev: move pci device code to separate class
..
Patch Set 10:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure hea
gerrit-hooks has posted comments on this change.
Change subject: hostdev: use specific device classes in HostDevice
..
Patch Set 10:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure
gerrit-hooks has posted comments on this change.
Change subject: hostdev: properly detect attached scsi devices
..
Patch Set 2:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure heade
Martin Polednik has uploaded a new change for review.
Change subject: network/sr-iov: use device teardown to reattach device
..
network/sr-iov: use device teardown to reattach device
Change-Id: I2ff3299e4a9baaf02a3b96cd94cdf9871
gerrit-hooks has posted comments on this change.
Change subject: hostdev: report device MMIO numa node
..
Patch Set 2:
* #1356161::Update tracker: OK
* Check Bug-Url::OK
* Check Public Bug::#1356161::OK, public bug
* Check Prod
gerrit-hooks has posted comments on this change.
Change subject: hostdev: prefer numa nodes close to device MMIO
..
Patch Set 2:
* #1356161::Update tracker: OK
* Check Bug-Url::OK
* Check Public Bug::#1356161::OK, public bug
*
gerrit-hooks has posted comments on this change.
Change subject: utils: add utlity to generate positive cpuset notation
..
Patch Set 2:
* #1356161::Update tracker: OK
* Check Bug-Url::OK
* Check Public Bug::#1356161::OK, public
gerrit-hooks has posted comments on this change.
Change subject: hostdev: expose numa_node in host device
..
Patch Set 2:
* #1356161::Update tracker: OK
* Check Bug-Url::OK
* Check Public Bug::#1356161::OK, public bug
* Check P
Francesco Romani has posted comments on this change.
Change subject: vm: graphics: drop legacy configuration support
..
Patch Set 4:
I'd say looks good:
1099 15:46:57 fromani@musashi ~/Projects/upstream/vdsm $ git co
virt-dev-
Milan Zamazal has posted comments on this change.
Change subject: vm: graphics: drop legacy configuration support
..
Patch Set 4:
Great, thanks. Would you like to check also places in deviceTests.py where
isLegacy is used?
--
gerrit-hooks has posted comments on this change.
Change subject: v2v: dup commands.execCmd to allow redirection
..
Patch Set 2:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure heade
Francesco Romani has posted comments on this change.
Change subject: v2v: dup commands.execCmd to allow redirection
..
Patch Set 1: Code-Review-1
(1 comment)
https://gerrit.ovirt.org/#/c/60660/1/lib/vdsm/v2v.py
File lib/vdsm/v
Milan Zamazal has posted comments on this change.
Change subject: virt: Limit the number of workers in executor
..
Patch Set 19: Verified+1
Verified by injecting time.sleep(10) into _RunnableOnVm.__call__, printing
the num
gerrit-hooks has posted comments on this change.
Change subject: v2v: dup commands.execCmd to allow redirection
..
Patch Set 1:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure heade
gerrit-hooks has posted comments on this change.
Change subject: virt: Add docstrings about Executor parameters and behavior
..
Patch Set 15:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, m
Freddy Rolland has posted comments on this change.
Change subject: Define the SDM.copy_data API
..
Patch Set 3: Code-Review+1
--
To view, visit https://gerrit.ovirt.org/60419
To unsubscribe, visit https://gerrit.ovirt.org/sett
Freddy Rolland has posted comments on this change.
Change subject: Define the SDM.copy_data API
..
Patch Set 3:
Endpoint has a network connotation for me, but I don't have a better
proposition.
--
To view, visit https://gerr
gerrit-hooks has posted comments on this change.
Change subject: virt: Limit the number of workers in executor
..
Patch Set 19:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure heade
Milan Zamazal has posted comments on this change.
Change subject: tox: Exclude .ropeproject from pep8 check
..
Patch Set 4: Verified+1
Verified by running `make check' in a Vdsm tree with .ropeproject and checking
that it brea
Liron Aravot has posted comments on this change.
Change subject: Define the SDM.copy_data API
..
Patch Set 3: Code-Review+1
--
To view, visit https://gerrit.ovirt.org/60419
To unsubscribe, visit https://gerrit.ovirt.org/settin
Francesco Romani has posted comments on this change.
Change subject: vm: graphics: drop legacy configuration support
..
Patch Set 4: Verified+1
since last verification dropped more stale tests, copied score.
--
To view, visit
Francesco Romani has posted comments on this change.
Change subject: vm: graphics: drop legacy configuration support
..
Patch Set 3:
(1 comment)
https://gerrit.ovirt.org/#/c/60321/3//COMMIT_MSG
Commit Message:
Line 5: CommitD
gerrit-hooks has posted comments on this change.
Change subject: vm: storage: drop legacy network config support
..
Patch Set 4:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure head
gerrit-hooks has posted comments on this change.
Change subject: vm: storage: drop legacy graphics config support
..
Patch Set 4:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure hea
gerrit-hooks has posted comments on this change.
Change subject: vm: graphics: report display info from device
..
Patch Set 4:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header
gerrit-hooks has posted comments on this change.
Change subject: vm: always expect Vm devices to be sent
..
Patch Set 4:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header match
gerrit-hooks has posted comments on this change.
Change subject: vm: graphics: drop legacy configuration support
..
Patch Set 4:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure head
gerrit-hooks has posted comments on this change.
Change subject: vm: drop legacy device config support
..
Patch Set 4:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches
gerrit-hooks has posted comments on this change.
Change subject: vm: storage: drop legacy drive config support
..
Patch Set 4:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header
Francesco Romani has posted comments on this change.
Change subject: Send vm info report each sampling interval from HostMonitor
..
Patch Set 2:
(1 comment)
https://gerrit.ovirt.org/#/c/59523/2/lib/vdsm/virt/sampling.py
File l
Martin Polednik has posted comments on this change.
Change subject: hostdev: improve robustness of libvirt SCSI access
..
Patch Set 8:
I don't think we have proper testing framework for these methods, but since
this one is iso
Francesco Romani has posted comments on this change.
Change subject: Adding report_stats to virt.stats
..
Patch Set 7:
(5 comments)
looks generally ok, few comments inside. -1 for visibility.
https://gerrit.ovirt.org/#/c/5906
Martin Polednik has posted comments on this change.
Change subject: hostdev: move pci device code to separate class
..
Patch Set 9:
(1 comment)
https://gerrit.ovirt.org/#/c/57956/9/vdsm/virt/vmdevices/hostdevice.py
File vdsm/v
Edward Haas has posted comments on this change.
Change subject: vm: storage: drop legacy network config support
..
Patch Set 3: Code-Review+1
--
To view, visit https://gerrit.ovirt.org/60324
To unsubscribe, visit https://gerri
Martin Polednik has posted comments on this change.
Change subject: hostdev: cleanup udev files after PCI host devices
..
Patch Set 6: Code-Review-1
(1 comment)
https://gerrit.ovirt.org/#/c/59042/6//COMMIT_MSG
Commit Message:
gerrit-hooks has posted comments on this change.
Change subject: utils: add utlity to generate positive cpuset notation
..
Patch Set 1:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make su
gerrit-hooks has posted comments on this change.
Change subject: hostdev: prefer numa nodes close to device MMIO
..
Patch Set 1:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure head
gerrit-hooks has posted comments on this change.
Change subject: hostdev: expose numa_node in host device
..
Patch Set 1:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matc
gerrit-hooks has posted comments on this change.
Change subject: hostdev: report device MMIO numa node
..
Patch Set 1:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches
gerrit-hooks has posted comments on this change.
Change subject: sos report: added full module name to _importVdsmPylibModule
..
Patch Set 3:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, m
Francesco Romani has posted comments on this change.
Change subject: hostdev: properly detect attached scsi devices
..
Patch Set 1: Code-Review+1
--
To view, visit https://gerrit.ovirt.org/60601
To unsubscribe, visit https://g
Francesco Romani has posted comments on this change.
Change subject: hostdev: improve robustness of libvirt SCSI access
..
Patch Set 8: Code-Review-1
how hard is to add some tests?
-1 for visibility
--
To view, visit https://
Francesco Romani has posted comments on this change.
Change subject: hostdev: use proper scsi address
..
Patch Set 1: Code-Review+1
--
To view, visit https://gerrit.ovirt.org/60600
To unsubscribe, visit https://gerrit.ovirt.or
Francesco Romani has posted comments on this change.
Change subject: hostdev: move scsi device code to separate class
..
Patch Set 9: Code-Review+1
I don't see any obvious issue if we go down this route.
--
To view, visit htt
Francesco Romani has posted comments on this change.
Change subject: hostdev: use specific device classes in HostDevice
..
Patch Set 9: Code-Review+1
copied score
--
To view, visit https://gerrit.ovirt.org/57963
To unsubscrib
1 - 100 of 154 matches
Mail list logo