Change in vdsm[master]: ovs: use Setup class directly

2016-07-16 Thread edwardh
Edward Haas has posted comments on this change. Change subject: ovs: use Setup class directly .. Patch Set 4: (1 comment) A nit. https://gerrit.ovirt.org/#/c/60405/4/lib/vdsm/network/ovs/switch.py File lib/vdsm/network/ovs/sw

Change in vdsm[master]: ovs: flush IP config from attached ifaces

2016-07-16 Thread edwardh
Edward Haas has posted comments on this change. Change subject: ovs: flush IP config from attached ifaces .. Patch Set 11: (1 comment) https://gerrit.ovirt.org/#/c/59958/11/tests/network/func_dhclient_test.py File tests/networ

Change in vdsm[master]: refmt: Use more standard main() function

2016-07-16 Thread automation
gerrit-hooks has posted comments on this change. Change subject: refmt: Use more standard main() function .. Patch Set 2: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matc

Change in vdsm[master]: remft: Add online help

2016-07-16 Thread automation
gerrit-hooks has posted comments on this change. Change subject: remft: Add online help .. Patch Set 2: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' a

Change in vdsm[master]: Implement SDM.copy_data

2016-07-16 Thread nsoffer
Nir Soffer has posted comments on this change. Change subject: Implement SDM.copy_data .. Patch Set 9: Code-Review-1 (5 comments) https://gerrit.ovirt.org/#/c/60420/9/tests/storage_sdm_copy_data_test.py File tests/storage_sdm_

Change in vdsm[master]: Implement SDM.copy_data

2016-07-16 Thread automation
gerrit-hooks has posted comments on this change. Change subject: Implement SDM.copy_data .. Patch Set 9: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: '

Change in vdsm[master]: Modify reports to metrics

2016-07-16 Thread nsoffer
Nir Soffer has submitted this change and it was merged. Change subject: Modify reports to metrics .. Modify reports to metrics Reports is more about the output graphs. The idea behind this module is to send metrics information.

Change in vdsm[master]: Modify reports to metrics

2016-07-16 Thread automation
gerrit-hooks has posted comments on this change. Change subject: Modify reports to metrics .. Patch Set 5: * Update tracker: IGNORE, no Bug-Url found * Set MODIFIED::IGNORE, no Bug-Url found. -- To view, visit https://gerrit.

Change in vdsm[master]: Modify reports to metrics

2016-07-16 Thread nsoffer
Nir Soffer has posted comments on this change. Change subject: Modify reports to metrics .. Patch Set 4: Code-Review+2 -- To view, visit https://gerrit.ovirt.org/60450 To unsubscribe, visit https://gerrit.ovirt.org/settings G

Change in vdsm[master]: stomp: make client user aware that no connection available

2016-07-16 Thread nsoffer
Nir Soffer has posted comments on this change. Change subject: stomp: make client user aware that no connection available .. Patch Set 8: Code-Review-1 (1 comment) https://gerrit.ovirt.org/#/c/58029/8/lib/yajsonrpc/stompreacto

Change in vdsm[master]: vm: storage: drop legacy drive config support

2016-07-16 Thread nsoffer
Nir Soffer has posted comments on this change. Change subject: vm: storage: drop legacy drive config support .. Patch Set 6: Please rebase to get the tests pass on fc24. -- To view, visit https://gerrit.ovirt.org/60323 To uns

Change in vdsm[master]: vm: storage: drop legacy drive config support

2016-07-16 Thread nsoffer
Nir Soffer has posted comments on this change. Change subject: vm: storage: drop legacy drive config support .. Patch Set 6: Code-Review+2 -- To view, visit https://gerrit.ovirt.org/60323 To unsubscribe, visit https://gerrit.o

Change in vdsm[master]: oop: Explicitly close running ioprocesses

2016-07-16 Thread automation
gerrit-hooks has posted comments on this change. Change subject: oop: Explicitly close running ioprocesses .. Patch Set 3: * #1334274::Update tracker: OK * Check Bug-Url::OK * Check Public Bug::#1334274::OK, public bug * Check

Change in vdsm[master]: automation: move master to fc24

2016-07-16 Thread nsoffer
Nir Soffer has posted comments on this change. Change subject: automation: move master to fc24 .. Patch Set 2: Merging quickly to unbreak our CI. -- To view, visit https://gerrit.ovirt.org/60725 To unsubscribe, visit https://

Change in vdsm[master]: automation: move master to fc24

2016-07-16 Thread automation
gerrit-hooks has posted comments on this change. Change subject: automation: move master to fc24 .. Patch Set 3: * Update tracker: IGNORE, no Bug-Url found * Set MODIFIED::IGNORE, no Bug-Url found. -- To view, visit https://g

Change in vdsm[master]: automation: move master to fc24

2016-07-16 Thread nsoffer
Nir Soffer has submitted this change and it was merged. Change subject: automation: move master to fc24 .. automation: move master to fc24 Change-Id: I5c1f04d112ed8eab2e72ba629a3d21ec89536e02 Signed-off-by: Sandro Bonazzola Re

Change in vdsm[master]: automation: move master to fc24

2016-07-16 Thread nsoffer
Nir Soffer has posted comments on this change. Change subject: automation: move master to fc24 .. Patch Set 2: Code-Review+2 -- To view, visit https://gerrit.ovirt.org/60725 To unsubscribe, visit https://gerrit.ovirt.org/setti

Change in vdsm[master]: oop: Explicitly close running ioprocesses

2016-07-16 Thread automation
gerrit-hooks has posted comments on this change. Change subject: oop: Explicitly close running ioprocesses .. Patch Set 2: * #1334274::Update tracker: OK * Check Bug-Url::OK * Check Public Bug::#1334274::OK, public bug * Check

Change in vdsm[master]: oop: Explicitly close running ioprocesses

2016-07-16 Thread automation
gerrit-hooks has posted comments on this change. Change subject: oop: Explicitly close running ioprocesses .. Patch Set 1: * #1334274::Update tracker: OK * Check Bug-Url::OK * Check Public Bug::#1334274::OK, public bug * Check

Change in vdsm[master]: oop: Explicitly close running ioprocesses

2016-07-16 Thread nsoffer
Nir Soffer has uploaded a new change for review. Change subject: oop: Explicitly close running ioprocesses .. oop: Explicitly close running ioprocesses IOProcess client is using __del__ for automatic closing when the last refere

Change in vdsm[master]: ovs: acquire external ifaces

2016-07-16 Thread automation
gerrit-hooks has posted comments on this change. Change subject: ovs: acquire external ifaces .. Patch Set 18: * #1195208::Update tracker: OK * Check Bug-Url::OK * Check Public Bug::#1195208::OK, public bug * Check Product::#11

Change in vdsm[master]: ovs: acquire external ifaces

2016-07-16 Thread phoracek
Petr Horáček has posted comments on this change. Change subject: ovs: acquire external ifaces .. Patch Set 17: Verified+1 (1 comment) Passed network/*_test.py OK. Now we can test it on a real host. https://gerrit.ovirt.org/#/

Change in vdsm[master]: ovs: acquire external ifaces

2016-07-16 Thread automation
gerrit-hooks has posted comments on this change. Change subject: ovs: acquire external ifaces .. Patch Set 17: * #1195208::Update tracker: OK * Check Bug-Url::OK * Check Public Bug::#1195208::OK, public bug * Check Product::#11

Change in vdsm[master]: ovs: acquire external ifaces

2016-07-16 Thread phoracek
Petr Horáček has restored this change. Change subject: ovs: acquire external ifaces .. Restored -- To view, visit https://gerrit.ovirt.org/60404 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: rest

Change in vdsm[master]: ovs: use ovsdb factory

2016-07-16 Thread automation
gerrit-hooks has posted comments on this change. Change subject: ovs: use ovsdb factory .. Patch Set 6: * #1195208::Update tracker: OK -- To view, visit https://gerrit.ovirt.org/60824 To unsubscribe, visit https://gerrit.ovir

Change in vdsm[master]: ovs: acquire external ifaces

2016-07-16 Thread automation
gerrit-hooks has posted comments on this change. Change subject: ovs: acquire external ifaces .. Patch Set 16: * #1195208::Update tracker: OK -- To view, visit https://gerrit.ovirt.org/60404 To unsubscribe, visit https://gerr

Change in vdsm[master]: ovs: use ovsdb factory

2016-07-16 Thread phoracek
Petr Horáček has abandoned this change. Change subject: ovs: use ovsdb factory .. Abandoned -- To view, visit https://gerrit.ovirt.org/60824 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: abandon

Change in vdsm[master]: ovs: acquire external ifaces

2016-07-16 Thread phoracek
Petr Horáček has abandoned this change. Change subject: ovs: acquire external ifaces .. Abandoned -- To view, visit https://gerrit.ovirt.org/60404 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: ab

Change in vdsm[master]: ovs: use Setup class directly

2016-07-16 Thread phoracek
Petr Horáček has posted comments on this change. Change subject: ovs: use Setup class directly .. Patch Set 4: Verified+1 (1 comment) Passed network/*_test.py OK. https://gerrit.ovirt.org/#/c/60405/3/lib/vdsm/network/ovs/swit

Change in vdsm[master]: ovs: use Setup class directly

2016-07-16 Thread automation
gerrit-hooks has posted comments on this change. Change subject: ovs: use Setup class directly .. Patch Set 4: * #1195208::Update tracker: OK * Check Bug-Url::OK * Check Public Bug::#1195208::OK, public bug * Check Product::#11

Change in vdsm[master]: ovs: acquire external ifaces

2016-07-16 Thread automation
gerrit-hooks has posted comments on this change. Change subject: ovs: acquire external ifaces .. Patch Set 16: * #1195208::Update tracker: OK * Check Bug-Url::OK * Check Public Bug::#1195208::OK, public bug * Check Product::#11

Change in vdsm[master]: ovs: use Setup class directly

2016-07-16 Thread edwardh
Edward Haas has posted comments on this change. Change subject: ovs: use Setup class directly .. Patch Set 3: (1 comment) https://gerrit.ovirt.org/#/c/60405/3/lib/vdsm/network/ovs/switch.py File lib/vdsm/network/ovs/switch.py:

Change in vdsm[master]: ovs: use ovsdb factory

2016-07-16 Thread edwardh
Edward Haas has posted comments on this change. Change subject: ovs: use ovsdb factory .. Patch Set 6: The point was to avoid exposing ovsdb to the netswitch level. If you create an object in the Setup constructor it makes the

Change in vdsm[master]: ovs: use Setup class directly

2016-07-16 Thread automation
gerrit-hooks has posted comments on this change. Change subject: ovs: use Setup class directly .. Patch Set 3: * #1195208::Update tracker: OK * Check Bug-Url::OK * Check Public Bug::#1195208::OK, public bug * Check Product::#11

Change in vdsm[master]: ovs: flush IP config from attached ifaces

2016-07-16 Thread phoracek
Petr Horáček has posted comments on this change. Change subject: ovs: flush IP config from attached ifaces .. Patch Set 11: (8 comments) https://gerrit.ovirt.org/#/c/59958/11/lib/vdsm/network/ovs/switch.py File lib/vdsm/networ

Change in vdsm[master]: ovs: acquire external ifaces

2016-07-16 Thread automation
gerrit-hooks has posted comments on this change. Change subject: ovs: acquire external ifaces .. Patch Set 15: * #1195208::Update tracker: OK * Check Bug-Url::OK * Check Public Bug::#1195208::OK, public bug * Check Product::#11

Change in vdsm[master]: ovs: use ovsdb factory

2016-07-16 Thread phoracek
Petr Horáček has posted comments on this change. Change subject: ovs: use ovsdb factory .. Patch Set 6: Sorry, I still cannot see any benefit of using Setup factory instead of Setup directly (Setup will obtain ovsdb on its own

Change in vdsm[master]: ovs: use ovsdb factory

2016-07-16 Thread edwardh
Edward Haas has posted comments on this change. Change subject: ovs: use ovsdb factory .. Patch Set 6: Code-Review-1 I think there was a misunderstanding. Why do we need an ovsdb factory? I was thinking about a factory for the

Change in vdsm[master]: ovs: acquire external ifaces

2016-07-16 Thread automation
gerrit-hooks has posted comments on this change. Change subject: ovs: acquire external ifaces .. Patch Set 14: * #1195208::Update tracker: OK * Check Bug-Url::OK * Check Public Bug::#1195208::OK, public bug * Check Product::#11

Change in vdsm[master]: ovs: use ovsdb factory

2016-07-16 Thread phoracek
Petr Horáček has posted comments on this change. Change subject: ovs: use ovsdb factory .. Patch Set 6: Verified+1 Passed network/*_test.py OK -- To view, visit https://gerrit.ovirt.org/60824 To unsubscribe, visit https://ger

Change in vdsm[master]: ovs: use ovsdb factory

2016-07-16 Thread automation
gerrit-hooks has posted comments on this change. Change subject: ovs: use ovsdb factory .. Patch Set 6: * #1195208::Update tracker: OK * Check Bug-Url::OK * Check Public Bug::#1195208::OK, public bug * Check Product::#1195208::