Change in vdsm[master]: osutils: Move NoIntrCall to osutils.uninterruptible

2016-07-20 Thread edwardh
Edward Haas has posted comments on this change. Change subject: osutils: Move NoIntrCall to osutils.uninterruptible .. Patch Set 2: Code-Review+1 (1 comment) Looks good to me, only one nit. https://gerrit.ovirt.org/#/c/61153/

Change in vdsm[master]: osutils: Move NoIntrCall to osutils.uninterruptible

2016-07-20 Thread fromani
Francesco Romani has posted comments on this change. Change subject: osutils: Move NoIntrCall to osutils.uninterruptible .. Patch Set 2: Code-Review+1 much nicer this way -- To view, visit https://gerrit.ovirt.org/61153 To un

Change in vdsm[master]: osutils: Start the osutils module

2016-07-20 Thread fromani
Francesco Romani has posted comments on this change. Change subject: osutils: Start the osutils module .. Patch Set 3: Code-Review+1 -- To view, visit https://gerrit.ovirt.org/61142 To unsubscribe, visit https://gerrit.ovirt.o

Change in vdsm[ovirt-4.0]: vdscli: Provide py3 compatible xmlrpclib (using six)

2016-07-20 Thread edwardh
Edward Haas has posted comments on this change. Change subject: vdscli: Provide py3 compatible xmlrpclib (using six) .. Patch Set 1: Code-Review+1 (1 comment) https://gerrit.ovirt.org/#/c/61150/1//COMMIT_MSG Commit Message: L

Change in vdsm[master]: ovs: copy NIC hwaddr to NB

2016-07-20 Thread automation
gerrit-hooks has posted comments on this change. Change subject: ovs: copy NIC hwaddr to NB .. Patch Set 8: * #1195208::Update tracker: OK * Check Bug-Url::OK * Check Public Bug::#1195208::OK, public bug * Check Product::#11952

Change in vdsm[master]: ovs: rollback acquired ifaces after failure

2016-07-20 Thread automation
gerrit-hooks has posted comments on this change. Change subject: ovs: rollback acquired ifaces after failure .. Patch Set 5: * #1195208::Update tracker: OK * Check Bug-Url::OK * Check Public Bug::#1195208::OK, public bug * Chec

Change in vdsm[ovirt-4.0]: vdscli: Provide py3 compatible xmlrpclib (using six)

2016-07-20 Thread phoracek
Petr Horáček has posted comments on this change. Change subject: vdscli: Provide py3 compatible xmlrpclib (using six) .. Patch Set 1: Without this backport, the following patch fails with: 14:41:07 File "/home/jenkins/works

Change in vdsm[master]: ovs: copy NIC hwaddr to NB

2016-07-20 Thread automation
gerrit-hooks has posted comments on this change. Change subject: ovs: copy NIC hwaddr to NB .. Patch Set 7: * #1195208::Update tracker: OK * Check Bug-Url::OK * Check Public Bug::#1195208::OK, public bug * Check Product::#11952

Change in vdsm[master]: Live Merge: Restore watermark tracking

2016-07-20 Thread alitke
Adam Litke has posted comments on this change. Change subject: Live Merge: Restore watermark tracking .. Patch Set 6: (9 comments) Nice! https://gerrit.ovirt.org/#/c/60889/6/vdsm/virt/vm.py File vdsm/virt/vm.py: Line 198:

Change in vdsm[master]: ovs: copy NIC hwaddr to NB

2016-07-20 Thread automation
gerrit-hooks has posted comments on this change. Change subject: ovs: copy NIC hwaddr to NB .. Patch Set 6: * #1195208::Update tracker: OK * Check Bug-Url::OK * Check Public Bug::#1195208::OK, public bug * Check Product::#11952

Change in vdsm[master]: ovs: rollback acquired ifaces after failure

2016-07-20 Thread automation
gerrit-hooks has posted comments on this change. Change subject: ovs: rollback acquired ifaces after failure .. Patch Set 4: * #1195208::Update tracker: OK * Check Bug-Url::OK * Check Public Bug::#1195208::OK, public bug * Chec

Change in vdsm[master]: storage: add getDeviceList discard related fields

2016-07-20 Thread automation
gerrit-hooks has posted comments on this change. Change subject: storage: add getDeviceList discard related fields .. Patch Set 6: * #1241106::Update tracker: OK * #1342919::Update tracker: OK * Set MODIFIED::bug 1241106#12

Change in vdsm[master]: storage: add getDeviceList discard related fields

2016-07-20 Thread nsoffer
Nir Soffer has submitted this change and it was merged. Change subject: storage: add getDeviceList discard related fields .. storage: add getDeviceList discard related fields This patch adds getDeviceList two discard related fi

Change in vdsm[master]: Live Merge: Restore watermark tracking

2016-07-20 Thread automation
gerrit-hooks has posted comments on this change. Change subject: Live Merge: Restore watermark tracking .. Patch Set 6: * #1168327::Update tracker: OK * Check Bug-Url::OK * Check Public Bug::#1168327::OK, public bug * Check Pro

Change in vdsm[master]: Live Merge: Restore watermark tracking

2016-07-20 Thread ahino
Ala Hino has posted comments on this change. Change subject: Live Merge: Restore watermark tracking .. Patch Set 5: (18 comments) https://gerrit.ovirt.org/#/c/60889/5/vdsm/virt/vm.py File vdsm/virt/vm.py: PS5, Line 200: st =

Change in vdsm[master]: storage: add getDeviceList discard related fields

2016-07-20 Thread automation
gerrit-hooks has posted comments on this change. Change subject: storage: add getDeviceList discard related fields .. Patch Set 5: * #1241106::Update tracker: OK * #1342919::Update tracker: OK * Check Bug-Url::OK * Check Public

Change in vdsm[master]: multipath: add the read_int helper function

2016-07-20 Thread automation
gerrit-hooks has posted comments on this change. Change subject: multipath: add the read_int helper function .. Patch Set 5: * Update tracker: IGNORE, no Bug-Url found * Set MODIFIED::IGNORE, no Bug-Url found. -- To view, vis

Change in vdsm[master]: multipath: add the read_int helper function

2016-07-20 Thread nsoffer
Nir Soffer has submitted this change and it was merged. Change subject: multipath: add the read_int helper function .. multipath: add the read_int helper function This patch adds a new function that reads the first line of a fi

Change in vdsm[master]: osutils: Move NoIntrCall to osutils.uninterruptible

2016-07-20 Thread automation
gerrit-hooks has posted comments on this change. Change subject: osutils: Move NoIntrCall to osutils.uninterruptible .. Patch Set 2: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure

Change in vdsm[master]: sdm: Jobs may be run only when status=pending

2016-07-20 Thread nsoffer
Nir Soffer has posted comments on this change. Change subject: sdm: Jobs may be run only when status=pending .. Patch Set 2: (1 comment) https://gerrit.ovirt.org/#/c/61138/2/vdsm/storage/sdm/api/base.py File vdsm/storage/sdm/a

Change in vdsm[master]: sdm: Jobs may be run only when status=pending

2016-07-20 Thread nsoffer
Nir Soffer has posted comments on this change. Change subject: sdm: Jobs may be run only when status=pending .. Patch Set 2: Code-Review+2 -- To view, visit https://gerrit.ovirt.org/61138 To unsubscribe, visit https://gerrit.o

Change in vdsm[master]: tests: Enable tests watcher only if TIMEOUT set

2016-07-20 Thread nsoffer
Nir Soffer has posted comments on this change. Change subject: tests: Enable tests watcher only if TIMEOUT set .. Patch Set 1: ping -- To view, visit https://gerrit.ovirt.org/60240 To unsubscribe, visit https://gerrit.ovirt.o

Change in vdsm[master]: tests: Terminate watcher when tests fail

2016-07-20 Thread nsoffer
Nir Soffer has posted comments on this change. Change subject: tests: Terminate watcher when tests fail .. Patch Set 1: ping -- To view, visit https://gerrit.ovirt.org/60239 To unsubscribe, visit https://gerrit.ovirt.org/sett

Change in vdsm[master]: tests: Add test for testing the timeout mechanism

2016-07-20 Thread nsoffer
Nir Soffer has posted comments on this change. Change subject: tests: Add test for testing the timeout mechanism .. Patch Set 6: ping -- To view, visit https://gerrit.ovirt.org/58423 To unsubscribe, visit https://gerrit.ovirt

Change in vdsm[master]: osutils: Move NoIntrCall to osutils.uninterruptible

2016-07-20 Thread automation
gerrit-hooks has posted comments on this change. Change subject: osutils: Move NoIntrCall to osutils.uninterruptible .. Patch Set 1: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure

Change in vdsm[master]: osutils: Move NoIntrCall to osutils.uninterruptible

2016-07-20 Thread nsoffer
Nir Soffer has uploaded a new change for review. Change subject: osutils: Move NoIntrCall to osutils.uninterruptible .. osutils: Move NoIntrCall to osutils.uninterruptible Streamline the code and missing tests Change-Id: I51f85

Change in vdsm[master]: sdm: Jobs may be run only when status=pending

2016-07-20 Thread automation
gerrit-hooks has posted comments on this change. Change subject: sdm: Jobs may be run only when status=pending .. Patch Set 2: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header

Change in vdsm[master]: Live Merge: Restore watermark tracking

2016-07-20 Thread alitke
Adam Litke has posted comments on this change. Change subject: Live Merge: Restore watermark tracking .. Patch Set 5: (18 comments) Great patch! I gave this a pretty hands-on review because I saw some room for making it a bi

Change in vdsm[master]: osutils: Start the osutils module

2016-07-20 Thread nsoffer
Nir Soffer has posted comments on this change. Change subject: osutils: Start the osutils module .. Patch Set 3: Verified+1 -- To view, visit https://gerrit.ovirt.org/61142 To unsubscribe, visit https://gerrit.ovirt.org/settin

Change in vdsm[ovirt-4.0]: vdscli: Provide py3 compatible xmlrpclib (using six)

2016-07-20 Thread nsoffer
Nir Soffer has posted comments on this change. Change subject: vdscli: Provide py3 compatible xmlrpclib (using six) .. Patch Set 1: (1 comment) https://gerrit.ovirt.org/#/c/61150/1//COMMIT_MSG Commit Message: Line 3: AuthorDa

Change in vdsm[master]: clusterlock: Raise if lock is used improperly

2016-07-20 Thread automation
gerrit-hooks has posted comments on this change. Change subject: clusterlock: Raise if lock is used improperly .. Patch Set 5: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header

Change in vdsm[master]: osutils: Start the osutils module

2016-07-20 Thread automation
gerrit-hooks has posted comments on this change. Change subject: osutils: Start the osutils module .. Patch Set 3: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bu

Change in vdsm[master]: clusterlock: Fix double close on EINTR

2016-07-20 Thread automation
gerrit-hooks has posted comments on this change. Change subject: clusterlock: Fix double close on EINTR .. Patch Set 4: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matche

Change in vdsm[master]: sd: Support volume leases

2016-07-20 Thread automation
gerrit-hooks has posted comments on this change. Change subject: sd: Support volume leases .. Patch Set 6: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: '

Change in vdsm[master]: sd: Unify getVolumeLease signature

2016-07-20 Thread automation
gerrit-hooks has posted comments on this change. Change subject: sd: Unify getVolumeLease signature .. Patch Set 6: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'B

Change in vdsm[master]: sd: Move getVolumeLease to StorageDomainManifest

2016-07-20 Thread automation
gerrit-hooks has posted comments on this change. Change subject: sd: Move getVolumeLease to StorageDomainManifest .. Patch Set 6: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure hea

Change in vdsm[master]: clusterlock: Fix LocalLock.supports_volume_leases

2016-07-20 Thread automation
gerrit-hooks has posted comments on this change. Change subject: clusterlock: Fix LocalLock.supports_volume_leases .. Patch Set 5: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure he

Change in vdsm[master]: clusterlock: Support for multiple leases

2016-07-20 Thread automation
gerrit-hooks has posted comments on this change. Change subject: clusterlock: Support for multiple leases .. Patch Set 6: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matc

Change in vdsm[master]: osutils: Start the osutils module

2016-07-20 Thread nsoffer
Nir Soffer has posted comments on this change. Change subject: osutils: Start the osutils module .. Patch Set 1: (3 comments) https://gerrit.ovirt.org/#/c/61142/1/lib/vdsm/osutils.py File lib/vdsm/osutils.py: Line 37: htt

Change in vdsm[ovirt-4.0]: vdscli: Provide py3 compatible xmlrpclib (using six)

2016-07-20 Thread automation
gerrit-hooks has posted comments on this change. Change subject: vdscli: Provide py3 compatible xmlrpclib (using six) .. Patch Set 1: * #1195208::Update tracker: OK * Check Bug-Url::OK * Check Public Bug::#1195208::OK, public b

Change in vdsm[master]: clusterlock: Raise if lock is used improperly

2016-07-20 Thread automation
gerrit-hooks has posted comments on this change. Change subject: clusterlock: Raise if lock is used improperly .. Patch Set 4: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header

Change in vdsm[master]: osutils: Start the osutils module

2016-07-20 Thread automation
gerrit-hooks has posted comments on this change. Change subject: osutils: Start the osutils module .. Patch Set 2: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bu

Change in vdsm[master]: clusterlock: Support for multiple leases

2016-07-20 Thread automation
gerrit-hooks has posted comments on this change. Change subject: clusterlock: Support for multiple leases .. Patch Set 5: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matc

Change in vdsm[master]: sd: Support volume leases

2016-07-20 Thread automation
gerrit-hooks has posted comments on this change. Change subject: sd: Support volume leases .. Patch Set 5: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: '

Change in vdsm[master]: clusterlock: Fix LocalLock.supports_volume_leases

2016-07-20 Thread automation
gerrit-hooks has posted comments on this change. Change subject: clusterlock: Fix LocalLock.supports_volume_leases .. Patch Set 4: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure he

Change in vdsm[master]: clusterlock: Fix double close on EINTR

2016-07-20 Thread automation
gerrit-hooks has posted comments on this change. Change subject: clusterlock: Fix double close on EINTR .. Patch Set 3: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matche

Change in vdsm[master]: sd: Move getVolumeLease to StorageDomainManifest

2016-07-20 Thread automation
gerrit-hooks has posted comments on this change. Change subject: sd: Move getVolumeLease to StorageDomainManifest .. Patch Set 5: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure hea

Change in vdsm[master]: sd: Unify getVolumeLease signature

2016-07-20 Thread automation
gerrit-hooks has posted comments on this change. Change subject: sd: Unify getVolumeLease signature .. Patch Set 5: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'B

Change in vdsm[master]: osutils: Start the osutils module

2016-07-20 Thread ybronhei
Yaniv Bronhaim has posted comments on this change. Change subject: osutils: Start the osutils module .. Patch Set 1: (3 comments) https://gerrit.ovirt.org/#/c/61142/1/lib/vdsm/osutils.py File lib/vdsm/osutils.py: Line 37:

Change in vdsm[ovirt-4.0]: net tests: Functional tests infrastructure

2016-07-20 Thread automation
gerrit-hooks has posted comments on this change. Change subject: net tests: Functional tests infrastructure .. Patch Set 3: * #1195208::Update tracker: OK * Check Bug-Url::OK * Check Public Bug::#1195208::OK, public bug * Check

Change in vdsm[ovirt-4.0]: vdscli: Provide py3 compatible xmlrpclib (using six)

2016-07-20 Thread phoracek
Hello Piotr Kliczewski, Nir Soffer, Edward Haas, I'd like you to do a code review. Please visit https://gerrit.ovirt.org/61150 to review the following change. Change subject: vdscli: Provide py3 compatible xmlrpclib (using six) ..

Change in vdsm[master]: Live Merge: Restore watermark tracking

2016-07-20 Thread automation
gerrit-hooks has posted comments on this change. Change subject: Live Merge: Restore watermark tracking .. Patch Set 5: * #1168327::Update tracker: OK * Check Bug-Url::OK * Check Public Bug::#1168327::OK, public bug * Check Pro

Change in vdsm[master]: Live Merge: Restore watermark tracking

2016-07-20 Thread automation
gerrit-hooks has posted comments on this change. Change subject: Live Merge: Restore watermark tracking .. Patch Set 4: * #1168327::Update tracker: OK * Check Bug-Url::OK * Check Public Bug::#1168327::OK, public bug * Check Pro

Change in vdsm[master]: Live Merge: Restore watermark tracking

2016-07-20 Thread ahino
Ala Hino has posted comments on this change. Change subject: Live Merge: Restore watermark tracking .. Patch Set 3: (6 comments) https://gerrit.ovirt.org/#/c/60889/3/vdsm/virt/vm.py File vdsm/virt/vm.py: PS3, Line 928: else:

Change in vdsm[master]: clusterlock: Raise if lock is used improperly

2016-07-20 Thread automation
gerrit-hooks has posted comments on this change. Change subject: clusterlock: Raise if lock is used improperly .. Patch Set 3: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header

Change in vdsm[master]: sd: Support volume leases

2016-07-20 Thread automation
gerrit-hooks has posted comments on this change. Change subject: sd: Support volume leases .. Patch Set 4: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: '

Change in vdsm[master]: osutils: Start the osutils module

2016-07-20 Thread automation
gerrit-hooks has posted comments on this change. Change subject: osutils: Start the osutils module .. Patch Set 1: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bu

Change in vdsm[master]: sd: Move getVolumeLease to StorageDomainManifest

2016-07-20 Thread automation
gerrit-hooks has posted comments on this change. Change subject: sd: Move getVolumeLease to StorageDomainManifest .. Patch Set 4: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure hea

Change in vdsm[master]: clusterlock: Fix LocalLock.supports_volume_leases

2016-07-20 Thread automation
gerrit-hooks has posted comments on this change. Change subject: clusterlock: Fix LocalLock.supports_volume_leases .. Patch Set 3: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure he

Change in vdsm[master]: clusterlock: Support for multiple leases

2016-07-20 Thread automation
gerrit-hooks has posted comments on this change. Change subject: clusterlock: Support for multiple leases .. Patch Set 4: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matc

Change in vdsm[master]: osutils: Start the osutils module

2016-07-20 Thread nsoffer
Nir Soffer has posted comments on this change. Change subject: osutils: Start the osutils module .. Patch Set 1: Verified+1 Verified with the tests. -- To view, visit https://gerrit.ovirt.org/61142 To unsubscribe, visit https

Change in vdsm[master]: clusterlock: Fix double close on EINTR

2016-07-20 Thread automation
gerrit-hooks has posted comments on this change. Change subject: clusterlock: Fix double close on EINTR .. Patch Set 2: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matche

Change in vdsm[master]: cluserlock: Use errno instead of os.errno

2016-07-20 Thread automation
gerrit-hooks has posted comments on this change. Change subject: cluserlock: Use errno instead of os.errno .. Patch Set 2: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header mat

Change in vdsm[master]: sd: Unify getVolumeLease signature

2016-07-20 Thread automation
gerrit-hooks has posted comments on this change. Change subject: sd: Unify getVolumeLease signature .. Patch Set 4: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'B

Change in vdsm[master]: osutils: Start the osutils module

2016-07-20 Thread nsoffer
Nir Soffer has uploaded a new change for review. Change subject: osutils: Start the osutils module .. osutils: Start the osutils module We use to have code calling os.close() using utils.NoIntrCall. If os.close(fd) was interrupt

Change in vdsm[ovirt-4.0]: net: Setup ipv6autoconf with OVS switch

2016-07-20 Thread phoracek
Hello Dan Kenigsberg, Edward Haas, I'd like you to do a code review. Please visit https://gerrit.ovirt.org/61114 to review the following change. Change subject: net: Setup ipv6autoconf with OVS switch .. net: Setup ipv6au

Change in vdsm[master]: ovs: copy NIC hwaddr to NB

2016-07-20 Thread automation
gerrit-hooks has posted comments on this change. Change subject: ovs: copy NIC hwaddr to NB .. Patch Set 4: * #1195208::Update tracker: OK * Check Bug-Url::OK * Check Public Bug::#1195208::OK, public bug * Check Product::#11952

Change in vdsm[master]: ovs: copy NIC hwaddr to NB

2016-07-20 Thread automation
gerrit-hooks has posted comments on this change. Change subject: ovs: copy NIC hwaddr to NB .. Patch Set 5: * #1195208::Update tracker: OK * Check Bug-Url::OK * Check Public Bug::#1195208::OK, public bug * Check Product::#11952

Change in vdsm[master]: ovs: rollback acquired ifaces after failure

2016-07-20 Thread automation
gerrit-hooks has posted comments on this change. Change subject: ovs: rollback acquired ifaces after failure .. Patch Set 3: * #1195208::Update tracker: OK * Check Bug-Url::OK * Check Public Bug::#1195208::OK, public bug * Chec

Change in vdsm[ovirt-4.0]: net: call address.flush explicitly after dhclient.kill

2016-07-20 Thread automation
gerrit-hooks has posted comments on this change. Change subject: net: call address.flush explicitly after dhclient.kill .. Patch Set 2: * #1195208::Update tracker: OK * Check Bug-Url::OK * Check Public Bug::#1195208::OK, public

Change in vdsm[master]: ovs: acquire external ifaces

2016-07-20 Thread automation
gerrit-hooks has posted comments on this change. Change subject: ovs: acquire external ifaces .. Patch Set 25: * #1195208::Update tracker: OK * Check Bug-Url::OK * Check Public Bug::#1195208::OK, public bug * Check Product::#11

Change in vdsm[ovirt-4.0]: ovs hook: fix dhclient imports

2016-07-20 Thread automation
gerrit-hooks has posted comments on this change. Change subject: ovs hook: fix dhclient imports .. Patch Set 2: * #1195208::Update tracker: OK * Check Bug-Url::OK * Check Public Bug::#1195208::OK, public bug * Check Product::#1

Change in vdsm[ovirt-4.0]: net: add address.flush family argument

2016-07-20 Thread automation
gerrit-hooks has posted comments on this change. Change subject: net: add address.flush family argument .. Patch Set 2: * #1195208::Update tracker: OK * Check Bug-Url::OK * Check Public Bug::#1195208::OK, public bug * Check Pro

Change in vdsm[ovirt-4.0]: ovs: rollback transaction

2016-07-20 Thread automation
gerrit-hooks has posted comments on this change. Change subject: ovs: rollback transaction .. Patch Set 2: * #1195208::Update tracker: OK * Check Bug-Url::OK * Check Public Bug::#1195208::OK, public bug * Check Product::#119520

Change in vdsm[ovirt-4.0]: ovs: move bridges cleanup to a separate function

2016-07-20 Thread automation
gerrit-hooks has posted comments on this change. Change subject: ovs: move bridges cleanup to a separate function .. Patch Set 2: * #1195208::Update tracker: OK * Check Bug-Url::OK * Check Public Bug::#1195208::OK, public bug *

Change in vdsm[ovirt-4.0]: ovs: add network with dhcp configuration

2016-07-20 Thread automation
gerrit-hooks has posted comments on this change. Change subject: ovs: add network with dhcp configuration .. Patch Set 2: * #1195208::Update tracker: OK * Check Bug-Url::OK * Check Public Bug::#1195208::OK, public bug * Check P

Change in vdsm[ovirt-4.0]: net: move dhclient.py to ip package

2016-07-20 Thread automation
gerrit-hooks has posted comments on this change. Change subject: net: move dhclient.py to ip package .. Patch Set 2: * #1195208::Update tracker: OK * Check Bug-Url::OK * Check Public Bug::#1195208::OK, public bug * Check Produc

Change in vdsm[ovirt-4.0]: net: move dhclient_run/stop helpers to dhclient.py

2016-07-20 Thread automation
gerrit-hooks has posted comments on this change. Change subject: net: move dhclient_run/stop helpers to dhclient.py .. Patch Set 2: * #1195208::Update tracker: OK * Check Bug-Url::OK * Check Public Bug::#1195208::OK, public bug

Change in vdsm[ovirt-4.0]: net: disable unused IPv6 in ip.address.add()

2016-07-20 Thread automation
gerrit-hooks has posted comments on this change. Change subject: net: disable unused IPv6 in ip.address.add() .. Patch Set 2: * #1195208::Update tracker: OK * Check Bug-Url::OK * Check Public Bug::#1195208::OK, public bug * Che

Change in vdsm[ovirt-4.0]: ovs: add OVS network with IP configuration

2016-07-20 Thread automation
gerrit-hooks has posted comments on this change. Change subject: ovs: add OVS network with IP configuration .. Patch Set 2: * #1195208::Update tracker: OK * Check Bug-Url::OK * Check Public Bug::#1195208::OK, public bug * Check

Change in vdsm[ovirt-4.0]: ovs: turn created links UP

2016-07-20 Thread automation
gerrit-hooks has posted comments on this change. Change subject: ovs: turn created links UP .. Patch Set 2: * #1195208::Update tracker: OK * Check Bug-Url::OK * Check Public Bug::#1195208::OK, public bug * Check Product::#11952

Change in vdsm[ovirt-4.0]: net func test: test network based on a vlan

2016-07-20 Thread automation
gerrit-hooks has posted comments on this change. Change subject: net func test: test network based on a vlan .. Patch Set 2: * #1195208::Update tracker: OK * Check Bug-Url::OK * Check Public Bug::#1195208::OK, public bug * Chec

Change in vdsm[ovirt-4.0]: net func test: add basic bond tests

2016-07-20 Thread automation
gerrit-hooks has posted comments on this change. Change subject: net func test: add basic bond tests .. Patch Set 2: * #1195208::Update tracker: OK * Check Bug-Url::OK * Check Public Bug::#1195208::OK, public bug * Check Produc

Change in vdsm[ovirt-4.0]: net tests: common tests for 'ovs' and 'legacy'

2016-07-20 Thread automation
gerrit-hooks has posted comments on this change. Change subject: net tests: common tests for 'ovs' and 'legacy' .. Patch Set 2: * #1195208::Update tracker: OK * Check Bug-Url::OK * Check Public Bug::#1195208::OK, public bug * C

Change in vdsm[ovirt-4.0]: net func test: Support remove network check

2016-07-20 Thread automation
gerrit-hooks has posted comments on this change. Change subject: net func test: Support remove network check .. Patch Set 2: * #1195208::Update tracker: OK * Check Bug-Url::OK * Check Public Bug::#1195208::OK, public bug * Chec

Change in vdsm[ovirt-4.0]: net tests: Functional tests infrastructure

2016-07-20 Thread automation
gerrit-hooks has posted comments on this change. Change subject: net tests: Functional tests infrastructure .. Patch Set 2: * #1195208::Update tracker: OK * Check Bug-Url::OK * Check Public Bug::#1195208::OK, public bug * Check

Change in vdsm[ovirt-4.0]: virt net: Change graphics type from network to address

2016-07-20 Thread automation
gerrit-hooks has posted comments on this change. Change subject: virt net: Change graphics type from network to address .. Patch Set 2: * #1195208::Update tracker: OK * Check Bug-Url::OK * Check Public Bug::#1195208::OK, public

Change in vdsm[ovirt-4.0]: net virt: Support connecting VM/s to an ovs bridge

2016-07-20 Thread automation
gerrit-hooks has posted comments on this change. Change subject: net virt: Support connecting VM/s to an ovs bridge .. Patch Set 2: * #1195208::Update tracker: OK * Check Bug-Url::OK * Check Public Bug::#1195208::OK, public bug

Change in vdsm[ovirt-4.0]: net: move ip configuration to ip.address module

2016-07-20 Thread automation
gerrit-hooks has posted comments on this change. Change subject: net: move ip configuration to ip.address module .. Patch Set 2: * #1195208::Update tracker: OK * Check Bug-Url::OK * Check Public Bug::#1195208::OK, public bug *

Change in vdsm[master]: clusterlock: Fix double close on EINTR

2016-07-20 Thread nsoffer
Nir Soffer has posted comments on this change. Change subject: clusterlock: Fix double close on EINTR .. Patch Set 1: (2 comments) https://gerrit.ovirt.org/#/c/60539/1/lib/vdsm/storage/clusterlock.py File lib/vdsm/storage/clus

Change in vdsm[master]: storagetestlib: qemu chain verification

2016-07-20 Thread automation
gerrit-hooks has posted comments on this change. Change subject: storagetestlib: qemu chain verification .. Patch Set 5: * Update tracker: IGNORE, no Bug-Url found * Set MODIFIED::IGNORE, no Bug-Url found. -- To view, visit h

Change in vdsm[master]: Implement SDM.copy_data

2016-07-20 Thread automation
gerrit-hooks has posted comments on this change. Change subject: Implement SDM.copy_data .. Patch Set 14: * Update tracker: IGNORE, no Bug-Url found * Set MODIFIED::IGNORE, no Bug-Url found. -- To view, visit https://gerrit.o

Change in vdsm[master]: ovs: copy NIC hwaddr to NB

2016-07-20 Thread automation
gerrit-hooks has posted comments on this change. Change subject: ovs: copy NIC hwaddr to NB .. Patch Set 3: * #1195208::Update tracker: OK * Check Bug-Url::OK * Check Public Bug::#1195208::OK, public bug * Check Product::#11952

Change in vdsm[master]: ovs: acquire external ifaces

2016-07-20 Thread automation
gerrit-hooks has posted comments on this change. Change subject: ovs: acquire external ifaces .. Patch Set 24: * #1195208::Update tracker: OK * Check Bug-Url::OK * Check Public Bug::#1195208::OK, public bug * Check Product::#11

Change in vdsm[master]: sdm: Jobs may be run only when status=pending

2016-07-20 Thread nsoffer
Nir Soffer has posted comments on this change. Change subject: sdm: Jobs may be run only when status=pending .. Patch Set 1: (3 comments) https://gerrit.ovirt.org/#/c/61138/1/tests/storage_sdm_api_test.py File tests/storage_sd

Change in vdsm[master]: ovs: rollback acquired ifaces after failure

2016-07-20 Thread automation
gerrit-hooks has posted comments on this change. Change subject: ovs: rollback acquired ifaces after failure .. Patch Set 2: * #1195208::Update tracker: OK * Check Bug-Url::OK * Check Public Bug::#1195208::OK, public bug * Chec

Change in vdsm[master]: sd: Move getVolumeLease to StorageDomainManifest

2016-07-20 Thread alitke
Adam Litke has posted comments on this change. Change subject: sd: Move getVolumeLease to StorageDomainManifest .. Patch Set 3: Code-Review+2 -- To view, visit https://gerrit.ovirt.org/60282 To unsubscribe, visit https://gerri

Change in vdsm[master]: clusterlock: Fix double close on EINTR

2016-07-20 Thread alitke
Adam Litke has posted comments on this change. Change subject: clusterlock: Fix double close on EINTR .. Patch Set 1: (2 comments) https://gerrit.ovirt.org/#/c/60539/1/lib/vdsm/storage/clusterlock.py File lib/vdsm/storage/clus

Change in vdsm[master]: utils: add utlity to generate positive cpuset notation

2016-07-20 Thread fromani
Francesco Romani has posted comments on this change. Change subject: utils: add utlity to generate positive cpuset notation .. Patch Set 3: Code-Review-1 (1 comment) -1 for visibility. The code is clever, but maybe too packed

Change in vdsm[master]: Implement SDM.copy_data

2016-07-20 Thread nsoffer
Nir Soffer has submitted this change and it was merged. Change subject: Implement SDM.copy_data .. Implement SDM.copy_data Add tests and implementation of SDM.copy_data. This is a work in progress with TODO items noted in code

  1   2   3   4   5   >