Change in vdsm[ovirt-4.0]: virt: sampling: add is_empty() method to StatsSample

gerrit-hooks has posted comments on this change. Change subject: virt: sampling: add is_empty() method to StatsSample .. Patch Set 1: * #1357798::Update tracker: OK * Check Bug-Url::OK * Check Public Bug::#1357798::OK, public b

Change in vdsm[ovirt-4.0]: vm: periodic: fix stats age reporting

gerrit-hooks has posted comments on this change. Change subject: vm: periodic: fix stats age reporting .. Patch Set 1: * #1357798::Update tracker: OK * Check Bug-Url::OK * Check Public Bug::#1357798::OK, public bug * Check Prod

Change in vdsm[ovirt-4.0]: tests: sampling: add FakeClock helper

gerrit-hooks has posted comments on this change. Change subject: tests: sampling: add FakeClock helper .. Patch Set 1: * #1357798::Update tracker: OK * Check Bug-Url::OK * Check Public Bug::#1357798::OK, public bug * Check Prod

Change in vdsm[ovirt-4.0]: tests: sampling: add FakeClock helper

Francesco Romani has posted comments on this change. Change subject: tests: sampling: add FakeClock helper .. Patch Set 1: Verified+1 changes only in tests: if Jenkins is happy, so we are. -- To view, visit https://gerrit.ovi

Change in vdsm[ovirt-4.0]: virt: sampling: add is_empty() method to StatsSample

Hello Dan Kenigsberg, I'd like you to do a code review. Please visit https://gerrit.ovirt.org/61821 to review the following change. Change subject: virt: sampling: add is_empty() method to StatsSample .. virt: sampling: a

Change in vdsm[ovirt-4.0]: vm: periodic: fix stats age reporting

Hello Dan Kenigsberg, I'd like you to do a code review. Please visit https://gerrit.ovirt.org/61822 to review the following change. Change subject: vm: periodic: fix stats age reporting .. vm: periodic: fix stats age repo

Change in vdsm[ovirt-4.0]: tests: sampling: add FakeClock helper

Hello Dan Kenigsberg, Martin Polednik, I'd like you to do a code review. Please visit https://gerrit.ovirt.org/61820 to review the following change. Change subject: tests: sampling: add FakeClock helper .. tests: sampling

Change in vdsm[master]: Fix return value names for VM.ioTune calls

Martin Sivák has posted comments on this change. Change subject: Fix return value names for VM.ioTune calls .. Patch Set 7: Danken: we do not have a bug (nobody reported it) and old mom uses xmlrpc that is not affected by this

Change in vdsm[master]: vdscli test: Minor pythonic changes in _assertValidAddress

gerrit-hooks has posted comments on this change. Change subject: vdscli test: Minor pythonic changes in _assertValidAddress .. Patch Set 2: * Update tracker: IGNORE, no Bug-Url found * Set MODIFIED::IGNORE, no Bug-Url found. -

Change in vdsm[master]: vdscli test: Minor pythonic changes in _assertValidAddress

Dan Kenigsberg has submitted this change and it was merged. Change subject: vdscli test: Minor pythonic changes in _assertValidAddress .. vdscli test: Minor pythonic changes in _assertValidAddress Change-Id: I4b8bce3df493ab5221

Change in vdsm[master]: Fix return value names for VM.ioTune calls

gerrit-hooks has posted comments on this change. Change subject: Fix return value names for VM.ioTune calls .. Patch Set 7: * Update tracker: IGNORE, no Bug-Url found * Set MODIFIED::IGNORE, no Bug-Url found. -- To view, visi

Change in vdsm[master]: Fix return value names for VM.ioTune calls

Dan Kenigsberg has submitted this change and it was merged. Change subject: Fix return value names for VM.ioTune calls .. Fix return value names for VM.ioTune calls Change-Id: I4eaac318db3d76743b1ff83f47268d0fc1c2dad7 Signed-of

Change in vdsm[master]: Fix return value names for VM.ioTune calls

Dan Kenigsberg has posted comments on this change. Change subject: Fix return value names for VM.ioTune calls .. Patch Set 6: Code-Review+2 Don't you have a adjacent bug to this? doesn't it need backporting? -- To view, visit

Change in vdsm[master]: docs: add README about logging configuration

gerrit-hooks has posted comments on this change. Change subject: docs: add README about logging configuration .. Patch Set 9: * Update tracker: IGNORE, no Bug-Url found * Set MODIFIED::IGNORE, no Bug-Url found. -- To view, vi

Change in vdsm[master]: docs: add README about logging configuration

Dan Kenigsberg has posted comments on this change. Change subject: docs: add README about logging configuration .. Patch Set 8: Code-Review+2 It seems that Nir's comments have been addressed. -- To view, visit https://gerrit.

Change in vdsm[master]: docs: add README about logging configuration

Dan Kenigsberg has submitted this change and it was merged. Change subject: docs: add README about logging configuration .. docs: add README about logging configuration Most notably, document how to tune the logging settings of

Change in vdsm[master]: periodic: always re-schedule operations

Dan Kenigsberg has posted comments on this change. Change subject: periodic: always re-schedule operations .. Patch Set 4: Code-Review+2 -- To view, visit https://gerrit.ovirt.org/61685 To unsubscribe, visit https://gerrit.ovi

Change in vdsm[master]: periodic: always re-schedule operations

Dan Kenigsberg has submitted this change and it was merged. Change subject: periodic: always re-schedule operations .. periodic: always re-schedule operations when one periodic.Operation() try to dispatch itself to the executor

Change in vdsm[master]: periodic: always re-schedule operations

gerrit-hooks has posted comments on this change. Change subject: periodic: always re-schedule operations .. Patch Set 5: * #1361028::Update tracker: OK * Set MODIFIED::bug 1361028#1361028IGNORE, not all related patches

Change in vdsm[master]: vm: periodic: fix stats age reporting

Dan Kenigsberg has posted comments on this change. Change subject: vm: periodic: fix stats age reporting .. Patch Set 11: Code-Review+2 Seems like Milan's textual comments have been addressed -- To view, visit https://gerrit.

Change in vdsm[master]: vm: periodic: fix stats age reporting

gerrit-hooks has posted comments on this change. Change subject: vm: periodic: fix stats age reporting .. Patch Set 12: * #1357798::Update tracker: OK * Set MODIFIED::bug 1357798#1357798IGNORE, not all related patches a

Change in vdsm[master]: vm: periodic: fix stats age reporting

Dan Kenigsberg has submitted this change and it was merged. Change subject: vm: periodic: fix stats age reporting .. vm: periodic: fix stats age reporting We need to report the Vm responsiveness, because it is one important ind

Change in vdsm[master]: virt: sampling: add is_empty() method to StatsSample

gerrit-hooks has posted comments on this change. Change subject: virt: sampling: add is_empty() method to StatsSample .. Patch Set 7: * #1357798::Update tracker: OK * Set MODIFIED::bug 1357798#1357798IGNORE, not all rel

Change in vdsm[master]: virt: sampling: add is_empty() method to StatsSample

Dan Kenigsberg has submitted this change and it was merged. Change subject: virt: sampling: add is_empty() method to StatsSample .. virt: sampling: add is_empty() method to StatsSample One upcoming patch wants to fill the 'stat

Change in vdsm[master]: utils: atomic file write

Dan Kenigsberg has posted comments on this change. Change subject: utils: atomic file write .. Patch Set 9: (3 comments) https://gerrit.ovirt.org/#/c/61482/9/lib/vdsm/utils.py File lib/vdsm/utils.py: PS9, Line 936: file this

Change in vdsm[master]: Adding get_batch to StatsCache - returns dict with all vms stat

Francesco Romani has posted comments on this change. Change subject: Adding get_batch to StatsCache - returns dict with all vms stat .. Patch Set 2: Code-Review+2 thanks for the updates! -- To view, visit https://gerrit.ovirt

Change in vdsm[master]: Fix return value names for VM.ioTune calls

Martin Sivák has posted comments on this change. Change subject: Fix return value names for VM.ioTune calls .. Patch Set 6: Verified+1 -- To view, visit https://gerrit.ovirt.org/60513 To unsubscribe, visit https://gerrit.ovirt

Change in vdsm[master]: v2v: Log detailed output of virt-v2v

gerrit-hooks has posted comments on this change. Change subject: v2v: Log detailed output of virt-v2v .. Patch Set 11: * #1350465::Update tracker: OK * Check Bug-Url::OK * Check Public Bug::#1350465::OK, public bug * Check Prod

Change in vdsm[master]: utils: atomic file write

gerrit-hooks has posted comments on this change. Change subject: utils: atomic file write .. Patch Set 10: * #1195208::Update tracker: OK * Check Bug-Url::OK * Check Public Bug::#1195208::OK, public bug * Check Product::#119520

Change in vdsm[master]: v2v: Log detailed output of virt-v2v

Francesco Romani has posted comments on this change. Change subject: v2v: Log detailed output of virt-v2v .. Patch Set 10: (2 comments) initial review. Good improvements! https://gerrit.ovirt.org/#/c/59834/10/lib/vdsm/v2v.py

Change in vdsm[master]: net: introduce acquire module

gerrit-hooks has posted comments on this change. Change subject: net: introduce acquire module .. Patch Set 18: * #1195208::Update tracker: OK * Check Bug-Url::OK * Check Public Bug::#1195208::OK, public bug * Check Product::#1

Change in vdsm[master]: Adding get_batch to StatsCache - returns dict with all vms stat

gerrit-hooks has posted comments on this change. Change subject: Adding get_batch to StatsCache - returns dict with all vms stat .. Patch Set 2: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found

Change in vdsm[master]: jsonvdscli: change hostname default

Piotr Kliczewski has posted comments on this change. Change subject: jsonvdscli: change hostname default .. Patch Set 5: Verified+1 Verified by running vdsClient with enabled and disabled ipv6. -- To view, visit https://gerri

Change in vdsm[master]: utils: atomic file write

Yaniv Bronhaim has posted comments on this change. Change subject: utils: atomic file write .. Patch Set 9: Code-Review-1 (3 comments) https://gerrit.ovirt.org/#/c/61482/9/lib/vdsm/utils.py File lib/vdsm/utils.py: Line 932:

Change in vdsm[master]: stomp: use socket pending

Piotr Kliczewski has posted comments on this change. Change subject: stomp: use socket pending .. Patch Set 1: Verified+1 Verified by updating existing vdsm and seeing that there are no issues with communication. -- To view,

Change in vdsm[master]: stomp: use socket pending

gerrit-hooks has posted comments on this change. Change subject: stomp: use socket pending .. Patch Set 1: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: '

Change in vdsm[master]: stomp: use socket pending

Piotr Kliczewski has uploaded a new change for review. Change subject: stomp: use socket pending .. stomp: use socket pending Dispatcher pending method is deprecated and we want to use socket pending method instead. Change-Id:

Change in vdsm[master]: lib: set system name for threads

gerrit-hooks has posted comments on this change. Change subject: lib: set system name for threads .. Patch Set 3: * #1141422::Update tracker: OK * Check Bug-Url::OK * Check Public Bug::#1141422::OK, public bug * Check Product::

Change in vdsm[master]: network: switch to concurrent.thread()

gerrit-hooks has posted comments on this change. Change subject: network: switch to concurrent.thread() .. Patch Set 2: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matche

Change in vdsm[master]: virt: vm: switch to concurrent.thread()

gerrit-hooks has posted comments on this change. Change subject: virt: vm: switch to concurrent.thread() .. Patch Set 3: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header match

Change in vdsm[master]: jsonrpc: switch to concurrent.thread()

gerrit-hooks has posted comments on this change. Change subject: jsonrpc: switch to concurrent.thread() .. Patch Set 2: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matche

Change in vdsm[master]: virt: vmchannels: switch to concurrent.thread()

gerrit-hooks has posted comments on this change. Change subject: virt: vmchannels: switch to concurrent.thread() .. Patch Set 2: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure head

Change in vdsm[master]: yajsonrpc: switch to concurrent.thread()

gerrit-hooks has posted comments on this change. Change subject: yajsonrpc: switch to concurrent.thread() .. Patch Set 2: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matc

Change in vdsm[master]: virt: migration: switch to concurrent.thread()

gerrit-hooks has posted comments on this change. Change subject: virt: migration: switch to concurrent.thread() .. Patch Set 3: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure heade

Change in vdsm[master]: utils: rename random_iface_name to random_name

gerrit-hooks has posted comments on this change. Change subject: utils: rename random_iface_name to random_name .. Patch Set 1: * #1195208::Update tracker: OK -- To view, visit https://gerrit.ovirt.org/61648 To unsubscribe, v

Change in vdsm[master]: utils: rename random_iface_name to random_name

Petr Horáček has abandoned this change. Change subject: utils: rename random_iface_name to random_name .. Abandoned we are using tempfile for atomic_write instead -- To view, visit https://gerrit.ovirt.org/61648 To unsubscrib

Change in vdsm[master]: net: introduce acquire module

gerrit-hooks has posted comments on this change. Change subject: net: introduce acquire module .. Patch Set 17: * #1195208::Update tracker: OK * Check Bug-Url::OK * Check Public Bug::#1195208::OK, public bug * Check Product::#1

Change in vdsm[master]: ifcfg: simplify _update_from_ifcfg

Dan Kenigsberg has posted comments on this change. Change subject: ifcfg: simplify _update_from_ifcfg .. Patch Set 3: Code-Review-1 (1 comment) https://gerrit.ovirt.org/#/c/61472/3/lib/vdsm/network/configurators/ifcfg.py File

Change in vdsm[master]: network: rename reported 'dnss' to 'nameservers' for clarity

Dan Kenigsberg has posted comments on this change. Change subject: network: rename reported 'dnss' to 'nameservers' for clarity .. Patch Set 4: Code-Review+2 -- To view, visit https://gerrit.ovirt.org/61712 To unsubscribe, vis

Change in vdsm[master]: utils: atomic file write

gerrit-hooks has posted comments on this change. Change subject: utils: atomic file write .. Patch Set 9: * #1195208::Update tracker: OK * Check Bug-Url::OK * Check Public Bug::#1195208::OK, public bug * Check Product::#1195208

Change in vdsm[master]: net: Introduce nameservers (dns) network api

gerrit-hooks has posted comments on this change. Change subject: net: Introduce nameservers (dns) network api .. Patch Set 3: * Update tracker: IGNORE, no Bug-Url found * Set MODIFIED::IGNORE, no Bug-Url found. -- To view, vi

Change in vdsm[master]: net: Introduce nameservers (dns) network api

Dan Kenigsberg has posted comments on this change. Change subject: net: Introduce nameservers (dns) network api .. Patch Set 2: Code-Review+2 -- To view, visit https://gerrit.ovirt.org/61739 To unsubscribe, visit https://gerri

Change in vdsm[master]: net: Introduce nameservers (dns) network api

Dan Kenigsberg has submitted this change and it was merged. Change subject: net: Introduce nameservers (dns) network api .. net: Introduce nameservers (dns) network api oVirt is required to preserve and manage the nameservers f

Change in vdsm[master]: net: Introduce nameservers (dns) network api

Ondřej Svoboda has posted comments on this change. Change subject: net: Introduce nameservers (dns) network api .. Patch Set 2: Code-Review+1 -- To view, visit https://gerrit.ovirt.org/61739 To unsubscribe, visit https://gerri

Change in vdsm[ovirt-4.0]: jsonrpc: expose Volume.setDescription as setVolumeDescription

Rafael Martins has posted comments on this change. Change subject: jsonrpc: expose Volume.setDescription as setVolumeDescription .. Patch Set 2: Verified+1 -- To view, visit https://gerrit.ovirt.org/61793 To unsubscribe, visit

Change in vdsm[ovirt-4.0]: jsonrpc: expose Volume.setDescription as setVolumeDescription

Piotr Kliczewski has posted comments on this change. Change subject: jsonrpc: expose Volume.setDescription as setVolumeDescription .. Patch Set 2: Code-Review+1 -- To view, visit https://gerrit.ovirt.org/61793 To unsubscribe,

Change in vdsm[ovirt-4.0]: virt: Limit the number of workers in executor

Martin Polednik has posted comments on this change. Change subject: virt: Limit the number of workers in executor .. Patch Set 2: Code-Review+1 I slightly hate the "protected" methods that explicitly state they're called from

Change in vdsm[ovirt-4.0]: virt: Fix of Executor._active_workers crash on modification

Martin Polednik has posted comments on this change. Change subject: virt: Fix of Executor._active_workers crash on modification .. Patch Set 2: Code-Review+1 -- To view, visit https://gerrit.ovirt.org/61770 To unsubscribe, vis

Change in vdsm[ovirt-4.0]: virt net: Interface default driver name set to 'vhost'

Francesco Romani has posted comments on this change. Change subject: virt net: Interface default driver name set to 'vhost' .. Patch Set 1: Code-Review+1 please verify -- To view, visit https://gerrit.ovirt.org/61772 To unsub

Change in vdsm[ovirt-4.0]: virt net: Interface default driver name set to 'vhost'

Francesco Romani has posted comments on this change. Change subject: virt net: Interface default driver name set to 'vhost' .. Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.ovirt.org/61772 To unsubscribe, visit h

Change in vdsm[master]: jsonvdscli: change hostname default

gerrit-hooks has posted comments on this change. Change subject: jsonvdscli: change hostname default .. Patch Set 5: * #1358530::Update tracker: OK * Check Bug-Url::OK * Check Public Bug::#1358530::OK, public bug * Check Produc

Change in vdsm[master]: Adding network functional tests to check-merged job

gerrit-hooks has posted comments on this change. Change subject: Adding network functional tests to check-merged job .. Patch Set 9: * Update tracker: IGNORE, no Bug-Url found -- To view, visit https://gerrit.ovirt.org/53902

Change in vdsm[master]: Adding network functional tests to check-merged job

Yaniv Bronhaim has abandoned this change. Change subject: Adding network functional tests to check-merged job .. Abandoned -- To view, visit https://gerrit.ovirt.org/53902 To unsubscribe, visit https://gerrit.ovirt.org/setting

Change in vdsm[master]: jsonvdscli: change hostname default

gerrit-hooks has posted comments on this change. Change subject: jsonvdscli: change hostname default .. Patch Set 4: * #1358530::Update tracker: OK * Check Bug-Url::OK * Check Public Bug::#1358530::OK, public bug * Check Produc

Change in vdsm[master]: jsonvdscli: change hostname default

Simone Tiraboschi has posted comments on this change. Change subject: jsonvdscli: change hostname default .. Patch Set 3: Code-Review+1 -- To view, visit https://gerrit.ovirt.org/61782 To unsubscribe, visit https://gerrit.ovir

Change in vdsm[master]: jsonvdscli: change hostname default

gerrit-hooks has posted comments on this change. Change subject: jsonvdscli: change hostname default .. Patch Set 3: * #1358530::Update tracker: OK * Check Bug-Url::OK * Check Public Bug::#1358530::OK, public bug * Check Produc

Change in vdsm[master]: network: rename reported 'dnss' to 'nameservers' for clarity

Edward Haas has posted comments on this change. Change subject: network: rename reported 'dnss' to 'nameservers' for clarity .. Patch Set 4: Code-Review+1 -- To view, visit https://gerrit.ovirt.org/61712 To unsubscribe, visit

Change in vdsm[master]: configs: move sudoers to static

Yaniv Bronhaim has posted comments on this change. Change subject: configs: move sudoers to static .. Patch Set 5: (1 comment) https://gerrit.ovirt.org/#/c/61603/5/static/Makefile.am File static/Makefile.am: PS5, Line 60: chm

Change in vdsm[master]: configs: move sudoers to static

Francesco Romani has posted comments on this change. Change subject: configs: move sudoers to static .. Patch Set 5: (2 comments) https://gerrit.ovirt.org/#/c/61603/5/static/Makefile.am File static/Makefile.am: PS5, Line 58:

Change in vdsm[master]: configs: move sudoers to static

Martin Polednik has posted comments on this change. Change subject: configs: move sudoers to static .. Patch Set 5: (2 comments) https://gerrit.ovirt.org/#/c/61603/5/static/Makefile.am File static/Makefile.am: PS5, Line 58: m

Change in vdsm[master]: netinfo: report DNS search domains from /etc/resolv.conf

gerrit-hooks has posted comments on this change. Change subject: netinfo: report DNS search domains from /etc/resolv.conf .. Patch Set 2: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make

Change in vdsm[master]: network: rename reported 'dnss' to 'nameservers' for clarity

gerrit-hooks has posted comments on this change. Change subject: network: rename reported 'dnss' to 'nameservers' for clarity .. Patch Set 4: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, m

Change in vdsm[master]: network: rename reported 'dnss' to 'nameservers' for clarity

Ondřej Svoboda has posted comments on this change. Change subject: network: rename reported 'dnss' to 'nameservers' for clarity .. Patch Set 3: (1 comment) https://gerrit.ovirt.org/#/c/61712/3/lib/vdsm/network/netinfo/dns.py F

Change in vdsm[master]: network: introduce DNS search domains to the API

gerrit-hooks has posted comments on this change. Change subject: network: introduce DNS search domains to the API .. Patch Set 2: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure hea

Change in vdsm[master]: network: preserve the current DNS search domains as well

gerrit-hooks has posted comments on this change. Change subject: network: preserve the current DNS search domains as well .. Patch Set 6: * #1351095::Update tracker: OK * Check Bug-Url::OK * Check Public Bug::#1351095::OK, publ

Change in vdsm[master]: jsonvdscli: change hostname default

Piotr Kliczewski has posted comments on this change. Change subject: jsonvdscli: change hostname default .. Patch Set 2: (1 comment) https://gerrit.ovirt.org/#/c/61782/2/lib/vdsm/jsonrpcvdscli.py File lib/vdsm/jsonrpcvdscli.py

<    1   2