gerrit-hooks has posted comments on this change.
Change subject: net: lookup dhclient file
..
Patch Set 7:
* #1364081::Update tracker: OK
* Check Bug-Url::OK
* Check Public Bug::#1364081::OK, public bug
* Check Product::#136408
gerrit-hooks has posted comments on this change.
Change subject: Pass scheduler to jobs.start
..
Patch Set 1:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url
gerrit-hooks has posted comments on this change.
Change subject: Add start/stop interface to jobs module
..
Patch Set 1:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header match
gerrit-hooks has posted comments on this change.
Change subject: jobs: Move _run from sdm.base.Job to jobs.Job
..
Patch Set 1:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header
gerrit-hooks has posted comments on this change.
Change subject: jobs: Autodelete
..
Patch Set 1:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: '
and is
Adam Litke has uploaded a new change for review.
Change subject: Pass scheduler to jobs.start
..
Pass scheduler to jobs.start
In a subsequent patch the jobs module will want to defer calls to delete by
using the program's schedu
Hello Nir Soffer,
I'd like you to do a code review. Please visit
https://gerrit.ovirt.org/62002
to review the following change.
Change subject: jobs: Autodelete
..
jobs: Autodelete
For storage jobs we like to delete fini
Adam Litke has uploaded a new change for review.
Change subject: jobs: Move _run from sdm.base.Job to jobs.Job
..
jobs: Move _run from sdm.base.Job to jobs.Job
The _run implementation in sdm.base.Job is generally useful. It per
Adam Litke has uploaded a new change for review.
Change subject: Add start/stop interface to jobs module
..
Add start/stop interface to jobs module
Add interfaces similar to virt.periodic and other subsystems for initializing a
gerrit-hooks has posted comments on this change.
Change subject: net: lookup dhclient file
..
Patch Set 6:
* #1364081::Update tracker: OK
* Check Bug-Url::OK
* Check Public Bug::#1364081::OK, public bug
* Check Product::#136408
Tomas Golembiovsky has posted comments on this change.
Change subject: compat: py3: capture output of CPopen.communicate
..
Patch Set 2:
(2 comments)
https://gerrit.ovirt.org/#/c/61393/2//COMMIT_MSG
Commit Message:
PS2, Line
gerrit-hooks has posted comments on this change.
Change subject: storage: domainMonitor.getAllHostIds() API
..
Patch Set 1:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header ma
gerrit-hooks has posted comments on this change.
Change subject: storage: export volume lease state in getVolumeInfo
..
Patch Set 1:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure
gerrit-hooks has posted comments on this change.
Change subject: tests: Add more stub methods for sanlock
..
Patch Set 1:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matc
gerrit-hooks has posted comments on this change.
Change subject: sd: Move getVolumeLease to StorageDomainManifest
..
Patch Set 8:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure hea
gerrit-hooks has posted comments on this change.
Change subject: sd: Support volume leases
..
Patch Set 8:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: '
gerrit-hooks has posted comments on this change.
Change subject: storage: Sortable ResourceManager lock namespaces
..
Patch Set 4:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure he
gerrit-hooks has posted comments on this change.
Change subject: sd: Unify getVolumeLease signature
..
Patch Set 8:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'B
gerrit-hooks has posted comments on this change.
Change subject: sdm: Use guarded.context in copy_data
..
Patch Set 3:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches
gerrit-hooks has posted comments on this change.
Change subject: clusterlock: Raise if lock is used improperly
..
Patch Set 7:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header
gerrit-hooks has posted comments on this change.
Change subject: osutils: Move NoIntrCall to osutils.uninterruptible
..
Patch Set 4:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure
gerrit-hooks has posted comments on this change.
Change subject: clusterlock: Support for multiple leases
..
Patch Set 8:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matc
gerrit-hooks has posted comments on this change.
Change subject: cluserlock: Use errno instead of os.errno
..
Patch Set 4:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header mat
gerrit-hooks has posted comments on this change.
Change subject: storage: Introduce guarded utilities
..
Patch Set 5:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches
gerrit-hooks has posted comments on this change.
Change subject: clusterlock: Fix LocalLock.supports_volume_leases
..
Patch Set 7:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure he
gerrit-hooks has posted comments on this change.
Change subject: osutils: Start the osutils module
..
Patch Set 5:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bu
Adam Litke has uploaded a new change for review.
Change subject: tests: Add more stub methods for sanlock
..
tests: Add more stub methods for sanlock
When testing Volume Leases we make additional calls into sanlock. Add stubs
f
gerrit-hooks has posted comments on this change.
Change subject: clusterlock: Fix double close on EINTR
..
Patch Set 6:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matche
Adam Litke has uploaded a new change for review.
Change subject: storage: domainMonitor.getAllHostIds() API
..
storage: domainMonitor.getAllHostIds() API
SDM verbs require host_ids when working with Storage Domains. The current
gerrit-hooks has posted comments on this change.
Change subject: testlib: Use osutils.close_fd to avoid fd leaks
..
Patch Set 2:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure head
Adam Litke has uploaded a new change for review.
Change subject: storage: export volume lease state in getVolumeInfo
..
storage: export volume lease state in getVolumeInfo
In order to support an entity-based polling methodology
Edward Haas has posted comments on this change.
Change subject: net: early IP+link setup
..
Patch Set 10: Code-Review-1
From CI logs:
./lib/vdsm/tool/restore_nets_init.py:53: undefined name
'_convert_to_blocking_dhcp'
--
To
gerrit-hooks has posted comments on this change.
Change subject: WIP vm: add utility to get sublogger
..
Patch Set 1:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches
gerrit-hooks has posted comments on this change.
Change subject: WIP: virt: migration: use the new VM sublogger
..
Patch Set 1:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure heade
gerrit-hooks has posted comments on this change.
Change subject: jsonrpc: switch to concurrent.thread()
..
Patch Set 4:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matche
gerrit-hooks has posted comments on this change.
Change subject: network: switch to concurrent.thread()
..
Patch Set 4:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matche
gerrit-hooks has posted comments on this change.
Change subject: yajsonrpc: switch to concurrent.thread()
..
Patch Set 4:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matc
gerrit-hooks has posted comments on this change.
Change subject: virt: migration: switch to concurrent.thread()
..
Patch Set 5:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure heade
gerrit-hooks has posted comments on this change.
Change subject: virt: vm: switch to concurrent.thread()
..
Patch Set 5:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header match
gerrit-hooks has posted comments on this change.
Change subject: jsonrpc: shorten executor thread system names
..
Patch Set 2:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header
Adam Litke has restored this change.
Change subject: storage: export volume lease state in getVolumeInfo
..
Restored
--
To view, visit https://gerrit.ovirt.org/38623
To unsubscribe, visit https://gerrit.ovirt.org/settings
Ger
Sandro Bonazzola has posted comments on this change.
Change subject: automation: build also vhostmd hook
..
Patch Set 1: Verified+1
--
To view, visit https://gerrit.ovirt.org/61984
To unsubscribe, visit https://gerrit.ovirt.or
Sandro Bonazzola has uploaded a new change for review.
Change subject: automation: build also vhostmd hook
..
automation: build also vhostmd hook
Change-Id: I249131cf4d3a3623a32708b961a5273fba4a69eb
Signed-off-by: Sandro Bonazzo
gerrit-hooks has posted comments on this change.
Change subject: automation: build also vhostmd hook
..
Patch Set 1:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches '
gerrit-hooks has posted comments on this change.
Change subject: jsonrpc: shorten executor thread' system names
..
Patch Set 1:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure head
Francesco Romani has uploaded a new change for review.
Change subject: jsonrpc: shorten executor thread' system names
..
jsonrpc: shorten executor thread' system names
We shorten the basename of the jsonrpc executor,
because t
Vinzenz Feenstra has posted comments on this change.
Change subject: virt: vmchannels: switch to concurrent.thread()
..
Patch Set 3: Code-Review-1
(1 comment)
https://gerrit.ovirt.org/#/c/61460/3/lib/vdsm/virt/vmchannels.py
Fi
Vinzenz Feenstra has posted comments on this change.
Change subject: virt: vmchannels: switch to concurrent.thread()
..
Patch Set 3: Code-Review+1
--
To view, visit https://gerrit.ovirt.org/61460
To unsubscribe, visit https://
gerrit-hooks has posted comments on this change.
Change subject: network: switch to concurrent.thread()
..
Patch Set 3:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matche
gerrit-hooks has posted comments on this change.
Change subject: virt: vmchannels: switch to concurrent.thread()
..
Patch Set 3:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure head
gerrit-hooks has posted comments on this change.
Change subject: virt: migration: switch to concurrent.thread()
..
Patch Set 4:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure heade
gerrit-hooks has posted comments on this change.
Change subject: yajsonrpc: switch to concurrent.thread()
..
Patch Set 3:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matc
gerrit-hooks has posted comments on this change.
Change subject: jsonrpc: switch to concurrent.thread()
..
Patch Set 3:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matche
gerrit-hooks has posted comments on this change.
Change subject: virt: vm: switch to concurrent.thread()
..
Patch Set 4:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header match
Francesco Romani has posted comments on this change.
Change subject: virt: vmchannels: switch to concurrent.thread()
..
Patch Set 3: Verified+1
verified that the threads still runs as expected, and its name shows up as
expecte
gerrit-hooks has posted comments on this change.
Change subject: lib: set system name for threads
..
Patch Set 4:
* #1141422::Update tracker: OK
* Check Bug-Url::OK
* Check Public Bug::#1141422::OK, public bug
* Check Product::
Francesco Romani has posted comments on this change.
Change subject: lib: set system name for threads
..
Patch Set 3:
discard last comment, it applies to 61460
--
To view, visit https://gerrit.ovirt.org/55074
To unsubscribe,
Francesco Romani has posted comments on this change.
Change subject: lib: set system name for threads
..
Patch Set 3:
verified that the thread still works and has the expected name
--
To view, visit https://gerrit.ovirt.org/5
Francesco Romani has posted comments on this change.
Change subject: lib: set system name for threads
..
Patch Set 3: Verified+1
verified that the name still show up.
--
To view, visit https://gerrit.ovirt.org/55074
To unsubs
Francesco Romani has posted comments on this change.
Change subject: virt: vmchannels: switch to concurrent.thread()
..
Patch Set 2: Code-Review-1
(1 comment)
https://gerrit.ovirt.org/#/c/61460/2/lib/vdsm/virt/vmchannels.py
Fi
Francesco Romani has posted comments on this change.
Change subject: virt: migration: switch to concurrent.thread()
..
Patch Set 3: Code-Review-1
(3 comments)
https://gerrit.ovirt.org/#/c/61463/3/vdsm/virt/migration.py
File vd
Francesco Romani has posted comments on this change.
Change subject: automation: use 4.0 repos
..
Patch Set 1: Code-Review+1
--
To view, visit https://gerrit.ovirt.org/61969
To unsubscribe, visit https://gerrit.ovirt.org/setti
Francesco Romani has posted comments on this change.
Change subject: automation: use 3.6 repos
..
Patch Set 1: Code-Review+1
--
To view, visit https://gerrit.ovirt.org/61970
To unsubscribe, visit https://gerrit.ovirt.org/setti
Tomas Golembiovsky has posted comments on this change.
Change subject: v2v: Log detailed output of virt-v2v
..
Patch Set 10:
(2 comments)
https://gerrit.ovirt.org/#/c/59834/10/lib/vdsm/v2v.py
File lib/vdsm/v2v.py:
PS10, Line
gerrit-hooks has posted comments on this change.
Change subject: v2v: Log detailed output of virt-v2v
..
Patch Set 12:
* #1350465::Update tracker: OK
* Check Bug-Url::OK
* Check Public Bug::#1350465::OK, public bug
* Check Prod
Sandro Bonazzola has posted comments on this change.
Change subject: automation: use 3.6 repos
..
Patch Set 1: Verified+1
--
To view, visit https://gerrit.ovirt.org/61970
To unsubscribe, visit https://gerrit.ovirt.org/settings
gerrit-hooks has posted comments on this change.
Change subject: automation: use 3.6 repos
..
Patch Set 1: Verified-1
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::ERROR, At least one bug-url is required for the
Sandro Bonazzola has uploaded a new change for review.
Change subject: automation: use 3.6 repos
..
automation: use 3.6 repos
Change-Id: I739787b39b7ec24d8fc432f007e33cacf0c60ae6
Signed-off-by: Sandro Bonazzola
---
M automation
Sandro Bonazzola has posted comments on this change.
Change subject: automation: use 4.0 repos
..
Patch Set 1: Verified+1
--
To view, visit https://gerrit.ovirt.org/61969
To unsubscribe, visit https://gerrit.ovirt.org/settings
gerrit-hooks has posted comments on this change.
Change subject: automation: use 4.0 repos
..
Patch Set 1: Verified-1
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::ERROR, At least one bug-url is required for the
Sandro Bonazzola has uploaded a new change for review.
Change subject: automation: use 4.0 repos
..
automation: use 4.0 repos
Change-Id: I5d6f39009d5fa24de00c56eeb8297d9691af3b2a
Signed-off-by: Sandro Bonazzola
---
M automation
71 matches
Mail list logo