Change in vdsm[master]: spec: bridge-utils are required for tests

2016-09-09 Thread automation
gerrit-hooks has posted comments on this change. Change subject: spec: bridge-utils are required for tests .. Patch Set 2: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header mat

Change in vdsm[master]: resourceManager: Inline LockType.validate

2016-09-09 Thread automation
gerrit-hooks has posted comments on this change. Change subject: resourceManager: Inline LockType.validate .. Patch Set 1: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header mat

Change in vdsm[master]: resourceManager: Flatten LockType constants

2016-09-09 Thread automation
gerrit-hooks has posted comments on this change. Change subject: resourceManager: Flatten LockType constants .. Patch Set 1: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header m

Change in vdsm[master]: resourceManager: Remove unused method

2016-09-09 Thread automation
gerrit-hooks has posted comments on this change. Change subject: resourceManager: Remove unused method .. Patch Set 1: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches

Change in vdsm[master]: resourceManager: Flatten LockType constants

2016-09-09 Thread nsoffer
Nir Soffer has uploaded a new change for review. Change subject: resourceManager: Flatten LockType constants .. resourceManager: Flatten LockType constants Replace the LockType class with flat constants, streamlining client code

Change in vdsm[master]: resourceManager: Remove unused method

2016-09-09 Thread nsoffer
Nir Soffer has uploaded a new change for review. Change subject: resourceManager: Remove unused method .. resourceManager: Remove unused method LockType.fromState is not used. Remove it so we can replace the LockType class with

Change in vdsm[master]: resourceManager: Inline LockType.validate

2016-09-09 Thread nsoffer
Nir Soffer has uploaded a new change for review. Change subject: resourceManager: Inline LockType.validate .. resourceManager: Inline LockType.validate Inline the function in the single call site, allowing replacing LockType wit

Change in vdsm[master]: net test: Clean lease files on setup-cleanup

2016-09-09 Thread phoracek
Petr Horáček has posted comments on this change. Change subject: net test: Clean lease files on setup-cleanup .. Patch Set 9: (1 comment) https://gerrit.ovirt.org/#/c/63089/9/tests/network/netfunctestlib.py File tests/network/

Change in vdsm[master]: net test: Clean lease files on setup-cleanup

2016-09-09 Thread edwardh
Edward Haas has posted comments on this change. Change subject: net test: Clean lease files on setup-cleanup .. Patch Set 10: Verified+1 -- To view, visit https://gerrit.ovirt.org/63089 To unsubscribe, visit https://gerrit.ovi

Change in vdsm[master]: net: Bond - preserve original slaves link state.

2016-09-09 Thread automation
gerrit-hooks has posted comments on this change. Change subject: net: Bond - preserve original slaves link state. .. Patch Set 10: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure he

Change in vdsm[master]: net: Bond - adding a transaction context.

2016-09-09 Thread automation
gerrit-hooks has posted comments on this change. Change subject: net: Bond - adding a transaction context. .. Patch Set 10: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header ma

Change in vdsm[master]: net test: Clean lease files on setup-cleanup

2016-09-09 Thread automation
gerrit-hooks has posted comments on this change. Change subject: net test: Clean lease files on setup-cleanup .. Patch Set 10: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header

Change in vdsm[master]: net: Bond - add refresh method to update bond config

2016-09-09 Thread automation
gerrit-hooks has posted comments on this change. Change subject: net: Bond - add refresh method to update bond config .. Patch Set 10: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sur

Change in vdsm[master]: net: Bond - Add logging to the bond driver.

2016-09-09 Thread automation
gerrit-hooks has posted comments on this change. Change subject: net: Bond - Add logging to the bond driver. .. Patch Set 10: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header

Change in vdsm[master]: net: Expose owned_device method through the configurator

2016-09-09 Thread automation
gerrit-hooks has posted comments on this change. Change subject: net: Expose owned_device method through the configurator .. Patch Set 9: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make

Change in vdsm[master]: net: Link setup module - includes bond setup logic.

2016-09-09 Thread automation
gerrit-hooks has posted comments on this change. Change subject: net: Link setup module - includes bond setup logic. .. Patch Set 20: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure

Change in vdsm[master]: net: Bond - Expose the (kernel) bond list.

2016-09-09 Thread automation
gerrit-hooks has posted comments on this change. Change subject: net: Bond - Expose the (kernel) bond list. .. Patch Set 11: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header m

Change in vdsm[master]: net: Use Linux bonds with OVS networks

2016-09-09 Thread automation
gerrit-hooks has posted comments on this change. Change subject: net: Use Linux bonds with OVS networks .. Patch Set 14: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header match

Change in vdsm[master]: virt net: Disable special OVS handling for exteranal network

2016-09-09 Thread edwardh
Edward Haas has posted comments on this change. Change subject: virt net: Disable special OVS handling for exteranal network .. Patch Set 1: (1 comment) https://gerrit.ovirt.org/#/c/63621/1/vdsm/virt/vm_migrate_hook.py File vd

Change in vdsm[master]: StorageDomain.getInfo - report lvm metadata device for block sd

2016-09-09 Thread alitke
Adam Litke has posted comments on this change. Change subject: StorageDomain.getInfo - report lvm metadata device for block sd .. Patch Set 4: (1 comment) Update to the commit message is needed. https://gerrit.ovirt.org/#/c/6

Change in vdsm[master]: sdm: Use guarded.context in copy_data

2016-09-09 Thread automation
gerrit-hooks has posted comments on this change. Change subject: sdm: Use guarded.context in copy_data .. Patch Set 17: * Update tracker: IGNORE, no Bug-Url found * Set MODIFIED::IGNORE, no Bug-Url found. -- To view, visit ht

Change in vdsm[master]: sdm: Use guarded.context in copy_data

2016-09-09 Thread nsoffer
Nir Soffer has submitted this change and it was merged. Change subject: sdm: Use guarded.context in copy_data .. sdm: Use guarded.context in copy_data Take the appropriate ResourceManager locks and a Volume Lease on the destina

Change in vdsm[master]: Pass scheduler to jobs.start

2016-09-09 Thread automation
gerrit-hooks has posted comments on this change. Change subject: Pass scheduler to jobs.start .. Patch Set 3: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url

Change in vdsm[master]: jobs: Move run from sdm.base.Job to jobs.Job

2016-09-09 Thread automation
gerrit-hooks has posted comments on this change. Change subject: jobs: Move run from sdm.base.Job to jobs.Job .. Patch Set 4: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header

Change in vdsm[master]: jobs: Autodelete

2016-09-09 Thread automation
gerrit-hooks has posted comments on this change. Change subject: jobs: Autodelete .. Patch Set 4: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is

Change in vdsm[master]: sdm: Drop support for thread-local job_id

2016-09-09 Thread automation
gerrit-hooks has posted comments on this change. Change subject: sdm: Drop support for thread-local job_id .. Patch Set 3: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header mat

Change in vdsm[master]: sdm: Use guarded.context in copy_data

2016-09-09 Thread alitke
Adam Litke has posted comments on this change. Change subject: sdm: Use guarded.context in copy_data .. Patch Set 16: Verified+1 -- To view, visit https://gerrit.ovirt.org/61693 To unsubscribe, visit https://gerrit.ovirt.org/s

Change in vdsm[master]: sdm: Use guarded.context in copy_data

2016-09-09 Thread nsoffer
Nir Soffer has posted comments on this change. Change subject: sdm: Use guarded.context in copy_data .. Patch Set 16: Code-Review+2 -- To view, visit https://gerrit.ovirt.org/61693 To unsubscribe, visit https://gerrit.ovirt.or

Change in vdsm[master]: sdm: Use guarded.context in copy_data

2016-09-09 Thread automation
gerrit-hooks has posted comments on this change. Change subject: sdm: Use guarded.context in copy_data .. Patch Set 16: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matche

Change in vdsm[master]: sdm: Use guarded.context in copy_data

2016-09-09 Thread alitke
Adam Litke has posted comments on this change. Change subject: sdm: Use guarded.context in copy_data .. Patch Set 15: Verified+1 -- To view, visit https://gerrit.ovirt.org/61693 To unsubscribe, visit https://gerrit.ovirt.org/s

Change in vdsm[master]: sdm: Use guarded.context in copy_data

2016-09-09 Thread alitke
Adam Litke has posted comments on this change. Change subject: sdm: Use guarded.context in copy_data .. Patch Set 15: (4 comments) https://gerrit.ovirt.org/#/c/61693/14/tests/storage_sdm_copy_data_test.py File tests/storage_sd

Change in vdsm[master]: sdm: Use guarded.context in copy_data

2016-09-09 Thread nsoffer
Nir Soffer has posted comments on this change. Change subject: sdm: Use guarded.context in copy_data .. Patch Set 15: Code-Review-1 (2 comments) https://gerrit.ovirt.org/#/c/61693/15/tests/storage_sdm_copy_data_test.py File te

Change in vdsm[master]: net: Link setup module - includes bond setup logic.

2016-09-09 Thread edwardh
Edward Haas has posted comments on this change. Change subject: net: Link setup module - includes bond setup logic. .. Patch Set 17: (1 comment) https://gerrit.ovirt.org/#/c/62831/17/lib/vdsm/network/link/setup.py File lib/vds

Change in vdsm[master]: sdm: Drop support for thread-local job_id

2016-09-09 Thread nsoffer
Nir Soffer has posted comments on this change. Change subject: sdm: Drop support for thread-local job_id .. Patch Set 2: Code-Review+2 -- To view, visit https://gerrit.ovirt.org/62083 To unsubscribe, visit https://gerrit.ovirt

Change in vdsm[master]: sdm: Drop support for thread-local job_id

2016-09-09 Thread alitke
Adam Litke has posted comments on this change. Change subject: sdm: Drop support for thread-local job_id .. Patch Set 2: (1 comment) https://gerrit.ovirt.org/#/c/62083/2/tests/storage_sdm_api_test.py File tests/storage_sdm_api

Change in vdsm[master]: Pass scheduler to jobs.start

2016-09-09 Thread alitke
Adam Litke has posted comments on this change. Change subject: Pass scheduler to jobs.start .. Patch Set 2: (1 comment) https://gerrit.ovirt.org/#/c/62000/2/tests/jobsTests.py File tests/jobsTests.py: Line 63: class JobsTests

Change in vdsm[master]: net test: Clean lease files on setup-cleanup

2016-09-09 Thread edwardh
Edward Haas has posted comments on this change. Change subject: net test: Clean lease files on setup-cleanup .. Patch Set 9: -Verified (3 comments) https://gerrit.ovirt.org/#/c/63089/9/tests/network/netfunctestlib.py File test

Change in vdsm[master]: sdm: Use guarded.context in copy_data

2016-09-09 Thread automation
gerrit-hooks has posted comments on this change. Change subject: sdm: Use guarded.context in copy_data .. Patch Set 15: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matche

Change in vdsm[master]: sdm: Use guarded.context in copy_data

2016-09-09 Thread alitke
Adam Litke has posted comments on this change. Change subject: sdm: Use guarded.context in copy_data .. Patch Set 14: (14 comments) https://gerrit.ovirt.org/#/c/61693/14/tests/storage_sdm_copy_data_test.py File tests/storage_s

Change in vdsm[master]: sampling: Retrieve backing chain stats

2016-09-09 Thread nsoffer
Nir Soffer has posted comments on this change. Change subject: sampling: Retrieve backing chain stats .. Patch Set 4: (1 comment) https://gerrit.ovirt.org/#/c/60888/4/lib/vdsm/virt/sampling.py File lib/vdsm/virt/sampling.py:

Change in vdsm[master]: sampling: Retrieve backing chain stats

2016-09-09 Thread nsoffer
Nir Soffer has posted comments on this change. Change subject: sampling: Retrieve backing chain stats .. Patch Set 4: Code-Review-1 (1 comment) We want to explore another approach, getting watermarks for current domain before

Change in vdsm[master]: sdm: Use guarded.context in copy_data

2016-09-09 Thread nsoffer
Nir Soffer has posted comments on this change. Change subject: sdm: Use guarded.context in copy_data .. Patch Set 14: Code-Review-1 (12 comments) https://gerrit.ovirt.org/#/c/61693/14/tests/storage_sdm_copy_data_test.py File t

Change in vdsm[master]: spec: bridge-utils are required for tests

2016-09-09 Thread sbonazzo
Sandro Bonazzola has posted comments on this change. Change subject: spec: bridge-utils are required for tests .. Patch Set 1: No magic automation I'm aware of. -- To view, visit https://gerrit.ovirt.org/62612 To unsubscribe,

Change in vdsm[master]: upgrade: Support upgrade to v4 from v3

2016-09-09 Thread nsoffer
Nir Soffer has posted comments on this change. Change subject: upgrade: Support upgrade to v4 from v3 .. Patch Set 1: (1 comment) https://gerrit.ovirt.org/#/c/63547/1/vdsm/storage/imageRepository/formatConverter.py File vdsm/s

Change in vdsm[master]: virt: Typo fix in Vm._acquireCpuLockWithTimeout error message

2016-09-09 Thread automation
gerrit-hooks has posted comments on this change. Change subject: virt: Typo fix in Vm._acquireCpuLockWithTimeout error message .. Patch Set 1: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found,

Change in vdsm[master]: virt: Refuse to cancel post-copy migrations

2016-09-09 Thread automation
gerrit-hooks has posted comments on this change. Change subject: virt: Refuse to cancel post-copy migrations .. Patch Set 2: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header m

Change in vdsm[master]: virt net: Disable special OVS handling for exteranal network

2016-09-09 Thread automation
gerrit-hooks has posted comments on this change. Change subject: virt net: Disable special OVS handling for exteranal network .. Patch Set 1: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, m

Change in vdsm[master]: virt net: Disable special OVS handling for exteranal network

2016-09-09 Thread mmirecki
Marcin Mirecki has uploaded a new change for review. Change subject: virt net: Disable special OVS handling for exteranal network .. virt net: Disable special OVS handling for exteranal network Exteranal network rely of changes

Change in vdsm[master]: sdm: Use guarded.context in copy_data

2016-09-09 Thread alitke
Adam Litke has posted comments on this change. Change subject: sdm: Use guarded.context in copy_data .. Patch Set 14: Verified+1 Verified through unit testing and functional testing of the copy_data verb. -- To view, visit ht

Change in vdsm[master]: net: Link setup module - includes bond setup logic.

2016-09-09 Thread phoracek
Petr Horáček has posted comments on this change. Change subject: net: Link setup module - includes bond setup logic. .. Patch Set 19: Code-Review-1 (1 comment) -1 for attention https://gerrit.ovirt.org/#/c/62831/17/lib/vdsm/n

Change in vdsm[master]: net test: Clean lease files on setup-cleanup

2016-09-09 Thread phoracek
Petr Horáček has posted comments on this change. Change subject: net test: Clean lease files on setup-cleanup .. Patch Set 9: Code-Review-1 (3 comments) https://gerrit.ovirt.org/#/c/63089/9/tests/network/netfunctestlib.py File

Change in vdsm[master]: upgrade: Support upgrade to v4 from v3

2016-09-09 Thread amureini
Allon Mureinik has posted comments on this change. Change subject: upgrade: Support upgrade to v4 from v3 .. Patch Set 1: Code-Review-1 (3 comments) https://gerrit.ovirt.org/#/c/63547/1/vdsm/storage/imageRepository/formatConve

Change in vdsm[master]: net: Use Linux bonds with OVS networks

2016-09-09 Thread automation
gerrit-hooks has posted comments on this change. Change subject: net: Use Linux bonds with OVS networks .. Patch Set 13: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header match

Change in vdsm[master]: net: Link setup module - includes bond setup logic.

2016-09-09 Thread automation
gerrit-hooks has posted comments on this change. Change subject: net: Link setup module - includes bond setup logic. .. Patch Set 19: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure

Change in vdsm[master]: gluster: set selinux labels while creating bricks

2016-09-09 Thread automation
gerrit-hooks has posted comments on this change. Change subject: gluster: set selinux labels while creating bricks .. Patch Set 5: * #1368474::Update tracker: OK * Check Bug-Url::OK * Check Public Bug::#1368474::OK, public bug

Change in vdsm[master]: sos: replace dumpStorageTable with dump_volume_chains

2016-09-09 Thread automation
gerrit-hooks has posted comments on this change. Change subject: sos: replace dumpStorageTable with dump_volume_chains .. Patch Set 5: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sur

Change in vdsm[master]: dump_volume_chains: migrate to jsonrpcvdscli

2016-09-09 Thread automation
gerrit-hooks has posted comments on this change. Change subject: dump_volume_chains: migrate to jsonrpcvdscli .. Patch Set 14: * #1365007::Update tracker: OK * Check Bug-Url::OK * Check Public Bug::#1365007::OK, public bug * Ch

Change in vdsm[master]: sos: change getConnectedStoragePoolsList result key

2016-09-09 Thread automation
gerrit-hooks has posted comments on this change. Change subject: sos: change getConnectedStoragePoolsList result key .. Patch Set 2: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure