Dan Kenigsberg has posted comments on this change.
Change subject: stomp: simplified client
..
Patch Set 10: Code-Review-1
(2 comments)
https://gerrit.ovirt.org/#/c/59151/10/lib/yajsonrpc/stompreactor.py
File lib/yajsonrpc/sto
Hello Petr Horáček,
I'd like you to do a code review. Please visit
https://gerrit.ovirt.org/64438
to review the following change.
Change subject: net tests: fix test_events_keys
..
net tests: fix test_events_keys
On Jenk
gerrit-hooks has posted comments on this change.
Change subject: net tests: fix test_events_keys
..
Patch Set 1:
* update_tracker: OK
* Check Bug-Url::OK
* Check Public Bug::#1374328::OK, public bug
* Check Product::#1374328::O
gerrit-hooks has posted comments on this change.
Change subject: virt: enable glusterfs access through libgfapi interface
..
Patch Set 11:
* update_tracker: OK
* Check Bug-Url::OK
* Check Public Bug::#1022961::OK, public bug
*
Dan Kenigsberg has submitted this change and it was merged.
Change subject: build: Allow tox to run all checkers in one shot.
..
build: Allow tox to run all checkers in one shot.
tox has been called for each checker (pep8, pyfl
gerrit-hooks has posted comments on this change.
Change subject: build: Allow tox to run all checkers in one shot.
..
Patch Set 2:
* update_tracker: OK
* Set MODIFIED::IGNORE, no Bug-Url found.
--
To view, visit https://gerri
Dan Kenigsberg has posted comments on this change.
Change subject: build: Allow tox to run all checkers in one shot.
..
Patch Set 1: Code-Review+2
--
To view, visit https://gerrit.ovirt.org/63633
To unsubscribe, visit https://
gerrit-hooks has posted comments on this change.
Change subject: Define the SDM.move_domain_device API
..
Patch Set 2:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches
gerrit-hooks has posted comments on this change.
Change subject: implementing SDM.move_domain_device
..
Patch Set 5:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches '
gerrit-hooks has posted comments on this change.
Change subject: StorageDomain.getInfo - report the first pv of the metadata lv
..
Patch Set 8:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found,
gerrit-hooks has posted comments on this change.
Change subject: StorageDomain.getInfo - report lvm metadata device for block sd
..
Patch Set 2:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found
gerrit-hooks has posted comments on this change.
Change subject: implementing SDM.move_domain_device
..
Patch Set 4:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches '
Liron Aravot has uploaded a new change for review.
Change subject: Define the SDM.move_domain_device API
..
Define the SDM.move_domain_device API
This patch defines the SDM.move_domain_device API that will
be used to move data f
Liron Aravot has uploaded a new change for review.
Change subject: StorageDomain.getInfo - report lvm metadata device for block sd
..
StorageDomain.getInfo - report lvm metadata device for block sd
When a block storage domain is
Liron Aravot has uploaded a new change for review.
Change subject: StorageDomain.getInfo - report the first pv of the metadata lv
..
StorageDomain.getInfo - report the first pv of the metadata lv
This patch adds the report of th
gerrit-hooks has posted comments on this change.
Change subject: implementing SDM.move_domain_device
..
Patch Set 3:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches '
Yaniv Bronhaim has submitted this change and it was merged.
Change subject: spec: Require ioprocess 0.15.2
..
spec: Require ioprocess 0.15.2
The first time IOProcess.truncate() or IOProcess.touch() is called,
ioprocess keep the
gerrit-hooks has posted comments on this change.
Change subject: spec: Require ioprocess 0.15.2
..
Patch Set 3:
* #1370564::Update tracker: OK
* Set MODIFIED::bug 1370564#1370564OK
--
To view, visit https://gerrit.ovi
Yaniv Bronhaim has posted comments on this change.
Change subject: infra tests: added functional test for upgrading vdsm
..
Patch Set 14:
please trigger check_merged job so we'll see the output -
jenkins.ovirt.org/job/vdsm_mas
Yaniv Bronhaim has posted comments on this change.
Change subject: build: Allow tox to run all checkers in one shot.
..
Patch Set 1: Code-Review+1
--
To view, visit https://gerrit.ovirt.org/63633
To unsubscribe, visit https://
Yaniv Bronhaim has posted comments on this change.
Change subject: contrib: Simple jsonrpc client
..
Patch Set 20:
(1 comment)
https://gerrit.ovirt.org/#/c/35181/20/contrib/jsonrpc
File contrib/jsonrpc:
Line 72: from yajsonrp
gerrit-hooks has posted comments on this change.
Change subject: core: Expose API for qemuimg commit
..
Patch Set 6:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches '
gerrit-hooks has posted comments on this change.
Change subject: sdm: Introduce new SDM.merge verb
..
Patch Set 8:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bu
Ala Hino has posted comments on this change.
Change subject: core: Expose API for qemuimg commit
..
Patch Set 5:
(7 comments)
Nir, note that I created a single test that covers all use cases. I am hoping
that I addressed all
gerrit-hooks has posted comments on this change.
Change subject: sdm: Introduce new SDM.merge verb
..
Patch Set 7:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bu
gerrit-hooks has posted comments on this change.
Change subject: core: Expose API for qemuimg commit
..
Patch Set 5:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches '
Nir Soffer has posted comments on this change.
Change subject: guest-lvs: Add lvm bootstrap tests
..
Patch Set 7:
(1 comment)
https://gerrit.ovirt.org/#/c/64367/7/tests/storage_lvm_test.py
File tests/storage_lvm_test.py:
Line
gerrit-hooks has posted comments on this change.
Change subject: implementing SDM.move_domain_device
..
Patch Set 3:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches '
Irit Goihman has posted comments on this change.
Change subject: infra tests: added functional test for upgrading vdsm
..
Patch Set 14: Verified+1
passes in jenkins
--
To view, visit https://gerrit.ovirt.org/61186
To unsubscr
Nir Soffer has posted comments on this change.
Change subject: qemuimg: Add qcow_compat optional parameter.
..
Patch Set 17:
Please fix pep8 errors, without fixing them the CI won't even try the real
tests.
./lib/vdsm/qemuimg
Yaniv Bronhaim has posted comments on this change.
Change subject: stomp: simplified client
..
Patch Set 10: Code-Review+1
--
To view, visit https://gerrit.ovirt.org/59151
To unsubscribe, visit https://gerrit.ovirt.org/setting
Nir Soffer has posted comments on this change.
Change subject: spec: Require ioprocess 0.15.2
..
Patch Set 2: Continuous-Integration+1
Falling network tests is not relevant.
--
To view, visit https://gerrit.ovirt.org/63038
To
gerrit-hooks has posted comments on this change.
Change subject: copy_data: Add qcow2_compat on convert.
..
Patch Set 5:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header match
gerrit-hooks has posted comments on this change.
Change subject: file_volume: Add qcow2_compat on create
..
Patch Set 5:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header match
gerrit-hooks has posted comments on this change.
Change subject: qemuimg: Add qcow_compat optional parameter.
..
Patch Set 17:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header
gerrit-hooks has posted comments on this change.
Change subject: volume: Add qcow2_compat on create
..
Patch Set 5:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'B
gerrit-hooks has posted comments on this change.
Change subject: vm: Add qcow2_compat on create
..
Patch Set 5:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-U
gerrit-hooks has posted comments on this change.
Change subject: volume_artifacts: Add qcow2_compat on create.
..
Patch Set 5:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header
gerrit-hooks has posted comments on this change.
Change subject: image: Pass compat version.
..
Patch Set 9:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url:
gerrit-hooks has posted comments on this change.
Change subject: blockVolume: Add qcow2_compat on create
..
Patch Set 5:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header match
gerrit-hooks has posted comments on this change.
Change subject: sd: Select qcow2_compat by storage domain version
..
Patch Set 10:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure h
gerrit-hooks has posted comments on this change.
Change subject: implementing SDM.move_domain_device
..
Patch Set 3:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches '
gerrit-hooks has posted comments on this change.
Change subject: spec: Require ioprocess 0.15.2
..
Patch Set 2: Verified-1
* #1370564::Update tracker: OK
* Check Bug-Url::OK
* Check Public Bug::#1370564::OK, public bug
* Check
Yaniv Bronhaim has posted comments on this change.
Change subject: spec: Require ioprocess 0.15.2
..
Patch Set 1: Code-Review+2
--
To view, visit https://gerrit.ovirt.org/63038
To unsubscribe, visit https://gerrit.ovirt.org/se
Yaniv Bronhaim has posted comments on this change.
Change subject: py3: remove capsTests from blacklist
..
Patch Set 2: Code-Review+1
good ! thanks
--
To view, visit https://gerrit.ovirt.org/64363
To unsubscribe, visit https:
gerrit-hooks has posted comments on this change.
Change subject: image: Pass compat version.
..
Patch Set 8:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url:
gerrit-hooks has posted comments on this change.
Change subject: copy_data: Add qcow2_compat on convert.
..
Patch Set 4:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header match
gerrit-hooks has posted comments on this change.
Change subject: qemuimg: Add qcow_compat optional parameter.
..
Patch Set 16:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header
gerrit-hooks has posted comments on this change.
Change subject: volume_artifacts: Add qcow2_compat on create.
..
Patch Set 4:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header
gerrit-hooks has posted comments on this change.
Change subject: file_volume: Add qcow2_compat on create
..
Patch Set 4:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header match
gerrit-hooks has posted comments on this change.
Change subject: blockVolume: Add qcow2_compat on create
..
Patch Set 4:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header match
gerrit-hooks has posted comments on this change.
Change subject: infra tests: added functional test for upgrading vdsm
..
Patch Set 14:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make su
gerrit-hooks has posted comments on this change.
Change subject: vm: Add qcow2_compat on create
..
Patch Set 4:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-U
gerrit-hooks has posted comments on this change.
Change subject: volume: Add qcow2_compat on create
..
Patch Set 4:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'B
gerrit-hooks has posted comments on this change.
Change subject: sd: Select qcow2_compat by storage domain version
..
Patch Set 9:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure he
gerrit-hooks has posted comments on this change.
Change subject: infra tests: added functional test for upgrading vdsm
..
Patch Set 13:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make su
gerrit-hooks has posted comments on this change.
Change subject: infra tests: added functional test for upgrading vdsm
..
Patch Set 12:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make su
Irit Goihman has posted comments on this change.
Change subject: infra tests: added functional test for upgrading vdsm
..
Patch Set 11:
(11 comments)
https://gerrit.ovirt.org/#/c/61186/10/tests/functional/Makefile.am
File test
gerrit-hooks has posted comments on this change.
Change subject: infra tests: added functional test for upgrading vdsm
..
Patch Set 11:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make su
gerrit-hooks has posted comments on this change.
Change subject: volume: Add qcow2_compat on create
..
Patch Set 3:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'B
gerrit-hooks has posted comments on this change.
Change subject: file_volume: Add qcow2_compat on create
..
Patch Set 3:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header match
gerrit-hooks has posted comments on this change.
Change subject: sd: Select qcow2_compat by storage domain version
..
Patch Set 8:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure he
gerrit-hooks has posted comments on this change.
Change subject: copy_data: Add qcow2_compat on convert.
..
Patch Set 3:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header match
gerrit-hooks has posted comments on this change.
Change subject: vm: Add qcow2_compat on create
..
Patch Set 3:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-U
gerrit-hooks has posted comments on this change.
Change subject: qemuimg: Add qcow_compat optional parameter.
..
Patch Set 15:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header
gerrit-hooks has posted comments on this change.
Change subject: volume_artifacts: Add qcow2_compat on create.
..
Patch Set 3:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header
gerrit-hooks has posted comments on this change.
Change subject: image: Pass compat version.
..
Patch Set 7:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url:
gerrit-hooks has posted comments on this change.
Change subject: blockVolume: Add qcow2_compat on create
..
Patch Set 3:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header match
gerrit-hooks has posted comments on this change.
Change subject: qemuimg_test: make test pass.
..
Patch Set 2:
* Update tracker: IGNORE, no Bug-Url found
--
To view, visit https://gerrit.ovirt.org/64371
To unsubscribe, visit
Maor Lipchuk has abandoned this change.
Change subject: qemuimg_test: make test pass.
..
Abandoned
--
To view, visit https://gerrit.ovirt.org/64371
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: a
Maor Lipchuk has posted comments on this change.
Change subject: qemuimg_test: make test pass.
..
Patch Set 2:
(1 comment)
This is what I get when I run ./run_tests.sh qemuimg_test.py on latest VDSM:
FAIL: test_qcow2_backing
gerrit-hooks has posted comments on this change.
Change subject: net: Log a setup networks transaction failure when using ovs
switch
..
Patch Set 1:
* #1379115::Update tracker: OK
* Check Bug-Url::OK
* Check Public Bug::#13791
gerrit-hooks has posted comments on this change.
Change subject: net: Setup validation for OVS - Check nics usage
..
Patch Set 1:
* #1379115::Update tracker: OK
* Check Bug-Url::OK
* Check Public Bug::#1379115::OK, public bug
*
gerrit-hooks has posted comments on this change.
Change subject: net: Delete an OVS bridge when the last SB is detached.
..
Patch Set 1:
* #1379115::Update tracker: OK
* Check Bug-Url::OK
* Check Public Bug::#1379115::OK, publi
gerrit-hooks has posted comments on this change.
Change subject: net: Split OVS setup transaction to adjust for bond setup
..
Patch Set 1:
* #1379115::Update tracker: OK
* Check Bug-Url::OK
* Check Public Bug::#1379115::OK, pub
gerrit-hooks has posted comments on this change.
Change subject: net: Use Linux bonds with OVS networks
..
Patch Set 1:
* #1379115::Update tracker: OK
* Check Bug-Url::OK
* Check Public Bug::#1379115::OK, public bug
* Check Pro
gerrit-hooks has posted comments on this change.
Change subject: net: Remove OVS bond implementation.
..
Patch Set 1:
* #1379115::Update tracker: OK
* Check Bug-Url::OK
* Check Public Bug::#1379115::OK, public bug
* Check Produ
gerrit-hooks has posted comments on this change.
Change subject: net: Relocate sysfs_bond_permission to nettestlib
..
Patch Set 1:
* #1379115::Update tracker: OK
* Check Bug-Url::OK
* Check Public Bug::#1379115::OK, public bug
gerrit-hooks has posted comments on this change.
Change subject: net: Disable IPv6 on OVS southbound iface (nic or bonding)
..
Patch Set 1:
* #1379115::Update tracker: OK
* Check Bug-Url::OK
* Check Public Bug::#1379115::OK, pu
gerrit-hooks has posted comments on this change.
Change subject: net: test ovs info with southbound nic
..
Patch Set 1:
* #1379115::Update tracker: OK
* Check Bug-Url::OK
* Check Public Bug::#1379115::OK, public bug
* Check Pro
gerrit-hooks has posted comments on this change.
Change subject: net: Bond - preserve original slaves link state.
..
Patch Set 1:
* #1379115::Update tracker: OK
* Check Bug-Url::OK
* Check Public Bug::#1379115::OK, public bug
*
gerrit-hooks has posted comments on this change.
Change subject: net: Bond - Add logging to the bond driver.
..
Patch Set 1:
* #1379115::Update tracker: OK
* Check Bug-Url::OK
* Check Public Bug::#1379115::OK, public bug
* Chec
gerrit-hooks has posted comments on this change.
Change subject: net: Bond - add refresh method to update bond config
..
Patch Set 1:
* #1379115::Update tracker: OK
* Check Bug-Url::OK
* Check Public Bug::#1379115::OK, public b
gerrit-hooks has posted comments on this change.
Change subject: net: Link setup module - includes bond setup logic.
..
Patch Set 1:
* #1379115::Update tracker: OK
* Check Bug-Url::OK
* Check Public Bug::#1379115::OK, public bu
gerrit-hooks has posted comments on this change.
Change subject: net: Bond - adding a transaction context.
..
Patch Set 1:
* #1379115::Update tracker: OK
* Check Bug-Url::OK
* Check Public Bug::#1379115::OK, public bug
* Check
gerrit-hooks has posted comments on this change.
Change subject: net: dhclient - address flush before starting and on shutdown
..
Patch Set 1:
* #1379115::Update tracker: OK
* Check Bug-Url::OK
* Check Public Bug::#1379115::OK,
gerrit-hooks has posted comments on this change.
Change subject: net: dhclient kill - early exit if iface does not exists
..
Patch Set 1:
* #1379115::Update tracker: OK
* Check Bug-Url::OK
* Check Public Bug::#1379115::OK, publ
gerrit-hooks has posted comments on this change.
Change subject: net: Bond - Expose the (kernel) bond list.
..
Patch Set 1:
* #1379115::Update tracker: OK
* Check Bug-Url::OK
* Check Public Bug::#1379115::OK, public bug
* Check
gerrit-hooks has posted comments on this change.
Change subject: net: ifcfg - dhclient should always be stopped
..
Patch Set 1:
* #1379115::Update tracker: OK
* Check Bug-Url::OK
* Check Public Bug::#1379115::OK, public bug
* C
gerrit-hooks has posted comments on this change.
Change subject: net: Introduce iface.exists and start using it in ip.dhclient
..
Patch Set 1:
* #1379115::Update tracker: OK
* Check Bug-Url::OK
* Check Public Bug::#1379115::OK,
gerrit-hooks has posted comments on this change.
Change subject: net: For IP-less networks, wait for link-up on ifup execution
..
Patch Set 1:
* #1379115::Update tracker: OK
* Check Bug-Url::OK
* Check Public Bug::#1379115::OK,
gerrit-hooks has posted comments on this change.
Change subject: net: Use is_link_up instead of operstate in netfunctestlib
..
Patch Set 1:
* #1379115::Update tracker: OK
* Check Bug-Url::OK
* Check Public Bug::#1379115::OK, pu
gerrit-hooks has posted comments on this change.
Change subject: net: Expose disable IPv6 through ip.address module
..
Patch Set 1:
* #1379115::Update tracker: OK
* Check Bug-Url::OK
* Check Public Bug::#1379115::OK, public bug
gerrit-hooks has posted comments on this change.
Change subject: net tests: Set dummy ifaces up by default.
..
Patch Set 1:
* #1379115::Update tracker: OK
* Check Bug-Url::OK
* Check Public Bug::#1379115::OK, public bug
* Check
gerrit-hooks has posted comments on this change.
Change subject: net: Relocating wait-for-event under its own module.
..
Patch Set 1:
* #1379115::Update tracker: OK
* Check Bug-Url::OK
* Check Public Bug::#1379115::OK, public b
gerrit-hooks has posted comments on this change.
Change subject: net func tests: Cleanup ifcfg files after each func test.
..
Patch Set 1:
* #1379115::Update tracker: OK
* Check Bug-Url::OK
* Check Public Bug::#1379115::OK, pub
gerrit-hooks has posted comments on this change.
Change subject: net: Adding the 'link' package with an iface module
..
Patch Set 1:
* #1379115::Update tracker: OK
* Check Bug-Url::OK
* Check Public Bug::#1379115::OK, public bu
gerrit-hooks has posted comments on this change.
Change subject: net: Adding bond api with sysfs driver under link
..
Patch Set 1:
* #1379115::Update tracker: OK
* Check Bug-Url::OK
* Check Public Bug::#1379115::OK, public bug
gerrit-hooks has posted comments on this change.
Change subject: net test: sourceroute thread crashes due to a test race
..
Patch Set 1:
* #1379115::Update tracker: OK
* Check Bug-Url::OK
* Check Public Bug::#1379115::OK, publi
gerrit-hooks has posted comments on this change.
Change subject: net: Define netlink netdev flags constants under netlink.link
..
Patch Set 1:
* #1379115::Update tracker: OK
* Check Bug-Url::OK
* Check Public Bug::#1379115::OK,
1 - 100 of 200 matches
Mail list logo