Change in vdsm[master]: betterasynccore: Prevent double close

2016-10-06 Thread automation
gerrit-hooks has posted comments on this change. Change subject: betterasynccore: Prevent double close .. Patch Set 1: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header

Change in vdsm[master]: betterasynccore: Prevent double close

2016-10-06 Thread nsoffer
Nir Soffer has uploaded a new change for review. Change subject: betterasynccore: Prevent double close .. betterasynccore: Prevent double close asyncore.dispatcher is defining a closing attribute, but never use it. This make it

Change in vdsm[master]: sp: Streamline image namespace locking

2016-10-06 Thread automation
gerrit-hooks has posted comments on this change. Change subject: sp: Streamline image namespace locking .. Patch Set 8: * Update tracker: IGNORE, no Bug-Url found * Set MODIFIED::IGNORE, no Bug-Url found. -- To view, visit

Change in vdsm[master]: vm: Add qcow2_compat on create

2016-10-06 Thread nsoffer
Nir Soffer has submitted this change and it was merged. Change subject: vm: Add qcow2_compat on create .. vm: Add qcow2_compat on create Pass qcow2 compat on create. Change-Id: I331eee6a12853c2fa65e62f42c51504f88723538

Change in vdsm[master]: sp: Streamline image namespace locking

2016-10-06 Thread nsoffer
Nir Soffer has submitted this change and it was merged. Change subject: sp: Streamline image namespace locking .. sp: Streamline image namespace locking Replace imageResourcesNamespace with img_ns, streamlining acquiring of

Change in vdsm[master]: vm: Add qcow2_compat on create

2016-10-06 Thread automation
gerrit-hooks has posted comments on this change. Change subject: vm: Add qcow2_compat on create .. Patch Set 24: * Update tracker: IGNORE, no Bug-Url found * Set MODIFIED::IGNORE, no Bug-Url found. -- To view, visit

Change in vdsm[master]: qemuimg: Introduce InvalidOutput exception

2016-10-06 Thread ahino
Ala Hino has posted comments on this change. Change subject: qemuimg: Introduce InvalidOutput exception .. Patch Set 3: (3 comments) https://gerrit.ovirt.org/#/c/65208/3/lib/vdsm/qemuimg.py File lib/vdsm/qemuimg.py: Line 67:

Change in vdsm[master]: qemuimg: Add wrapper to execute command

2016-10-06 Thread automation
gerrit-hooks has posted comments on this change. Change subject: qemuimg: Add wrapper to execute command .. Patch Set 5: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header

Change in vdsm[master]: qemuimg: Introduce InvalidOutput exception

2016-10-06 Thread automation
gerrit-hooks has posted comments on this change. Change subject: qemuimg: Introduce InvalidOutput exception .. Patch Set 4: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header

Change in vdsm[master]: qemuimg: Introduce InvalidOutput exception

2016-10-06 Thread nsoffer
Nir Soffer has posted comments on this change. Change subject: qemuimg: Introduce InvalidOutput exception .. Patch Set 3: (3 comments) https://gerrit.ovirt.org/#/c/65208/3/lib/vdsm/qemuimg.py File lib/vdsm/qemuimg.py: Line

Change in vdsm[master]: qemuimg: Introduce InvalidOutput exception

2016-10-06 Thread ahino
Ala Hino has posted comments on this change. Change subject: qemuimg: Introduce InvalidOutput exception .. Patch Set 2: (1 comment) https://gerrit.ovirt.org/#/c/65208/1/lib/vdsm/qemuimg.py File lib/vdsm/qemuimg.py: Line 67:

Change in vdsm[master]: qemuimg: Add the command to QImgError

2016-10-06 Thread ahino
Ala Hino has posted comments on this change. Change subject: qemuimg: Add the command to QImgError .. Patch Set 3: (1 comment) https://gerrit.ovirt.org/#/c/65179/3/lib/vdsm/qemuimg.py File lib/vdsm/qemuimg.py: Line 218 Line

Change in vdsm[master]: qemuimg: Introduce InvalidOutput exception

2016-10-06 Thread automation
gerrit-hooks has posted comments on this change. Change subject: qemuimg: Introduce InvalidOutput exception .. Patch Set 3: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header

Change in vdsm[master]: qemuimg: Add wrapper to execute command

2016-10-06 Thread automation
gerrit-hooks has posted comments on this change. Change subject: qemuimg: Add wrapper to execute command .. Patch Set 4: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header

Change in vdsm[master]: qemuimg: Add the command to QImgError

2016-10-06 Thread automation
gerrit-hooks has posted comments on this change. Change subject: qemuimg: Add the command to QImgError .. Patch Set 4: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header

Change in vdsm[master]: qemuimg: Add the command to QImgError

2016-10-06 Thread nsoffer
Nir Soffer has posted comments on this change. Change subject: qemuimg: Add the command to QImgError .. Patch Set 3: (1 comment) https://gerrit.ovirt.org/#/c/65179/3/lib/vdsm/qemuimg.py File lib/vdsm/qemuimg.py: Line 218

Change in vdsm[master]: qemuimg: Introduce InvalidOutput exception

2016-10-06 Thread nsoffer
Nir Soffer has posted comments on this change. Change subject: qemuimg: Introduce InvalidOutput exception .. Patch Set 1: (1 comment) https://gerrit.ovirt.org/#/c/65208/1/lib/vdsm/qemuimg.py File lib/vdsm/qemuimg.py: Line

Change in vdsm[master]: qemuimg: Introduce InvalidOutput exception

2016-10-06 Thread automation
gerrit-hooks has posted comments on this change. Change subject: qemuimg: Introduce InvalidOutput exception .. Patch Set 2: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header

Change in vdsm[master]: qemuimg: Introduce InvalidOutput exception

2016-10-06 Thread ahino
Ala Hino has posted comments on this change. Change subject: qemuimg: Introduce InvalidOutput exception .. Patch Set 1: (1 comment) https://gerrit.ovirt.org/#/c/65208/1//COMMIT_MSG Commit Message: Line 5: CommitDate:

Change in vdsm[master]: qemuimg: Add the command to QImgError

2016-10-06 Thread automation
gerrit-hooks has posted comments on this change. Change subject: qemuimg: Add the command to QImgError .. Patch Set 3: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header

Change in vdsm[master]: qemuimg: Add wrapper to execute command

2016-10-06 Thread ahino
Ala Hino has posted comments on this change. Change subject: qemuimg: Add wrapper to execute command .. Patch Set 2: (3 comments) https://gerrit.ovirt.org/#/c/65178/2/lib/vdsm/qemuimg.py File lib/vdsm/qemuimg.py: Line 86:

Change in vdsm[master]: qemuimg: Add wrapper to execute command

2016-10-06 Thread automation
gerrit-hooks has posted comments on this change. Change subject: qemuimg: Add wrapper to execute command .. Patch Set 3: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header

Change in vdsm[master]: qemuimg: Add the command to QImgError

2016-10-06 Thread ahino
Ala Hino has posted comments on this change. Change subject: qemuimg: Add the command to QImgError .. Patch Set 2: > (1 comment) how do I get the cmd from the CPopen instance? -- To view, visit

Change in vdsm[master]: qemuimg: Add wrapper to execute command

2016-10-06 Thread nsoffer
Nir Soffer has posted comments on this change. Change subject: qemuimg: Add wrapper to execute command .. Patch Set 2: (3 comments) https://gerrit.ovirt.org/#/c/65178/2/lib/vdsm/qemuimg.py File lib/vdsm/qemuimg.py: Line 86:

Change in vdsm[master]: qemuimg: Introduce InvalidOutput exception

2016-10-06 Thread nsoffer
Nir Soffer has posted comments on this change. Change subject: qemuimg: Introduce InvalidOutput exception .. Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.ovirt.org/65208 To unsubscribe, visit

Change in vdsm[master]: qemuimg: Introduce InvalidOutput exception

2016-10-06 Thread nsoffer
Nir Soffer has posted comments on this change. Change subject: qemuimg: Introduce InvalidOutput exception .. Patch Set 1: (1 comment) Nice https://gerrit.ovirt.org/#/c/65208/1//COMMIT_MSG Commit Message: Line 5: CommitDate:

Change in vdsm[master]: qemuimg: Add the command to QImgError

2016-10-06 Thread nsoffer
Nir Soffer has posted comments on this change. Change subject: qemuimg: Add the command to QImgError .. Patch Set 2: (1 comment) https://gerrit.ovirt.org/#/c/65179/2/lib/vdsm/qemuimg.py File lib/vdsm/qemuimg.py: Line 279:

Change in vdsm[master]: jobs: Fix abort semantics

2016-10-06 Thread nsoffer
Nir Soffer has posted comments on this change. Change subject: jobs: Fix abort semantics .. Patch Set 4: Code-Review+1 (5 comments) https://gerrit.ovirt.org/#/c/65102/4/lib/vdsm/jobs.py File lib/vdsm/jobs.py: Line 146 Line

Change in vdsm[master]: jobs: Fix abort semantics

2016-10-06 Thread automation
gerrit-hooks has posted comments on this change. Change subject: jobs: Fix abort semantics .. Patch Set 4: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url:

Change in vdsm[master]: qemuimg: Require explicit start of QemuImgOperation

2016-10-06 Thread automation
gerrit-hooks has posted comments on this change. Change subject: qemuimg: Require explicit start of QemuImgOperation .. Patch Set 4: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure

Change in vdsm[master]: jobs: Fix abort semantics

2016-10-06 Thread alitke
Adam Litke has posted comments on this change. Change subject: jobs: Fix abort semantics .. Patch Set 3: (7 comments) https://gerrit.ovirt.org/#/c/65102/3/lib/vdsm/jobs.py File lib/vdsm/jobs.py: Line 168 Line 169 Line 170

Change in vdsm[master]: storage: Fix abort race in SDM.copy_data

2016-10-06 Thread automation
gerrit-hooks has posted comments on this change. Change subject: storage: Fix abort race in SDM.copy_data .. Patch Set 4: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header

Change in vdsm[master]: qemuimg: Add wrapper to execute command

2016-10-06 Thread automation
gerrit-hooks has posted comments on this change. Change subject: qemuimg: Add wrapper to execute command .. Patch Set 2: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header

Change in vdsm[master]: qemuimg: Add the command to QImgError

2016-10-06 Thread automation
gerrit-hooks has posted comments on this change. Change subject: qemuimg: Add the command to QImgError .. Patch Set 2: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header

Change in vdsm[master]: qemuimg: Introduce InvalidOutput exception

2016-10-06 Thread automation
gerrit-hooks has posted comments on this change. Change subject: qemuimg: Introduce InvalidOutput exception .. Patch Set 1: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header

Change in vdsm[master]: qemuimg: Introduce InvalidOutput exception

2016-10-06 Thread ahino
Ala Hino has uploaded a new change for review. Change subject: qemuimg: Introduce InvalidOutput exception .. qemuimg: Introduce InvalidOutput exception Raised when the command output is not valid. Change-Id:

Change in vdsm[master]: jobs: Fix abort semantics

2016-10-06 Thread nsoffer
Nir Soffer has posted comments on this change. Change subject: jobs: Fix abort semantics .. Patch Set 3: Code-Review+1 (7 comments) Nice and simple! Please check the comments.

Change in vdsm[master]: tests: Fail if abort was not called

2016-10-06 Thread automation
gerrit-hooks has posted comments on this change. Change subject: tests: Fail if abort was not called .. Patch Set 1: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches

Change in vdsm[master]: tests: Fail if abort was not called

2016-10-06 Thread nsoffer
Nir Soffer has uploaded a new change for review. Change subject: tests: Fail if abort was not called .. tests: Fail if abort was not called The StuckJob was waiting one second and terminating silently even if the test never

Change in vdsm[master]: protocoldetector: Fix random double close

2016-10-06 Thread automation
gerrit-hooks has posted comments on this change. Change subject: protocoldetector: Fix random double close .. Patch Set 1: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header

Change in vdsm[master]: clientIF: Fix reactor life cycle

2016-10-06 Thread automation
gerrit-hooks has posted comments on this change. Change subject: clientIF: Fix reactor life cycle .. Patch Set 1: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches

Change in vdsm[master]: protocoldetector: Fix random double close

2016-10-06 Thread nsoffer
Nir Soffer has uploaded a new change for review. Change subject: protocoldetector: Fix random double close .. protocoldetector: Fix random double close Previously we stopped the reactor before closing the acceptor. This works

Change in vdsm[master]: clientIF: Fix reactor life cycle

2016-10-06 Thread nsoffer
Nir Soffer has uploaded a new change for review. Change subject: clientIF: Fix reactor life cycle .. clientIF: Fix reactor life cycle Previously we created the reactor when initializing clientIF, and started the reactor thread

Change in vdsm[master]: tests: Create all instance variables in setUp

2016-10-06 Thread automation
gerrit-hooks has posted comments on this change. Change subject: tests: Create all instance variables in setUp .. Patch Set 2: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure

Change in vdsm[master]: [WIP] use libvirt domain xml prepared in advance

2016-10-06 Thread automation
gerrit-hooks has posted comments on this change. Change subject: [WIP] use libvirt domain xml prepared in advance .. Patch Set 2: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure

Change in vdsm[master]: [WIP] use libvirt domain xml prepared in advance

2016-10-06 Thread ahadas
Arik Hadas has uploaded a new change for review. Change subject: [WIP] use libvirt domain xml prepared in advance .. [WIP] use libvirt domain xml prepared in advance Change-Id: I469fad3ca14a6b7f4675ef5c200175053f6dd4af

Change in vdsm[master]: [WIP] use libvirt domain xml prepared in advance

2016-10-06 Thread automation
gerrit-hooks has posted comments on this change. Change subject: [WIP] use libvirt domain xml prepared in advance .. Patch Set 1: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure

Change in vdsm[master]: qemuimg: Add the command to QImgError

2016-10-06 Thread nsoffer
Nir Soffer has posted comments on this change. Change subject: qemuimg: Add the command to QImgError .. Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.ovirt.org/65179 To unsubscribe, visit

Change in vdsm[master]: qemuimg: Add the command to QImgError

2016-10-06 Thread automation
gerrit-hooks has posted comments on this change. Change subject: qemuimg: Add the command to QImgError .. Patch Set 1: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header

Change in vdsm[master]: qemuimg: Add the command to QImgError

2016-10-06 Thread ahino
Ala Hino has uploaded a new change for review. Change subject: qemuimg: Add the command to QImgError .. qemuimg: Add the command to QImgError Change-Id: I226a54b29ae4afc3854056efea78767383b89619 Signed-off-by: Ala Hino

Change in vdsm[master]: qemuimg: Add wrapper to execute command

2016-10-06 Thread automation
gerrit-hooks has posted comments on this change. Change subject: qemuimg: Add wrapper to execute command .. Patch Set 1: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header

Change in vdsm[master]: qemuimg: Add wrapper to execute command

2016-10-06 Thread ahino
Ala Hino has uploaded a new change for review. Change subject: qemuimg: Add wrapper to execute command .. qemuimg: Add wrapper to execute command Add wrapper to execute qemuimg command and raise QImgError if error encountered.

Change in vdsm[master]: tests: Mark integration tests

2016-10-06 Thread nsoffer
Nir Soffer has abandoned this change. Change subject: tests: Mark integration tests .. Abandoned These tests pass now on travis in master, fixed by adding missing packages. -- To view, visit https://gerrit.ovirt.org/55730 To

Change in vdsm[master]: tests: Rename storagetestlibTests.py to new Vdsm convention

2016-10-06 Thread automation
gerrit-hooks has posted comments on this change. Change subject: tests: Rename storagetestlibTests.py to new Vdsm convention .. Patch Set 2: * Update tracker: IGNORE, no Bug-Url found * Set MODIFIED::IGNORE, no Bug-Url found.

Change in vdsm[master]: tests: Make the run_tests*.sh scripts readable

2016-10-06 Thread nsoffer
Nir Soffer has abandoned this change. Change subject: tests: Make the run_tests*.sh scripts readable .. Abandoned Similar change was already merged. -- To view, visit https://gerrit.ovirt.org/55729 To unsubscribe, visit

Change in vdsm[master]: tests: Change offset and len arguments type

2016-10-06 Thread nsoffer
Nir Soffer has submitted this change and it was merged. Change subject: tests: Change offset and len arguments type .. tests: Change offset and len arguments type Change offset and len arguments type from string to integer.

Change in vdsm[master]: tests: Mark integration tests

2016-10-06 Thread automation
gerrit-hooks has posted comments on this change. Change subject: tests: Mark integration tests .. Patch Set 6: * Update tracker: IGNORE, no Bug-Url found -- To view, visit https://gerrit.ovirt.org/55730 To unsubscribe, visit

Change in vdsm[master]: tests: Make the run_tests*.sh scripts readable

2016-10-06 Thread automation
gerrit-hooks has posted comments on this change. Change subject: tests: Make the run_tests*.sh scripts readable .. Patch Set 2: * Update tracker: IGNORE, no Bug-Url found -- To view, visit https://gerrit.ovirt.org/55729 To

Change in vdsm[master]: tests: Change offset and len arguments type

2016-10-06 Thread nsoffer
Nir Soffer has posted comments on this change. Change subject: tests: Change offset and len arguments type .. Patch Set 1: Let move quicker. -- To view, visit https://gerrit.ovirt.org/65174 To unsubscribe, visit

Change in vdsm[master]: tests: Change offset and len arguments type

2016-10-06 Thread automation
gerrit-hooks has posted comments on this change. Change subject: tests: Change offset and len arguments type .. Patch Set 2: * Update tracker: IGNORE, no Bug-Url found * Set MODIFIED::IGNORE, no Bug-Url found. -- To view,

Change in vdsm[master]: qemuimg: Simplify and complete map tests

2016-10-06 Thread automation
gerrit-hooks has posted comments on this change. Change subject: qemuimg: Simplify and complete map tests .. Patch Set 3: * Update tracker: IGNORE, no Bug-Url found -- To view, visit https://gerrit.ovirt.org/65151 To

Change in vdsm[master]: qemuimg: Simplify and complete map tests

2016-10-06 Thread nsoffer
Nir Soffer has abandoned this change. Change subject: qemuimg: Simplify and complete map tests .. Abandoned Squashed into previous patch -- To view, visit https://gerrit.ovirt.org/65151 To unsubscribe, visit

Change in vdsm[master]: tests: Change offset and len arguments type

2016-10-06 Thread nsoffer
Nir Soffer has posted comments on this change. Change subject: tests: Change offset and len arguments type .. Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.ovirt.org/65174 To unsubscribe, visit

Change in vdsm[master]: tests: Rename storagetestlibTests.py to new Vdsm convention

2016-10-06 Thread nsoffer
Nir Soffer has submitted this change and it was merged. Change subject: tests: Rename storagetestlibTests.py to new Vdsm convention .. tests: Rename storagetestlibTests.py to new Vdsm convention Change-Id:

Change in vdsm[master]: tests: Rename storagetestlibTests.py to new Vdsm convention

2016-10-06 Thread nsoffer
Nir Soffer has posted comments on this change. Change subject: tests: Rename storagetestlibTests.py to new Vdsm convention .. Patch Set 1: Code-Review+2 Thanks! -- To view, visit https://gerrit.ovirt.org/65173 To

Change in vdsm[master]: tests: Change offset and len arguments type

2016-10-06 Thread nsoffer
Nir Soffer has posted comments on this change. Change subject: tests: Change offset and len arguments type .. Patch Set 1: Code-Review+1 Waiting for Adam ack. -- To view, visit https://gerrit.ovirt.org/65174 To unsubscribe,

Change in vdsm[master]: tests: Change offset and len arguments type

2016-10-06 Thread nsoffer
Nir Soffer has posted comments on this change. Change subject: tests: Change offset and len arguments type .. Patch Set 1: Code-Review+2 Looks good, hopefully we did not forget any other caller. -- To view, visit

Change in vdsm[master]: tests: Rename storagetestlibTests.py to new Vdsm convention

2016-10-06 Thread ahino
Ala Hino has uploaded a new change for review. Change subject: tests: Rename storagetestlibTests.py to new Vdsm convention .. tests: Rename storagetestlibTests.py to new Vdsm convention Change-Id:

Change in vdsm[master]: tests: Change offset and len arguments type

2016-10-06 Thread ahino
Ala Hino has uploaded a new change for review. Change subject: tests: Change offset and len arguments type .. tests: Change offset and len arguments type Change offset and len arguments type from string to integer. Change-Id:

Change in vdsm[master]: tests: Rename storagetestlibTests.py to new Vdsm convention

2016-10-06 Thread ahino
Ala Hino has posted comments on this change. Change subject: tests: Rename storagetestlibTests.py to new Vdsm convention .. Patch Set 1: Verified+1 -- To view, visit https://gerrit.ovirt.org/65173 To unsubscribe, visit

Change in vdsm[master]: tests: Change offset and len arguments type

2016-10-06 Thread ahino
Ala Hino has posted comments on this change. Change subject: tests: Change offset and len arguments type .. Patch Set 1: Verified+1 -- To view, visit https://gerrit.ovirt.org/65174 To unsubscribe, visit

Change in vdsm[master]: sp: Remove vol_extend_policy option

2016-10-06 Thread nsoffer
Nir Soffer has posted comments on this change. Change subject: sp: Remove vol_extend_policy option .. Patch Set 8: Verified+1 -- To view, visit https://gerrit.ovirt.org/65053 To unsubscribe, visit

Change in vdsm[master]: tests: Change offset and len arguments type

2016-10-06 Thread automation
gerrit-hooks has posted comments on this change. Change subject: tests: Change offset and len arguments type .. Patch Set 1: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header

Change in vdsm[master]: tests: Rename storagetestlibTests.py to new Vdsm convention

2016-10-06 Thread automation
gerrit-hooks has posted comments on this change. Change subject: tests: Rename storagetestlibTests.py to new Vdsm convention .. Patch Set 1: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found,

Change in vdsm[master]: sp: Streamline building domains list for upgrade

2016-10-06 Thread automation
gerrit-hooks has posted comments on this change. Change subject: sp: Streamline building domains list for upgrade .. Patch Set 7: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure

Change in vdsm[master]: sp: Do not use rm.acquireResource return value

2016-10-06 Thread automation
gerrit-hooks has posted comments on this change. Change subject: sp: Do not use rm.acquireResource return value .. Patch Set 7: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure

Change in vdsm[master]: procwatch: Rename closed property to watching

2016-10-06 Thread automation
gerrit-hooks has posted comments on this change. Change subject: procwatch: Rename closed property to watching .. Patch Set 6: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure

Change in vdsm[master]: procwatch: Specify stdin, stdout, and stderr

2016-10-06 Thread automation
gerrit-hooks has posted comments on this change. Change subject: procwatch: Specify stdin, stdout, and stderr .. Patch Set 7: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header

Change in vdsm[master]: procwatch: Port to python 3

2016-10-06 Thread automation
gerrit-hooks has posted comments on this change. Change subject: procwatch: Port to python 3 .. Patch Set 5: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches

Change in vdsm[master]: procwatch: Rename CommandStream to ProcessWatcher

2016-10-06 Thread automation
gerrit-hooks has posted comments on this change. Change subject: procwatch: Rename CommandStream to ProcessWatcher .. Patch Set 6: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure

Change in vdsm[master]: procwatch: Move CommandStream to new module

2016-10-06 Thread automation
gerrit-hooks has posted comments on this change. Change subject: procwatch: Move CommandStream to new module .. Patch Set 6: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header

Change in vdsm[master]: procwatch: Replace command with process

2016-10-06 Thread automation
gerrit-hooks has posted comments on this change. Change subject: procwatch: Replace command with process .. Patch Set 5: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header

Change in vdsm[master]: procwatch: Modernize and clarify helper name

2016-10-06 Thread automation
gerrit-hooks has posted comments on this change. Change subject: procwatch: Modernize and clarify helper name .. Patch Set 5: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header

Change in vdsm[master]: procwatch: There is no need for _private helpers

2016-10-06 Thread automation
gerrit-hooks has posted comments on this change. Change subject: procwatch: There is no need for _private helpers .. Patch Set 5: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure

Change in vdsm[master]: procwatch: Move test helpers to bottom

2016-10-06 Thread automation
gerrit-hooks has posted comments on this change. Change subject: procwatch: Move test helpers to bottom .. Patch Set 5: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header

Change in vdsm[master]: sp: Remove double dict key

2016-10-06 Thread nsoffer
Nir Soffer has posted comments on this change. Change subject: sp: Remove double dict key .. Patch Set 7: Verified+1 -- To view, visit https://gerrit.ovirt.org/65051 To unsubscribe, visit https://gerrit.ovirt.org/settings

Change in vdsm[master]: sp: Remove vol_extend_policy option

2016-10-06 Thread automation
gerrit-hooks has posted comments on this change. Change subject: sp: Remove vol_extend_policy option .. Patch Set 9: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches

Change in vdsm[master]: sp: Sort dict literal by key

2016-10-06 Thread automation
gerrit-hooks has posted comments on this change. Change subject: sp: Sort dict literal by key .. Patch Set 9: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches

Change in vdsm[master]: sp: Remove double dict key

2016-10-06 Thread automation
gerrit-hooks has posted comments on this change. Change subject: sp: Remove double dict key .. Patch Set 8: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url:

Change in vdsm[master]: sp: Streamline usage of image.Image class

2016-10-06 Thread automation
gerrit-hooks has posted comments on this change. Change subject: sp: Streamline usage of image.Image class .. Patch Set 9: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header

Change in vdsm[master]: sp: Fix positional args calling convention

2016-10-06 Thread automation
gerrit-hooks has posted comments on this change. Change subject: sp: Fix positional args calling convention .. Patch Set 8: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header

Change in vdsm[master]: sp: Streamline acquiring of multiple images locks

2016-10-06 Thread automation
gerrit-hooks has posted comments on this change. Change subject: sp: Streamline acquiring of multiple images locks .. Patch Set 7: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure

Change in vdsm[master]: sp: pep8 1.6.2 fix

2016-10-06 Thread automation
gerrit-hooks has posted comments on this change. Change subject: sp: pep8 1.6.2 fix .. Patch Set 8: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and

Change in vdsm[master]: sp: Remove useless continuation to a commented line

2016-10-06 Thread automation
gerrit-hooks has posted comments on this change. Change subject: sp: Remove useless continuation to a commented line .. Patch Set 7: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure

Change in vdsm[master]: sp: Fix domain.produceVolume calling convention

2016-10-06 Thread automation
gerrit-hooks has posted comments on this change. Change subject: sp: Fix domain.produceVolume calling convention .. Patch Set 8: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure

Change in vdsm[master]: sp: Simplify long lines using continuation \

2016-10-06 Thread automation
gerrit-hooks has posted comments on this change. Change subject: sp: Simplify long lines using continuation \ .. Patch Set 7: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header

Change in vdsm[master]: sp: Streamline calls to volume methods

2016-10-06 Thread automation
gerrit-hooks has posted comments on this change. Change subject: sp: Streamline calls to volume methods .. Patch Set 8: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header

Change in vdsm[master]: sp: Streamline image namespace locking

2016-10-06 Thread automation
gerrit-hooks has posted comments on this change. Change subject: sp: Streamline image namespace locking .. Patch Set 7: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header

Change in vdsm[master]: sp: Fix domain.produceVolume calling convention

2016-10-06 Thread nsoffer
Nir Soffer has posted comments on this change. Change subject: sp: Fix domain.produceVolume calling convention .. Patch Set 7: Continuous-Integration+1 Test failures not relevant. -- To view, visit

Change in vdsm[master]: sp: Fix positional args calling convention

2016-10-06 Thread nsoffer
Nir Soffer has posted comments on this change. Change subject: sp: Fix positional args calling convention .. Patch Set 7: Verified+1 -- To view, visit https://gerrit.ovirt.org/65048 To unsubscribe, visit

  1   2   >