gerrit-hooks has posted comments on this change.
Change subject: betterasynccore: Prevent double close
..
Patch Set 1:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header
Nir Soffer has uploaded a new change for review.
Change subject: betterasynccore: Prevent double close
..
betterasynccore: Prevent double close
asyncore.dispatcher is defining a closing attribute, but never use it.
This make it
gerrit-hooks has posted comments on this change.
Change subject: sp: Streamline image namespace locking
..
Patch Set 8:
* Update tracker: IGNORE, no Bug-Url found
* Set MODIFIED::IGNORE, no Bug-Url found.
--
To view, visit
Nir Soffer has submitted this change and it was merged.
Change subject: vm: Add qcow2_compat on create
..
vm: Add qcow2_compat on create
Pass qcow2 compat on create.
Change-Id: I331eee6a12853c2fa65e62f42c51504f88723538
Nir Soffer has submitted this change and it was merged.
Change subject: sp: Streamline image namespace locking
..
sp: Streamline image namespace locking
Replace imageResourcesNamespace with img_ns, streamlining acquiring of
gerrit-hooks has posted comments on this change.
Change subject: vm: Add qcow2_compat on create
..
Patch Set 24:
* Update tracker: IGNORE, no Bug-Url found
* Set MODIFIED::IGNORE, no Bug-Url found.
--
To view, visit
Ala Hino has posted comments on this change.
Change subject: qemuimg: Introduce InvalidOutput exception
..
Patch Set 3:
(3 comments)
https://gerrit.ovirt.org/#/c/65208/3/lib/vdsm/qemuimg.py
File lib/vdsm/qemuimg.py:
Line 67:
gerrit-hooks has posted comments on this change.
Change subject: qemuimg: Add wrapper to execute command
..
Patch Set 5:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header
gerrit-hooks has posted comments on this change.
Change subject: qemuimg: Introduce InvalidOutput exception
..
Patch Set 4:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header
Nir Soffer has posted comments on this change.
Change subject: qemuimg: Introduce InvalidOutput exception
..
Patch Set 3:
(3 comments)
https://gerrit.ovirt.org/#/c/65208/3/lib/vdsm/qemuimg.py
File lib/vdsm/qemuimg.py:
Line
Ala Hino has posted comments on this change.
Change subject: qemuimg: Introduce InvalidOutput exception
..
Patch Set 2:
(1 comment)
https://gerrit.ovirt.org/#/c/65208/1/lib/vdsm/qemuimg.py
File lib/vdsm/qemuimg.py:
Line 67:
Ala Hino has posted comments on this change.
Change subject: qemuimg: Add the command to QImgError
..
Patch Set 3:
(1 comment)
https://gerrit.ovirt.org/#/c/65179/3/lib/vdsm/qemuimg.py
File lib/vdsm/qemuimg.py:
Line 218
Line
gerrit-hooks has posted comments on this change.
Change subject: qemuimg: Introduce InvalidOutput exception
..
Patch Set 3:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header
gerrit-hooks has posted comments on this change.
Change subject: qemuimg: Add wrapper to execute command
..
Patch Set 4:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header
gerrit-hooks has posted comments on this change.
Change subject: qemuimg: Add the command to QImgError
..
Patch Set 4:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header
Nir Soffer has posted comments on this change.
Change subject: qemuimg: Add the command to QImgError
..
Patch Set 3:
(1 comment)
https://gerrit.ovirt.org/#/c/65179/3/lib/vdsm/qemuimg.py
File lib/vdsm/qemuimg.py:
Line 218
Nir Soffer has posted comments on this change.
Change subject: qemuimg: Introduce InvalidOutput exception
..
Patch Set 1:
(1 comment)
https://gerrit.ovirt.org/#/c/65208/1/lib/vdsm/qemuimg.py
File lib/vdsm/qemuimg.py:
Line
gerrit-hooks has posted comments on this change.
Change subject: qemuimg: Introduce InvalidOutput exception
..
Patch Set 2:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header
Ala Hino has posted comments on this change.
Change subject: qemuimg: Introduce InvalidOutput exception
..
Patch Set 1:
(1 comment)
https://gerrit.ovirt.org/#/c/65208/1//COMMIT_MSG
Commit Message:
Line 5: CommitDate:
gerrit-hooks has posted comments on this change.
Change subject: qemuimg: Add the command to QImgError
..
Patch Set 3:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header
Ala Hino has posted comments on this change.
Change subject: qemuimg: Add wrapper to execute command
..
Patch Set 2:
(3 comments)
https://gerrit.ovirt.org/#/c/65178/2/lib/vdsm/qemuimg.py
File lib/vdsm/qemuimg.py:
Line 86:
gerrit-hooks has posted comments on this change.
Change subject: qemuimg: Add wrapper to execute command
..
Patch Set 3:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header
Ala Hino has posted comments on this change.
Change subject: qemuimg: Add the command to QImgError
..
Patch Set 2:
> (1 comment)
how do I get the cmd from the CPopen instance?
--
To view, visit
Nir Soffer has posted comments on this change.
Change subject: qemuimg: Add wrapper to execute command
..
Patch Set 2:
(3 comments)
https://gerrit.ovirt.org/#/c/65178/2/lib/vdsm/qemuimg.py
File lib/vdsm/qemuimg.py:
Line 86:
Nir Soffer has posted comments on this change.
Change subject: qemuimg: Introduce InvalidOutput exception
..
Patch Set 1: Code-Review+1
--
To view, visit https://gerrit.ovirt.org/65208
To unsubscribe, visit
Nir Soffer has posted comments on this change.
Change subject: qemuimg: Introduce InvalidOutput exception
..
Patch Set 1:
(1 comment)
Nice
https://gerrit.ovirt.org/#/c/65208/1//COMMIT_MSG
Commit Message:
Line 5: CommitDate:
Nir Soffer has posted comments on this change.
Change subject: qemuimg: Add the command to QImgError
..
Patch Set 2:
(1 comment)
https://gerrit.ovirt.org/#/c/65179/2/lib/vdsm/qemuimg.py
File lib/vdsm/qemuimg.py:
Line 279:
Nir Soffer has posted comments on this change.
Change subject: jobs: Fix abort semantics
..
Patch Set 4: Code-Review+1
(5 comments)
https://gerrit.ovirt.org/#/c/65102/4/lib/vdsm/jobs.py
File lib/vdsm/jobs.py:
Line 146
Line
gerrit-hooks has posted comments on this change.
Change subject: jobs: Fix abort semantics
..
Patch Set 4:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url:
gerrit-hooks has posted comments on this change.
Change subject: qemuimg: Require explicit start of QemuImgOperation
..
Patch Set 4:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure
Adam Litke has posted comments on this change.
Change subject: jobs: Fix abort semantics
..
Patch Set 3:
(7 comments)
https://gerrit.ovirt.org/#/c/65102/3/lib/vdsm/jobs.py
File lib/vdsm/jobs.py:
Line 168
Line 169
Line 170
gerrit-hooks has posted comments on this change.
Change subject: storage: Fix abort race in SDM.copy_data
..
Patch Set 4:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header
gerrit-hooks has posted comments on this change.
Change subject: qemuimg: Add wrapper to execute command
..
Patch Set 2:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header
gerrit-hooks has posted comments on this change.
Change subject: qemuimg: Add the command to QImgError
..
Patch Set 2:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header
gerrit-hooks has posted comments on this change.
Change subject: qemuimg: Introduce InvalidOutput exception
..
Patch Set 1:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header
Ala Hino has uploaded a new change for review.
Change subject: qemuimg: Introduce InvalidOutput exception
..
qemuimg: Introduce InvalidOutput exception
Raised when the command output is not valid.
Change-Id:
Nir Soffer has posted comments on this change.
Change subject: jobs: Fix abort semantics
..
Patch Set 3: Code-Review+1
(7 comments)
Nice and simple!
Please check the comments.
gerrit-hooks has posted comments on this change.
Change subject: tests: Fail if abort was not called
..
Patch Set 1:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches
Nir Soffer has uploaded a new change for review.
Change subject: tests: Fail if abort was not called
..
tests: Fail if abort was not called
The StuckJob was waiting one second and terminating silently even if the
test never
gerrit-hooks has posted comments on this change.
Change subject: protocoldetector: Fix random double close
..
Patch Set 1:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header
gerrit-hooks has posted comments on this change.
Change subject: clientIF: Fix reactor life cycle
..
Patch Set 1:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches
Nir Soffer has uploaded a new change for review.
Change subject: protocoldetector: Fix random double close
..
protocoldetector: Fix random double close
Previously we stopped the reactor before closing the acceptor. This
works
Nir Soffer has uploaded a new change for review.
Change subject: clientIF: Fix reactor life cycle
..
clientIF: Fix reactor life cycle
Previously we created the reactor when initializing clientIF, and
started the reactor thread
gerrit-hooks has posted comments on this change.
Change subject: tests: Create all instance variables in setUp
..
Patch Set 2:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure
gerrit-hooks has posted comments on this change.
Change subject: [WIP] use libvirt domain xml prepared in advance
..
Patch Set 2:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure
Arik Hadas has uploaded a new change for review.
Change subject: [WIP] use libvirt domain xml prepared in advance
..
[WIP] use libvirt domain xml prepared in advance
Change-Id: I469fad3ca14a6b7f4675ef5c200175053f6dd4af
gerrit-hooks has posted comments on this change.
Change subject: [WIP] use libvirt domain xml prepared in advance
..
Patch Set 1:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure
Nir Soffer has posted comments on this change.
Change subject: qemuimg: Add the command to QImgError
..
Patch Set 1: Code-Review+2
--
To view, visit https://gerrit.ovirt.org/65179
To unsubscribe, visit
gerrit-hooks has posted comments on this change.
Change subject: qemuimg: Add the command to QImgError
..
Patch Set 1:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header
Ala Hino has uploaded a new change for review.
Change subject: qemuimg: Add the command to QImgError
..
qemuimg: Add the command to QImgError
Change-Id: I226a54b29ae4afc3854056efea78767383b89619
Signed-off-by: Ala Hino
gerrit-hooks has posted comments on this change.
Change subject: qemuimg: Add wrapper to execute command
..
Patch Set 1:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header
Ala Hino has uploaded a new change for review.
Change subject: qemuimg: Add wrapper to execute command
..
qemuimg: Add wrapper to execute command
Add wrapper to execute qemuimg command and raise QImgError if error
encountered.
Nir Soffer has abandoned this change.
Change subject: tests: Mark integration tests
..
Abandoned
These tests pass now on travis in master, fixed by adding missing packages.
--
To view, visit https://gerrit.ovirt.org/55730
To
gerrit-hooks has posted comments on this change.
Change subject: tests: Rename storagetestlibTests.py to new Vdsm convention
..
Patch Set 2:
* Update tracker: IGNORE, no Bug-Url found
* Set MODIFIED::IGNORE, no Bug-Url found.
Nir Soffer has abandoned this change.
Change subject: tests: Make the run_tests*.sh scripts readable
..
Abandoned
Similar change was already merged.
--
To view, visit https://gerrit.ovirt.org/55729
To unsubscribe, visit
Nir Soffer has submitted this change and it was merged.
Change subject: tests: Change offset and len arguments type
..
tests: Change offset and len arguments type
Change offset and len arguments type from string to integer.
gerrit-hooks has posted comments on this change.
Change subject: tests: Mark integration tests
..
Patch Set 6:
* Update tracker: IGNORE, no Bug-Url found
--
To view, visit https://gerrit.ovirt.org/55730
To unsubscribe, visit
gerrit-hooks has posted comments on this change.
Change subject: tests: Make the run_tests*.sh scripts readable
..
Patch Set 2:
* Update tracker: IGNORE, no Bug-Url found
--
To view, visit https://gerrit.ovirt.org/55729
To
Nir Soffer has posted comments on this change.
Change subject: tests: Change offset and len arguments type
..
Patch Set 1:
Let move quicker.
--
To view, visit https://gerrit.ovirt.org/65174
To unsubscribe, visit
gerrit-hooks has posted comments on this change.
Change subject: tests: Change offset and len arguments type
..
Patch Set 2:
* Update tracker: IGNORE, no Bug-Url found
* Set MODIFIED::IGNORE, no Bug-Url found.
--
To view,
gerrit-hooks has posted comments on this change.
Change subject: qemuimg: Simplify and complete map tests
..
Patch Set 3:
* Update tracker: IGNORE, no Bug-Url found
--
To view, visit https://gerrit.ovirt.org/65151
To
Nir Soffer has abandoned this change.
Change subject: qemuimg: Simplify and complete map tests
..
Abandoned
Squashed into previous patch
--
To view, visit https://gerrit.ovirt.org/65151
To unsubscribe, visit
Nir Soffer has posted comments on this change.
Change subject: tests: Change offset and len arguments type
..
Patch Set 1: Code-Review+2
--
To view, visit https://gerrit.ovirt.org/65174
To unsubscribe, visit
Nir Soffer has submitted this change and it was merged.
Change subject: tests: Rename storagetestlibTests.py to new Vdsm convention
..
tests: Rename storagetestlibTests.py to new Vdsm convention
Change-Id:
Nir Soffer has posted comments on this change.
Change subject: tests: Rename storagetestlibTests.py to new Vdsm convention
..
Patch Set 1: Code-Review+2
Thanks!
--
To view, visit https://gerrit.ovirt.org/65173
To
Nir Soffer has posted comments on this change.
Change subject: tests: Change offset and len arguments type
..
Patch Set 1: Code-Review+1
Waiting for Adam ack.
--
To view, visit https://gerrit.ovirt.org/65174
To unsubscribe,
Nir Soffer has posted comments on this change.
Change subject: tests: Change offset and len arguments type
..
Patch Set 1: Code-Review+2
Looks good, hopefully we did not forget any other caller.
--
To view, visit
Ala Hino has uploaded a new change for review.
Change subject: tests: Rename storagetestlibTests.py to new Vdsm convention
..
tests: Rename storagetestlibTests.py to new Vdsm convention
Change-Id:
Ala Hino has uploaded a new change for review.
Change subject: tests: Change offset and len arguments type
..
tests: Change offset and len arguments type
Change offset and len arguments type from string to integer.
Change-Id:
Ala Hino has posted comments on this change.
Change subject: tests: Rename storagetestlibTests.py to new Vdsm convention
..
Patch Set 1: Verified+1
--
To view, visit https://gerrit.ovirt.org/65173
To unsubscribe, visit
Ala Hino has posted comments on this change.
Change subject: tests: Change offset and len arguments type
..
Patch Set 1: Verified+1
--
To view, visit https://gerrit.ovirt.org/65174
To unsubscribe, visit
Nir Soffer has posted comments on this change.
Change subject: sp: Remove vol_extend_policy option
..
Patch Set 8: Verified+1
--
To view, visit https://gerrit.ovirt.org/65053
To unsubscribe, visit
gerrit-hooks has posted comments on this change.
Change subject: tests: Change offset and len arguments type
..
Patch Set 1:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header
gerrit-hooks has posted comments on this change.
Change subject: tests: Rename storagetestlibTests.py to new Vdsm convention
..
Patch Set 1:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found,
gerrit-hooks has posted comments on this change.
Change subject: sp: Streamline building domains list for upgrade
..
Patch Set 7:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure
gerrit-hooks has posted comments on this change.
Change subject: sp: Do not use rm.acquireResource return value
..
Patch Set 7:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure
gerrit-hooks has posted comments on this change.
Change subject: procwatch: Rename closed property to watching
..
Patch Set 6:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure
gerrit-hooks has posted comments on this change.
Change subject: procwatch: Specify stdin, stdout, and stderr
..
Patch Set 7:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header
gerrit-hooks has posted comments on this change.
Change subject: procwatch: Port to python 3
..
Patch Set 5:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches
gerrit-hooks has posted comments on this change.
Change subject: procwatch: Rename CommandStream to ProcessWatcher
..
Patch Set 6:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure
gerrit-hooks has posted comments on this change.
Change subject: procwatch: Move CommandStream to new module
..
Patch Set 6:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header
gerrit-hooks has posted comments on this change.
Change subject: procwatch: Replace command with process
..
Patch Set 5:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header
gerrit-hooks has posted comments on this change.
Change subject: procwatch: Modernize and clarify helper name
..
Patch Set 5:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header
gerrit-hooks has posted comments on this change.
Change subject: procwatch: There is no need for _private helpers
..
Patch Set 5:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure
gerrit-hooks has posted comments on this change.
Change subject: procwatch: Move test helpers to bottom
..
Patch Set 5:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header
Nir Soffer has posted comments on this change.
Change subject: sp: Remove double dict key
..
Patch Set 7: Verified+1
--
To view, visit https://gerrit.ovirt.org/65051
To unsubscribe, visit https://gerrit.ovirt.org/settings
gerrit-hooks has posted comments on this change.
Change subject: sp: Remove vol_extend_policy option
..
Patch Set 9:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches
gerrit-hooks has posted comments on this change.
Change subject: sp: Sort dict literal by key
..
Patch Set 9:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches
gerrit-hooks has posted comments on this change.
Change subject: sp: Remove double dict key
..
Patch Set 8:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url:
gerrit-hooks has posted comments on this change.
Change subject: sp: Streamline usage of image.Image class
..
Patch Set 9:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header
gerrit-hooks has posted comments on this change.
Change subject: sp: Fix positional args calling convention
..
Patch Set 8:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header
gerrit-hooks has posted comments on this change.
Change subject: sp: Streamline acquiring of multiple images locks
..
Patch Set 7:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure
gerrit-hooks has posted comments on this change.
Change subject: sp: pep8 1.6.2 fix
..
Patch Set 8:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: '
and
gerrit-hooks has posted comments on this change.
Change subject: sp: Remove useless continuation to a commented line
..
Patch Set 7:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure
gerrit-hooks has posted comments on this change.
Change subject: sp: Fix domain.produceVolume calling convention
..
Patch Set 8:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure
gerrit-hooks has posted comments on this change.
Change subject: sp: Simplify long lines using continuation \
..
Patch Set 7:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header
gerrit-hooks has posted comments on this change.
Change subject: sp: Streamline calls to volume methods
..
Patch Set 8:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header
gerrit-hooks has posted comments on this change.
Change subject: sp: Streamline image namespace locking
..
Patch Set 7:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header
Nir Soffer has posted comments on this change.
Change subject: sp: Fix domain.produceVolume calling convention
..
Patch Set 7: Continuous-Integration+1
Test failures not relevant.
--
To view, visit
Nir Soffer has posted comments on this change.
Change subject: sp: Fix positional args calling convention
..
Patch Set 7: Verified+1
--
To view, visit https://gerrit.ovirt.org/65048
To unsubscribe, visit
1 - 100 of 183 matches
Mail list logo