Change in vdsm[master]: sp: Streamline usage of image.Image class

2016-10-06 Thread nsoffer
Nir Soffer has posted comments on this change. Change subject: sp: Streamline usage of image.Image class .. Patch Set 8: Verified+1 -- To view, visit https://gerrit.ovirt.org/65049 To unsubscribe, visit https://gerrit.ovirt.or

Change in vdsm[master]: sp: Fix positional args calling convention

2016-10-06 Thread nsoffer
Nir Soffer has posted comments on this change. Change subject: sp: Fix positional args calling convention .. Patch Set 7: Continuous-Integration+1 Test failures not relevant. -- To view, visit https://gerrit.ovirt.org/65048 T

Change in vdsm[master]: sp: Streamline calls to volume methods

2016-10-06 Thread nsoffer
Nir Soffer has posted comments on this change. Change subject: sp: Streamline calls to volume methods .. Patch Set 7: Verified+1 -- To view, visit https://gerrit.ovirt.org/65047 To unsubscribe, visit https://gerrit.ovirt.org/s

Change in vdsm[master]: sp: Fix domain.produceVolume calling convention

2016-10-06 Thread nsoffer
Nir Soffer has posted comments on this change. Change subject: sp: Fix domain.produceVolume calling convention .. Patch Set 7: Verified+1 -- To view, visit https://gerrit.ovirt.org/65046 To unsubscribe, visit https://gerrit.ov

Change in vdsm[master]: sp: Remove useless continuation to a commented line

2016-10-06 Thread nsoffer
Nir Soffer has posted comments on this change. Change subject: sp: Remove useless continuation to a commented line .. Patch Set 6: Verified+1 -- To view, visit https://gerrit.ovirt.org/65044 To unsubscribe, visit https://gerri

Change in vdsm[master]: sp: Simplify long lines using continuation \

2016-10-06 Thread nsoffer
Nir Soffer has posted comments on this change. Change subject: sp: Simplify long lines using continuation \ .. Patch Set 6: Verified+1 -- To view, visit https://gerrit.ovirt.org/65045 To unsubscribe, visit https://gerrit.ovirt

Change in vdsm[master]: sp: Streamline building domains list for upgrade

2016-10-06 Thread nsoffer
Nir Soffer has posted comments on this change. Change subject: sp: Streamline building domains list for upgrade .. Patch Set 6: Continuous-Integration+1 Test failures not relevant. -- To view, visit https://gerrit.ovirt.org/6

Change in vdsm[master]: sp: Streamline building domains list for upgrade

2016-10-06 Thread nsoffer
Nir Soffer has posted comments on this change. Change subject: sp: Streamline building domains list for upgrade .. Patch Set 6: Verified+1 -- To view, visit https://gerrit.ovirt.org/65043 To unsubscribe, visit https://gerrit.o

Change in vdsm[master]: sp: Do not use rm.acquireResource return value

2016-10-06 Thread nsoffer
Nir Soffer has posted comments on this change. Change subject: sp: Do not use rm.acquireResource return value .. Patch Set 6: Verified+1 -- To view, visit https://gerrit.ovirt.org/65042 To unsubscribe, visit https://gerrit.ovi

Change in vdsm[master]: sp: Streamline acquiring of multiple images locks

2016-10-06 Thread nsoffer
Nir Soffer has posted comments on this change. Change subject: sp: Streamline acquiring of multiple images locks .. Patch Set 6: Continuous-Integration+1 Test failures not relevant. -- To view, visit https://gerrit.ovirt.org/

Change in vdsm[master]: sp: Streamline image namespace locking

2016-10-06 Thread nsoffer
Nir Soffer has posted comments on this change. Change subject: sp: Streamline image namespace locking .. Patch Set 6: Continuous-Integration+1 Tests failure no relevant. -- To view, visit https://gerrit.ovirt.org/65040 To uns

Change in vdsm[master]: sp: Streamline acquiring of multiple images locks

2016-10-06 Thread nsoffer
Nir Soffer has posted comments on this change. Change subject: sp: Streamline acquiring of multiple images locks .. Patch Set 6: Verified+1 -- To view, visit https://gerrit.ovirt.org/65041 To unsubscribe, visit https://gerrit.

Change in vdsm[master]: sp: Streamline image namespace locking

2016-10-06 Thread nsoffer
Nir Soffer has posted comments on this change. Change subject: sp: Streamline image namespace locking .. Patch Set 6: Verified+1 -- To view, visit https://gerrit.ovirt.org/65040 To unsubscribe, visit https://gerrit.ovirt.org/s

Change in vdsm[master]: volume_artifacts: Add qcow2_compat on create.

2016-10-06 Thread alitke
Adam Litke has posted comments on this change. Change subject: volume_artifacts: Add qcow2_compat on create. .. Patch Set 20: (1 comment) https://gerrit.ovirt.org/#/c/64372/20/vdsm/storage/sdm/volume_artifacts.py File vdsm/sto

Change in vdsm[master]: osinfo: properly parse kernel compile time

2016-10-06 Thread michal . skrivanek
Michal Skrivanek has posted comments on this change. Change subject: osinfo: properly parse kernel compile time .. Patch Set 2: (1 comment) https://gerrit.ovirt.org/#/c/65059/2/lib/vdsm/osinfo.py File lib/vdsm/osinfo.py: Line

Change in vdsm[master]: storage: Fix abort race in SDM.copy_data

2016-10-06 Thread automation
gerrit-hooks has posted comments on this change. Change subject: storage: Fix abort race in SDM.copy_data .. Patch Set 3: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matc

Change in vdsm[master]: jobs: Fix abort semantics

2016-10-06 Thread automation
gerrit-hooks has posted comments on this change. Change subject: jobs: Fix abort semantics .. Patch Set 3: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: '

Change in vdsm[master]: qemuimg: Require explicit start of QemuImgOperation

2016-10-06 Thread automation
gerrit-hooks has posted comments on this change. Change subject: qemuimg: Require explicit start of QemuImgOperation .. Patch Set 3: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure

Change in vdsm[master]: osinfo: properly parse kernel compile time

2016-10-06 Thread mpolednik
Martin Polednik has posted comments on this change. Change subject: osinfo: properly parse kernel compile time .. Patch Set 2: (1 comment) https://gerrit.ovirt.org/#/c/65059/2/lib/vdsm/osinfo.py File lib/vdsm/osinfo.py: Line

Change in vdsm[master]: vm: ignore more errors in isDomainReadyForCommands

2016-10-06 Thread mzamazal
Milan Zamazal has posted comments on this change. Change subject: vm: ignore more errors in isDomainReadyForCommands .. Patch Set 1: (2 comments) https://gerrit.ovirt.org/#/c/65131/1//COMMIT_MSG Commit Message: PS1, Line 13:

Change in vdsm[ovirt-4.0]: Fix return value names for VM.ioTune calls

2016-10-06 Thread akrejcir
Andrej Krejcir has posted comments on this change. Change subject: Fix return value names for VM.ioTune calls .. Patch Set 2: Verified+1 -- To view, visit https://gerrit.ovirt.org/63478 To unsubscribe, visit https://gerrit.ovi

Change in vdsm[ovirt-4.0]: Add all MOM calls to jsonrpc client

2016-10-06 Thread akrejcir
Andrej Krejcir has posted comments on this change. Change subject: Add all MOM calls to jsonrpc client .. Patch Set 2: Verified+1 -- To view, visit https://gerrit.ovirt.org/63479 To unsubscribe, visit https://gerrit.ovirt.org/

Change in vdsm[master]: vm: a Down domain is not ready for commands

2016-10-06 Thread mzamazal
Milan Zamazal has posted comments on this change. Change subject: vm: a Down domain is not ready for commands .. Patch Set 1: Code-Review+1 (4 comments) https://gerrit.ovirt.org/#/c/65130/1//COMMIT_MSG Commit Message: PS1, Li

Change in vdsm[master]: osinfo: properly parse kernel compile time

2016-10-06 Thread michal . skrivanek
Michal Skrivanek has posted comments on this change. Change subject: osinfo: properly parse kernel compile time .. Patch Set 2: (1 comment) https://gerrit.ovirt.org/#/c/65059/2/lib/vdsm/osinfo.py File lib/vdsm/osinfo.py: Line

Change in vdsm[master]: osinfo: properly parse kernel compile time

2016-10-06 Thread danken
Dan Kenigsberg has posted comments on this change. Change subject: osinfo: properly parse kernel compile time .. Patch Set 2: Code-Review-1 (1 comment) https://gerrit.ovirt.org/#/c/65059/2/lib/vdsm/osinfo.py File lib/vdsm/osin

Change in vdsm[master]: schema: Change description of io tune parameters.

2016-10-06 Thread rmohr
Roman Mohr has posted comments on this change. Change subject: schema: Change description of io tune parameters. .. Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.ovirt.org/65164 To unsubscribe, visit https://gerr

Change in vdsm[master]: schema: Change description of io tune parameters.

2016-10-06 Thread akrejcir
Andrej Krejcir has posted comments on this change. Change subject: schema: Change description of io tune parameters. .. Patch Set 1: Verified+1 -- To view, visit https://gerrit.ovirt.org/65164 To unsubscribe, visit https://ger

Change in vdsm[master]: schema: Change description of io tune parameters.

2016-10-06 Thread automation
gerrit-hooks has posted comments on this change. Change subject: schema: Change description of io tune parameters. .. Patch Set 1: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure he

Change in vdsm[master]: schema: Change description of io tune parameters.

2016-10-06 Thread akrejcir
Andrej Krejcir has uploaded a new change for review. Change subject: schema: Change description of io tune parameters. .. schema: Change description of io tune parameters. Change-Id: Idb130c7182ba2d618a9618b324fa1537d616a966 Sig

Change in vdsm[master]: travis: Run docker with --privileged

2016-10-06 Thread danken
Dan Kenigsberg has submitted this change and it was merged. Change subject: travis: Run docker with --privileged .. travis: Run docker with --privileged Running docker with --privileged allow creation of loop devices inside the

Change in vdsm[master]: travis: Run docker with --privileged

2016-10-06 Thread automation
gerrit-hooks has posted comments on this change. Change subject: travis: Run docker with --privileged .. Patch Set 2: * Update tracker: IGNORE, no Bug-Url found * Set MODIFIED::IGNORE, no Bug-Url found. -- To view, visit http

Change in vdsm[master]: travis: Run docker with --privileged

2016-10-06 Thread danken
Dan Kenigsberg has posted comments on this change. Change subject: travis: Run docker with --privileged .. Patch Set 1: Code-Review+2 Verified+1 -- To view, visit https://gerrit.ovirt.org/65146 To unsubscribe, visit https://ge

Change in vdsm[master]: travis: Fix build using new docker image

2016-10-06 Thread automation
gerrit-hooks has posted comments on this change. Change subject: travis: Fix build using new docker image .. Patch Set 5: * Update tracker: IGNORE, no Bug-Url found * Set MODIFIED::IGNORE, no Bug-Url found. -- To view, visit

Change in vdsm[master]: travis: Fix build using new docker image

2016-10-06 Thread danken
Dan Kenigsberg has submitted this change and it was merged. Change subject: travis: Fix build using new docker image .. travis: Fix build using new docker image - Use the new image built from updated dockerfile - Remove unneede

Change in vdsm[master]: travis: Fix build using new docker image

2016-10-06 Thread danken
Dan Kenigsberg has posted comments on this change. Change subject: travis: Fix build using new docker image .. Patch Set 4: Code-Review+2 Verified+1 -- To view, visit https://gerrit.ovirt.org/65070 To unsubscribe, visit https:

Change in vdsm[master]: dockerfile: Install development tools using pip

2016-10-06 Thread automation
gerrit-hooks has posted comments on this change. Change subject: dockerfile: Install development tools using pip .. Patch Set 5: * Update tracker: IGNORE, no Bug-Url found * Set MODIFIED::IGNORE, no Bug-Url found. -- To view,

Change in vdsm[master]: dockerfile: Use one package per line

2016-10-06 Thread danken
Dan Kenigsberg has posted comments on this change. Change subject: dockerfile: Use one package per line .. Patch Set 4: Code-Review+2 Verified+1 -- To view, visit https://gerrit.ovirt.org/65068 To unsubscribe, visit https://ge

Change in vdsm[master]: dockerfile: Install development tools using pip

2016-10-06 Thread danken
Dan Kenigsberg has submitted this change and it was merged. Change subject: dockerfile: Install development tools using pip .. dockerfile: Install development tools using pip - Remove python-nose which is too old on CentOS, and

Change in vdsm[master]: dockerfile: Use one package per line

2016-10-06 Thread automation
gerrit-hooks has posted comments on this change. Change subject: dockerfile: Use one package per line .. Patch Set 5: * Update tracker: IGNORE, no Bug-Url found * Set MODIFIED::IGNORE, no Bug-Url found. -- To view, visit http

Change in vdsm[master]: dockerfile: Install development tools using pip

2016-10-06 Thread danken
Dan Kenigsberg has posted comments on this change. Change subject: dockerfile: Install development tools using pip .. Patch Set 4: Code-Review+2 Verified+1 -- To view, visit https://gerrit.ovirt.org/65069 To unsubscribe, visit

Change in vdsm[master]: dockerfile: Use one package per line

2016-10-06 Thread danken
Dan Kenigsberg has submitted this change and it was merged. Change subject: dockerfile: Use one package per line .. dockerfile: Use one package per line Having one package per line make it easier to add and remove packages and

Change in vdsm[master]: dockerfile: Add missing packages

2016-10-06 Thread automation
gerrit-hooks has posted comments on this change. Change subject: dockerfile: Add missing packages .. Patch Set 4: * Update tracker: IGNORE, no Bug-Url found * Set MODIFIED::IGNORE, no Bug-Url found. -- To view, visit https://

Change in vdsm[master]: dockerfile: Use one package per line

2016-10-06 Thread danken
Dan Kenigsberg has posted comments on this change. Change subject: dockerfile: Use one package per line .. Patch Set 4: Continuous-Integration+1 unrelated -- To view, visit https://gerrit.ovirt.org/65068 To unsubscribe, visit

Change in vdsm[master]: dockerfile: Add missing packages

2016-10-06 Thread danken
Dan Kenigsberg has submitted this change and it was merged. Change subject: dockerfile: Add missing packages .. dockerfile: Add missing packages Add missing packages: - PyYaml - dosfstools (for mkfs.msdos) - e2fsprogs (for mkfs

Change in vdsm[master]: dockerfile: Add missing packages

2016-10-06 Thread danken
Dan Kenigsberg has posted comments on this change. Change subject: dockerfile: Add missing packages .. Patch Set 3: Code-Review+2 Verified+1 -- To view, visit https://gerrit.ovirt.org/65067 To unsubscribe, visit https://gerrit

Change in vdsm[master]: osinfo: properly parse kernel compile time

2016-10-06 Thread mpolednik
Martin Polednik has posted comments on this change. Change subject: osinfo: properly parse kernel compile time .. Patch Set 2: (1 comment) https://gerrit.ovirt.org/#/c/65059/2/lib/vdsm/osinfo.py File lib/vdsm/osinfo.py: Line

Change in vdsm[master]: vm: Add qcow2_compat on create

2016-10-06 Thread mlipchuk
Maor Lipchuk has posted comments on this change. Change subject: vm: Add qcow2_compat on create .. Patch Set 23: Verified+1 -- To view, visit https://gerrit.ovirt.org/64377 To unsubscribe, visit https://gerrit.ovirt.org/settin

Change in vdsm[master]: schema: fixing type of default values

2016-10-06 Thread automation
gerrit-hooks has posted comments on this change. Change subject: schema: fixing type of default values .. Patch Set 2: * Update tracker: IGNORE, no Bug-Url found * Set MODIFIED::IGNORE, no Bug-Url found. -- To view, visit htt

Change in vdsm[master]: schema: fixing type of default values

2016-10-06 Thread nsoffer
Nir Soffer has submitted this change and it was merged. Change subject: schema: fixing type of default values .. schema: fixing type of default values Change-Id: Id5ee7e26b9228bd4e423f3fbc87efff5c4374294 Signed-off-by: Piotr K

Change in vdsm[master]: schema: fixing type of default values

2016-10-06 Thread akrejcir
Andrej Krejcir has posted comments on this change. Change subject: schema: fixing type of default values .. Patch Set 1: (1 comment) https://gerrit.ovirt.org/#/c/65113/1/lib/api/vdsm-api.yml File lib/api/vdsm-api.yml: Line 21

Change in vdsm[master]: schema: fixing type of default values

2016-10-06 Thread nsoffer
Nir Soffer has posted comments on this change. Change subject: schema: fixing type of default values .. Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.ovirt.org/65113 To unsubscribe, visit https://gerrit.ovirt.org

Change in vdsm[master]: schema: fixing type of default values

2016-10-06 Thread akrejcir
Andrej Krejcir has posted comments on this change. Change subject: schema: fixing type of default values .. Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.ovirt.org/65113 To unsubscribe, visit https://gerrit.ovirt

Change in vdsm[master]: osinfo: properly parse kernel compile time

2016-10-06 Thread fromani
Francesco Romani has posted comments on this change. Change subject: osinfo: properly parse kernel compile time .. Patch Set 2: Code-Review+1 (1 comment) https://gerrit.ovirt.org/#/c/65059/2/lib/vdsm/osinfo.py File lib/vdsm/os

Change in vdsm[master]: schema: fixing type of default values

2016-10-06 Thread nsoffer
Nir Soffer has posted comments on this change. Change subject: schema: fixing type of default values .. Patch Set 1: (1 comment) https://gerrit.ovirt.org/#/c/65113/1/lib/api/vdsm-api.yml File lib/api/vdsm-api.yml: Line 2119 L

Change in vdsm[master]: schema: fixing type of default values

2016-10-06 Thread danken
Dan Kenigsberg has posted comments on this change. Change subject: schema: fixing type of default values .. Patch Set 1: (1 comment) https://gerrit.ovirt.org/#/c/65113/1/lib/api/vdsm-api.yml File lib/api/vdsm-api.yml: PS1, Li

Change in vdsm[ovirt-4.0]: Fix return value names for VM.ioTune calls

2016-10-06 Thread automation
gerrit-hooks has posted comments on this change. Change subject: Fix return value names for VM.ioTune calls .. Patch Set 2: * #1373832::Update tracker: OK * #60513::Update tracker: OK * Check Bug-Url::OK * Check Public Bug::#13

Change in vdsm[ovirt-4.0]: Add all MOM calls to jsonrpc client

2016-10-06 Thread automation
gerrit-hooks has posted comments on this change. Change subject: Add all MOM calls to jsonrpc client .. Patch Set 2: * #1373832::Update tracker: OK * Check Bug-Url::OK * Check Public Bug::#1373832::OK, public bug * Check merged

Change in vdsm[master]: vm: Add qcow2_compat on create

2016-10-06 Thread fromani
Francesco Romani has posted comments on this change. Change subject: vm: Add qcow2_compat on create .. Patch Set 23: please verify -- To view, visit https://gerrit.ovirt.org/64377 To unsubscribe, visit https://gerrit.ovirt.or

Change in vdsm[master]: vm: Add qcow2_compat on create

2016-10-06 Thread fromani
Francesco Romani has posted comments on this change. Change subject: vm: Add qcow2_compat on create .. Patch Set 23: Code-Review+2 looks ok to me from virt perspective -- To view, visit https://gerrit.ovirt.org/64377 To unsub

Change in vdsm[master]: schema: fixing type of default values

2016-10-06 Thread akrejcir
Andrej Krejcir has posted comments on this change. Change subject: schema: fixing type of default values .. Patch Set 1: (1 comment) https://gerrit.ovirt.org/#/c/65113/1/lib/api/vdsm-api.yml File lib/api/vdsm-api.yml: PS1, Li

Change in vdsm[master]: net tests: bond tests fails on CI with ctypes.AttributeError

2016-10-06 Thread automation
gerrit-hooks has posted comments on this change. Change subject: net tests: bond tests fails on CI with ctypes.AttributeError .. Patch Set 5: * Update tracker: IGNORE, no Bug-Url found * Set MODIFIED::IGNORE, no Bug-Url found.

Change in vdsm[master]: net tests: bond tests fails on CI with ctypes.AttributeError

2016-10-06 Thread danken
Dan Kenigsberg has submitted this change and it was merged. Change subject: net tests: bond tests fails on CI with ctypes.AttributeError .. net tests: bond tests fails on CI with ctypes.AttributeError Quite often the marked tes

Change in vdsm[master]: net tests: bond tests fails on CI with ctypes.AttributeError

2016-10-06 Thread danken
Dan Kenigsberg has posted comments on this change. Change subject: net tests: bond tests fails on CI with ctypes.AttributeError .. Patch Set 4: Continuous-Integration+1 Unrelated failure in

Change in vdsm[master]: image: Calculate qcow volume size on import.

2016-10-06 Thread mlipchuk
Maor Lipchuk has posted comments on this change. Change subject: image: Calculate qcow volume size on import. .. Patch Set 1: (7 comments) https://gerrit.ovirt.org/#/c/65039/1/vdsm/storage/image.py File vdsm/storage/image.py:

Change in vdsm[master]: net tests: bond tests fails on CI with ctypes.AttributeError

2016-10-06 Thread danken
Dan Kenigsberg has posted comments on this change. Change subject: net tests: bond tests fails on CI with ctypes.AttributeError .. Patch Set 4: Code-Review+2 Verified+1 -- To view, visit https://gerrit.ovirt.org/64345 To unsub

Change in vdsm[master]: net tests: bond tests fails on CI with ctypes.AttributeError

2016-10-06 Thread automation
gerrit-hooks has posted comments on this change. Change subject: net tests: bond tests fails on CI with ctypes.AttributeError .. Patch Set 4: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, m

<    1   2