Change in vdsm[master]: py3: make gluster_cli_tests pass

2016-10-11 Thread rnachimu
Ramesh N has posted comments on this change. Change subject: py3: make gluster_cli_tests pass .. Patch Set 4: Code-Review+1 -- To view, visit https://gerrit.ovirt.org/65008 To unsubscribe, visit

Change in vdsm[master]: logging: Unify SimpleLogAdapter format

2016-10-11 Thread piotr . kliczewski
Piotr Kliczewski has posted comments on this change. Change subject: logging: Unify SimpleLogAdapter format .. Patch Set 2: Code-Review+1 -- To view, visit https://gerrit.ovirt.org/64227 To unsubscribe, visit

Change in vdsm[master]: logging: Improve log level alignment

2016-10-11 Thread piotr . kliczewski
Piotr Kliczewski has posted comments on this change. Change subject: logging: Improve log level alignment .. Patch Set 3: Code-Review+1 -- To view, visit https://gerrit.ovirt.org/64217 To unsubscribe, visit

Change in vdsm[master]: storage: Fix abort race in SDM.copy_data

2016-10-11 Thread automation
gerrit-hooks has posted comments on this change. Change subject: storage: Fix abort race in SDM.copy_data .. Patch Set 5: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header

Change in vdsm[master]: jobs: Fix abort semantics

2016-10-11 Thread automation
gerrit-hooks has posted comments on this change. Change subject: jobs: Fix abort semantics .. Patch Set 5: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url:

Change in vdsm[master]: qemuimg: Explicit run semantics for QemuImgOperation

2016-10-11 Thread automation
gerrit-hooks has posted comments on this change. Change subject: qemuimg: Explicit run semantics for QemuImgOperation .. Patch Set 5: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make

Change in vdsm[master]: jobs: Fix abort semantics

2016-10-11 Thread alitke
Adam Litke has posted comments on this change. Change subject: jobs: Fix abort semantics .. Patch Set 4: (6 comments) https://gerrit.ovirt.org/#/c/65102/4/lib/vdsm/jobs.py File lib/vdsm/jobs.py: Line 146 Line 147 Line 148

Change in vdsm[master]: v2v: support for block devices

2016-10-11 Thread fromani
Francesco Romani has posted comments on this change. Change subject: v2v: support for block devices .. Patch Set 4: Code-Review-1 Ooops, good catch Tomas. -- To view, visit https://gerrit.ovirt.org/64272 To unsubscribe,

Change in vdsm[master]: v2v: support for block devices

2016-10-11 Thread Tomas Golembiovsky
Tomas Golembiovsky has posted comments on this change. Change subject: v2v: support for block devices .. Patch Set 4: Code-Review-1 (1 comment) As pointed out by a user on ML the change breaks engine. VDSM fails to fetch

Change in vdsm[ovirt-4.0]: net: canonicalize IPv4 prefix to netmask

2016-10-11 Thread phoracek
Petr Horáček has posted comments on this change. Change subject: net: canonicalize IPv4 prefix to netmask .. Patch Set 3: Verified+1 (1 comment) Passed network/*_test.py and functional/networkTests.py OK. I added task to

Change in vdsm[ovirt-4.0.5]: virt: Make boolean values from boolean migration options

2016-10-11 Thread automation
gerrit-hooks has posted comments on this change. Change subject: virt: Make boolean values from boolean migration options .. Patch Set 2: * #1380822::Update tracker: OK * Set MODIFIED::bug 1380822#1380822OK -- To

Change in vdsm[ovirt-4.0.5]: virt: Make boolean values from boolean migration options

2016-10-11 Thread fromani
Francesco Romani has posted comments on this change. Change subject: virt: Make boolean values from boolean migration options .. Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.ovirt.org/65307 To unsubscribe,

Change in vdsm[ovirt-4.0.5]: virt: Don't crash in migration progress on compression bytes

2016-10-11 Thread automation
gerrit-hooks has posted comments on this change. Change subject: virt: Don't crash in migration progress on compression bytes .. Patch Set 2: * #1380822::Update tracker: OK * Set MODIFIED::bug 1380822#1380822IGNORE,

Change in vdsm[ovirt-4.0.5]: virt: Don't crash in migration progress on compression bytes

2016-10-11 Thread fromani
Francesco Romani has submitted this change and it was merged. Change subject: virt: Don't crash in migration progress on compression bytes .. virt: Don't crash in migration progress on compression bytes If compression is not

Change in vdsm[ovirt-4.0.5]: spec: Require selinux-policy-targeted for CephFS

2016-10-11 Thread automation
gerrit-hooks has posted comments on this change. Change subject: spec: Require selinux-policy-targeted for CephFS .. Patch Set 2: * #1365640::Update tracker: OK * #1303550::Update tracker: OK * Set MODIFIED::bug

Change in vdsm[ovirt-4.0.5]: virt: Make boolean values from boolean migration options

2016-10-11 Thread fromani
Francesco Romani has posted comments on this change. Change subject: virt: Make boolean values from boolean migration options .. Patch Set 1: Continuous-Integration+1 run 'make check' locally and independently -- To view,

Change in vdsm[ovirt-4.0.5]: virt: Make boolean values from boolean migration options

2016-10-11 Thread fromani
Francesco Romani has submitted this change and it was merged. Change subject: virt: Make boolean values from boolean migration options .. virt: Make boolean values from boolean migration options `compressed' and `autoConverge'

Change in vdsm[ovirt-4.0.5]: net: Consume ifcfg files that have a non vdsm standard name

2016-10-11 Thread fromani
Francesco Romani has submitted this change and it was merged. Change subject: net: Consume ifcfg files that have a non vdsm standard name .. net: Consume ifcfg files that have a non vdsm standard name VDSM assumes that the

Change in vdsm[ovirt-4.0.5]: spec: Require selinux-policy-targeted for CephFS

2016-10-11 Thread fromani
Francesco Romani has submitted this change and it was merged. Change subject: spec: Require selinux-policy-targeted for CephFS .. spec: Require selinux-policy-targeted for CephFS RHEL bug https://bugzilla.redhat.com/1365640

Change in vdsm[ovirt-4.0.5]: net: Consume ifcfg files that have a non vdsm standard name

2016-10-11 Thread automation
gerrit-hooks has posted comments on this change. Change subject: net: Consume ifcfg files that have a non vdsm standard name .. Patch Set 2: * #1367378::Update tracker: OK * Set MODIFIED::bug 1367378#1367378OK, already

Change in vdsm[ovirt-4.0.5]: net ifcfg: fix bond rollback

2016-10-11 Thread automation
gerrit-hooks has posted comments on this change. Change subject: net ifcfg: fix bond rollback .. Patch Set 2: * #1374194::Update tracker: OK * Set MODIFIED::bug 1374194#1374194IGNORE, not all related patches are

Change in vdsm[ovirt-4.0.5]: net ifcfg: fix bond rollback

2016-10-11 Thread fromani
Francesco Romani has submitted this change and it was merged. Change subject: net ifcfg: fix bond rollback .. net ifcfg: fix bond rollback When setupNetworks(NET, BOND) fails on NET configuration, BOND ifcfg file is removed,

Change in vdsm[ovirt-4.0.5]: virt: Make boolean values from boolean migration options

2016-10-11 Thread mzamazal
Milan Zamazal has posted comments on this change. Change subject: virt: Make boolean values from boolean migration options .. Patch Set 1: Code-Review+1 Verified+1 Verified that migration still works and the options values are

Change in vdsm[ovirt-4.0]: net: canonicalize IPv4 prefix to netmask

2016-10-11 Thread automation
gerrit-hooks has posted comments on this change. Change subject: net: canonicalize IPv4 prefix to netmask .. Patch Set 3: * #1374194::Update tracker: OK * Check Bug-Url::OK * Check Public Bug::#1374194::OK, public bug * Check

Change in vdsm[master]: net tests: minor libvirt_tests style refactoring

2016-10-11 Thread phoracek
Petr Horáček has posted comments on this change. Change subject: net tests: minor libvirt_tests style refactoring .. Patch Set 6: Verified+1 libvirt test passed OK -- To view, visit https://gerrit.ovirt.org/65091 To

Change in vdsm[master]: net tests: separate ifcfg and libvirt unit tests

2016-10-11 Thread phoracek
Petr Horáček has posted comments on this change. Change subject: net tests: separate ifcfg and libvirt unit tests .. Patch Set 6: Verified+1 (2 comments) Both tests passed.

Change in vdsm[master]: net: edit nic detached from bridge but still attached to a vlan

2016-10-11 Thread phoracek
Petr Horáček has posted comments on this change. Change subject: net: edit nic detached from bridge but still attached to a vlan .. Patch Set 1: I tried to, but it does not fail with dummy (only with system NIC), I don't know

Change in vdsm[master]: net: edit nic detached from bridge but still attached to a vlan

2016-10-11 Thread danken
Dan Kenigsberg has posted comments on this change. Change subject: net: edit nic detached from bridge but still attached to a vlan .. Patch Set 1: -Code-Review -- To view, visit https://gerrit.ovirt.org/65231 To unsubscribe,

Change in vdsm[ovirt-4.0]: api: Speed up schema loading

2016-10-11 Thread fromani
Francesco Romani has posted comments on this change. Change subject: api: Speed up schema loading .. Patch Set 1: assuming yaml.CLoader is available in the package we already depend on - some packagers may want to split into

Change in vdsm[ovirt-4.0]: api: Speed up schema loading

2016-10-11 Thread fromani
Francesco Romani has posted comments on this change. Change subject: api: Speed up schema loading .. Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.ovirt.org/65274 To unsubscribe, visit

Change in vdsm[ovirt-4.0]: api: Speed up schema loading

2016-10-11 Thread danken
Dan Kenigsberg has posted comments on this change. Change subject: api: Speed up schema loading .. Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.ovirt.org/65274 To unsubscribe, visit

Change in vdsm[master]: protocoldetector: Fix random double close

2016-10-11 Thread piotr . kliczewski
Piotr Kliczewski has posted comments on this change. Change subject: protocoldetector: Fix random double close .. Patch Set 1: (1 comment) https://gerrit.ovirt.org/#/c/65187/1/lib/vdsm/protocoldetector.py File

Change in vdsm[master]: clientIF: Fix reactor life cycle

2016-10-11 Thread piotr . kliczewski
Piotr Kliczewski has posted comments on this change. Change subject: clientIF: Fix reactor life cycle .. Patch Set 1: (1 comment) https://gerrit.ovirt.org/#/c/65188/1/tests/protocoldetectorTests.py File

Change in vdsm[master]: tests: Add tests for poll and wait failures

2016-10-11 Thread fromani
Francesco Romani has posted comments on this change. Change subject: tests: Add tests for poll and wait failures .. Patch Set 6: Code-Review+1 -- To view, visit https://gerrit.ovirt.org/65294 To unsubscribe, visit

Change in vdsm[master]: tests: Add test for terminating a terminated process

2016-10-11 Thread fromani
Francesco Romani has posted comments on this change. Change subject: tests: Add test for terminating a terminated process .. Patch Set 4: Code-Review+1 -- To view, visit https://gerrit.ovirt.org/65328 To unsubscribe, visit

Change in vdsm[master]: tests: Add tests for waiting on a zombie process

2016-10-11 Thread fromani
Francesco Romani has posted comments on this change. Change subject: tests: Add tests for waiting on a zombie process .. Patch Set 4: Code-Review+1 -- To view, visit https://gerrit.ovirt.org/65327 To unsubscribe, visit

Change in vdsm[master]: utils: Raise detectable error if termination fail

2016-10-11 Thread fromani
Francesco Romani has posted comments on this change. Change subject: utils: Raise detectable error if termination fail .. Patch Set 4: Code-Review+1 (1 comment) https://gerrit.ovirt.org/#/c/65325/4//COMMIT_MSG Commit Message:

Change in vdsm[master]: tests: Refine TerminationTests names

2016-10-11 Thread fromani
Francesco Romani has posted comments on this change. Change subject: tests: Refine TerminationTests names .. Patch Set 4: Code-Review+1 -- To view, visit https://gerrit.ovirt.org/65326 To unsubscribe, visit

Change in vdsm[master]: utils: Wait for terminated process

2016-10-11 Thread fromani
Francesco Romani has posted comments on this change. Change subject: utils: Wait for terminated process .. Patch Set 3: Code-Review+1 -- To view, visit https://gerrit.ovirt.org/65324 To unsubscribe, visit

Change in vdsm[master]: tests: Use Popen.poll() for running state

2016-10-11 Thread fromani
Francesco Romani has posted comments on this change. Change subject: tests: Use Popen.poll() for running state .. Patch Set 3: Code-Review+1 -- To view, visit https://gerrit.ovirt.org/65323 To unsubscribe, visit

Change in vdsm[master]: tests: Wait for child process in tearDown

2016-10-11 Thread fromani
Francesco Romani has posted comments on this change. Change subject: tests: Wait for child process in tearDown .. Patch Set 3: Code-Review+1 -- To view, visit https://gerrit.ovirt.org/65322 To unsubscribe, visit

Change in vdsm[master]: utils: Add missing Popen methods

2016-10-11 Thread fromani
Francesco Romani has posted comments on this change. Change subject: utils: Add missing Popen methods .. Patch Set 3: Code-Review+1 -- To view, visit https://gerrit.ovirt.org/65321 To unsubscribe, visit