gerrit-hooks has posted comments on this change.
Change subject: Add all MOM calls to jsonrpc client
..
Patch Set 1:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::OK
* Check Public Bug::#1373832::OK, public bug
*
gerrit-hooks has posted comments on this change.
Change subject: Fix return value names for VM.ioTune calls
..
Patch Set 1:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::OK
* Check Public Bug::#1373832::OK, public
Hello Piotr Kliczewski, Francesco Romani,
I'd like you to do a code review. Please visit
https://gerrit.ovirt.org/65378
to review the following change.
Change subject: Add all MOM calls to jsonrpc client
..
Add all MOM ca
gerrit-hooks has posted comments on this change.
Change subject: Fix return value names for VM.ioTune calls
..
Patch Set 4:
* Update tracker: IGNORE, no Bug-Url found
* Set MODIFIED::bug 1373832#1373832IGNORE, not all r
Francesco Romani has posted comments on this change.
Change subject: Fix return value names for VM.ioTune calls
..
Patch Set 3:
please backport again to the ovirt-4.0.5 branch if you want this in 4.0.5 -
otherwise will be in 4
Francesco Romani has submitted this change and it was merged.
Change subject: Add all MOM calls to jsonrpc client
..
Add all MOM calls to jsonrpc client
Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1373832
Change-Id: I9
Francesco Romani has posted comments on this change.
Change subject: Add all MOM calls to jsonrpc client
..
Patch Set 3:
please backport again to the ovirt-4.0.5 branch if you want this in 4.0.5 -
otherwise will be in 4.0.6 an
gerrit-hooks has posted comments on this change.
Change subject: Add all MOM calls to jsonrpc client
..
Patch Set 4:
* Update tracker: IGNORE, no Bug-Url found
* Set MODIFIED::bug 1373832#1373832::SKIPPED, The branch 'ovirt
Francesco Romani has submitted this change and it was merged.
Change subject: Fix return value names for VM.ioTune calls
..
Fix return value names for VM.ioTune calls
Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1373832
Francesco Romani has posted comments on this change.
Change subject: Add all MOM calls to jsonrpc client
..
Patch Set 3: Code-Review+2
--
To view, visit https://gerrit.ovirt.org/63479
To unsubscribe, visit https://gerrit.ovirt
Francesco Romani has posted comments on this change.
Change subject: Fix return value names for VM.ioTune calls
..
Patch Set 3: Code-Review+2
--
To view, visit https://gerrit.ovirt.org/63478
To unsubscribe, visit https://gerri
Ramesh N has posted comments on this change.
Change subject: py3: make gluster_cli_tests pass
..
Patch Set 4: Code-Review+1
--
To view, visit https://gerrit.ovirt.org/65008
To unsubscribe, visit https://gerrit.ovirt.org/settin
Piotr Kliczewski has posted comments on this change.
Change subject: logging: Unify SimpleLogAdapter format
..
Patch Set 2: Code-Review+1
--
To view, visit https://gerrit.ovirt.org/64227
To unsubscribe, visit https://gerrit.ov
Piotr Kliczewski has posted comments on this change.
Change subject: logging: Improve log level alignment
..
Patch Set 3: Code-Review+1
--
To view, visit https://gerrit.ovirt.org/64217
To unsubscribe, visit https://gerrit.ovir
gerrit-hooks has posted comments on this change.
Change subject: storage: Fix abort race in SDM.copy_data
..
Patch Set 5:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matc
gerrit-hooks has posted comments on this change.
Change subject: jobs: Fix abort semantics
..
Patch Set 5:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: '
gerrit-hooks has posted comments on this change.
Change subject: qemuimg: Explicit run semantics for QemuImgOperation
..
Patch Set 5:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure
Adam Litke has posted comments on this change.
Change subject: jobs: Fix abort semantics
..
Patch Set 4:
(6 comments)
https://gerrit.ovirt.org/#/c/65102/4/lib/vdsm/jobs.py
File lib/vdsm/jobs.py:
Line 146
Line 147
Line 148
Lin
Francesco Romani has posted comments on this change.
Change subject: v2v: support for block devices
..
Patch Set 4: Code-Review-1
Ooops, good catch Tomas.
--
To view, visit https://gerrit.ovirt.org/64272
To unsubscribe, visit
Tomas Golembiovsky has posted comments on this change.
Change subject: v2v: support for block devices
..
Patch Set 4: Code-Review-1
(1 comment)
As pointed out by a user on ML the change breaks engine. VDSM fails to fetch
disk
Petr Horáček has posted comments on this change.
Change subject: net: canonicalize IPv4 prefix to netmask
..
Patch Set 3: Verified+1
(1 comment)
Passed network/*_test.py and functional/networkTests.py OK.
I added task to impl
gerrit-hooks has posted comments on this change.
Change subject: virt: Make boolean values from boolean migration options
..
Patch Set 2:
* #1380822::Update tracker: OK
* Set MODIFIED::bug 1380822#1380822OK
--
To view
Francesco Romani has posted comments on this change.
Change subject: virt: Make boolean values from boolean migration options
..
Patch Set 1: Code-Review+2
--
To view, visit https://gerrit.ovirt.org/65307
To unsubscribe, visit
gerrit-hooks has posted comments on this change.
Change subject: virt: Don't crash in migration progress on compression bytes
..
Patch Set 2:
* #1380822::Update tracker: OK
* Set MODIFIED::bug 1380822#1380822IGNORE, not
Francesco Romani has submitted this change and it was merged.
Change subject: virt: Don't crash in migration progress on compression bytes
..
virt: Don't crash in migration progress on compression bytes
If compression is not en
gerrit-hooks has posted comments on this change.
Change subject: spec: Require selinux-policy-targeted for CephFS
..
Patch Set 2:
* #1365640::Update tracker: OK
* #1303550::Update tracker: OK
* Set MODIFIED::bug 1303550#130
Francesco Romani has posted comments on this change.
Change subject: virt: Make boolean values from boolean migration options
..
Patch Set 1: Continuous-Integration+1
run 'make check' locally and independently
--
To view, vis
Francesco Romani has submitted this change and it was merged.
Change subject: virt: Make boolean values from boolean migration options
..
virt: Make boolean values from boolean migration options
`compressed' and `autoConverge'
Francesco Romani has submitted this change and it was merged.
Change subject: net: Consume ifcfg files that have a non vdsm standard name
..
net: Consume ifcfg files that have a non vdsm standard name
VDSM assumes that the ifcf
Francesco Romani has submitted this change and it was merged.
Change subject: spec: Require selinux-policy-targeted for CephFS
..
spec: Require selinux-policy-targeted for CephFS
RHEL bug https://bugzilla.redhat.com/1365640 des
gerrit-hooks has posted comments on this change.
Change subject: net: Consume ifcfg files that have a non vdsm standard name
..
Patch Set 2:
* #1367378::Update tracker: OK
* Set MODIFIED::bug 1367378#1367378OK, already
gerrit-hooks has posted comments on this change.
Change subject: net ifcfg: fix bond rollback
..
Patch Set 2:
* #1374194::Update tracker: OK
* Set MODIFIED::bug 1374194#1374194IGNORE, not all related patches are
closed
Francesco Romani has submitted this change and it was merged.
Change subject: net ifcfg: fix bond rollback
..
net ifcfg: fix bond rollback
When setupNetworks(NET, BOND) fails on NET configuration, BOND ifcfg
file is removed, bu
Milan Zamazal has posted comments on this change.
Change subject: virt: Make boolean values from boolean migration options
..
Patch Set 1: Code-Review+1 Verified+1
Verified that migration still works and the options values are
gerrit-hooks has posted comments on this change.
Change subject: net: canonicalize IPv4 prefix to netmask
..
Patch Set 3:
* #1374194::Update tracker: OK
* Check Bug-Url::OK
* Check Public Bug::#1374194::OK, public bug
* Check P
Petr Horáček has posted comments on this change.
Change subject: net tests: minor libvirt_tests style refactoring
..
Patch Set 6: Verified+1
libvirt test passed OK
--
To view, visit https://gerrit.ovirt.org/65091
To unsubscri
Petr Horáček has posted comments on this change.
Change subject: net tests: separate ifcfg and libvirt unit tests
..
Patch Set 6: Verified+1
(2 comments)
Both tests passed.
https://gerrit.ovirt.org/#/c/65090/5/tests/Makefile.
Petr Horáček has posted comments on this change.
Change subject: net: edit nic detached from bridge but still attached to a vlan
..
Patch Set 1:
I tried to, but it does not fail with dummy (only with system NIC), I don't
know
Dan Kenigsberg has posted comments on this change.
Change subject: net: edit nic detached from bridge but still attached to a vlan
..
Patch Set 1: -Code-Review
--
To view, visit https://gerrit.ovirt.org/65231
To unsubscribe, v
Francesco Romani has posted comments on this change.
Change subject: api: Speed up schema loading
..
Patch Set 1:
assuming yaml.CLoader is available in the package we already depend on - some
packagers may want to split into a
Francesco Romani has posted comments on this change.
Change subject: api: Speed up schema loading
..
Patch Set 1: Code-Review+1
--
To view, visit https://gerrit.ovirt.org/65274
To unsubscribe, visit https://gerrit.ovirt.org/se
Dan Kenigsberg has posted comments on this change.
Change subject: api: Speed up schema loading
..
Patch Set 1: Code-Review+2
--
To view, visit https://gerrit.ovirt.org/65274
To unsubscribe, visit https://gerrit.ovirt.org/sett
Piotr Kliczewski has posted comments on this change.
Change subject: protocoldetector: Fix random double close
..
Patch Set 1:
(1 comment)
https://gerrit.ovirt.org/#/c/65187/1/lib/vdsm/protocoldetector.py
File lib/vdsm/protoco
Piotr Kliczewski has posted comments on this change.
Change subject: clientIF: Fix reactor life cycle
..
Patch Set 1:
(1 comment)
https://gerrit.ovirt.org/#/c/65188/1/tests/protocoldetectorTests.py
File tests/protocoldetectorT
44 matches
Mail list logo