Change in vdsm[master]: net: tests: Migrate testFailWithInvalidParams to the new fun...

2017-07-28 Thread Code Review
From Dan Kenigsberg : Dan Kenigsberg has submitted this change and it was merged. ( https://gerrit.ovirt.org/79905 ) Change subject: net: tests: Migrate testFailWithInvalidParams to the new func tests ..

Change in vdsm[master]: cmdutils: add env to exec_cmd()'s args

2017-07-28 Thread Code Review
From Dan Kenigsberg : Dan Kenigsberg has posted comments on this change. Change subject: cmdutils: add env to exec_cmd()'s args .. Patch Set 8: Verified+1 -- To view, visit https://gerrit.ovirt.org/79694

Change in vdsm[master]: hooking: move to lib

2017-07-28 Thread Code Review
From Dan Kenigsberg : Dan Kenigsberg has submitted this change and it was merged. ( https://gerrit.ovirt.org/79638 ) Change subject: hooking: move to lib .. hooking: move to lib As part of broader

Change in vdsm[master]: hooking: move to lib

2017-07-28 Thread Code Review
From Dan Kenigsberg : Dan Kenigsberg has posted comments on this change. Change subject: hooking: move to lib .. Patch Set 9: Code-Review+2 -- To view, visit https://gerrit.ovirt.org/79638 To unsubscribe,

Change in vdsm[master]: RPC: Fix tests in integration/jsonRpcTests.py

2017-07-28 Thread Code Review
From Dan Kenigsberg : Dan Kenigsberg has submitted this change and it was merged. ( https://gerrit.ovirt.org/79744 ) Change subject: RPC: Fix tests in integration/jsonRpcTests.py .. RPC: Fix tests in

Change in vdsm[master]: RPC: Fix tests in integration/jsonRpcTests.py

2017-07-28 Thread Code Review
From Dan Kenigsberg : Dan Kenigsberg has posted comments on this change. Change subject: RPC: Fix tests in integration/jsonRpcTests.py .. Patch Set 7: so very sorry, I forgot all about these tests. -- To

Change in vdsm[master]: move exec_sync_bytes to common.cmdutils.exec_cmd

2017-07-28 Thread Code Review
From Dan Kenigsberg : Dan Kenigsberg has posted comments on this change. Change subject: move exec_sync_bytes to common.cmdutils.exec_cmd .. Patch Set 8: Verified+1 -- To view, visit

Change in vdsm[master]: build: remove constants.py from dist package

2017-07-28 Thread Code Review
From Dan Kenigsberg : Dan Kenigsberg has posted comments on this change. Change subject: build: remove constants.py from dist package .. Patch Set 1: Tomas, can you suggest a test that would make sure we do

Change in vdsm[master]: net: tests: Migrate testFailWithInvalidParams to the new fun...

2017-07-28 Thread Code Review
From Dan Kenigsberg : Dan Kenigsberg has posted comments on this change. Change subject: net: tests: Migrate testFailWithInvalidParams to the new func tests .. Patch Set 2: Code-Review-1 requires manual

Change in vdsm[master]: net: tests: Migrate testFailWithInvalidIpConfig to the new f...

2017-07-28 Thread Code Review
From Dan Kenigsberg : Dan Kenigsberg has submitted this change and it was merged. ( https://gerrit.ovirt.org/79438 ) Change subject: net: tests: Migrate testFailWithInvalidIpConfig to the new func tests ..

Change in vdsm[master]: move hooks to common

2017-07-28 Thread Code Review
From Dan Kenigsberg : Dan Kenigsberg has posted comments on this change. Change subject: move hooks to common .. Patch Set 6: -Verified Thanks, I agree that my verification was a bit lazy. I'll do something