Dan Kenigsberg has posted comments on this change.
Change subject: tests: fix testGetBondingOptions
..
Patch Set 1: Code-Review+2
--
To view, visit https://gerrit.ovirt.org/63541
To unsubscribe, visit https://gerrit.ovirt.org/
Dan Kenigsberg has posted comments on this change.
Change subject: net tests: fix test_events_keys
..
Patch Set 1: Code-Review+2 Verified+1
test passes
--
To view, visit https://gerrit.ovirt.org/63539
To unsubscribe, visit ht
Dan Kenigsberg has posted comments on this change.
Change subject: tests: introducting broken_on_ci decorator
..
Patch Set 1: Code-Review+2
--
To view, visit https://gerrit.ovirt.org/63540
To unsubscribe, visit https://gerrit.
Dan Kenigsberg has submitted this change and it was merged.
Change subject: net tests: fix test_events_keys
..
net tests: fix test_events_keys
On Jenkins CI Fedora 23 this test sometimes fails because of missing
del_neigh event
Dan Kenigsberg has submitted this change and it was merged.
Change subject: build: Don't use fixed path to systemd directory
..
build: Don't use fixed path to systemd directory
Since commit 9d6f46d9 the project can no longer be
Dan Kenigsberg has posted comments on this change.
Change subject: storage: Unify stoage logger name
..
Patch Set 2: Code-Review+2
Oops, I've merged the follow-up readme before taking this one. I hope it is
verified soon.
--
Dan Kenigsberg has posted comments on this change.
Change subject: util: NoIntrPoll - replace time() with monotonic_time()
..
Patch Set 1: Code-Review+2
--
To view, visit https://gerrit.ovirt.org/63661
To unsubscribe, visit ht
Dan Kenigsberg has submitted this change and it was merged.
Change subject: util: NoIntrPoll - replace time() with monotonic_time()
..
util: NoIntrPoll - replace time() with monotonic_time()
Change-Id: I15dc7cc82ec196644612a119
Dan Kenigsberg has submitted this change and it was merged.
Change subject: rng: allow urandom as virtio rng entropy source
..
rng: allow urandom as virtio rng entropy source
Libvirt previously used a whitelist to only allow ra
Dan Kenigsberg has submitted this change and it was merged.
Change subject: readme.logging: Remove unneded storage hack
..
readme.logging: Remove unneded storage hack
All storage loggers were unified, there no need to call setL
Dan Kenigsberg has posted comments on this change.
Change subject: virt net: Disable special OVS handling for exteranal network
..
Patch Set 1: Code-Review-1
(1 comment)
https://gerrit.ovirt.org/#/c/63621/1/vdsm/virt/vm_migrat
Dan Kenigsberg has submitted this change and it was merged.
Change subject: logging: Improve logging when receiving signals
..
logging: Improve logging when receiving signals
Log INFO message when receiving signals, explaining
Dan Kenigsberg has submitted this change and it was merged.
Change subject: sd: Remove unused variable and evil thread
..
sd: Remove unused variable and evil thread
If storage domain had a non-null start instance variable, we u
Dan Kenigsberg has posted comments on this change.
Change subject: logging: Improve logging when receiving signals
..
Patch Set 1: Code-Review+2
--
To view, visit https://gerrit.ovirt.org/61289
To unsubscribe, visit https://ge
Dan Kenigsberg has posted comments on this change.
Change subject: sd: Remove unused variable and evil thread
..
Patch Set 3: Code-Review+2
should have been gone with 75ddec022648ec1a01bc8185e3f7541f9e6dbf4f
--
To view, visit
Dan Kenigsberg has posted comments on this change.
Change subject: spec: bridge-utils are required for tests
..
Patch Set 2: Code-Review+2
--
To view, visit https://gerrit.ovirt.org/62612
To unsubscribe, visit https://gerrit.o
Dan Kenigsberg has submitted this change and it was merged.
Change subject: net: early IP+link setup
..
net: early IP+link setup
Host networking must be available before libvirtd.service starts.
This cannot be handled by curren
Dan Kenigsberg has submitted this change and it was merged.
Change subject: net: Bond - preserve original slaves link state.
..
net: Bond - preserve original slaves link state.
Before attaching or removing a slave from a bond,
Dan Kenigsberg has posted comments on this change.
Change subject: net: Bond - preserve original slaves link state.
..
Patch Set 11: Code-Review+2
raising
--
To view, visit https://gerrit.ovirt.org/63446
To unsubscribe, visit
Dan Kenigsberg has submitted this change and it was merged.
Change subject: net: Bond - add refresh method to update bond config
..
net: Bond - add refresh method to update bond config
Change-Id: I6f36cc24833b0fc612c3af033c54c7
Dan Kenigsberg has posted comments on this change.
Change subject: net: Bond - Add logging to the bond driver.
..
Patch Set 11: Code-Review+2
raising
--
To view, visit https://gerrit.ovirt.org/63444
To unsubscribe, visit http
Dan Kenigsberg has submitted this change and it was merged.
Change subject: net: Bond - adding a transaction context.
..
net: Bond - adding a transaction context.
The bond transaction context is aimed to keep bonds in a control
Dan Kenigsberg has submitted this change and it was merged.
Change subject: net: Bond - Add logging to the bond driver.
..
net: Bond - Add logging to the bond driver.
Change-Id: I043a6232d59cd87f6b973d856df297322f4be387
Signed-
Dan Kenigsberg has posted comments on this change.
Change subject: net: Bond - add refresh method to update bond config
..
Patch Set 11: Code-Review+2
raising
--
To view, visit https://gerrit.ovirt.org/63445
To unsubscribe, v
Dan Kenigsberg has submitted this change and it was merged.
Change subject: net: Bond - Expose the (kernel) bond list.
..
net: Bond - Expose the (kernel) bond list.
Change-Id: I3ba2b9d5ec712b268cc3775682506ec83aabbdb8
Signed-of
Dan Kenigsberg has posted comments on this change.
Change subject: net: Bond - Expose the (kernel) bond list.
..
Patch Set 12: Code-Review+2
raising
--
To view, visit https://gerrit.ovirt.org/63234
To unsubscribe, visit https
Dan Kenigsberg has posted comments on this change.
Change subject: net: Bond - adding a transaction context.
..
Patch Set 11: Code-Review+2
raising
--
To view, visit https://gerrit.ovirt.org/63443
To unsubscribe, visit https:
Dan Kenigsberg has submitted this change and it was merged.
Change subject: net: Expose owned_device method through the configurator
..
net: Expose owned_device method through the configurator
Provide means to check if a device
Dan Kenigsberg has posted comments on this change.
Change subject: net: Expose owned_device method through the configurator
..
Patch Set 10: Code-Review+2
raising
--
To view, visit https://gerrit.ovirt.org/63442
To unsubscrib
Dan Kenigsberg has posted comments on this change.
Change subject: net: early IP+link setup
..
Patch Set 22: Code-Review+2
Raising score
--
To view, visit https://gerrit.ovirt.org/60371
To unsubscribe, visit https://gerrit.ov
Dan Kenigsberg has posted comments on this change.
Change subject: net: dhclient - address flush before starting and on shutdown
..
Patch Set 8: Code-Review+2
--
To view, visit https://gerrit.ovirt.org/63088
To unsubscribe, vi
Dan Kenigsberg has submitted this change and it was merged.
Change subject: net: dhclient - address flush before starting and on shutdown
..
net: dhclient - address flush before starting and on shutdown
Change-Id: I6e72f2aeb9f5
Dan Kenigsberg has submitted this change and it was merged.
Change subject: net: dhclient kill - early exit if iface does not exists
..
net: dhclient kill - early exit if iface does not exists
There is no need to lookup for dhc
Dan Kenigsberg has posted comments on this change.
Change subject: net: dhclient kill - early exit if iface does not exists
..
Patch Set 8: Code-Review+2
--
To view, visit https://gerrit.ovirt.org/63087
To unsubscribe, visit h
Dan Kenigsberg has posted comments on this change.
Change subject: net libvirt hook: Adjust hook to vmList report change.
..
Patch Set 1: Code-Review+2
--
To view, visit https://gerrit.ovirt.org/63542
To unsubscribe, visit htt
Dan Kenigsberg has submitted this change and it was merged.
Change subject: net libvirt hook: Adjust hook to vmList report change.
..
net libvirt hook: Adjust hook to vmList report change.
Patch 78ea853e131da3b91b812315a0656b8f
Dan Kenigsberg has posted comments on this change.
Change subject: rng: allow urandom as virtio rng entropy source
..
Patch Set 10: Code-Review+2
raising score
--
To view, visit https://gerrit.ovirt.org/59031
To unsubscribe,
Dan Kenigsberg has posted comments on this change.
Change subject: net: dhclient kill - early exit if iface does not exists
..
Patch Set 7: Code-Review-1
Please add the motivation for this patch in your commit message.
I don't
Dan Kenigsberg has submitted this change and it was merged.
Change subject: net: Introduce iface.exists and start using it in ip.dhclient
..
net: Introduce iface.exists and start using it in ip.dhclient
Change-Id: Ifcece92726e7
Dan Kenigsberg has posted comments on this change.
Change subject: net: Introduce iface.exists and start using it in ip.dhclient
..
Patch Set 6: Code-Review+2
raising score
--
To view, visit https://gerrit.ovirt.org/63086
To
Dan Kenigsberg has posted comments on this change.
Change subject: net: ifcfg - dhclient should always be stopped
..
Patch Set 13: Code-Review+2
horrible!
raising score regardless...
--
To view, visit https://gerrit.ovirt.org
Dan Kenigsberg has submitted this change and it was merged.
Change subject: net: ifcfg - dhclient should always be stopped
..
net: ifcfg - dhclient should always be stopped
While running functional tests, it has been observed t
Dan Kenigsberg has posted comments on this change.
Change subject: net: Expose disable IPv6 through ip.address module
..
Patch Set 12: Code-Review+2
raising score
--
To view, visit https://gerrit.ovirt.org/62830
To unsubscrib
Dan Kenigsberg has submitted this change and it was merged.
Change subject: net: Expose disable IPv6 through ip.address module
..
net: Expose disable IPv6 through ip.address module
Change-Id: I0673da939d575ab43d53cdb1fced4273db
Dan Kenigsberg has posted comments on this change.
Change subject: rng: allow urandom as virtio rng entropy source
..
Patch Set 9: Code-Review-1
(1 comment)
https://gerrit.ovirt.org/#/c/59031/9/lib/vdsm/host/rngsources.py
File
Dan Kenigsberg has posted comments on this change.
Change subject: rng: allow urandom as virtio rng entropy source
..
Patch Set 9: Continuous-Integration+1
FAIL: test_ip_info (network.netinfo_test.TestNetinfo)
indeed unrelated
Dan Kenigsberg has submitted this change and it was merged.
Change subject: net test: test_ip_info - Wait for IP setting to take affect
..
net test: test_ip_info - Wait for IP setting to take affect
test_ip_info is failing rand
Dan Kenigsberg has posted comments on this change.
Change subject: net test: test_ip_info - Wait for IP setting to take affect
..
Patch Set 1: Code-Review+2
--
To view, visit https://gerrit.ovirt.org/63516
To unsubscribe, visi
Dan Kenigsberg has posted comments on this change.
Change subject: tests: fix testGetBondingOptions
..
Patch Set 2: Code-Review+2
--
To view, visit https://gerrit.ovirt.org/63424
To unsubscribe, visit https://gerrit.ovirt.org/
Dan Kenigsberg has submitted this change and it was merged.
Change subject: tests: fix testGetBondingOptions
..
tests: fix testGetBondingOptions
Bonding options are reported only if they differ from defaults.
Bond 'mode' is exc
Dan Kenigsberg has submitted this change and it was merged.
Change subject: check-merged: switch fc24 to el7
..
check-merged: switch fc24 to el7
We used to run our functional tests using lago in check-merged
script over fc23. R
Dan Kenigsberg has submitted this change and it was merged.
Change subject: tests: introducting broken_on_ci decorator
..
tests: introducting broken_on_ci decorator
With this decorator we skip failed test only when it was execu
Dan Kenigsberg has posted comments on this change.
Change subject: tests: introducting broken_on_ci decorator
..
Patch Set 14: Code-Review+2
--
To view, visit https://gerrit.ovirt.org/63407
To unsubscribe, visit https://gerrit
Dan Kenigsberg has submitted this change and it was merged.
Change subject: jsonrpcvdscli: fix Host.getVMList command result
..
jsonrpcvdscli: fix Host.getVMList command result
Host.getVMList and Host.getFullVMList are similar
Dan Kenigsberg has posted comments on this change.
Change subject: py3: taskset.py/tasksetTests.py compliance.
..
Patch Set 12: Code-Review+2
--
To view, visit https://gerrit.ovirt.org/63223
To unsubscribe, visit https://gerri
Dan Kenigsberg has submitted this change and it was merged.
Change subject: py3: taskset.py/tasksetTests.py compliance.
..
py3: taskset.py/tasksetTests.py compliance.
tasksetTests.py: raw_values for test_online_cpus are now pro
Dan Kenigsberg has posted comments on this change.
Change subject: check-merged: switch fc24 to el7
..
Patch Set 6: Code-Review+2
raising Yaniv's score
--
To view, visit https://gerrit.ovirt.org/62352
To unsubscribe, visit ht
Dan Kenigsberg has posted comments on this change.
Change subject: tests: introducting broken_on_ci decorator
..
Patch Set 9: Code-Review+1
--
To view, visit https://gerrit.ovirt.org/63407
To unsubscribe, visit https://gerrit.
Dan Kenigsberg has posted comments on this change.
Change subject: net: ifcfg - dhclient should always be stopped
..
Patch Set 8: Code-Review+2
--
To view, visit https://gerrit.ovirt.org/62832
To unsubscribe, visit https://ger
Dan Kenigsberg has submitted this change and it was merged.
Change subject: net tests: fix test_events_keys
..
net tests: fix test_events_keys
On Jenkins CI Fedora 23 this test sometimes fails because of missing
del_neigh event
Dan Kenigsberg has posted comments on this change.
Change subject: tests: introducting broken_on_ci decorator
..
Patch Set 8:
Please mark the failing
ERROR: test_local_auto_with_dynamic_address_from_ra
(network.netinfo_test.T
Dan Kenigsberg has posted comments on this change.
Change subject: net tests: fix test_events_keys
..
Patch Set 1: Code-Review+2
--
To view, visit https://gerrit.ovirt.org/63406
To unsubscribe, visit https://gerrit.ovirt.org/s
Dan Kenigsberg has submitted this change and it was merged.
Change subject: tests: mom: create the socket under tmpdir
..
tests: mom: create the socket under tmpdir
Some tests may fail under automation if Vdsm
is built and its
Dan Kenigsberg has posted comments on this change.
Change subject: tests: mom: create the socket under tmpdir
..
Patch Set 2: Code-Review+2
--
To view, visit https://gerrit.ovirt.org/62779
To unsubscribe, visit https://gerrit.
Dan Kenigsberg has submitted this change and it was merged.
Change subject: Adding build-artifacts-manual.sh script
..
Adding build-artifacts-manual.sh script
Adding build-artifacts-manual.sh script and related
packages and rep
Dan Kenigsberg has posted comments on this change.
Change subject: Adding build-artifacts-manual.sh script
..
Patch Set 7: Code-Review+2
raising
--
To view, visit https://gerrit.ovirt.org/62560
To unsubscribe, visit https://g
Dan Kenigsberg has posted comments on this change.
Change subject: tests: split vmfakecon out of vmfakelib
..
Patch Set 1: Verified+1
unit tests still pass
--
To view, visit https://gerrit.ovirt.org/63197
To unsubscribe, visi
Dan Kenigsberg has submitted this change and it was merged.
Change subject: net test: Debug test_local_auto_with_dynamic_address_from_ra
..
net test: Debug test_local_auto_with_dynamic_address_from_ra
test_local_auto_with_dynam
Dan Kenigsberg has posted comments on this change.
Change subject: net test: Debug test_local_auto_with_dynamic_address_from_ra
..
Patch Set 1: Code-Review+2
--
To view, visit https://gerrit.ovirt.org/63334
To unsubscribe, vis
Dan Kenigsberg has posted comments on this change.
Change subject: misc: Remove log skipping infrastructure
..
Patch Set 4: Code-Review+2
--
To view, visit https://gerrit.ovirt.org/63267
To unsubscribe, visit https://gerrit.ov
Dan Kenigsberg has posted comments on this change.
Change subject: Fix makefile - move config.log to right location
..
Patch Set 3: Code-Review+2 Continuous-Integration+1
FAIL: test_events_keys (network.netlink_test.NetlinkEven
Dan Kenigsberg has submitted this change and it was merged.
Change subject: Fix makefile - move config.log to right location
..
Fix makefile - move config.log to right location
Probably by mistake config.log was declared in wro
Dan Kenigsberg has submitted this change and it was merged.
Change subject: tests: py3: commands_tests.py compliance
..
tests: py3: commands_tests.py compliance
decode byte string before checking for equality to string literal
Dan Kenigsberg has submitted this change and it was merged.
Change subject: jsonrpcvdscli: added VM cont verb
..
jsonrpcvdscli: added VM cont verb
VM.cont is needed in order to resume paused VMs
Change-Id: I0f740c83517850251f2
Dan Kenigsberg has posted comments on this change.
Change subject: misc: Remove log skipping infrastructure
..
Patch Set 3: Code-Review+1
(1 comment)
https://gerrit.ovirt.org/#/c/63267/3//COMMIT_MSG
Commit Message:
Line 8:
L
Dan Kenigsberg has submitted this change and it was merged.
Change subject: tests: install fake-virt-v2v.err to fix tests
..
tests: install fake-virt-v2v.err to fix tests
In commit 985cbe87077512adf1ff594841b7f79674d451fc new f
Dan Kenigsberg has posted comments on this change.
Change subject: tests: install fake-virt-v2v.err to fix tests
..
Patch Set 3: Code-Review+2 Continuous-Integration+1
ignoring evil, yet unrelated network test failure.
--
To
Dan Kenigsberg has posted comments on this change.
Change subject: jsonvdscli: change hostname default
..
Patch Set 6: Code-Review+2
--
To view, visit https://gerrit.ovirt.org/61782
To unsubscribe, visit https://gerrit.ovirt.o
Dan Kenigsberg has submitted this change and it was merged.
Change subject: jsonvdscli: change hostname default
..
jsonvdscli: change hostname default
We want to mitigate dns lookups due to potential issues with
connectivity or
Dan Kenigsberg has posted comments on this change.
Change subject: stomp: improve message id handling during response send
..
Patch Set 2: Code-Review+2
raising score
--
To view, visit https://gerrit.ovirt.org/49185
To unsubs
Dan Kenigsberg has submitted this change and it was merged.
Change subject: stomp: improve message id handling during response send
..
stomp: improve message id handling during response send
Signed-off-by: pkliczewski
Change-I
Dan Kenigsberg has posted comments on this change.
Change subject: ovs: add OVS bridges cleanup to shell_helper
..
Patch Set 6: Code-Review+2
passed tier1+2 by meni
--
To view, visit https://gerrit.ovirt.org/61688
To unsubscr
Dan Kenigsberg has submitted this change and it was merged.
Change subject: ovs: copy NIC hwaddr to NB
..
ovs: copy NIC hwaddr to NB
In order to receive the same IP for network as acquired NIC used to
have, we must copy NIC's h
Dan Kenigsberg has posted comments on this change.
Change subject: ovs: use vdsmbr_test name for test bridges
..
Patch Set 3: Code-Review+2
passed tier1+2 by meni
--
To view, visit https://gerrit.ovirt.org/62303
To unsubscrib
Dan Kenigsberg has posted comments on this change.
Change subject: ovs: copy NIC hwaddr to NB
..
Patch Set 4: Code-Review+2
passed tier1+2 by meni
--
To view, visit https://gerrit.ovirt.org/62031
To unsubscribe, visit https:/
Dan Kenigsberg has submitted this change and it was merged.
Change subject: ovs: add OVS bridges cleanup to shell_helper
..
ovs: add OVS bridges cleanup to shell_helper
Change-Id: I55addefb42550d88c83548ca31a94e40b7e47184
Bug-U
Dan Kenigsberg has submitted this change and it was merged.
Change subject: ovs: use vdsmbr_test name for test bridges
..
ovs: use vdsmbr_test name for test bridges
We should use the same prefix as for 'real' OVS bridge, so we
Dan Kenigsberg has submitted this change and it was merged.
Change subject: net: introduce acquire module
..
net: introduce acquire module
This module will be used to acquire ifaces, both persisted by ifcfg and
not persisted. I
Dan Kenigsberg has submitted this change and it was merged.
Change subject: test: Introduce mock module for testing
..
test: Introduce mock module for testing
Mock is part of py3 std lib (under unittest package) with enhanced
f
Dan Kenigsberg has posted comments on this change.
Change subject: net: introduce acquire module
..
Patch Set 5: Code-Review+2
passed tier1+2 by meni
--
To view, visit https://gerrit.ovirt.org/61955
To unsubscribe, visit http
Dan Kenigsberg has posted comments on this change.
Change subject: net: Introduce dhclient state check.
..
Patch Set 3: Code-Review+2
passed tier1+2 by meni
--
To view, visit https://gerrit.ovirt.org/62302
To unsubscribe, vis
Dan Kenigsberg has posted comments on this change.
Change subject: ovs: acquire ifaces
..
Patch Set 5: Code-Review+2
passed tier1+2 by meni
--
To view, visit https://gerrit.ovirt.org/61956
To unsubscribe, visit https://gerrit
Dan Kenigsberg has submitted this change and it was merged.
Change subject: net: Introduce dhclient state check.
..
net: Introduce dhclient state check.
Introduce dhclient.is_active.
To be used by caps (next patch) to report dh
Dan Kenigsberg has submitted this change and it was merged.
Change subject: ovs: acquire ifaces
..
ovs: acquire ifaces
Switch returns list of used devices, on upper level we should
check if they are owned by us and if not, aqui
Dan Kenigsberg has posted comments on this change.
Change subject: test: Introduce mock module for testing
..
Patch Set 4: Code-Review+2
passed tier1+2 by meni
--
To view, visit https://gerrit.ovirt.org/62279
To unsubscribe,
Dan Kenigsberg has submitted this change and it was merged.
Change subject: utils: atomic file write
..
utils: atomic file write
Atomic writes are needed for safe file editation. This function will
be used in following network
Dan Kenigsberg has posted comments on this change.
Change subject: ovs: use Setup class directly
..
Patch Set 6: Code-Review+2
passed tier1+2 by meni
--
To view, visit https://gerrit.ovirt.org/61686
To unsubscribe, visit http
Dan Kenigsberg has submitted this change and it was merged.
Change subject: ovs: use Setup class directly
..
ovs: use Setup class directly
We will need access to Setup instance in netswitch.py with next
patch.
Change-Id: I2fa6
Dan Kenigsberg has uploaded a new change for review.
Change subject: tests: unbreake testV2VOutput
..
tests: unbreake testV2VOutput
Change-Id: Ifc749a5580de712b2eea954afa78e69722d13619
Signed-off-by: Dan Kenigsberg
---
M tests/
Dan Kenigsberg has posted comments on this change.
Change subject: storage: py3: misc.py compliance
..
Patch Set 5:
(1 comment)
https://gerrit.ovirt.org/#/c/63192/5/lib/vdsm/storage/misc.py
File lib/vdsm/storage/misc.py:
Line
401 - 500 of 21419 matches
Mail list logo
