Change in vdsm[master]: libvirtvm.py: Extend controller support to allow configuring...

Hans De Goede has posted comments on this change. Change subject: libvirtvm.py: Extend controller support to allow configuring USB controllers .. Patch Set 3: (2 inline comments)

Change in vdsm[master]: Add support for redir devices

Hans De Goede has posted comments on this change. Change subject: Add support for redir devices .. Patch Set 2: Hi again, I'm sorry my review comment from yesterday may have been a bit harsh. It is just that I'm a bit

Change in vdsm[master]: Add support for redir devices

Hans De Goede has posted comments on this change. Change subject: Add support for redir devices .. Patch Set 2: WRT specParams, I believe that the engine then just needs to be changed to pass parameters which are now inside

Change in vdsm[master]: libvirtvm.py: Extend controller support to allow configuring...

Hans De Goede has posted comments on this change. Change subject: libvirtvm.py: Extend controller support to allow configuring USB controllers .. Patch Set 3: Correct, the engine would need to provide a master dict, with a

Change in vdsm[master]: vdsClient.py: Allow specifying nested dicts for devices when...

Hans De Goede has posted comments on this change. Change subject: vdsClient.py: Allow specifying nested dicts for devices when creating a vm .. Patch Set 1: (5 inline comments)

Change in vdsm[master]: libvirtvm.py: Refactor device xml generation

Hans De Goede has posted comments on this change. Change subject: libvirtvm.py: Refactor device xml generation .. Patch Set 1: (2 inline comments) File vdsm/libvirtvm.py

Change in vdsm[master]: libvirtvm.py: Extend controller support to allow configuring...

Hans De Goede has posted comments on this change. Change subject: libvirtvm.py: Extend controller support to allow configuring USB controllers .. Patch Set 2: (1 inline comment)

Change in vdsm[master]: vdsClient.py: Allow specifying nested dicts for devices when...

Hans De Goede has posted comments on this change. Change subject: vdsClient.py: Allow specifying nested dicts for devices when creating a vm .. Patch Set 2: Verified Tested and works for me. -- To view, visit

Change in vdsm[master]: vm.py: Fix legacy disk support

Hans De Goede has posted comments on this change. Change subject: vm.py: Fix legacy disk support .. Patch Set 1: Verified Tested and works for me. -- To view, visit http://gerrit.ovirt.org/4093 To unsubscribe, visit

Change in vdsm[master]: libvirtvm.py: Remove unnecessary constructor overriding

Hans De Goede has posted comments on this change. Change subject: libvirtvm.py: Remove unnecessary constructor overriding .. Patch Set 2: Verified Tested and works for me. -- To view, visit http://gerrit.ovirt.org/4131 To

Change in vdsm[master]: libvirtvm.py: Refactor device xml generation

Hans De Goede has posted comments on this change. Change subject: libvirtvm.py: Refactor device xml generation .. Patch Set 2: Verified (1 inline comment) Tested and works for me.

Change in vdsm[master]: libvirtvm.py: Extend controller support to allow configuring...

Hans De Goede has posted comments on this change. Change subject: libvirtvm.py: Extend controller support to allow configuring USB controllers .. Patch Set 3: Verified Tested and works for me. -- To view, visit

Change in vdsm[master]: Add support for redir devices

Hans De Goede has posted comments on this change. Change subject: Add support for redir devices .. Patch Set 2: Verified Tested and works for me. -- To view, visit http://gerrit.ovirt.org/4133 To unsubscribe, visit

Change in vdsm[master]: libvirtvm.py: Refactor device xml generation

Hans De Goede has uploaded a new change for review. Change subject: libvirtvm.py: Refactor device xml generation .. libvirtvm.py: Refactor device xml generation To remove a lot of code duplication and making adding new device

Change in vdsm[master]: libvirtvm.py: Remove unnecessary constructor overriding

Hans De Goede has uploaded a new change for review. Change subject: libvirtvm.py: Remove unnecessary constructor overriding .. libvirtvm.py: Remove unnecessary constructor overriding Change-Id:

Change in vdsm[master]: Add support for redir devices

Hans De Goede has uploaded a new change for review. Change subject: Add support for redir devices .. Add support for redir devices With this patch it is possible to create vms setup for usb redirection with vdsm, ie: vdsClient

Change in vdsm[master]: libvirtvm.py: Extend controller support to allow configuring...

Hans De Goede has posted comments on this change. Change subject: libvirtvm.py: Extend controller support to allow configuring USB controllers .. Patch Set 2: Yes we also need redirdev support, see the new version of the set

Change in vdsm[master]: vm.py: Fix legacy disk support

Hans De Goede has uploaded a new change for review. Change subject: vm.py: Fix legacy disk support .. vm.py: Fix legacy disk support Creating vms with legacy disk parameters, ie hda=/path/disk.img would fail with a backtrace in

Change in vdsm[master]: vdsClient.py: Allow specifying nested dicts for devices when...

Hans De Goede has uploaded a new change for review. Change subject: vdsClient.py: Allow specifying nested dicts for devices when creating a vm .. vdsClient.py: Allow specifying nested dicts for devices when creating a vm With

Change in vdsm[master]: libvirtvm.py: Extend controller support to allow configuring...

Hans De Goede has uploaded a new change for review. Change subject: libvirtvm.py: Extend controller support to allow configuring USB controllers .. libvirtvm.py: Extend controller support to allow configuring USB controllers