Idan Shaby has posted comments on this change.
Change subject: storage: add discard support for vm disks
..
Patch Set 1:
I am not sure that it is a good idea. If we wouldn't have the problem with WAD
vs passDiscard, maybe we c
Idan Shaby has uploaded a new change for review.
Change subject: storage: add discard support for vm disks
..
storage: add discard support for vm disks
When the engine sends the field 'passDiscard' with the value 'true' as
one o
Idan Shaby has posted comments on this change.
Change subject: multipath: getDeviceDiscardMaxBytes return type
..
Patch Set 3: Verified+1
(3 comments)
https://gerrit.ovirt.org/#/c/62799/2//COMMIT_MSG
Commit Message:
Line 8:
Idan Shaby has posted comments on this change.
Change subject: hsm: add getVGInfo discard related fields
..
Patch Set 2:
(1 comment)
https://gerrit.ovirt.org/#/c/62800/2/vdsm/storage/hsm.py
File vdsm/storage/hsm.py:
Line 2807
Idan Shaby has posted comments on this change.
Change subject: multipath: getDeviceDiscardMaxBytes return type
..
Patch Set 2:
(1 comment)
https://gerrit.ovirt.org/#/c/62799/2//COMMIT_MSG
Commit Message:
Line 9: Since /sys/bl
Idan Shaby has posted comments on this change.
Change subject: hsm: add getVGInfo discard related fields
..
Patch Set 2: Verified+1
--
To view, visit https://gerrit.ovirt.org/62800
To unsubscribe, visit https://gerrit.ovirt.or
Idan Shaby has posted comments on this change.
Change subject: multipath: getDeviceDiscardMaxBytes return type
..
Patch Set 2: Verified+1
--
To view, visit https://gerrit.ovirt.org/62799
To unsubscribe, visit https://gerrit.ov
Idan Shaby has uploaded a new change for review.
Change subject: hsm: add getVGInfo discard related fields
..
hsm: add getVGInfo discard related fields
Patch I7ff47 added the fields discard_max_bytes and discard_zeroes_data
to g
Idan Shaby has uploaded a new change for review.
Change subject: multipath: getDeviceDiscardMaxBytes return type
..
multipath: getDeviceDiscardMaxBytes return type
Since /sys/block/dm-X/queue/discard_max_bytes may return more th
Idan Shaby has posted comments on this change.
Change subject: mount: Support NFS4 mounts with double slash
..
Patch Set 2: Verified+1
--
To view, visit https://gerrit.ovirt.org/61581
To unsubscribe, visit https://gerrit.ovirt
Idan Shaby has posted comments on this change.
Change subject: fileUtils: Normalize initial double slashes
..
Patch Set 2: Verified+1
--
To view, visit https://gerrit.ovirt.org/61580
To unsubscribe, visit https://gerrit.ovirt.
Idan Shaby has posted comments on this change.
Change subject: Remove _udevrulesdir global macro
..
Patch Set 3: Verified+1
--
To view, visit https://gerrit.ovirt.org/62196
To unsubscribe, visit https://gerrit.ovirt.org/settin
Idan Shaby has posted comments on this change.
Change subject: Revert "Using %{_libdir} macro instead of /usr/lib"
..
Patch Set 1: Verified+1
--
To view, visit https://gerrit.ovirt.org/62196
To unsubscribe, visit https://gerri
Idan Shaby has uploaded a new change for review.
Change subject: Revert "Using %{_libdir} macro instead of /usr/lib"
..
Revert "Using %{_libdir} macro instead of /usr/lib"
This reverts commit 271dd9bca1288e732f8d80d98a3d022e5c46
Idan Shaby has posted comments on this change.
Change subject: fileUtils: Normalize initial double slashes
..
Patch Set 2: Code-Review+1 Verified+1
--
To view, visit https://gerrit.ovirt.org/61578
To unsubscribe, visit https:/
Idan Shaby has posted comments on this change.
Change subject: mount: Support NFS4 mounts with double slash
..
Patch Set 2: Code-Review+1 Verified+1
--
To view, visit https://gerrit.ovirt.org/61579
To unsubscribe, visit https:
Idan Shaby has posted comments on this change.
Change subject: blockSD: fix rebase error of commit dd3306d
..
Patch Set 1: Verified+1
--
To view, visit https://gerrit.ovirt.org/61346
To unsubscribe, visit https://gerrit.ovirt.
Idan Shaby has posted comments on this change.
Change subject: blockSD: fix rebase error of commit dd3306d
..
Patch Set 1: Verified+1
--
To view, visit https://gerrit.ovirt.org/61342
To unsubscribe, visit https://gerrit.ovirt.
Idan Shaby has uploaded a new change for review.
Change subject: blockSD: fix rebase error of commit dd3306d
..
blockSD: fix rebase error of commit dd3306d
A faulty rebase of commit dd3306d accidently removed an exception
raise
Idan Shaby has posted comments on this change.
Change subject: storage: add getDeviceList discard related fields
..
Patch Set 4: Verified+1
--
To view, visit https://gerrit.ovirt.org/60628
To unsubscribe, visit https://gerrit.
Idan Shaby has posted comments on this change.
Change subject: multipath: add the read_int helper function
..
Patch Set 3: Verified+1
--
To view, visit https://gerrit.ovirt.org/60856
To unsubscribe, visit https://gerrit.ovirt.
Idan Shaby has posted comments on this change.
Change subject: multipath: add a constant for /sys/block
..
Patch Set 2: Verified+1
--
To view, visit https://gerrit.ovirt.org/60854
To unsubscribe, visit https://gerrit.ovirt.org
Idan Shaby has posted comments on this change.
Change subject: multipath: add a constant for the queue subpath
..
Patch Set 2: Verified+1
--
To view, visit https://gerrit.ovirt.org/60855
To unsubscribe, visit https://gerrit.ov
Idan Shaby has posted comments on this change.
Change subject: multipath: add the read_int helper function
..
Patch Set 2:
(2 comments)
https://gerrit.ovirt.org/#/c/60856/1//COMMIT_MSG
Commit Message:
Line 3: AuthorDate: 2016
Idan Shaby has posted comments on this change.
Change subject: storage: add getDeviceList discard related fields
..
Patch Set 3:
(1 comment)
https://gerrit.ovirt.org/#/c/60628/2/vdsm/storage/hsm.py
File vdsm/storage/hsm.py:
L
Idan Shaby has uploaded a new change for review.
Change subject: multipath: add a constant for the queue subpath
..
multipath: add a constant for the queue subpath
Change-Id: I2d0296c97a4f6bd8793c9172f3e413a2384c1e0d
Signed-off-
Idan Shaby has posted comments on this change.
Change subject: storage: add getDeviceList discard related fields
..
Patch Set 2:
(3 comments)
https://gerrit.ovirt.org/#/c/60628/1/vdsm/storage/hsm.py
File vdsm/storage/hsm.py:
Idan Shaby has uploaded a new change for review.
Change subject: multipath: add the readInt helper function
..
multipath: add the readInt helper function
This patch adds a new function that reads the first line of a file noted
b
Idan Shaby has uploaded a new change for review.
Change subject: multipath: add a constant for /sys/block
..
multipath: add a constant for /sys/block
Change-Id: I09bb76de212b9022b7fe6952f188d125aa802260
Signed-off-by: Idan Shaby
Idan Shaby has posted comments on this change.
Change subject: storage: add getDeviceList discard related fields
..
Patch Set 1:
The patches that use it are not yet there, but I plan to keep the storage
domain up to date, i.e
Idan Shaby has posted comments on this change.
Change subject: storage: add getDeviceList discard related fields
..
Patch Set 1:
(1 comment)
https://gerrit.ovirt.org/#/c/60628/1/vdsm/storage/multipath.py
File vdsm/storage/mult
Idan Shaby has uploaded a new change for review.
Change subject: storage: add getDeviceList discard related fields
..
storage: add getDeviceList discard related fields
This patch adds getDeviceList two discard related fields:
1.
Idan Shaby has posted comments on this change.
Change subject: storage: fix spec normalization when mounting
..
Patch Set 17:
This patch set contains two failing tests:
1. storageServerTests.py:MountConnectionTests.test_normali
Idan Shaby has posted comments on this change.
Change subject: storage: fix spec normalization when mounting
..
Patch Set 17: Code-Review-1
--
To view, visit https://gerrit.ovirt.org/55182
To unsubscribe, visit https://gerrit.
Idan Shaby has abandoned this change.
Change subject: storage: move iscsi.py to vdsm storage lib
..
Abandoned
Abandoning this patch due to inability to merge it in a reasonable time.
--
To view, visit https://gerrit.ovirt.org
Idan Shaby has abandoned this change.
Change subject: storage: move imageSharing.py to vdsm storage lib
..
Abandoned
Abandoning this patch due to inability to merge it in a reasonable time.
--
To view, visit https://gerrit.ov
Idan Shaby has abandoned this change.
Change subject: storage: organize imports in iscsi.py
..
Abandoned
Abandoning this patch due to inability to merge it in a reasonable time.
--
To view, visit https://gerrit.ovirt.org/5689
Idan Shaby has abandoned this change.
Change subject: storage: move imagetickets.py to vdsm storage lib
..
Abandoned
Abandoning this patch due to inability to merge it in a reasonable time.
--
To view, visit https://gerrit.ov
Idan Shaby has abandoned this change.
Change subject: storage: move iscsiadm.py to vdsm storage lib
..
Abandoned
Abandoning this patch due to inability to merge it in a reasonable time.
--
To view, visit https://gerrit.ovirt.
Idan Shaby has abandoned this change.
Change subject: storage: organize imports in iscsiadm.py
..
Abandoned
Abandoning this patch due to inability to merge it in a reasonable time.
--
To view, visit https://gerrit.ovirt.org/5
Idan Shaby has abandoned this change.
Change subject: storage: organize imports in imageSharing.py
..
Abandoned
Abandoning this patch due to inability to merge it in a reasonable time.
--
To view, visit https://gerrit.ovirt.o
Idan Shaby has abandoned this change.
Change subject: storage: organize imports in devicemapper.py
..
Abandoned
Abandoning this patch due to inability to merge it in a reasonable time.
--
To view, visit https://gerrit.ovirt.o
Idan Shaby has abandoned this change.
Change subject: storage: move devicemapper.py to vdsm storage lib
..
Abandoned
Abandoning this patch due to inability to merge it in a reasonable time.
--
To view, visit https://gerrit.ov
Idan Shaby has abandoned this change.
Change subject: storage: move hba.py to vdsm storage lib
..
Abandoned
Abandoning this patch due to inability to merge it in a reasonable time.
--
To view, visit https://gerrit.ovirt.org/5
Idan Shaby has abandoned this change.
Change subject: storage: move curlImgWrap.py to vdsm storage lib
..
Abandoned
Abandoning this patch due to inability to merge it in a reasonable time.
--
To view, visit https://gerrit.ovi
Idan Shaby has posted comments on this change.
Change subject: storage: fix spec normalization when mounting
..
Patch Set 16: Code-Review-1
This patch does not take into consideration using a port after the host name,
i.e a re
Idan Shaby has posted comments on this change.
Change subject: storage: move iscsi.py to vdsm storage lib
..
Patch Set 4: Verified+1
--
To view, visit https://gerrit.ovirt.org/56896
To unsubscribe, visit https://gerrit.ovirt.o
Idan Shaby has posted comments on this change.
Change subject: storage: organize imports in iscsi.py
..
Patch Set 4: Verified+1
--
To view, visit https://gerrit.ovirt.org/56895
To unsubscribe, visit https://gerrit.ovirt.org/se
Idan Shaby has posted comments on this change.
Change subject: storage: move hba.py to vdsm storage lib
..
Patch Set 4: Verified+1
--
To view, visit https://gerrit.ovirt.org/56889
To unsubscribe, visit https://gerrit.ovirt.org
Idan Shaby has posted comments on this change.
Change subject: storage: move devicemapper.py to vdsm storage lib
..
Patch Set 4: Verified+1
--
To view, visit https://gerrit.ovirt.org/56888
To unsubscribe, visit https://gerrit.
Idan Shaby has posted comments on this change.
Change subject: storage: move misc module to vdsm storage lib
..
Patch Set 8: Verified+1
--
To view, visit https://gerrit.ovirt.org/56614
To unsubscribe, visit https://gerrit.ovir
Idan Shaby has posted comments on this change.
Change subject: storagetests: add a test for normalize_local_path
..
Patch Set 11: Verified+1
--
To view, visit https://gerrit.ovirt.org/55181
To unsubscribe, visit https://gerrit
Idan Shaby has posted comments on this change.
Change subject: storage: move iscsi.py to vdsm storage lib
..
Patch Set 2: Verified+1
--
To view, visit https://gerrit.ovirt.org/56896
To unsubscribe, visit https://gerrit.ovirt.o
Idan Shaby has posted comments on this change.
Change subject: storage: move imagetickets.py to vdsm storage lib
..
Patch Set 2: Verified+1
--
To view, visit https://gerrit.ovirt.org/56892
To unsubscribe, visit https://gerrit.
Idan Shaby has posted comments on this change.
Change subject: storage: move iscsiadm.py to vdsm storage lib
..
Patch Set 2: Verified+1
--
To view, visit https://gerrit.ovirt.org/56894
To unsubscribe, visit https://gerrit.ovir
Idan Shaby has posted comments on this change.
Change subject: storage: move hba.py to vdsm storage lib
..
Patch Set 2: Verified+1
--
To view, visit https://gerrit.ovirt.org/56889
To unsubscribe, visit https://gerrit.ovirt.org
Idan Shaby has posted comments on this change.
Change subject: storage: move imageSharing.py to vdsm storage lib
..
Patch Set 2: Verified+1
--
To view, visit https://gerrit.ovirt.org/56891
To unsubscribe, visit https://gerrit.
Idan Shaby has posted comments on this change.
Change subject: storage: move devicemapper.py to vdsm storage lib
..
Patch Set 2: Verified+1
--
To view, visit https://gerrit.ovirt.org/56888
To unsubscribe, visit https://gerrit.
Idan Shaby has posted comments on this change.
Change subject: storage: move misc module to vdsm storage lib
..
Patch Set 6: Verified+1
--
To view, visit https://gerrit.ovirt.org/56614
To unsubscribe, visit https://gerrit.ovir
Idan Shaby has posted comments on this change.
Change subject: storage: add support for blkdiscard command
..
Patch Set 6: Code-Review-1 -Verified
Yaniv, a parameter can always be added to the method, and then appended to the
Idan Shaby has posted comments on this change.
Change subject: blockSD: fix log message in zeroImgVolumes
..
Patch Set 1: Verified+1
--
To view, visit https://gerrit.ovirt.org/57000
To unsubscribe, visit https://gerrit.ovirt.o
Idan Shaby has uploaded a new change for review.
Change subject: blockSD: fix log message in zeroImgVolumes
..
blockSD: fix log message in zeroImgVolumes
When logging a debug message regarding a volume that has been zeroed, we
a
Idan Shaby has posted comments on this change.
Change subject: storage: add support for blkdiscard command
..
Patch Set 6: Verified+1
(1 comment)
https://gerrit.ovirt.org/#/c/35629/5/tests/Makefile.am
File tests/Makefile.am:
Idan Shaby has posted comments on this change.
Change subject: storage: add support for blkdiscard command
..
Patch Set 4: Verified+1
--
To view, visit https://gerrit.ovirt.org/35629
To unsubscribe, visit https://gerrit.ovirt.
Idan Shaby has posted comments on this change.
Change subject: storage: organize imports in iscsi.py
..
Patch Set 1: Verified+1
--
To view, visit https://gerrit.ovirt.org/56895
To unsubscribe, visit https://gerrit.ovirt.org/se
Idan Shaby has posted comments on this change.
Change subject: storage: organize imports in imageSharing.py
..
Patch Set 1: Verified+1
--
To view, visit https://gerrit.ovirt.org/56890
To unsubscribe, visit https://gerrit.ovirt
Idan Shaby has posted comments on this change.
Change subject: storage: organize imports in iscsiadm.py
..
Patch Set 1: Verified+1
--
To view, visit https://gerrit.ovirt.org/56893
To unsubscribe, visit https://gerrit.ovirt.org
Idan Shaby has posted comments on this change.
Change subject: storage: organize imports in devicemapper.py
..
Patch Set 1: Verified+1
--
To view, visit https://gerrit.ovirt.org/56887
To unsubscribe, visit https://gerrit.ovirt
Idan Shaby has uploaded a new change for review.
Change subject: storage: move devicemapper.py to vdsm storage lib
..
storage: move devicemapper.py to vdsm storage lib
This patch moves the module vdsm/storage/devicemapper.py to
Idan Shaby has uploaded a new change for review.
Change subject: storage: organize imports in imageSharing.py
..
storage: organize imports in imageSharing.py
Change-Id: Ibe431154a9eace82eaeedb764777c25dd3cf3996
Signed-off-by: Id
Idan Shaby has uploaded a new change for review.
Change subject: storage: move hba.py to vdsm storage lib
..
storage: move hba.py to vdsm storage lib
This patch moves the module vdsm/storage/hba.py to
lib/vdsm/storage/hba.py.
C
Idan Shaby has uploaded a new change for review.
Change subject: storage: move iscsiadm.py to vdsm storage lib
..
storage: move iscsiadm.py to vdsm storage lib
This patch moves the module vdsm/storage/iscsiadm.py to
lib/vdsm/sto
Idan Shaby has uploaded a new change for review.
Change subject: storage: move imageSharing.py to vdsm storage lib
..
storage: move imageSharing.py to vdsm storage lib
This patch moves the module vdsm/storage/imageSharing.py to
Idan Shaby has uploaded a new change for review.
Change subject: storage: move imagetickets.py to vdsm storage lib
..
storage: move imagetickets.py to vdsm storage lib
This patch moves the module vdsm/storage/imagetickets.py to
Idan Shaby has uploaded a new change for review.
Change subject: storage: move iscsi.py to vdsm storage lib
..
storage: move iscsi.py to vdsm storage lib
This patch moves the module vdsm/storage/iscsi.py to
lib/vdsm/storage/iscs
Idan Shaby has uploaded a new change for review.
Change subject: storage: organize imports in iscsi.py
..
storage: organize imports in iscsi.py
Change-Id: Ia5ba4fa68fe6d3d97b009b6eb7c0a0824590c875
Signed-off-by: Idan Shaby
---
Idan Shaby has uploaded a new change for review.
Change subject: storage: organize imports in iscsiadm.py
..
storage: organize imports in iscsiadm.py
Change-Id: I2bbad3cd7dda225d22031b951bd0206b70de4d89
Signed-off-by: Idan Shaby
Idan Shaby has uploaded a new change for review.
Change subject: storage: organize imports in devicemapper.py
..
storage: organize imports in devicemapper.py
Change-Id: I4924c62760d98ea8292794755db706bd9a6b1ea1
Signed-off-by: Id
Idan Shaby has posted comments on this change.
Change subject: storagetests: add a test for normalize_local_path
..
Patch Set 10: -Verified
There've been too many rebases since the last time I verified.
Marking as not verified
Idan Shaby has posted comments on this change.
Change subject: storage: streamline getting domain mountpoint
..
Patch Set 4: Verified+1
--
To view, visit https://gerrit.ovirt.org/56706
To unsubscribe, visit https://gerrit.ovir
Idan Shaby has posted comments on this change.
Change subject: storage: add tests for Mount.isMounted in mount.py
..
Patch Set 3:
(1 comment)
https://gerrit.ovirt.org/#/c/56704/2/tests/mountTests.py
File tests/mountTests.py:
Idan Shaby has posted comments on this change.
Change subject: storage: add tests for Mount.isMounted in mount.py
..
Patch Set 3: Verified+1
--
To view, visit https://gerrit.ovirt.org/56704
To unsubscribe, visit https://gerrit
Idan Shaby has posted comments on this change.
Change subject: storage: fix spec normalization when mounting
..
Patch Set 11:
(4 comments)
https://gerrit.ovirt.org/#/c/55182/10/tests/fileUtilTests.py
File tests/fileUtilTests.p
Idan Shaby has posted comments on this change.
Change subject: storage: streamline getting domain mountpoint
..
Patch Set 2:
(4 comments)
https://gerrit.ovirt.org/#/c/56706/1//COMMIT_MSG
Commit Message:
Line 3: AuthorDate: 20
Idan Shaby has posted comments on this change.
Change subject: storage: add tests for Mount.isMounted in mount.py
..
Patch Set 2: Verified+1
(8 comments)
https://gerrit.ovirt.org/#/c/56704/1/tests/mountTests.py
File tests/moun
Idan Shaby has posted comments on this change.
Change subject: storage: fix spec normalization when mounting
..
Patch Set 10:
(10 comments)
https://gerrit.ovirt.org/#/c/55182/9/lib/vdsm/storage/fileUtils.py
File lib/vdsm/stora
Idan Shaby has posted comments on this change.
Change subject: storage: remove unused method from mount.py
..
Patch Set 1: Verified+1
--
To view, visit https://gerrit.ovirt.org/56705
To unsubscribe, visit https://gerrit.ovirt.
Idan Shaby has posted comments on this change.
Change subject: storage: add tests for Mount.isMounted in mount.py
..
Patch Set 1: Verified+1
--
To view, visit https://gerrit.ovirt.org/56704
To unsubscribe, visit https://gerrit
Idan Shaby has uploaded a new change for review.
Change subject: storage: remove unused method from mount.py
..
storage: remove unused method from mount.py
This patch removes the unused method getMountFromDevice from mount.py.
Idan Shaby has uploaded a new change for review.
Change subject: storage: mount.isMounted input refactor
..
storage: mount.isMounted input refactor
When calling mount.isMounted from Mount.py, in order to get the
directory of a g
Idan Shaby has uploaded a new change for review.
Change subject: storage: add tests for Mount.isMounted in mount.py
..
storage: add tests for Mount.isMounted in mount.py
Change-Id: Ic6a97e5dc537bf41897e05ec41d2b1cc9f42981c
Signe
Idan Shaby has posted comments on this change.
Change subject: storage: move clusterlock.py to vdsm storage lib
..
Patch Set 2: Verified+1
--
To view, visit https://gerrit.ovirt.org/56641
To unsubscribe, visit https://gerrit.o
Idan Shaby has posted comments on this change.
Change subject: storage: move curlImgWrap.py to vdsm storage lib
..
Patch Set 2: Verified+1
--
To view, visit https://gerrit.ovirt.org/56642
To unsubscribe, visit https://gerrit.o
Idan Shaby has posted comments on this change.
Change subject: storage: organize imports in clusterlock.py
..
Patch Set 2: Verified+1
--
To view, visit https://gerrit.ovirt.org/56639
To unsubscribe, visit https://gerrit.ovirt.
Idan Shaby has posted comments on this change.
Change subject: storage: move fuser module to vdsm storage lib
..
Patch Set 3: Verified+1
--
To view, visit https://gerrit.ovirt.org/56620
To unsubscribe, visit https://gerrit.ovi
Idan Shaby has posted comments on this change.
Change subject: storage: move misc module to vdsm storage lib
..
Patch Set 4: Verified+1
--
To view, visit https://gerrit.ovirt.org/56614
To unsubscribe, visit https://gerrit.ovir
Idan Shaby has posted comments on this change.
Change subject: storage: organize imports in clusterlock.py
..
Patch Set 1:
(2 comments)
https://gerrit.ovirt.org/#/c/56639/1/vdsm/storage/clusterlock.py
File vdsm/storage/cluster
Idan Shaby has posted comments on this change.
Change subject: storage: organize imports in clusterlock.py
..
Patch Set 1: Verified+1
--
To view, visit https://gerrit.ovirt.org/56639
To unsubscribe, visit https://gerrit.ovirt.
Idan Shaby has uploaded a new change for review.
Change subject: storage: move clusterlock.py to vdsm storage lib
..
storage: move clusterlock.py to vdsm storage lib
This patch moves the module vdsm/storage/clusterlock.py to
lib
Idan Shaby has uploaded a new change for review.
Change subject: storage: move curlImgWrap.py to vdsm storage lib
..
storage: move curlImgWrap.py to vdsm storage lib
This patch moves the module vdsm/storage/curlImgWrap.py to
lib
1 - 100 of 207 matches
Mail list logo
