Zhou Zheng Sheng has posted comments on this change.
Change subject: packaging: allow to boot VMs from host CD-ROM
..
Patch Set 3: Code-Review+1
Changes to Debian packaging looks fine. As Dan says, the only problem is to
verif
Zhou Zheng Sheng has posted comments on this change.
Change subject: vds-tool: keep env on sysV service
..
Patch Set 2: Code-Review+1
--
To view, visit http://gerrit.ovirt.org/26255
To unsubscribe, visit http://gerrit.ovirt.or
Zhou Zheng Sheng has posted comments on this change.
Change subject: vdsm-tool: handle error during module loading
..
Patch Set 1: Code-Review+1
--
To view, visit http://gerrit.ovirt.org/25238
To unsubscribe, visit http://gerr
Zhou Zheng Sheng has posted comments on this change.
Change subject: vdsm-tool: handle error during module loading
..
Patch Set 2: Code-Review+1
--
To view, visit http://gerrit.ovirt.org/23456
To unsubscribe, visit http://gerr
Zhou Zheng Sheng has posted comments on this change.
Change subject: vdsm-tool: handle error during module loading
..
Patch Set 1:
(1 comment)
http://gerrit.ovirt.org/#/c/23456/1/vdsm-tool/vdsm-tool
File vdsm-tool/vdsm-tool:
Zhou Zheng Sheng has posted comments on this change.
Change subject: Changing the order of the services management alternatives
..
Patch Set 1:
Hi, I think on RHEL6, SysV init and Upstart co-exists. I don't see why
systemctl r
Zhou Zheng Sheng has posted comments on this change.
Change subject: Changing the order of the services management alternatives
..
Patch Set 1:
Could you explain why it should prefer initctl then systemctl? It's not obvious
to
Zhou Zheng Sheng has posted comments on this change.
Change subject: utilsTests: Styling of RollbackContextTests
..
Patch Set 3: Code-Review+1
--
To view, visit http://gerrit.ovirt.org/22886
To unsubscribe, visit http://gerrit
Zhou Zheng Sheng has posted comments on this change.
Change subject: misc: Fix exception re-raising in RollbackContext
..
Patch Set 8: Code-Review+1
Thanks to improve it. I think this RollbackContext is very useful. I'm happy
Zhou Zheng Sheng has posted comments on this change.
Change subject: misc: Fix exception re-raising in RollbackContext
..
Patch Set 6:
(1 comment)
File vdsm/storage/misc.py
Zhou Zheng Sheng has posted comments on this change.
Change subject: utilsTests: Avoiding returning in the middle of the method
..
Patch Set 1: Code-Review-1
(1 comment)
Since the original code logic is correct, I think the co
Zhou Zheng Sheng has posted comments on this change.
Change subject: misc: Fix exception re-raising in RollbackContext
..
Patch Set 6: Code-Review-1
(1 comment)
File vdsm/st
Zhou Zheng Sheng has posted comments on this change.
Change subject: vdsm: Hardware information about POWER hosts
..
Patch Set 8: Verified+1 Code-Review+1
Test build on Ubuntu.
It seems the Jenkins RPM failure is not related t
Zhou Zheng Sheng has posted comments on this change.
Change subject: vdsm: Hardware information about POWER hosts
..
Patch Set 7: Code-Review-1
(1 comment)
File vdsm/Makefil
Zhou Zheng Sheng has posted comments on this change.
Change subject: package: allow redefine user and group as configure options
..
Patch Set 2: Code-Review-1
(2 comments)
F
Zhou Zheng Sheng has posted comments on this change.
Change subject: Adding debian folder makefile
..
Patch Set 1:
@Sandro. In Debian packaging system there is a tool to generate
vdsm_version.orig.tar.gz (copied from upstream
Zhou Zheng Sheng has posted comments on this change.
Change subject: Adding debian folder makefile
..
Patch Set 1: Verified+1 Code-Review+1
Successfully build deb packages on my Ubuntu.
I think it's fine to include both rpm sp
Zhou Zheng Sheng has posted comments on this change.
Change subject: Ubuntu: Sync with vdsm.spec.in
..
Patch Set 1: Verified+1
--
To view, visit http://gerrit.ovirt.org/21297
To unsubscribe, visit http://gerrit.ovirt.org/setti
Zhou Zheng Sheng has posted comments on this change.
Change subject: Ubuntu: make hard coded group names configurable in
configurator.py
..
Patch Set 1: Verified+1
--
To view, visit http://gerrit.ovirt.org/21296
To unsubscrib
Zhou Zheng Sheng has uploaded a new change for review.
Change subject: Ubuntu: make hard coded group names configurable in
configurator.py
..
Ubuntu: make hard coded group names configurable in configurator.py
In the sanlock pa
Zhou Zheng Sheng has uploaded a new change for review.
Change subject: Ubuntu: Sync with vdsm.spec.in
..
Ubuntu: Sync with vdsm.spec.in
Recently we split zombiereaper and made some changes in libvirt
configuring. This patch upda
Zhou Zheng Sheng has posted comments on this change.
Change subject: Add lib/tool/restore_nets.py to debian/vdsm-python-install
..
Patch Set 2:
Thanks very much to keep the Ubuntu packaging files updated. Please feel free
to a
Zhou Zheng Sheng has posted comments on this change.
Change subject: Get oop from object instance
..
Patch Set 2: -Code-Review
Looks like it should be abandoned according to Mark Wu's last comments.
--
To view, visit http://g
Zhou Zheng Sheng has abandoned this change.
Change subject: logging: setup log filter correctly
..
Abandoned
--
To view, visit http://gerrit.ovirt.org/9688
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-Message
Zhou Zheng Sheng has abandoned this change.
Change subject: logUtils: a timed log throttle filter for stats thread
..
Abandoned
--
To view, visit http://gerrit.ovirt.org/9689
To unsubscribe, visit http://gerrit.ovirt.org/setti
Zhou Zheng Sheng has abandoned this change.
Change subject: AdvancedStatsThread: Rotate duplicated stats log
..
Abandoned
--
To view, visit http://gerrit.ovirt.org/8884
To unsubscribe, visit http://gerrit.ovirt.org/settings
G
Zhou Zheng Sheng has posted comments on this change.
Change subject: Add shutdown based on qemu-ga(qemu guest agent) in vdsm
..
Patch Set 4:
I think it can be abandoned.
--
To view, visit http://gerrit.ovirt.org/9655
To unsub
Zhou Zheng Sheng has abandoned this change.
Change subject: Add a router to multiplex port 54321 and serve HTTP request
..
Abandoned
--
To view, visit http://gerrit.ovirt.org/9605
To unsubscribe, visit http://gerrit.ovirt.org/
Zhou Zheng Sheng has posted comments on this change.
Change subject: move get-conf-item/set-conf-item to vdsm-tool
..
Patch Set 5:
I think these patch can be abandoned.
--
To view, visit http://gerrit.ovirt.org/7695
To unsubs
Zhou Zheng Sheng has abandoned this change.
Change subject: remote serial console via HTTP streaming handler
..
Abandoned
This patch did not attract enough interest. Maybe we can implement remote
serial access using websockify
Zhou Zheng Sheng has posted comments on this change.
Change subject: Introducing configurator package in vdsm-tool
..
Patch Set 15:
(4 comments)
Commit Message
Line 5: Commi
Zhou Zheng Sheng has posted comments on this change.
Change subject: Packaging: Update Ubuntu packaging scripts
..
Patch Set 2: Verified+1
Verify with .deb building and installing and functional tests. Unfortunately we
have a
Zhou Zheng Sheng has posted comments on this change.
Change subject: Packaging: libvirt configuration detection should skip /dev/null
..
Patch Set 1: Verified+1
Tested on Ubuntu.
--
To view, visit http://gerrit.ovirt.org/2026
Zhou Zheng Sheng has uploaded a new change for review.
Change subject: Packaging: libvirt configuration detection should skip /dev/null
..
Packaging: libvirt configuration detection should skip /dev/null
We disabled libvirt-sanl
Zhou Zheng Sheng has posted comments on this change.
Change subject: Adding [start|stop]MonitoringDomain().
..
Patch Set 1:
(1 comment)
File vdsm/storage/sp.py
Line 1033:
L
Zhou Zheng Sheng has posted comments on this change.
Change subject: Adding [start|stop]MonitoringDomain().
..
Patch Set 4:
Hi Eduardo. I find a problem in patch. Maybe we need to fix it.
--
To view, visit http://gerrit.ovirt
Zhou Zheng Sheng has posted comments on this change.
Change subject: Adding [start|stop]MonitoringDomain().
..
Patch Set 1:
(1 comment)
File vdsm/storage/sp.py
Line 1548:
Zhou Zheng Sheng has abandoned this change.
Change subject: Packaging: make the auto build scripts suitable for running in
Jenkins
..
Abandoned
--
To view, visit http://gerrit.ovirt.org/11238
To unsubscribe, visit http://gerr
Zhou Zheng Sheng has posted comments on this change.
Change subject: Packaging: fix libvirt configuration
..
Patch Set 1:
(3 comments)
Thanks.
This patch does not depend on http://gerrit.ovirt.org/#/c/20142/3 , but the
child
Zhou Zheng Sheng has posted comments on this change.
Change subject: Adding dependency on cpopen formal package
..
Patch Set 3:
The Jenkins failure is not related to this patch. The Jenkins slave should
install python-cpopen p
Zhou Zheng Sheng has posted comments on this change.
Change subject: Packaging: Update Ubuntu packaging scripts
..
Patch Set 1:
I read Jenkins build log, Jenkins failure is not related to this patch.
--
To view, visit http://
Zhou Zheng Sheng has posted comments on this change.
Change subject: Packaging: Fix vdsm.prerm of Ubuntu packaging scripts
..
Patch Set 1:
I read Jenkins build log, Jenkins failure is not related to this patch.
--
To view, vi
Zhou Zheng Sheng has posted comments on this change.
Change subject: Packaging: fix libvirt configuration
..
Patch Set 1:
I read Jenkins build log, Jenkins failure is not related to this patch.
--
To view, visit http://gerrit
Zhou Zheng Sheng has posted comments on this change.
Change subject: Packaging: Update Ubuntu packaging scripts
..
Patch Set 1: Verified+1
Test on Ubuntu 13.04
--
To view, visit http://gerrit.ovirt.org/20170
To unsubscribe, v
Zhou Zheng Sheng has posted comments on this change.
Change subject: Packaging: Fix vdsm.prerm of Ubuntu packaging scripts
..
Patch Set 1: Verified+1
Test on Ubuntu 13.04
--
To view, visit http://gerrit.ovirt.org/20169
To uns
Zhou Zheng Sheng has posted comments on this change.
Change subject: Packaging: fix libvirt configuration
..
Patch Set 1: Verified+1
Test on Ubuntu 13.04
--
To view, visit http://gerrit.ovirt.org/20168
To unsubscribe, visit h
Zhou Zheng Sheng has posted comments on this change.
Change subject: Adding dependency on cpopen formal package
..
Patch Set 3: Verified+1 Code-Review+1
Test on Ubuntu. I also submit some subsequent patches to keep Ubuntu
comp
Zhou Zheng Sheng has uploaded a new change for review.
Change subject: Packaging: Update Ubuntu packaging scripts
..
Packaging: Update Ubuntu packaging scripts
Recently upstream VDSM added some files and dirs, as well as some
de
Zhou Zheng Sheng has uploaded a new change for review.
Change subject: Packaging: Fix vdsm.prerm of Ubuntu packaging scripts
..
Packaging: Fix vdsm.prerm of Ubuntu packaging scripts
On Ubuntu, qemu-sanlock.conf is not used, so t
Zhou Zheng Sheng has uploaded a new change for review.
Change subject: Packaging: fix libvirt configuration
..
Packaging: fix libvirt configuration
The help string "=FILE" is incorrectly added to the name of the
configure option
Zhou Zheng Sheng has abandoned this change.
Change subject: remoteFileHandler: config logging in spawned process
..
Abandoned
http://gerrit.ovirt.org/14626 covers this case and it's simpler.
--
To view, visit http://gerrit.ov
Zhou Zheng Sheng has posted comments on this change.
Change subject: virtTests: fix initramfs permission detection
..
Patch Set 2: Code-Review+1
--
To view, visit http://gerrit.ovirt.org/20031
To unsubscribe, visit http://gerr
Zhou Zheng Sheng has posted comments on this change.
Change subject: Removing unnecessary subshell call
..
Patch Set 1:
(1 comment)
File init/sysvinit/vdsmd.init.in
Line 68:
Zhou Zheng Sheng has posted comments on this change.
Change subject: Changing return method from vdsmd start function
..
Patch Set 6:
(1 comment)
File init/sysvinit/vdsmd.in
Zhou Zheng Sheng has posted comments on this change.
Change subject: Removing unnecessary subshell call
..
Patch Set 1:
(1 comment)
File init/sysvinit/vdsmd.init.in
Line 68:
Zhou Zheng Sheng has posted comments on this change.
Change subject: virtTests: fix initramfs permission detection
..
Patch Set 1:
(1 comment)
File tests/functional/virtTest
Zhou Zheng Sheng has posted comments on this change.
Change subject: Move zombieReaper to its own package
..
Patch Set 7: Code-Review+1
CentOS slave build fail seems not related to this patch [1]. I see all recent
build on Cen
Zhou Zheng Sheng has posted comments on this change.
Change subject: Ubuntu: packaging: keep up with vdsm.spec.in
..
Patch Set 2:
Thanks Dan. Mail sent.
@Alon, when I do Ubuntu compatibility fix and packaging, I find Ubuntu sp
Zhou Zheng Sheng has posted comments on this change.
Change subject: Ubuntu: packaging: keep up with vdsm.spec.in
..
Patch Set 1:
Thanks!
Till now I did not investigate how to run oVirt Engine on Ubuntu. I think the
next step
Zhou Zheng Sheng has posted comments on this change.
Change subject: Ubuntu: packaging: keep up with vdsm.spec.in
..
Patch Set 1: Verified+1
Tested on Ubunt 13.04 and launchpad.net PPA build environment.
--
To view, visit htt
Zhou Zheng Sheng has uploaded a new change for review.
Change subject: Ubuntu: packaging: keep up with vdsm.spec.in
..
Ubuntu: packaging: keep up with vdsm.spec.in
In vdsm.spec.in we add new files and folders, so add those files
Zhou Zheng Sheng has posted comments on this change.
Change subject: Move zombieReaper to its own package
..
Patch Set 4:
Since we already have vdsm-python-cpopen, I think vdsm-python-zombiereaper is a
better name. For other p
Zhou Zheng Sheng has posted comments on this change.
Change subject: Move zombieReaper to its own package
..
Patch Set 4: Code-Review+1
--
To view, visit http://gerrit.ovirt.org/19253
To unsubscribe, visit http://gerrit.ovirt.
Zhou Zheng Sheng has posted comments on this change.
Change subject: vdsm: Load softdog if hardware watchdog is not available
..
Patch Set 4:
Bug is reported to Ubuntu at
https://bugs.launchpad.net/ubuntu/+source/sanlock/+bug
Zhou Zheng Sheng has posted comments on this change.
Change subject: Packaging: VDSM v4.12.0 packaged on Ubuntu
..
Patch Set 6: Verified+1
Since Ubuntu and Debian are among the most popular distributions, I think it's
good to
Zhou Zheng Sheng has posted comments on this change.
Change subject: Removing automatic restart of services in libvirt-reconfigure
..
Patch Set 15: Code-Review+1
--
To view, visit http://gerrit.ovirt.org/18780
To unsubscribe,
Zhou Zheng Sheng has posted comments on this change.
Change subject: Move zombieReaper to its own package
..
Patch Set 2:
(1 comment)
File lib/zombieReaper/Makefile.am
Line
Zhou Zheng Sheng has posted comments on this change.
Change subject: Removing automatic restart of services in libvirt-reconfigure
..
Patch Set 14:
(1 comment)
File lib/vdsm
Zhou Zheng Sheng has posted comments on this change.
Change subject: Removing automatic restart of services in libvirt-reconfigure
..
Patch Set 14:
(1 comment)
File lib/vdsm
Zhou Zheng Sheng has posted comments on this change.
Change subject: Modification in lockfile usage mechanism as part of sysv init
script
..
Patch Set 14:
(1 comment)
File
Zhou Zheng Sheng has posted comments on this change.
Change subject: Modification in lockfile usage mechanism as part of sysv init
script
..
Patch Set 14:
(1 comment)
File
Zhou Zheng Sheng has posted comments on this change.
Change subject: Modification in lockfile usage mechanism as part of sysv init
script
..
Patch Set 14: Code-Review-1
(2 comments)
...
Zhou Zheng Sheng has posted comments on this change.
Change subject: Packaging: Fix help string and usage for
--disable-libvirt-sanlock
..
Patch Set 4:
(1 comment)
File con
Zhou Zheng Sheng has posted comments on this change.
Change subject: service.py: _runAlts() remove ServiceNotExistError
..
Patch Set 1:
(1 comment)
File lib/vdsm/tool/servic
Zhou Zheng Sheng has posted comments on this change.
Change subject: service.py: _runAlts() remove ServiceNotExistError
..
Patch Set 1:
(1 comment)
File lib/vdsm/tool/servic
Zhou Zheng Sheng has posted comments on this change.
Change subject: service.py: _runAlts() remove ServiceNotExistError
..
Patch Set 1:
(1 comment)
File lib/vdsm/tool/servic
Zhou Zheng Sheng has posted comments on this change.
Change subject: Modification in lockfile usage mechanism as part of sysv init
script
..
Patch Set 6:
(1 comment)
File i
Zhou Zheng Sheng has posted comments on this change.
Change subject: Packaging: Fix help string and usage for
--disable-libvirt-sanlock
..
Patch Set 4:
(1 comment)
File con
Zhou Zheng Sheng has posted comments on this change.
Change subject: Packaging: Fix help string and usage for
--disable-libvirt-sanlock
..
Patch Set 4: Verified+1
(2 comments)
.
Zhou Zheng Sheng has posted comments on this change.
Change subject: Modification in lockfile usage mechanism as part of sysv init
script
..
Patch Set 6:
(1 comment)
File i
Zhou Zheng Sheng has posted comments on this change.
Change subject: Packaging: VDSM v4.12.0 packaged on Ubuntu
..
Patch Set 6:
Hi Alon. Do you mean the bazaar repository hosted by launchpad.net? I think
it's better to have th
Zhou Zheng Sheng has posted comments on this change.
Change subject: Packaging: Fix help string and usage for
--disable-libvirt-sanlock
..
Patch Set 3:
(1 comment)
File con
Zhou Zheng Sheng has posted comments on this change.
Change subject: Modification in lockfile usage mechanism as part of sysv init
script
..
Patch Set 6:
(4 comments)
File
Zhou Zheng Sheng has posted comments on this change.
Change subject: Packaging: make libvirtd env file path and qemu process user
group configurable
..
Patch Set 3: Verified+1
--
To view, visit http://gerrit.ovirt.org/19007
T
Zhou Zheng Sheng has posted comments on this change.
Change subject: Packaging: Fix help string and usage for
--disable-libvirt-sanlock
..
Patch Set 3:
(1 comment)
File con
Zhou Zheng Sheng has posted comments on this change.
Change subject: Packaging: Fix help string and usage for
--disable-libvirt-sanlock
..
Patch Set 3:
(1 comment)
File con
Zhou Zheng Sheng has posted comments on this change.
Change subject: Packaging: make libvirt service name and qemu process user
group configurable
..
Patch Set 2:
(3 comments)
Thanks Alon.
...
Zhou Zheng Sheng has posted comments on this change.
Change subject: Packaging: Fix help string and usage for
--disable-libvirt-sanlock
..
Patch Set 3:
(1 comment)
File con
Zhou Zheng Sheng has posted comments on this change.
Change subject: Packaging: Fix help string and usage for
--disable-libvirt-sanlock
..
Patch Set 3: Verified+1
In this version I apply the opinion from Dan and Alon. The fina
Zhou Zheng Sheng has posted comments on this change.
Change subject: Packaging: Remove hard coded 12- prefix of vdsm-lvm.rules from
upstream
..
Patch Set 2: Verified+1
A rebase of patch series. This patch does not change.
--
Zhou Zheng Sheng has posted comments on this change.
Change subject: build: cleanup: reformat AC_ARG_ENABLE
..
Patch Set 2: Code-Review+1
--
To view, visit http://gerrit.ovirt.org/18939
To unsubscribe, visit http://gerrit.ovir
Zhou Zheng Sheng has posted comments on this change.
Change subject: systemd init: no need to stop conflicting services
..
Patch Set 1: Code-Review+1
--
To view, visit http://gerrit.ovirt.org/19046
To unsubscribe, visit http:/
Zhou Zheng Sheng has posted comments on this change.
Change subject: vdsm: Load softdog if hardware watchdog is not available
..
Patch Set 4:
The reason is more or less political. I agree wdmd init script is a better
place, bu
Zhou Zheng Sheng has posted comments on this change.
Change subject: Removing automatic restart of services in libvirt-reconfigure
..
Patch Set 1:
I agree. So a total solution would involve vdsmd_init_common, it should restart
Zhou Zheng Sheng has posted comments on this change.
Change subject: Packaging: Fix help string and usage for
--enable-libvirt-sanlock
..
Patch Set 1:
(1 comment)
File conf
Zhou Zheng Sheng has posted comments on this change.
Change subject: Packaging: Fix misleading help string for
--enable-libvirt-sanlock
..
Patch Set 1:
(1 comment)
File con
Zhou Zheng Sheng has posted comments on this change.
Change subject: vdsm: Load softdog if hardware watchdog is not available
..
Patch Set 4: Verified+1
--
To view, visit http://gerrit.ovirt.org/17814
To unsubscribe, visit htt
Zhou Zheng Sheng has posted comments on this change.
Change subject: Packaging: VDSM v4.12.0 packaged on Ubuntu
..
Patch Set 5:
This is a hard question. I think if we want to make VDSM more popular, we'd
better take this respo
Zhou Zheng Sheng has posted comments on this change.
Change subject: Packaging: Fix misleading help string for
--enable-libvirt-sanlock
..
Patch Set 1:
(1 comment)
File con
Zhou Zheng Sheng has posted comments on this change.
Change subject: Packaging: make libvirt service name and qemu process user
group configurable
..
Patch Set 1:
(2 comments)
Thanks Alon.
...
1 - 100 of 1152 matches
Mail list logo
