Igor Lvovsky has posted comments on this change. Change subject: [WIP] BZ#788640 - Refactor Pool.deleteImage() ......................................................................
Patch Set 6: I would prefer that you didn't submit this (5 inline comments) looks fine, just minor comments. should be tested carefully with pre-integration team .................................................... File vdsm/storage/sp.py Line 1722: imgsByVol = dict((k, v) for k, v in allVols.iteritems() if imgUUID in v.imgs) Please not k,v again Line 1737: # TODO: Lock the template, reload allVols. Don't forget to do this Line 1745: " %s" % (ts, imgsByVol, allVols)) you not need this 'if' Line 1748: img.delete(sdUUID=sdUUID, imgUUID=imgUUID, postZero=False, force=False) postZero = postZero, force=force Line 1751: img.delete(sdUUID=sdUUID, imgUUID=tSelfImage, postZero=False, force=False) force=True -- To view, visit http://gerrit.ovirt.org/3464 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ifbc1397c69c7ffa835abe0747b6573d56bb9d74e Gerrit-PatchSet: 6 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Eduardo <ewars...@redhat.com> Gerrit-Reviewer: Dan Kenigsberg <dan...@redhat.com> Gerrit-Reviewer: Eduardo <ewars...@redhat.com> Gerrit-Reviewer: Igor Lvovsky <ilvov...@redhat.com> Gerrit-Reviewer: Saggi Mizrahi <smizr...@redhat.com> _______________________________________________ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://fedorahosted.org/mailman/listinfo/vdsm-patches
