Itamar Heim has abandoned this change.
Change subject: Move and encapsulate preun section into vdsm-tool
..
Abandoned
ok, abandoning per last comment.
--
To view, visit http://gerrit.ovirt.org/4526
To unsubscribe, visit http:
Yaniv Bronhaim has posted comments on this change.
Change subject: Move and encapsulate preun section into vdsm-tool
..
Patch Set 8:
I created http://gerrit.ovirt.org/#/c/21772/ to replace this work. It is too
old to rebase an
Itamar Heim has posted comments on this change.
Change subject: Move and encapsulate preun section into vdsm-tool
..
Patch Set 8:
ping
--
To view, visit http://gerrit.ovirt.org/4526
To unsubscribe, visit http://gerrit.ovirt.o
Lei Li has posted comments on this change.
Change subject: Move and encapsulate preun section into vdsm-tool
..
Patch Set 8:
I am glad that this still could be useful, it'd be great if
you could help on the rebase the pushing!
Yaniv Bronhaim has posted comments on this change.
Change subject: Move and encapsulate preun section into vdsm-tool
..
Patch Set 8: Code-Review-1
I created http://gerrit.ovirt.org/#/c/21772/ to replace this work. It is too
ol
Yaniv Bronhaim has posted comments on this change.
Change subject: Move and encapsulate preun section into vdsm-tool
..
Patch Set 8:
This patch contains very usable parts. I prefer to split it a bit and get it
merged. Lei Li,
Yaniv Bronhaim has posted comments on this change.
Change subject: Move and encapsulate preun section into vdsm-tool
..
Patch Set 8:
Didn't notice that patch. reviewing it
--
To view, visit http://gerrit.ovirt.org/4526
To uns
Itamar Heim has posted comments on this change.
Change subject: Move and encapsulate preun section into vdsm-tool
..
Patch Set 8:
still relevant or should be abandoned?
--
To view, visit http://gerrit.ovirt.org/4526
To unsubs
Lei Li has posted comments on this change.
Change subject: Move and encapsulate preun section into vdsm-tool
..
Patch Set 8:
I am petty sure that I have tested the code and pass the build...
Take a look at the build error from
oVirt Jenkins CI Server has posted comments on this change.
Change subject: Move and encapsulate preun section into vdsm-tool
..
Patch Set 8: Fails
Build Failed
http://jenkins.ovirt.org/job/vdsm_unit_tests_manual_gerrit/11/ :
oVirt Jenkins CI Server has posted comments on this change.
Change subject: Move and encapsulate preun section into vdsm-tool
..
Patch Set 8:
Build Started http://jenkins.ovirt.org/job/vdsm_unit_tests_manual_gerrit/11/
--
To v
oVirt Jenkins CI Server has posted comments on this change.
Change subject: Move and encapsulate preun section into vdsm-tool
..
Patch Set 7: Fails
Build Failed
http://jenkins.ovirt.org/job/vdsm_unit_tests_manual_gerrit/10/ :
oVirt Jenkins CI Server has posted comments on this change.
Change subject: Move and encapsulate preun section into vdsm-tool
..
Patch Set 7:
Build Started http://jenkins.ovirt.org/job/vdsm_unit_tests_manual_gerrit/10/
--
To v
Ryan Harper has posted comments on this change.
Change subject: Move and encapsulate preun section into vdsm-tool
..
Patch Set 6: I would prefer that you didn't submit this
(9 inline comments)
.
oVirt Jenkins CI Server has posted comments on this change.
Change subject: Move and encapsulate preun section into vdsm-tool
..
Patch Set 6:
Build Successful
http://jenkins.ovirt.info/job/vdsm_unit_tests_by_patch/182/ : SUCC
oVirt Jenkins CI Server has posted comments on this change.
Change subject: Move and encapsulate preun section into vdsm-tool
..
Patch Set 6: No score
Build Started http://jenkins.ovirt.info/job/vdsm_unit_tests_by_patch/182/
-
Wenyi Gao has posted comments on this change.
Change subject: Move and encapsulate preun section into vdsm-tool
..
Patch Set 6: (1 inline comment)
File vdsm_tool/passwd.py
Li
ShaoHe Feng has posted comments on this change.
Change subject: Move and encapsulate preun section into vdsm-tool
..
Patch Set 6: No score
--
To view, visit http://gerrit.ovirt.org/4526
To unsubscribe, visit http://gerrit.ovirt
ShaoHe Feng has posted comments on this change.
Change subject: Move and encapsulate preun section into vdsm-tool
..
Patch Set 6: No score
--
To view, visit http://gerrit.ovirt.org/4526
To unsubscribe, visit http://gerrit.ovirt
Lei Li has posted comments on this change.
Change subject: Move and encapsulate preun section into vdsm-tool
..
Patch Set 6: (1 inline comment)
Shaohe:
Please give more details about which vdsm-tool command failed..and the whic
ShaoHe Feng has posted comments on this change.
Change subject: Move and encapsulate preun section into vdsm-tool
..
Patch Set 6: Fails
$ sudo ls /sbin/initctl
ls: cannot access /sbin/initctl: No such file or directory
--
To v
ShaoHe Feng has posted comments on this change.
Change subject: Move and encapsulate preun section into vdsm-tool
..
Patch Set 6: I would prefer that you didn't submit this
(2 inline comments)
.
Wenyi Gao has posted comments on this change.
Change subject: Move and encapsulate preun section into vdsm-tool
..
Patch Set 6: (1 inline comment)
File vdsm_tool/passwd.py
Li
Lei Li has posted comments on this change.
Change subject: Move and encapsulate preun section into vdsm-tool
..
Patch Set 6:
And thanks to Xu He Jie and Zhou ZhengSheng for their help with the hacking of
importing vdsm_tool.
Lei Li has posted comments on this change.
Change subject: Move and encapsulate preun section into vdsm-tool
..
Patch Set 5:
Hi Dan,
1) For the unit tests, I will add it later.
2) For the constants, I will git rid of them if y
Lei Li has posted comments on this change.
Change subject: Move and encapsulate preun section into vdsm-tool
..
Patch Set 4: (1 inline comment)
File vdsm-tool/unregister.py
L
Lei Li has posted comments on this change.
Change subject: Move and encapsulate preun section into vdsm-tool
..
Patch Set 4: (6 inline comments)
File vdsm/constants.py.in
Lin
Dan Kenigsberg has posted comments on this change.
Change subject: Move and encapsulate preun section into vdsm-tool
..
Patch Set 4: I would prefer that you didn't submit this
(6 inline comments)
much better, but there's still
Dan Kenigsberg has posted comments on this change.
Change subject: Move and encapsulate preun section into vdsm-tool
..
Patch Set 2: I would prefer that you didn't submit this
(2 inline comments)
..
Lei Li has posted comments on this change.
Change subject: Move and encapsulate preun section into vdsm-tool
..
Patch Set 1: (3 inline comments)
File vdsm.spec.in
Line 372: %
30 matches
Mail list logo
