Change in vdsm[master]: Move removing libvirt network to configurator

2013-06-11 Thread danken
Dan Kenigsberg has posted comments on this change. Change subject: Move removing libvirt network to configurator .. Patch Set 5: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/15417 To unsubscribe, visit

Change in vdsm[master]: Move removing libvirt network to configurator

2013-06-11 Thread danken
Dan Kenigsberg has submitted this change and it was merged. Change subject: Move removing libvirt network to configurator .. Move removing libvirt network to configurator This patch adds a wrapper for the configWriter.removeLib

Change in vdsm[master]: Move removing libvirt network to configurator

2013-06-07 Thread wudxw
Mark Wu has posted comments on this change. Change subject: Move removing libvirt network to configurator .. Patch Set 5: Verified -- To view, visit http://gerrit.ovirt.org/15417 To unsubscribe, visit http://gerrit.ovirt.org/se

Change in vdsm[master]: Move removing libvirt network to configurator

2013-06-07 Thread asegurap
Antoni Segura Puimedon has posted comments on this change. Change subject: Move removing libvirt network to configurator .. Patch Set 5: verified the following patch, so I consider this one as included. -- To view, visit http:

Change in vdsm[master]: Move removing libvirt network to configurator

2013-06-07 Thread asegurap
Antoni Segura Puimedon has posted comments on this change. Change subject: Move removing libvirt network to configurator .. Patch Set 5: Looks good to me, but someone else must approve -- To view, visit http://gerrit.ovirt.org/

Change in vdsm[master]: Move removing libvirt network to configurator

2013-06-07 Thread Gerrit Code Review
oVirt Jenkins CI Server has posted comments on this change. Change subject: Move removing libvirt network to configurator .. Patch Set 5: Build Successful http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/2682/ : SUCCESS http://

Change in vdsm[master]: Move removing libvirt network to configurator

2013-06-07 Thread Gerrit Code Review
oVirt Jenkins CI Server has posted comments on this change. Change subject: Move removing libvirt network to configurator .. Patch Set 4: Build Successful http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/2679/ : SUCCESS http://

Change in vdsm[master]: Move removing libvirt network to configurator

2013-06-07 Thread asegurap
Antoni Segura Puimedon has posted comments on this change. Change subject: Move removing libvirt network to configurator .. Patch Set 3: Looks good to me, but someone else must approve -- To view, visit http://gerrit.ovirt.org/

Change in vdsm[master]: Move removing libvirt network to configurator

2013-06-07 Thread Gerrit Code Review
oVirt Jenkins CI Server has posted comments on this change. Change subject: Move removing libvirt network to configurator .. Patch Set 3: Build Successful http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/2674/ : SUCCESS http://

Change in vdsm[master]: Move removing libvirt network to configurator

2013-06-07 Thread wudxw
Mark Wu has posted comments on this change. Change subject: Move removing libvirt network to configurator .. Patch Set 3: No change. Just rebase. -- To view, visit http://gerrit.ovirt.org/15417 To unsubscribe, visit http://ger

Change in vdsm[master]: Move removing libvirt network to configurator

2013-06-07 Thread wudxw
Mark Wu has posted comments on this change. Change subject: Move removing libvirt network to configurator .. Patch Set 3: Verified -- To view, visit http://gerrit.ovirt.org/15417 To unsubscribe, visit http://gerrit.ovirt.org/se

Change in vdsm[master]: Move removing libvirt network to configurator

2013-06-07 Thread asegurap
Antoni Segura Puimedon has posted comments on this change. Change subject: Move removing libvirt network to configurator .. Patch Set 2: Looks good to me, but someone else must approve Thanks! -- To view, visit http://gerrit.o

Change in vdsm[master]: Move removing libvirt network to configurator

2013-06-06 Thread wudxw
Mark Wu has posted comments on this change. Change subject: Move removing libvirt network to configurator .. Patch Set 1: Good catch! It is caused a mistake during rebase, and I thought it's verified because the following patc

Change in vdsm[master]: Move removing libvirt network to configurator

2013-06-06 Thread asegurap
Antoni Segura Puimedon has posted comments on this change. Change subject: Move removing libvirt network to configurator .. Patch Set 1: I checked and it is not defined until the following patch. -- To view, visit http://gerri

Change in vdsm[master]: Move removing libvirt network to configurator

2013-06-06 Thread asegurap
Antoni Segura Puimedon has posted comments on this change. Change subject: Move removing libvirt network to configurator .. Patch Set 1: I would prefer that you didn't submit this is configurator defined on delNetwork before it

Change in vdsm[master]: Move removing libvirt network to configurator

2013-06-06 Thread Gerrit Code Review
oVirt Jenkins CI Server has posted comments on this change. Change subject: Move removing libvirt network to configurator .. Patch Set 1: Build Failed http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/2643/ : SUCCESS http://jenk

Change in vdsm[master]: Move removing libvirt network to configurator

2013-06-06 Thread asegurap
Antoni Segura Puimedon has posted comments on this change. Change subject: Move removing libvirt network to configurator .. Patch Set 1: Looks good to me, but someone else must approve -- To view, visit http://gerrit.ovirt.org/

Change in vdsm[master]: Move removing libvirt network to configurator

2013-06-06 Thread Gerrit Code Review
oVirt Jenkins CI Server has posted comments on this change. Change subject: Move removing libvirt network to configurator .. Patch Set 1: Fails Build Failed http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/2627/ : SUCCESS http:

Change in vdsm[master]: Move removing libvirt network to configurator

2013-06-06 Thread wudxw
Mark Wu has posted comments on this change. Change subject: Move removing libvirt network to configurator .. Patch Set 1: Verified libvirt network is removed as expected. -- To view, visit http://gerrit.ovirt.org/15417 To unsu

Change in vdsm[master]: Move removing libvirt network to configurator

2013-06-06 Thread wudxw
Mark Wu has uploaded a new change for review. Change subject: Move removing libvirt network to configurator .. Move removing libvirt network to configurator This patch adds a wrapper for the configWriter.removeLibvirtNetwork() i

Change in vdsm[master]: Move removing libvirt network to configurator

2013-06-04 Thread wudxw
Mark Wu has abandoned this change. Change subject: Move removing libvirt network to configurator .. Patch Set 3: Abandoned included in another patch -- To view, visit http://gerrit.ovirt.org/14874 To unsubscribe, visit http://

Change in vdsm[master]: Move removing libvirt network to configurator

2013-06-03 Thread Gerrit Code Review
oVirt Jenkins CI Server has posted comments on this change. Change subject: Move removing libvirt network to configurator .. Patch Set 3: Fails Build Failed http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/2516/ : SUCCESS http:

Change in vdsm[master]: Move removing libvirt network to configurator

2013-05-28 Thread wudxw
Mark Wu has posted comments on this change. Change subject: Move removing libvirt network to configurator .. Patch Set 2: Verified -- To view, visit http://gerrit.ovirt.org/14874 To unsubscribe, visit http://gerrit.ovirt.org/se

Change in vdsm[master]: Move removing libvirt network to configurator

2013-05-28 Thread Gerrit Code Review
oVirt Jenkins CI Server has posted comments on this change. Change subject: Move removing libvirt network to configurator .. Patch Set 2: Build Successful http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/2444/ : SUCCESS http://

Change in vdsm[master]: Move removing libvirt network to configurator

2013-05-28 Thread Gerrit Code Review
oVirt Jenkins CI Server has posted comments on this change. Change subject: Move removing libvirt network to configurator .. Patch Set 2: Build Started http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/1613/ (3/3) -- To v

Change in vdsm[master]: Move removing libvirt network to configurator

2013-05-28 Thread Gerrit Code Review
oVirt Jenkins CI Server has posted comments on this change. Change subject: Move removing libvirt network to configurator .. Patch Set 2: Build Started http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/2514/ (2/3) -- To view

Change in vdsm[master]: Move removing libvirt network to configurator

2013-05-28 Thread Gerrit Code Review
oVirt Jenkins CI Server has posted comments on this change. Change subject: Move removing libvirt network to configurator .. Patch Set 2: Build Started http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/2444/ (1/3) -- To view, visi

Change in vdsm[master]: Move removing libvirt network to configurator

2013-05-21 Thread asegurap
Antoni Segura Puimedon has posted comments on this change. Change subject: Move removing libvirt network to configurator .. Patch Set 1: Looks good to me, but someone else must approve Thanks! This and it's configureLibvirtNetw

Change in vdsm[master]: Move removing libvirt network to configurator

2013-05-19 Thread Gerrit Code Review
oVirt Jenkins CI Server has posted comments on this change. Change subject: Move removing libvirt network to configurator .. Patch Set 1: Fails Build Failed http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/2342/ : SUCCESS http:

Change in vdsm[master]: Move removing libvirt network to configurator

2013-05-19 Thread Gerrit Code Review
oVirt Jenkins CI Server has posted comments on this change. Change subject: Move removing libvirt network to configurator .. Patch Set 1: Build Started http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/1507/ (3/3) -- To v

Change in vdsm[master]: Move removing libvirt network to configurator

2013-05-19 Thread Gerrit Code Review
oVirt Jenkins CI Server has posted comments on this change. Change subject: Move removing libvirt network to configurator .. Patch Set 1: Build Started http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/2409/ (2/3) -- To view

Change in vdsm[master]: Move removing libvirt network to configurator

2013-05-19 Thread Gerrit Code Review
oVirt Jenkins CI Server has posted comments on this change. Change subject: Move removing libvirt network to configurator .. Patch Set 1: Build Started http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/2342/ (1/3) -- To view, visi

Change in vdsm[master]: Move removing libvirt network to configurator

2013-05-19 Thread wudxw
Mark Wu has uploaded a new change for review. Change subject: Move removing libvirt network to configurator .. Move removing libvirt network to configurator This patch adds a wrapper for the configWriter.removeLibvirtNetwork() i