automat...@ovirt.org has posted comments on this change.
Change subject: Refactor v2v jobs for reusability
..
Patch Set 10:
* Update tracker::IGNORE, no Bug-Url found
* Set MODIFIED::IGNORE, no Bug-Url found.
--
To view,
Dan Kenigsberg has submitted this change and it was merged.
Change subject: Refactor v2v jobs for reusability
..
Refactor v2v jobs for reusability
The jobs management infrastructure in v2v.py is general purpose and
reusable.
Piotr Kliczewski has posted comments on this change.
Change subject: Refactor v2v jobs for reusability
..
Patch Set 9: Code-Review+1
--
To view, visit https://gerrit.ovirt.org/44857
To unsubscribe, visit
Francesco Romani has posted comments on this change.
Change subject: Refactor v2v jobs for reusability
..
Patch Set 9: Code-Review+1
(2 comments)
https://gerrit.ovirt.org/#/c/44857/9/vdsm/jobs.py
File vdsm/jobs.py:
Line 45:
Nir Soffer has posted comments on this change.
Change subject: Refactor v2v jobs for reusability
..
Patch Set 9: Code-Review+2
I agree with Francesco, we will refine the docstrings later.
--
To view, visit
automat...@ovirt.org has posted comments on this change.
Change subject: Refactor v2v jobs for reusability
..
Patch Set 9:
* Update tracker::IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header
Nir Soffer has posted comments on this change.
Change subject: Refactor v2v jobs for reusability
..
Patch Set 9: Code-Review+1
--
To view, visit https://gerrit.ovirt.org/44857
To unsubscribe, visit
Adam Litke has posted comments on this change.
Change subject: Refactor v2v jobs for reusability
..
Patch Set 9: Verified+1
--
To view, visit https://gerrit.ovirt.org/44857
To unsubscribe, visit
Shahar Havivi has posted comments on this change.
Change subject: Refactor v2v jobs for reusability
..
Patch Set 7: Code-Review-1
the verification is not complete - it is not enough to validate
import of OVA file, but
Nir Soffer has posted comments on this change.
Change subject: Refactor v2v jobs for reusability
..
Patch Set 8: Code-Review-1
(1 comment)
https://gerrit.ovirt.org/#/c/44857/8/vdsm.spec.in
File vdsm.spec.in:
Line 790:
automat...@ovirt.org has posted comments on this change.
Change subject: Refactor v2v jobs for reusability
..
Patch Set 8:
* Update tracker::IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header
Adam Litke has posted comments on this change.
Change subject: Refactor v2v jobs for reusability
..
Patch Set 8: Verified+1
--
To view, visit https://gerrit.ovirt.org/44857
To unsubscribe, visit
Piotr Kliczewski has posted comments on this change.
Change subject: Refactor v2v jobs for reusability
..
Patch Set 7:
(1 comment)
https://gerrit.ovirt.org/#/c/44857/7/vdsm/v2v.py
File vdsm/v2v.py:
Line 282:
Piotr Kliczewski has posted comments on this change.
Change subject: Refactor v2v jobs for reusability
..
Patch Set 7:
(1 comment)
https://gerrit.ovirt.org/#/c/44857/7/vdsm/v2v.py
File vdsm/v2v.py:
Line 282:
Nir Soffer has posted comments on this change.
Change subject: Refactor v2v jobs for reusability
..
Patch Set 7:
Adam, I suggest to separate the new jobs module and the v2v changes. This will
allow us to use the new
Nir Soffer has posted comments on this change.
Change subject: Refactor v2v jobs for reusability
..
Patch Set 7:
(1 comment)
https://gerrit.ovirt.org/#/c/44857/7/vdsm/v2v.py
File vdsm/v2v.py:
Line 282:
Arik Hadas has posted comments on this change.
Change subject: Refactor v2v jobs for reusability
..
Patch Set 7: Code-Review-1
the verification is not complete - it is not enough to validate import of OVA
file, but import
automat...@ovirt.org has posted comments on this change.
Change subject: Refactor v2v jobs for reusability
..
Patch Set 7:
* Update tracker::IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header
Adam Litke has posted comments on this change.
Change subject: Refactor v2v jobs for reusability
..
Patch Set 7:
Oh how I love false CI failures :)
--
To view, visit https://gerrit.ovirt.org/44857
To unsubscribe, visit
Nir Soffer has posted comments on this change.
Change subject: Refactor v2v jobs for reusability
..
Patch Set 7:
Adam, when CI fail, you can visit the build url and click Retrigger to run
the failed job again. If this was
Adam Litke has posted comments on this change.
Change subject: Refactor v2v jobs for reusability
..
Patch Set 7: Verified+1
Verified with engine doing an OVA import. Added delete and abort passthrough
APIs back to v2v.py.
Nir Soffer has posted comments on this change.
Change subject: Refactor v2v jobs for reusability
..
Patch Set 7: Code-Review+1
Looks even better now with the missing apis :-)
--
To view, visit https://gerrit.ovirt.org/44857
Shahar Havivi has posted comments on this change.
Change subject: Refactor v2v jobs for reusability
..
Patch Set 6: Code-Review-1
Adam,
You can verify, engine and vdsm works fine with the jobs as well as with the
ova flow.
I
Adam Litke has posted comments on this change.
Change subject: Refactor v2v jobs for reusability
..
Patch Set 7:
Arik, would you be kind enough to test this for me? I do not have a vmware
environment.
--
To view, visit
Adam Litke has posted comments on this change.
Change subject: Refactor v2v jobs for reusability
..
Patch Set 5:
(8 comments)
https://gerrit.ovirt.org/#/c/44857/5/tests/jobsTests.py
File tests/jobsTests.py:
Line 28: class
Adam Litke has posted comments on this change.
Change subject: Refactor v2v jobs for reusability
..
Patch Set 3:
(4 comments)
https://gerrit.ovirt.org/#/c/44857/3/vdsm/jobs.py
File vdsm/jobs.py:
Line 73: _JOB_TYPE = None
automat...@ovirt.org has posted comments on this change.
Change subject: Refactor v2v jobs for reusability
..
Patch Set 6:
* Update tracker::IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header
Nir Soffer has posted comments on this change.
Change subject: Refactor v2v jobs for reusability
..
Patch Set 3:
(1 comment)
https://gerrit.ovirt.org/#/c/44857/3/vdsm/v2v.py
File vdsm/v2v.py:
Line 45: import caps
Line 46:
Adam Litke has posted comments on this change.
Change subject: Refactor v2v jobs for reusability
..
Patch Set 6: Verified+1
Verified with vdscli based script since the engine-vdsm OVA import flow is not
yet stabilized.
--
Nir Soffer has posted comments on this change.
Change subject: Refactor v2v jobs for reusability
..
Patch Set 6: Code-Review+1
Looks great, but I think Francesco and Piotr should approve this.
--
To view, visit
automat...@ovirt.org has posted comments on this change.
Change subject: Refactor v2v jobs for reusability
..
Patch Set 4:
* Update tracker::IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header
Adam Litke has posted comments on this change.
Change subject: Refactor v2v jobs for reusability
..
Patch Set 3:
(7 comments)
https://gerrit.ovirt.org/#/c/44857/3//COMMIT_MSG
Commit Message:
Line 11: to manage long-running
automat...@ovirt.org has posted comments on this change.
Change subject: Refactor v2v jobs for reusability
..
Patch Set 5:
* Update tracker::IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header
Nir Soffer has posted comments on this change.
Change subject: Refactor v2v jobs for reusability
..
Patch Set 5:
(6 comments)
The tests can be simplified.
https://gerrit.ovirt.org/#/c/44857/5/tests/jobsTests.py
File
Nir Soffer has posted comments on this change.
Change subject: Refactor v2v jobs for reusability
..
Patch Set 5:
(2 comments)
Looks good, -1 for visibility.
https://gerrit.ovirt.org/#/c/44857/5/vdsm/jobs.py
File
Nir Soffer has posted comments on this change.
Change subject: Refactor v2v jobs for reusability
..
Patch Set 3:
(1 comment)
https://gerrit.ovirt.org/#/c/44857/3/vdsm/jobs.py
File vdsm/jobs.py:
Line 73: _JOB_TYPE = None
Nir Soffer has posted comments on this change.
Change subject: Refactor v2v jobs for reusability
..
Patch Set 5: Code-Review-1
--
To view, visit https://gerrit.ovirt.org/44857
To unsubscribe, visit
Shahar Havivi has posted comments on this change.
Change subject: Refactor v2v jobs for reusability
..
Patch Set 3: Code-Review-1
Code wise is good and I on for separating the jobs,
But I don't see how did you verify???
you
Nir Soffer has posted comments on this change.
Change subject: Refactor v2v jobs for reusability
..
Patch Set 3:
(1 comment)
https://gerrit.ovirt.org/#/c/44857/3/vdsm/v2v.py
File vdsm/v2v.py:
Line 107:
Line 108: def
Francesco Romani has posted comments on this change.
Change subject: Refactor v2v jobs for reusability
..
Patch Set 3:
(1 comment)
https://gerrit.ovirt.org/#/c/44857/3//COMMIT_MSG
Commit Message:
Line 11: to manage
Nir Soffer has posted comments on this change.
Change subject: Refactor v2v jobs for reusability
..
Patch Set 3:
(1 comment)
https://gerrit.ovirt.org/#/c/44857/3/vdsm/v2v.py
File vdsm/v2v.py:
Line 107:
Line 108: def
Adam Litke has posted comments on this change.
Change subject: Refactor v2v jobs for reusability
..
Patch Set 3: Verified+1
Tested the OVA import flow using a vdscli script.
--
To view, visit https://gerrit.ovirt.org/44857
Francesco Romani has posted comments on this change.
Change subject: Refactor v2v jobs for reusability
..
Patch Set 3:
(4 comments)
initial comments, partial review, no score. Overall looks good, though
Nir Soffer has posted comments on this change.
Change subject: Refactor v2v jobs for reusability
..
Patch Set 3: Code-Review-1
--
To view, visit https://gerrit.ovirt.org/44857
To unsubscribe, visit
Nir Soffer has posted comments on this change.
Change subject: Refactor v2v jobs for reusability
..
Patch Set 3:
(10 comments)
https://gerrit.ovirt.org/#/c/44857/3/vdsm/jobs.py
File vdsm/jobs.py:
Line 45: UNKNOWN: the
automat...@ovirt.org has posted comments on this change.
Change subject: Refactor v2v jobs for reusability
..
Patch Set 2:
* Update tracker::IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header
Adam Litke has posted comments on this change.
Change subject: Refactor v2v jobs for reusability
..
Patch Set 2:
(27 comments)
https://gerrit.ovirt.org/#/c/44857/2/tests/jobsTests.py
File tests/jobsTests.py:
Line 19:
Line
automat...@ovirt.org has posted comments on this change.
Change subject: Refactor v2v jobs for reusability
..
Patch Set 3:
* Update tracker::IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header
Nir Soffer has posted comments on this change.
Change subject: Refactor v2v jobs for reusability
..
Patch Set 2: Code-Review-1
(27 comments)
Looks good, see inline comments.
Shahar Havivi has posted comments on this change.
Change subject: Refactor v2v jobs for reusability
..
Patch Set 1:
Please don't merge until patch https://gerrit.ovirt.org/#/c/43367/ will merged.
You need to verify that the
automat...@ovirt.org has posted comments on this change.
Change subject: Refactor v2v jobs for reusability
..
Patch Set 1:
* Update tracker::IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header
Adam Litke has uploaded a new change for review.
Change subject: Refactor v2v jobs for reusability
..
Refactor v2v jobs for reusability
Change-Id: Ida6b1c460c5030c820c540e836e423d4632410df
Signed-off-by: Adam Litke
Nir Soffer has posted comments on this change.
Change subject: Refactor v2v jobs for reusability
..
Patch Set 1: Code-Review-1
(3 comments)
https://gerrit.ovirt.org/#/c/44857/1/vdsm/jobs.py
File vdsm/jobs.py:
Line 21: import
53 matches
Mail list logo
