gerrit-hooks has posted comments on this change.
Change subject: Remove deathSignal usages in sync execCmd calls
..
Patch Set 7:
* Update tracker: IGNORE, no Bug-Url found
* Set MODIFIED::IGNORE, no Bug-Url found.
--
To
Dan Kenigsberg has submitted this change and it was merged.
Change subject: Remove deathSignal usages in sync execCmd calls
..
Remove deathSignal usages in sync execCmd calls
Once moving to systemd, when vdsm dies all
Yaniv Bronhaim has posted comments on this change.
Change subject: Remove deathSignal usages in sync execCmd calls
..
Patch Set 6: Verified+1
--
To view, visit https://gerrit.ovirt.org/52646
To unsubscribe, visit
Yaniv Bronhaim has posted comments on this change.
Change subject: Remove deathSignal usages in sync execCmd calls
..
Patch Set 6:
blkdiscard - unit tests are enough - DONE
curlimgWarp - if we have tests running this tool,
Francesco Romani has posted comments on this change.
Change subject: Remove deathSignal usages in sync execCmd calls
..
Patch Set 6: Code-Review+1
--
To view, visit https://gerrit.ovirt.org/52646
To unsubscribe, visit
Nir Soffer has posted comments on this change.
Change subject: Remove deathSignal usages in sync execCmd calls
..
Patch Set 6: Code-Review+2
Verifying this patch:
- blkdiscard - unit tests are enough
- curlimgWarp - if we have
Yaniv Bronhaim has posted comments on this change.
Change subject: Remove deathSignal usages in sync execCmd calls
..
Patch Set 6:
yes. please suggest how to verify . all are storage related parts
--
To view, visit
Nir Soffer has posted comments on this change.
Change subject: Remove deathSignal usages in sync execCmd calls
..
Patch Set 6:
Yaniv, did you address the comments in version 5?
--
To view, visit
gerrit-hooks has posted comments on this change.
Change subject: Remove deathSignal usages in sync execCmd calls
..
Patch Set 6:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure
Nir Soffer has posted comments on this change.
Change subject: Remove deathSignal usages in sync execCmd calls
..
Patch Set 5: Code-Review-1
(1 comment)
https://gerrit.ovirt.org/#/c/52646/5/lib/vdsm/qemuimg.py
File
Francesco Romani has posted comments on this change.
Change subject: Remove deathSignal usages in sync execCmd calls
..
Patch Set 5: Code-Review+1
let's move forward
--
To view, visit https://gerrit.ovirt.org/52646
To
gerrit-hooks has posted comments on this change.
Change subject: Remove deathSignal usages in sync execCmd calls
..
Patch Set 5:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure
gerrit-hooks has posted comments on this change.
Change subject: Remove deathSignal usages in sync execCmd calls
..
Patch Set 4:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure
gerrit-hooks has posted comments on this change.
Change subject: Remove deathSignal usages in sync execCmd calls
..
Patch Set 3:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure
Yaniv Bronhaim has posted comments on this change.
Change subject: Remove deathSignal usages in sync execCmd calls
..
Patch Set 2:
this can get it now.
--
To view, visit https://gerrit.ovirt.org/52646
To unsubscribe, visit
gerrit-hooks has posted comments on this change.
Change subject: Remove deathSignal usages in sync execCmd calls
..
Patch Set 2:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure
Yaniv Bronhaim has posted comments on this change.
Change subject: Remove deathSignal usages in sync execCmd calls
..
Patch Set 1:
meant to https://gerrit.ovirt.org/52670
--
To view, visit https://gerrit.ovirt.org/52646
To
Nir Soffer has posted comments on this change.
Change subject: Remove deathSignal usages in sync execCmd calls
..
Patch Set 1:
Yaniv, how is this patch not related to death signal removal?
--
To view, visit
Yaniv Bronhaim has posted comments on this change.
Change subject: Remove deathSignal usages in sync execCmd calls
..
Patch Set 1:
https://gerrit.ovirt.org/#/c/51763/ is about sync=False and data!=none and
Francesco Romani has posted comments on this change.
Change subject: Remove deathSignal usages in sync execCmd calls
..
Patch Set 1: Code-Review+1
(2 comments)
only nits about commit message.
Nir Soffer has posted comments on this change.
Change subject: Remove deathSignal usages in sync execCmd calls
..
Patch Set 1:
Looks good, but we are not handling yet errors in execCmd - we had few patches
for this, but they
Dan Kenigsberg has posted comments on this change.
Change subject: Remove deathSignal usages in sync execCmd calls
..
Patch Set 1: Code-Review+1
--
To view, visit https://gerrit.ovirt.org/52646
To unsubscribe, visit
Yaniv Bronhaim has posted comments on this change.
Change subject: Remove deathSignal usages in sync execCmd calls
..
Patch Set 1: Verified+1
--
To view, visit https://gerrit.ovirt.org/52646
To unsubscribe, visit
Yaniv Bronhaim has uploaded a new change for review.
Change subject: Remove deathSignal usages in sync execCmd calls
..
Remove deathSignal usages in sync execCmd calls
Once moving to systemctl, when vdsm dies all subprocesses
gerrit-hooks has posted comments on this change.
Change subject: Remove deathSignal usages in sync execCmd calls
..
Patch Set 1:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure
25 matches
Mail list logo
