Dan Kenigsberg has submitted this change and it was merged.
Change subject: Removing update of 'node.startup' setting in 'addIscsiPortal'
..
Removing update of 'node.startup' setting in 'addIscsiPortal'
I removed not working co
Dan Kenigsberg has posted comments on this change.
Change subject: Removing update of 'node.startup' setting in 'addIscsiPortal'
..
Patch Set 3:
Eduardo, I tend to agree that this patch, with its stated intention of removing
l
Ayal Baron has posted comments on this change.
Change subject: Removing update of 'node.startup' setting in 'addIscsiPortal'
..
Patch Set 3: Looks good to me, approved
So we came round circle on this.
addIscsiPortal is only eve
Sergey Gotliv has posted comments on this change.
Change subject: Removing update of 'node.startup' setting in 'addIscsiPortal'
..
Patch Set 3: Verified
Code removal is safe. All targets discovered during this method will be re
Ayal Baron has posted comments on this change.
Change subject: Removing update of 'node.startup' setting in 'addIscsiPortal'
..
Patch Set 3: No score
After discussing with Sergey, this is to make sure to override the basic
isc
Federico Simoncelli has posted comments on this change.
Change subject: Removing update of 'node.startup' setting in 'addIscsiPortal'
..
Patch Set 3: Looks good to me, but someone else must approve
--
To view, visit http://ger
Ayal Baron has posted comments on this change.
Change subject: Removing update of 'node.startup' setting in 'addIscsiPortal'
..
Patch Set 3: (1 inline comment)
File vdsm/stor
Federico Simoncelli has posted comments on this change.
Change subject: Removing update of 'node.startup' setting in 'addIscsiPortal'
..
Patch Set 3: I would prefer that you didn't submit this
(1 inline comment)
Downvoting for
Ayal Baron has posted comments on this change.
Change subject: Removing update of 'node.startup' setting in 'addIscsiPortal'
..
Patch Set 3: Looks good to me, approved
(2 inline comments)
..
Sergey Gotliv has posted comments on this change.
Change subject: Removing update of 'node.startup' setting in 'addIscsiPortal'
..
Patch Set 3: (1 inline comment)
File vdsm/s
Eduardo has posted comments on this change.
Change subject: Removing update of 'node.startup' setting in 'addIscsiPortal'
..
Patch Set 3: I would prefer that you didn't submit this
(1 inline comment)
..
Dan Kenigsberg has posted comments on this change.
Change subject: Removing update of 'node.startup' setting in 'addIscsiPortal'
..
Patch Set 3: (1 inline comment)
File vdsm/
Sergey Gotliv has posted comments on this change.
Change subject: Removing update of 'node.startup' setting in 'addIscsiPortal'
..
Patch Set 3: (1 inline comment)
File vdsm/s
Federico Simoncelli has posted comments on this change.
Change subject: Removing update of 'node.startup' setting in 'addIscsiPortal'
..
Patch Set 3: (1 inline comment)
File
Dan Kenigsberg has posted comments on this change.
Change subject: Removing update of 'node.startup' setting in 'addIscsiPortal'
..
Patch Set 3: Looks good to me, but someone else must approve
Removing non-functional code (with
oVirt Jenkins CI Server has posted comments on this change.
Change subject: Removing update of 'node.startup' setting in 'addIscsiPortal'
..
Patch Set 3:
Build Successful
http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el
16 matches
Mail list logo
