Zhou Zheng Sheng has posted comments on this change.
Change subject: Split vdsm init script into pieces
..
Patch Set 3: (2 inline comments)
File vdsm_hooks/vdsmd_init/env_com
Dan Kenigsberg has posted comments on this change.
Change subject: Split vdsm init script into pieces
..
Patch Set 3: (2 inline comments)
File vdsm_hooks/vdsmd_init/env_commo
Zhou Zheng Sheng has posted comments on this change.
Change subject: Split vdsm init script into pieces
..
Patch Set 3: No score
Thanks Alon!
1 and 2: use different wrapper script for Red Hat family and Debian famlily.
I agre
Alon Bar-Lev has posted comments on this change.
Change subject: Split vdsm init script into pieces
..
Patch Set 3:
1. A problem is that on Debian there is no /etc/init.d/functions, and the
"failure" and "success" function is
Zhou Zheng Sheng has posted comments on this change.
Change subject: Split vdsm init script into pieces
..
Patch Set 3:
By the way, I think sourcing all the scripts is simple, but I don't find how
can the demo script calculate
Zhou Zheng Sheng has posted comments on this change.
Change subject: Split vdsm init script into pieces
..
Patch Set 3:
Thanks Alon. I have two questions.
1. A problem is that on Debian there is no /etc/init.d/functions, and t
Alon Bar-Lev has posted comments on this change.
Change subject: Split vdsm init script into pieces
..
Patch Set 3:
1. Great.
2. I have a proposal. Can we consider using a
--with-initd-functions=/etc/init.d/functions option i
Zhou Zheng Sheng has posted comments on this change.
Change subject: Split vdsm init script into pieces
..
Patch Set 3:
Thanks very much, Alon.
Here are my response to the problems.
1. About setting a environment variable to
Alon Bar-Lev has posted comments on this change.
Change subject: Split vdsm init script into pieces
..
Patch Set 3: (1 inline comment)
First I would like to thank you for the effort!
However, before I continue th review...
Al
Zhou Zheng Sheng has posted comments on this change.
Change subject: Split vdsm init script into pieces
..
Patch Set 3: Verified
Successfully start/stop vdmsd on Fedora and RHEL6, and successfully configure
libvirt.
--
To vie
oVirt Jenkins CI Server has posted comments on this change.
Change subject: Split vdsm init script into pieces
..
Patch Set 3:
Build Successful
http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/2380/ : SUCCESS
http://jenkins.ovi
oVirt Jenkins CI Server has posted comments on this change.
Change subject: Split vdsm init script into pieces
..
Patch Set 3:
Build Started http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/2380/ (3/3)
--
To view, visit http://ge
oVirt Jenkins CI Server has posted comments on this change.
Change subject: Split vdsm init script into pieces
..
Patch Set 3:
Build Started http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/2448/ (2/3)
--
To view, visit htt
oVirt Jenkins CI Server has posted comments on this change.
Change subject: Split vdsm init script into pieces
..
Patch Set 3:
Build Started http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/1546/ (1/3)
--
To view, visit
14 matches
Mail list logo