Change in vdsm[master]: Split vdsm init script into pieces

2013-06-03 Thread zhshzhou
Zhou Zheng Sheng has posted comments on this change. Change subject: Split vdsm init script into pieces .. Patch Set 3: (2 inline comments) File vdsm_hooks/vdsmd_init/env_com

Change in vdsm[master]: Split vdsm init script into pieces

2013-06-02 Thread danken
Dan Kenigsberg has posted comments on this change. Change subject: Split vdsm init script into pieces .. Patch Set 3: (2 inline comments) File vdsm_hooks/vdsmd_init/env_commo

Change in vdsm[master]: Split vdsm init script into pieces

2013-05-30 Thread zhshzhou
Zhou Zheng Sheng has posted comments on this change. Change subject: Split vdsm init script into pieces .. Patch Set 3: No score Thanks Alon! 1 and 2: use different wrapper script for Red Hat family and Debian famlily. I agre

Change in vdsm[master]: Split vdsm init script into pieces

2013-05-24 Thread Alon Bar-Lev
Alon Bar-Lev has posted comments on this change. Change subject: Split vdsm init script into pieces .. Patch Set 3: 1. A problem is that on Debian there is no /etc/init.d/functions, and the "failure" and "success" function is

Change in vdsm[master]: Split vdsm init script into pieces

2013-05-24 Thread zhshzhou
Zhou Zheng Sheng has posted comments on this change. Change subject: Split vdsm init script into pieces .. Patch Set 3: By the way, I think sourcing all the scripts is simple, but I don't find how can the demo script calculate

Change in vdsm[master]: Split vdsm init script into pieces

2013-05-24 Thread zhshzhou
Zhou Zheng Sheng has posted comments on this change. Change subject: Split vdsm init script into pieces .. Patch Set 3: Thanks Alon. I have two questions. 1. A problem is that on Debian there is no /etc/init.d/functions, and t

Change in vdsm[master]: Split vdsm init script into pieces

2013-05-23 Thread Alon Bar-Lev
Alon Bar-Lev has posted comments on this change. Change subject: Split vdsm init script into pieces .. Patch Set 3: 1. Great. 2. I have a proposal. Can we consider using a --with-initd-functions=/etc/init.d/functions option i

Change in vdsm[master]: Split vdsm init script into pieces

2013-05-22 Thread zhshzhou
Zhou Zheng Sheng has posted comments on this change. Change subject: Split vdsm init script into pieces .. Patch Set 3: Thanks very much, Alon. Here are my response to the problems. 1. About setting a environment variable to

Change in vdsm[master]: Split vdsm init script into pieces

2013-05-22 Thread Alon Bar-Lev
Alon Bar-Lev has posted comments on this change. Change subject: Split vdsm init script into pieces .. Patch Set 3: (1 inline comment) First I would like to thank you for the effort! However, before I continue th review... Al

Change in vdsm[master]: Split vdsm init script into pieces

2013-05-21 Thread zhshzhou
Zhou Zheng Sheng has posted comments on this change. Change subject: Split vdsm init script into pieces .. Patch Set 3: Verified Successfully start/stop vdmsd on Fedora and RHEL6, and successfully configure libvirt. -- To vie

Change in vdsm[master]: Split vdsm init script into pieces

2013-05-21 Thread Gerrit Code Review
oVirt Jenkins CI Server has posted comments on this change. Change subject: Split vdsm init script into pieces .. Patch Set 3: Build Successful http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/2380/ : SUCCESS http://jenkins.ovi

Change in vdsm[master]: Split vdsm init script into pieces

2013-05-21 Thread Gerrit Code Review
oVirt Jenkins CI Server has posted comments on this change. Change subject: Split vdsm init script into pieces .. Patch Set 3: Build Started http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/2380/ (3/3) -- To view, visit http://ge

Change in vdsm[master]: Split vdsm init script into pieces

2013-05-21 Thread Gerrit Code Review
oVirt Jenkins CI Server has posted comments on this change. Change subject: Split vdsm init script into pieces .. Patch Set 3: Build Started http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/2448/ (2/3) -- To view, visit htt

Change in vdsm[master]: Split vdsm init script into pieces

2013-05-21 Thread Gerrit Code Review
oVirt Jenkins CI Server has posted comments on this change. Change subject: Split vdsm init script into pieces .. Patch Set 3: Build Started http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/1546/ (1/3) -- To view, visit