Change in vdsm[master]: client: do not protect requests on client side

2016-05-10 Thread danken
Dan Kenigsberg has submitted this change and it was merged. Change subject: client: do not protect requests on client side .. client: do not protect requests on client side We need to keep message content without any changes be

Change in vdsm[master]: client: do not protect requests on client side

2016-05-10 Thread ybronhei
Yaniv Bronhaim has posted comments on this change. Change subject: client: do not protect requests on client side .. Patch Set 4: Code-Review+1 -- To view, visit https://gerrit.ovirt.org/56288 To unsubscribe, visit https://ger

Change in vdsm[master]: client: do not protect requests on client side

2016-05-10 Thread stirabos
Simone Tiraboschi has posted comments on this change. Change subject: client: do not protect requests on client side .. Patch Set 4: Verified+1 Verified on HE flow -- To view, visit https://gerrit.ovirt.org/56288 To unsubscri

Change in vdsm[master]: client: do not protect requests on client side

2016-05-09 Thread nsoffer
Nir Soffer has posted comments on this change. Change subject: client: do not protect requests on client side .. Patch Set 4: Code-Review+2 -- To view, visit https://gerrit.ovirt.org/56288 To unsubscribe, visit https://gerrit.

Change in vdsm[master]: client: do not protect requests on client side

2016-05-09 Thread piotr . kliczewski
Piotr Kliczewski has posted comments on this change. Change subject: client: do not protect requests on client side .. Patch Set 4: Verified+1 Simone can you please verify? -- To view, visit https://gerrit.ovirt.org/56288 To

Change in vdsm[master]: client: do not protect requests on client side

2016-05-09 Thread automation
gerrit-hooks has posted comments on this change. Change subject: client: do not protect requests on client side .. Patch Set 4: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure heade

Change in vdsm[master]: client: do not protect requests on client side

2016-05-05 Thread ybronhei
Yaniv Bronhaim has posted comments on this change. Change subject: client: do not protect requests on client side .. Patch Set 3: hosted-engine setup still fails with this fix .. didnt see exactly why -- To view, visit https:

Change in vdsm[master]: client: do not protect requests on client side

2016-05-04 Thread nsoffer
Nir Soffer has posted comments on this change. Change subject: client: do not protect requests on client side .. Patch Set 3: Trying again: Asking the user of this code to send protect_password=False for client connection is

Change in vdsm[master]: client: do not protect requests on client side

2016-05-04 Thread ybronhei
Yaniv Bronhaim has posted comments on this change. Change subject: client: do not protect requests on client side .. Patch Set 3: > This is the wrong fix, taking it means breaking again the client code using > the wrong fix wh

Change in vdsm[master]: client: do not protect requests on client side

2016-05-04 Thread nsoffer
Nir Soffer has posted comments on this change. Change subject: client: do not protect requests on client side .. Patch Set 3: This is the wrong fix, taking it means breaking again the client code using the wrong fix when we ap

Change in vdsm[master]: client: do not protect requests on client side

2016-05-04 Thread ybronhei
Yaniv Bronhaim has posted comments on this change. Change subject: client: do not protect requests on client side .. Patch Set 3: I saw your comment. I agree that password protection should move to the decode part , but I also

Change in vdsm[master]: client: do not protect requests on client side

2016-05-04 Thread nsoffer
Nir Soffer has posted comments on this change. Change subject: client: do not protect requests on client side .. Patch Set 3: Code-Review-1 Please check my comments on version 2. -- To view, visit https://gerrit.ovirt.org/562

Change in vdsm[master]: client: do not protect requests on client side

2016-05-04 Thread ybronhei
Yaniv Bronhaim has posted comments on this change. Change subject: client: do not protect requests on client side .. Patch Set 3: Code-Review+1 -- To view, visit https://gerrit.ovirt.org/56288 To unsubscribe, visit https://ger

Change in vdsm[master]: client: do not protect requests on client side

2016-05-02 Thread nsoffer
Nir Soffer has posted comments on this change. Change subject: client: do not protect requests on client side .. Patch Set 2: (2 comments) https://gerrit.ovirt.org/#/c/56288/2/lib/yajsonrpc/__init__.py File lib/yajsonrpc/__ini

Change in vdsm[master]: client: do not protect requests on client side

2016-05-02 Thread automation
gerrit-hooks has posted comments on this change. Change subject: client: do not protect requests on client side .. Patch Set 3: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure heade

Change in vdsm[master]: client: do not protect requests on client side

2016-05-02 Thread piotr . kliczewski
Piotr Kliczewski has posted comments on this change. Change subject: client: do not protect requests on client side .. Patch Set 2: (2 comments) https://gerrit.ovirt.org/#/c/56288/2/lib/yajsonrpc/__init__.py File lib/yajsonrpc

Change in vdsm[master]: client: do not protect requests on client side

2016-05-01 Thread nsoffer
Nir Soffer has posted comments on this change. Change subject: client: do not protect requests on client side .. Patch Set 2: (5 comments) https://gerrit.ovirt.org/#/c/56288/2/lib/yajsonrpc/__init__.py File lib/yajsonrpc/__ini

Change in vdsm[master]: client: do not protect requests on client side

2016-05-01 Thread nsoffer
Nir Soffer has posted comments on this change. Change subject: client: do not protect requests on client side .. Patch Set 2: (1 comment) https://gerrit.ovirt.org/#/c/56288/2/lib/yajsonrpc/__init__.py File lib/yajsonrpc/__init

Change in vdsm[master]: client: do not protect requests on client side

2016-04-30 Thread ybronhei
Yaniv Bronhaim has posted comments on this change. Change subject: client: do not protect requests on client side .. Patch Set 2: Code-Review-1 (1 comment) https://gerrit.ovirt.org/#/c/56288/2/lib/yajsonrpc/__init__.py File li

Change in vdsm[master]: client: do not protect requests on client side

2016-04-27 Thread sbonazzo
Sandro Bonazzola has posted comments on this change. Change subject: client: do not protect requests on client side .. Patch Set 2: Code-Review+1 -- To view, visit https://gerrit.ovirt.org/56288 To unsubscribe, visit https://g

Change in vdsm[master]: client: do not protect requests on client side

2016-04-27 Thread stirabos
Simone Tiraboschi has posted comments on this change. Change subject: client: do not protect requests on client side .. Patch Set 2: Verified+1 Verified on iSCSI deployment -- To view, visit https://gerrit.ovirt.org/56288 To

Change in vdsm[master]: client: do not protect requests on client side

2016-04-26 Thread piotr . kliczewski
Piotr Kliczewski has posted comments on this change. Change subject: client: do not protect requests on client side .. Patch Set 2: Yaniv's comments fixed. Simone can you verify it one more time? -- To view, visit https://ger

Change in vdsm[master]: client: do not protect requests on client side

2016-04-26 Thread automation
gerrit-hooks has posted comments on this change. Change subject: client: do not protect requests on client side .. Patch Set 2: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure heade

Change in vdsm[master]: client: do not protect requests on client side

2016-04-26 Thread sbonazzo
Sandro Bonazzola has posted comments on this change. Change subject: client: do not protect requests on client side .. Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.ovirt.org/56288 To unsubscribe, visit https://g

Change in vdsm[master]: client: do not protect requests on client side

2016-04-26 Thread stirabos
Simone Tiraboschi has posted comments on this change. Change subject: client: do not protect requests on client side .. Patch Set 1: Verified on ovirt-hosted-engine-setup -- To view, visit https://gerrit.ovirt.org/56288 To un

Change in vdsm[master]: client: do not protect requests on client side

2016-04-22 Thread piotr . kliczewski
Piotr Kliczewski has posted comments on this change. Change subject: client: do not protect requests on client side .. Patch Set 1: (1 comment) https://gerrit.ovirt.org/#/c/56288/1/lib/yajsonrpc/__init__.py File lib/yajsonrpc/

Change in vdsm[master]: client: do not protect requests on client side

2016-04-21 Thread ybronhei
Yaniv Bronhaim has posted comments on this change. Change subject: client: do not protect requests on client side .. Patch Set 1: (2 comments) change the parameter name please. https://gerrit.ovirt.org/#/c/56288/1/lib/vdsm/js

Change in vdsm[master]: client: do not protect requests on client side

2016-04-20 Thread piotr . kliczewski
Piotr Kliczewski has posted comments on this change. Change subject: client: do not protect requests on client side .. Patch Set 1: (2 comments) https://gerrit.ovirt.org/#/c/56288/1/lib/vdsm/jsonrpcvdscli.py File lib/vdsm/json

Change in vdsm[master]: client: do not protect requests on client side

2016-04-19 Thread ybronhei
Yaniv Bronhaim has posted comments on this change. Change subject: client: do not protect requests on client side .. Patch Set 1: (2 comments) https://gerrit.ovirt.org/#/c/56288/1/lib/vdsm/jsonrpcvdscli.py File lib/vdsm/jsonrp

Change in vdsm[master]: client: do not protect requests on client side

2016-04-19 Thread piotr . kliczewski
Piotr Kliczewski has posted comments on this change. Change subject: client: do not protect requests on client side .. Patch Set 1: (1 comment) https://gerrit.ovirt.org/#/c/56288/1//COMMIT_MSG Commit Message: Line 7: client:

Change in vdsm[master]: client: do not protect requests on client side

2016-04-19 Thread ybronhei
Yaniv Bronhaim has posted comments on this change. Change subject: client: do not protect requests on client side .. Patch Set 1: (1 comment) https://gerrit.ovirt.org/#/c/56288/1//COMMIT_MSG Commit Message: Line 7: client: do

Change in vdsm[master]: client: do not protect requests on client side

2016-04-18 Thread piotr . kliczewski
Piotr Kliczewski has posted comments on this change. Change subject: client: do not protect requests on client side .. Patch Set 1: (1 comment) https://gerrit.ovirt.org/#/c/56288/1//COMMIT_MSG Commit Message: Line 7: client:

Change in vdsm[master]: client: do not protect requests on client side

2016-04-18 Thread ybronhei
Yaniv Bronhaim has posted comments on this change. Change subject: client: do not protect requests on client side .. Patch Set 1: Code-Review-1 (1 comment) https://gerrit.ovirt.org/#/c/56288/1//COMMIT_MSG Commit Message: Line

Change in vdsm[master]: client: do not protect requests on client side

2016-04-18 Thread stirabos
Simone Tiraboschi has posted comments on this change. Change subject: client: do not protect requests on client side .. Patch Set 1: Verified+1 -- To view, visit https://gerrit.ovirt.org/56288 To unsubscribe, visit https://ger

Change in vdsm[master]: client: do not protect requests on client side

2016-04-18 Thread piotr . kliczewski
Piotr Kliczewski has posted comments on this change. Change subject: client: do not protect requests on client side .. Patch Set 1: Simone can you verify it if it works for you? -- To view, visit https://gerrit.ovirt.org/5628

Change in vdsm[master]: client: do not protect requests on client side

2016-04-18 Thread automation
gerrit-hooks has posted comments on this change. Change subject: client: do not protect requests on client side .. Patch Set 1: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure heade

Change in vdsm[master]: client: do not protect requests on client side

2016-04-18 Thread piotr . kliczewski
Piotr Kliczewski has uploaded a new change for review. Change subject: client: do not protect requests on client side .. client: do not protect requests on client side We need to keep message content without any changes before s