Dan Kenigsberg has submitted this change and it was merged.
Change subject: clientIF: Teardown volume path only for VDSM images
..
clientIF: Teardown volume path only for VDSM images
Trying to tear down a cdrom or external lun
Sergey Gotliv has posted comments on this change.
Change subject: clientIF: Teardown volume path only for VDSM images
..
Patch Set 7: Verified+1
--
To view, visit http://gerrit.ovirt.org/21973
To unsubscribe, visit http://gerr
oVirt Jenkins CI Server has posted comments on this change.
Change subject: clientIF: Teardown volume path only for VDSM images
..
Patch Set 6: Verified-1
Build Failed
http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/61
Nir Soffer has posted comments on this change.
Change subject: clientIF: Teardown volume path only for VDSM images
..
Patch Set 7:
Verifying it would be useful.
--
To view, visit http://gerrit.ovirt.org/21973
To unsubscribe,
Allon Mureinik has posted comments on this change.
Change subject: clientIF: Teardown volume path only for VDSM images
..
Patch Set 7: Code-Review+1
--
To view, visit http://gerrit.ovirt.org/21973
To unsubscribe, visit http://
Ayal Baron has posted comments on this change.
Change subject: clientIF: Teardown volume path only for VDSM images
..
Patch Set 7: Code-Review+2
Symmetricity issue is solved by http://gerrit.ovirt.org/#/c/22363
--
To view, vi
Nir Soffer has posted comments on this change.
Change subject: clientIF: Teardown volume path only for VDSM images
..
Patch Set 7: Code-Review+1
--
To view, visit http://gerrit.ovirt.org/21973
To unsubscribe, visit http://gerr
Nir Soffer has posted comments on this change.
Change subject: clientIF: Teardown volume path only for VDSM images
..
Patch Set 6: Code-Review+1
(1 comment)
Looks good except the unneeded parenthesis.
http://gerrit.ovirt.org/
Nir Soffer has posted comments on this change.
Change subject: clientIF: Teardown volume path only for VDSM images
..
Patch Set 5:
(2 comments)
File vdsm/clientIF.py
Line 32
Nir Soffer has posted comments on this change.
Change subject: clientIF: Teardown volume path only for VDSM images
..
Patch Set 5:
This patch should be simpler after a rebase. Can you rebase?
--
To view, visit http://gerrit.o
Nir Soffer has posted comments on this change.
Change subject: clientIF: Teardown volume path only for VDSM images
..
Patch Set 5: Code-Review+1
I think it is time to move forward with this patch.
--
To view, visit http://ger
Nir Soffer has posted comments on this change.
Change subject: clientIF: Teardown volume path only for VDSM images
..
Patch Set 5:
I suggest again to rebase this on http://gerrit.ovirt.org/22370, which simplify
the handling of
Sergey Gotliv has posted comments on this change.
Change subject: clientIF: Teardown volume path only for VDSM images
..
Patch Set 5:
Related to my another patch http://gerrit.ovirt.org/#/c/22363/.
Funny that you don't remembe
Nir Soffer has posted comments on this change.
Change subject: clientIF: Teardown volume path only for VDSM images
..
Patch Set 5:
Removing the disk check is not related to your patch.
--
To view, visit http://gerrit.ovirt.or
Sergey Gotliv has posted comments on this change.
Change subject: clientIF: Teardown volume path only for VDSM images
..
Patch Set 5:
(1 comment)
@Nir, you introduced a nice patch, but please see Ayal's comment "device ==
dis
Nir Soffer has posted comments on this change.
Change subject: clientIF: Teardown volume path only for VDSM images
..
Patch Set 5:
This patch should be rebased on http://gerrit.ovirt.org/22370, which resolve
the issues discuss
Federico Simoncelli has posted comments on this change.
Change subject: clientIF: Teardown volume path only for VDSM images
..
Patch Set 5:
(2 comments)
File vdsm/clientIF.p
Ayal Baron has posted comments on this change.
Change subject: clientIF: Teardown volume path only for VDSM images
..
Patch Set 5: Code-Review+1
(1 comment)
File vdsm/client
Michal Skrivanek has posted comments on this change.
Change subject: clientIF: Teardown volume path only for VDSM images
..
Patch Set 5:
(1 comment)
File vdsm/clientIF.py
Li
Sergey Gotliv has posted comments on this change.
Change subject: clientIF: Teardown volume path only for VDSM images
..
Patch Set 5:
(1 comment)
File vdsm/clientIF.py
Line
Nir Soffer has posted comments on this change.
Change subject: clientIF: Teardown volume path only for VDSM images
..
Patch Set 5:
(2 comments)
File vdsm/clientIF.py
Line 32
Michal Skrivanek has posted comments on this change.
Change subject: clientIF: Teardown volume path only for VDSM images
..
Patch Set 5:
(1 comment)
File vdsm/clientIF.py
Li
Sergey Gotliv has posted comments on this change.
Change subject: clientIF: Teardown volume path only for VDSM images
..
Patch Set 5:
(2 comments)
File vdsm/clientIF.py
Line
Federico Simoncelli has posted comments on this change.
Change subject: clientIF: Teardown volume path only for VDSM images
..
Patch Set 5:
(3 comments)
File vdsm/clientIF.p
Michal Skrivanek has posted comments on this change.
Change subject: clientIF: Teardown volume path only for VDSM images
..
Patch Set 5:
I'd be for splitting as well. I think it needs to be carefully verified the
==disk check
Sergey Gotliv has posted comments on this change.
Change subject: clientIF: Teardown volume path only for VDSM images
..
Patch Set 5:
(2 comments)
Nir,
Let's wait to see what others think about this patch.
I easily see 2 diff
Nir Soffer has posted comments on this change.
Change subject: clientIF: Teardown volume path only for VDSM images
..
Patch Set 5:
(1 comment)
File vdsm/vm.py
Line 81:
Line
Nir Soffer has posted comments on this change.
Change subject: clientIF: Teardown volume path only for VDSM images
..
Patch Set 5:
(2 comments)
Looks good - but I'm not sure that isVdsmImage(drive) is correct as it is now.
I
oVirt Jenkins CI Server has posted comments on this change.
Change subject: clientIF: Teardown volume path only for VDSM images
..
Patch Set 5:
Build Successful
http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/6016/ : SUCCESS
h
Sergey Gotliv has posted comments on this change.
Change subject: clientIF: Teardown volume path only for VDSM images
..
Patch Set 5:
PEP8
--
To view, visit http://gerrit.ovirt.org/21973
To unsubscribe, visit http://gerrit.ov
Sergey Gotliv has posted comments on this change.
Change subject: clientIF: Teardown volume path only for VDSM images
..
Patch Set 4:
(1 comment)
Commit Message
Line 7: clie
oVirt Jenkins CI Server has posted comments on this change.
Change subject: clientIF: Teardown volume path only for VDSM images
..
Patch Set 4: Code-Review-1 Verified-1
Build Failed
http://jenkins.ovirt.org/job/vdsm_pep8_gerr
32 matches
Mail list logo
