Change in vdsm[master]: clusterLock: Make inquire retval consistent

2015-03-18 Thread oVirt Jenkins CI Server
oVirt Jenkins CI Server has posted comments on this change. Change subject: clusterLock: Make inquire retval consistent .. Patch Set 6: Build Successful http://jenkins.ovirt.org/job/vdsm_master_create-rpms-el6-x86_64_merged/7

Change in vdsm[master]: clusterLock: Make inquire retval consistent

2015-03-18 Thread danken
Dan Kenigsberg has submitted this change and it was merged. Change subject: clusterLock: Make inquire retval consistent .. clusterLock: Make inquire retval consistent Callers of clusterLock.inquire() expect a tuple with two val

Change in vdsm[master]: clusterLock: Make inquire retval consistent

2015-03-18 Thread automation
automat...@ovirt.org has posted comments on this change. Change subject: clusterLock: Make inquire retval consistent .. Patch Set 6: * Update tracker::IGNORE, no Bug-Url found * Set MODIFIED::IGNORE, no Bug-Url found. -- To v

Change in vdsm[master]: clusterLock: Make inquire retval consistent

2015-03-18 Thread Federico Simoncelli
Federico Simoncelli has posted comments on this change. Change subject: clusterLock: Make inquire retval consistent .. Patch Set 5: Code-Review+2 -- To view, visit https://gerrit.ovirt.org/38552 To unsubscribe, visit https://g

Change in vdsm[master]: clusterLock: Make inquire retval consistent

2015-03-18 Thread danken
Dan Kenigsberg has posted comments on this change. Change subject: clusterLock: Make inquire retval consistent .. Patch Set 5: Code-Review+2 Raising -- To view, visit https://gerrit.ovirt.org/38552 To unsubscribe, visit https

Change in vdsm[master]: clusterLock: Make inquire retval consistent

2015-03-17 Thread oVirt Jenkins CI Server
oVirt Jenkins CI Server has posted comments on this change. Change subject: clusterLock: Make inquire retval consistent .. Patch Set 5: Build Successful http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/16812/ : SUCCESS h

Change in vdsm[master]: clusterLock: Make inquire retval consistent

2015-03-17 Thread automation
automat...@ovirt.org has posted comments on this change. Change subject: clusterLock: Make inquire retval consistent .. Patch Set 5: * Update tracker::IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure

Change in vdsm[master]: clusterLock: Make inquire retval consistent

2015-03-16 Thread oVirt Jenkins CI Server
oVirt Jenkins CI Server has posted comments on this change. Change subject: clusterLock: Make inquire retval consistent .. Patch Set 4: Build Failed http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/16724/ : SUCCESS http:

Change in vdsm[master]: clusterLock: Make inquire retval consistent

2015-03-16 Thread automation
automat...@ovirt.org has posted comments on this change. Change subject: clusterLock: Make inquire retval consistent .. Patch Set 4: * Update tracker::IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure

Change in vdsm[master]: clusterLock: Make inquire retval consistent

2015-03-15 Thread automation
automat...@ovirt.org has posted comments on this change. Change subject: clusterLock: Make inquire retval consistent .. Patch Set 3: * Update tracker::IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure

Change in vdsm[master]: clusterLock: Make inquire retval consistent

2015-03-15 Thread automation
automat...@ovirt.org has posted comments on this change. Change subject: clusterLock: Make inquire retval consistent .. Patch Set 2: * Update tracker::IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure

Change in vdsm[master]: clusterLock: Make inquire retval consistent

2015-03-15 Thread automation
automat...@ovirt.org has posted comments on this change. Change subject: clusterLock: Make inquire retval consistent .. Patch Set 1: * Update tracker::IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure

Change in vdsm[master]: clusterLock: Make inquire retval consistent

2015-03-12 Thread nsoffer
Nir Soffer has posted comments on this change. Change subject: clusterLock: Make inquire retval consistent .. Patch Set 1: Code-Review+1 I think we should raise something instead of returning expected output (2-tuple) with une

Change in vdsm[master]: clusterLock: Make inquire retval consistent

2015-03-11 Thread oVirt Jenkins CI Server
oVirt Jenkins CI Server has posted comments on this change. Change subject: clusterLock: Make inquire retval consistent .. Patch Set 3: Build Failed http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/16559/ : SUCCESS http:

Change in vdsm[master]: clusterLock: Make inquire retval consistent

2015-03-11 Thread oVirt Jenkins CI Server
oVirt Jenkins CI Server has posted comments on this change. Change subject: clusterLock: Make inquire retval consistent .. Patch Set 2: Build Successful http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/16551/ : SUCCESS h

Change in vdsm[master]: clusterLock: Make inquire retval consistent

2015-03-11 Thread nsoffer
Nir Soffer has posted comments on this change. Change subject: clusterLock: Make inquire retval consistent .. Patch Set 1: I would like to have raise ResourceIsFree in this case, instead of fixing later "AttributeError None ob

Change in vdsm[master]: clusterLock: Make inquire retval consistent

2015-03-11 Thread alitke
Adam Litke has posted comments on this change. Change subject: clusterLock: Make inquire retval consistent .. Patch Set 1: Verified+1 Nir, I think None, None is perfectly fine to represent the case where a resource is free. W

Change in vdsm[master]: clusterLock: Make inquire retval consistent

2015-03-10 Thread oVirt Jenkins CI Server
oVirt Jenkins CI Server has posted comments on this change. Change subject: clusterLock: Make inquire retval consistent .. Patch Set 1: Build Failed http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/16489/ : SUCCESS http:

Change in vdsm[master]: clusterLock: Make inquire retval consistent

2015-03-10 Thread alitke
Adam Litke has uploaded a new change for review. Change subject: clusterLock: Make inquire retval consistent .. clusterLock: Make inquire retval consistent Callers of clusterLock.inquire() expect a tuple with two values to be re