Nir Soffer has posted comments on this change.
Change subject: imagetickets: add tests
..
Patch Set 13: Code-Review+2 Verified+1
Tests still pass
--
To view, visit https://gerrit.ovirt.org/52900
To unsubscribe, visit https://
gerrit-hooks has posted comments on this change.
Change subject: imagetickets: add tests
..
Patch Set 14:
* Update tracker: IGNORE, no Bug-Url found
* Set MODIFIED::IGNORE, no Bug-Url found.
--
To view, visit https://gerrit.o
Nir Soffer has submitted this change and it was merged.
Change subject: imagetickets: add tests
..
imagetickets: add tests
Adding tests to the new imagetickets module.
Change-Id: I2728851a91529ec35501f423d9a798af961fb82a
Signe
gerrit-hooks has posted comments on this change.
Change subject: imagetickets: add tests
..
Patch Set 13:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: '
Nir Soffer has posted comments on this change.
Change subject: imagetickets: add tests
..
Patch Set 12:
Amit, can you rebase and verify again?
There is a path conflict, probably because of changes in the imagetickets in
maste
Nir Soffer has posted comments on this change.
Change subject: imagetickets: add tests
..
Patch Set 12: Code-Review+2
--
To view, visit https://gerrit.ovirt.org/52900
To unsubscribe, visit https://gerrit.ovirt.org/settings
Ge
Amit Aviram has posted comments on this change.
Change subject: imagetickets: add tests
..
Patch Set 12:
(1 comment)
https://gerrit.ovirt.org/#/c/52900/12/vdsm/storage/imagetickets.py
File vdsm/storage/imagetickets.py:
> Is t
Freddy Rolland has posted comments on this change.
Change subject: imagetickets: add tests
..
Patch Set 12: Code-Review+1
(1 comment)
https://gerrit.ovirt.org/#/c/52900/12/vdsm/storage/imagetickets.py
File vdsm/storage/imageti
Amit Aviram has posted comments on this change.
Change subject: imagetickets: add tests
..
Patch Set 12: Verified+1
--
To view, visit https://gerrit.ovirt.org/52900
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerr
Nir Soffer has posted comments on this change.
Change subject: imagetickets: add tests
..
Patch Set 12: Code-Review+1
Looks fine now, lets get another review.
--
To view, visit https://gerrit.ovirt.org/52900
To unsubscribe, v
gerrit-hooks has posted comments on this change.
Change subject: imagetickets: add tests
..
Patch Set 12:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: '
Nir Soffer has posted comments on this change.
Change subject: imagetickets: add tests
..
Patch Set 11:
The test module looks fine now, but it does not run in make check:
http://jenkins.ovirt.org/job/vdsm_master_check-patch-fc
Nir Soffer has posted comments on this change.
Change subject: imagetickets: add tests
..
Patch Set 10:
(1 comment)
https://gerrit.ovirt.org/#/c/52900/10/tests/imagetickets_test.py
File tests/imagetickets_test.py:
Line 121:
gerrit-hooks has posted comments on this change.
Change subject: imagetickets: add tests
..
Patch Set 11:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: '
Amit Aviram has posted comments on this change.
Change subject: imagetickets: add tests
..
Patch Set 10:
(2 comments)
https://gerrit.ovirt.org/#/c/52900/10/tests/imagetickets_test.py
File tests/imagetickets_test.py:
Line 121:
Nir Soffer has posted comments on this change.
Change subject: imagetickets: add tests
..
Patch Set 10:
(2 comments)
https://gerrit.ovirt.org/#/c/52900/10/tests/imagetickets_test.py
File tests/imagetickets_test.py:
Line 121:
Amit Aviram has posted comments on this change.
Change subject: imagetickets: add tests
..
Patch Set 9:
(4 comments)
https://gerrit.ovirt.org/#/c/52900/9/tests/imagetickets_test.py
File tests/imagetickets_test.py:
Line 53:
gerrit-hooks has posted comments on this change.
Change subject: imagetickets: add tests
..
Patch Set 10:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: '
Amit Aviram has posted comments on this change.
Change subject: imagetickets: add tests
..
Patch Set 9: -Verified
--
To view, visit https://gerrit.ovirt.org/52900
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit
Amit Aviram has posted comments on this change.
Change subject: imagetickets: add tests
..
Patch Set 9: Verified+1
--
To view, visit https://gerrit.ovirt.org/52900
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerri
Nir Soffer has posted comments on this change.
Change subject: imagetickets: add tests
..
Patch Set 9:
(4 comments)
https://gerrit.ovirt.org/#/c/52900/9/tests/imagetickets_test.py
File tests/imagetickets_test.py:
Line 53:
gerrit-hooks has posted comments on this change.
Change subject: imagetickets: add tests
..
Patch Set 9:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: '
Amit Aviram has posted comments on this change.
Change subject: imagetickets: add tests
..
Patch Set 8: -Verified
--
To view, visit https://gerrit.ovirt.org/52900
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit
Amit Aviram has posted comments on this change.
Change subject: imagetickets: add tests
..
Patch Set 8: Verified+1
--
To view, visit https://gerrit.ovirt.org/52900
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerri
gerrit-hooks has posted comments on this change.
Change subject: imagetickets: add tests
..
Patch Set 8:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: '
Amit Aviram has posted comments on this change.
Change subject: imagetickets: add tests
..
Patch Set 7:
(10 comments)
https://gerrit.ovirt.org/#/c/52900/7/tests/imagetickets_test.py
File tests/imagetickets_test.py:
Line 101:
Nir Soffer has posted comments on this change.
Change subject: imagetickets: add tests
..
Patch Set 7:
(10 comments)
Nice to see 100% coverage!
https://gerrit.ovirt.org/#/c/52900/7/tests/imagetickets_test.py
File tests/imaget
gerrit-hooks has posted comments on this change.
Change subject: imagetickets: add tests
..
Patch Set 7:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: '
gerrit-hooks has posted comments on this change.
Change subject: imagetickets: add tests
..
Patch Set 6:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: '
gerrit-hooks has posted comments on this change.
Change subject: imagetickets: add tests
..
Patch Set 5:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: '
Amit Aviram has posted comments on this change.
Change subject: imagetickets: add tests
..
Patch Set 4: -Verified
--
To view, visit https://gerrit.ovirt.org/52900
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit
Amit Aviram has posted comments on this change.
Change subject: imagetickets: add tests
..
Patch Set 4:
re: first issue, Done.
re: second issue: I'm guessing you are not rebased,
https://gerrit.ovirt.org/#/c/53279/ changed the
Nir Soffer has posted comments on this change.
Change subject: imagetickets: add tests
..
Patch Set 4: Code-Review-1
The tests fail here when ovirt_image_daemon is not installed:
Looking at the failures, it seems that replacin
Amit Aviram has posted comments on this change.
Change subject: imagetickets: add tests
..
Patch Set 4: Verified+1
--
To view, visit https://gerrit.ovirt.org/52900
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerri
gerrit-hooks has posted comments on this change.
Change subject: imagetickets: add tests
..
Patch Set 4:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: '
Amit Aviram has abandoned this change.
Change subject: imagetickets: Add tests.
..
Abandoned
--
To view, visit https://gerrit.ovirt.org/53331
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: abandon
gerrit-hooks has posted comments on this change.
Change subject: imagetickets: Add tests.
..
Patch Set 1:
* Update tracker: IGNORE, no Bug-Url found
--
To view, visit https://gerrit.ovirt.org/53331
To unsubscribe, visit https
gerrit-hooks has posted comments on this change.
Change subject: imagetickets: add tests
..
Patch Set 3:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: '
Amit Aviram has uploaded a new change for review.
Change subject: imagetickets: Add tests.
..
imagetickets: Add tests.
Change-Id: Ia1d414c96c06484365911804e438845dfe17cbb1
Signed-off-by: Amit Aviram
---
M tests/imagetickets_tes
gerrit-hooks has posted comments on this change.
Change subject: imagetickets: Add tests.
..
Patch Set 1:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: '
gerrit-hooks has posted comments on this change.
Change subject: imagetickets: add tests
..
Patch Set 2:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: '
gerrit-hooks has posted comments on this change.
Change subject: imagetickets: add tests
..
Patch Set 1:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: '
Amit Aviram has uploaded a new change for review.
Change subject: imagetickets: add tests
..
imagetickets: add tests
Adding tests to the new imagetickets module.
Change-Id: I2728851a91529ec35501f423d9a798af961fb82a
Bug-Url: htt
43 matches
Mail list logo
