Change in vdsm[master]: libvirtconnection: Replace assert with AssertionError

2016-09-25 Thread nsoffer
Nir Soffer has restored this change. Change subject: libvirtconnection: Replace assert with AssertionError .. Restored -- To view, visit https://gerrit.ovirt.org/34364 To unsubscribe, visit https://gerrit.ovirt.org/settings G

Change in vdsm[master]: libvirtconnection: Replace assert with AssertionError

2016-09-24 Thread automation
gerrit-hooks has posted comments on this change. Change subject: libvirtconnection: Replace assert with AssertionError .. Patch Set 3: * Update tracker: IGNORE, no Bug-Url found -- To view, visit https://gerrit.ovirt.org/3436

Change in vdsm[master]: libvirtconnection: Replace assert with AssertionError

2016-09-24 Thread Jenkins CI RO
Jenkins CI RO has abandoned this change. Change subject: libvirtconnection: Replace assert with AssertionError .. Abandoned Abandoned due to no activity - please restore if still relevant -- To view, visit https://gerrit.ovir

Change in vdsm[master]: libvirtconnection: Replace assert with AssertionError

2016-04-10 Thread automation
gerrit-hooks has posted comments on this change. Change subject: libvirtconnection: Replace assert with AssertionError .. Patch Set 3: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sur

Change in vdsm[master]: libvirtconnection: Replace assert with AssertionError

2015-11-18 Thread piotr . kliczewski
Piotr Kliczewski has posted comments on this change. Change subject: libvirtconnection: Replace assert with AssertionError .. Patch Set 2: Code-Review+1 -- To view, visit https://gerrit.ovirt.org/34364 To unsubscribe, visit ht

Change in vdsm[master]: libvirtconnection: Replace assert with AssertionError

2015-11-18 Thread fromani
Francesco Romani has posted comments on this change. Change subject: libvirtconnection: Replace assert with AssertionError .. Patch Set 2: Code-Review+2 After some offline discussion, I claim this module -> +2 Let's resolve any

Change in vdsm[master]: libvirtconnection: Replace assert with AssertionError

2015-11-18 Thread fromani
Francesco Romani has posted comments on this change. Change subject: libvirtconnection: Replace assert with AssertionError .. Patch Set 2: Code-Review+1 not sure is my domain, so "only" +1 from me. -- To view, visit https://g

Change in vdsm[master]: libvirtconnection: Replace assert with AssertionError

2015-11-17 Thread automation
gerrit-hooks has posted comments on this change. Change subject: libvirtconnection: Replace assert with AssertionError .. Patch Set 2: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sur

Change in vdsm[master]: libvirtconnection: Replace assert with AssertionError

2015-08-13 Thread nsoffer
Nir Soffer has posted comments on this change. Change subject: libvirtconnection: Replace assert with AssertionError .. Patch Set 1: ping? -- To view, visit https://gerrit.ovirt.org/34364 To unsubscribe, visit https://gerrit.

Change in vdsm[master]: libvirtconnection: Replace assert with AssertionError

2015-03-03 Thread mlipchuk
Maor Lipchuk has posted comments on this change. Change subject: libvirtconnection: Replace assert with AssertionError .. Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.ovirt.org/34364 To unsubscribe, visit https:

Change in vdsm[master]: libvirtconnection: Replace assert with AssertionError

2014-10-22 Thread vfeenstr
Vinzenz Feenstra has posted comments on this change. Change subject: libvirtconnection: Replace assert with AssertionError .. Patch Set 1: Code-Review+1 -- To view, visit http://gerrit.ovirt.org/34364 To unsubscribe, visit htt

Change in vdsm[master]: libvirtconnection: Replace assert with AssertionError

2014-10-22 Thread oVirt Jenkins CI Server
oVirt Jenkins CI Server has posted comments on this change. Change subject: libvirtconnection: Replace assert with AssertionError .. Patch Set 1: Build Failed http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created/13073/

Change in vdsm[master]: libvirtconnection: Replace assert with AssertionError

2014-10-22 Thread fromani
Francesco Romani has posted comments on this change. Change subject: libvirtconnection: Replace assert with AssertionError .. Patch Set 1: Code-Review+1 I agree with the rationale behind this patch, but I'm wondering if we shou

Change in vdsm[master]: libvirtconnection: Replace assert with AssertionError

2014-10-22 Thread nsoffer
Nir Soffer has uploaded a new change for review. Change subject: libvirtconnection: Replace assert with AssertionError .. libvirtconnection: Replace assert with AssertionError The code wrongly assumed that assert always exists.