gerrit-hooks has posted comments on this change.
Change subject: logging: Improve log level alignment
..
Patch Set 4:
* Update Tracker::IGNORE, no bug url/s found
* Set MODIFIED::IGNORE, no Bug-Url found.
--
To view, visit
Dan Kenigsberg has posted comments on this change.
Change subject: logging: Improve log level alignment
..
Patch Set 3: Code-Review+2
raising
--
To view, visit https://gerrit.ovirt.org/64217
To unsubscribe, visit
Dan Kenigsberg has submitted this change and it was merged.
Change subject: logging: Improve log level alignment
..
logging: Improve log level alignment
Shorten WARNING to WARN and CRITICAL to CRIT to make log messages align
Edward Haas has posted comments on this change.
Change subject: logging: Improve log level alignment
..
Patch Set 3:
IMO the two char saving is not worth the small hack
(https://gerrit.ovirt.org/#/c/64217/3/vdsm/vdsm), it is
Nir Soffer has posted comments on this change.
Change subject: logging: Improve log level alignment
..
Patch Set 3:
Edward, 2 spaces on each log line, millions of spaces per day :-)
--
To view, visit
Piotr Kliczewski has posted comments on this change.
Change subject: logging: Improve log level alignment
..
Patch Set 3: Code-Review+1
--
To view, visit https://gerrit.ovirt.org/64217
To unsubscribe, visit
Edward Haas has posted comments on this change.
Change subject: logging: Improve log level alignment
..
Patch Set 3:
Does it really worth it for just saving 2 spaces?
If this is just for the output format, can it be cut there
Milan Zamazal has posted comments on this change.
Change subject: logging: Improve log level alignment
..
Patch Set 3: Code-Review+1
--
To view, visit https://gerrit.ovirt.org/64217
To unsubscribe, visit
Nir Soffer has posted comments on this change.
Change subject: logging: Improve log level alignment
..
Patch Set 3: Verified+1
--
To view, visit https://gerrit.ovirt.org/64217
To unsubscribe, visit
gerrit-hooks has posted comments on this change.
Change subject: logging: Improve log level alignment
..
Patch Set 3:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches
Piotr Kliczewski has posted comments on this change.
Change subject: logging: Improve log level alignment
..
Patch Set 2:
Looks good to me but please add example to commit message as Milan suggests
--
To view, visit
Milan Zamazal has posted comments on this change.
Change subject: logging: Improve log level alignment
..
Patch Set 2:
(1 comment)
I like the change, let's just replace the reference in the commit message.
gerrit-hooks has posted comments on this change.
Change subject: logging: Improve log level alignment
..
Patch Set 2:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches
Nir Soffer has posted comments on this change.
Change subject: logging: Improve log level alignment
..
Patch Set 2: Verified+1
--
To view, visit https://gerrit.ovirt.org/64217
To unsubscribe, visit
Nir Soffer has posted comments on this change.
Change subject: logging: Improve log level alignment
..
Patch Set 1: Verified+1
--
To view, visit https://gerrit.ovirt.org/64217
To unsubscribe, visit
gerrit-hooks has posted comments on this change.
Change subject: logging: Improve log level alignment
..
Patch Set 1:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches
Nir Soffer has uploaded a new change for review.
Change subject: logging: Improve log level alignment
..
logging: Improve log level alignment
Shorten WARNING to WARN and CRITICAL to CRIT to make log messages align
nicer.
Here
17 matches
Mail list logo
