Change in vdsm[master]: netinfo: stop using getVlanID() in network.api

2015-10-08 Thread osvoboda
Ondřej Svoboda has posted comments on this change. Change subject: netinfo: stop using getVlanID() in network.api .. Patch Set 4: (1 comment) https://gerrit.ovirt.org/#/c/46741/4/vdsm/network/api.py File vdsm/network/api.py:

Change in vdsm[master]: netinfo: stop using getVlanID() in network.api

2015-10-07 Thread ibarkan
Ido Barkan has posted comments on this change. Change subject: netinfo: stop using getVlanID() in network.api .. Patch Set 4: (1 comment) https://gerrit.ovirt.org/#/c/46741/4/vdsm/network/api.py File vdsm/network/api.py: Line

Change in vdsm[master]: netinfo: stop using getVlanID() in network.api

2015-10-07 Thread danken
Dan Kenigsberg has submitted this change and it was merged. Change subject: netinfo: stop using getVlanID() in network.api .. netinfo: stop using getVlanID() in network.api The same information is already present in _netinfo.

Change in vdsm[master]: netinfo: stop using getVlanID() in network.api

2015-10-07 Thread automation
automat...@ovirt.org has posted comments on this change. Change subject: netinfo: stop using getVlanID() in network.api .. Patch Set 7: * Update tracker::IGNORE, no Bug-Url found * Set MODIFIED::IGNORE, no Bug-Url found. -- T

Change in vdsm[master]: netinfo: stop using getVlanID() in network.api

2015-10-07 Thread danken
Dan Kenigsberg has posted comments on this change. Change subject: netinfo: stop using getVlanID() in network.api .. Patch Set 6: Code-Review+2 raising -- To view, visit https://gerrit.ovirt.org/46741 To unsubscribe, visit ht

Change in vdsm[master]: netinfo: stop using getVlanID() in network.api

2015-10-07 Thread automation
automat...@ovirt.org has posted comments on this change. Change subject: netinfo: stop using getVlanID() in network.api .. Patch Set 6: * Update tracker::IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make su

Change in vdsm[master]: netinfo: stop using getVlanID() in network.api

2015-10-07 Thread automation
automat...@ovirt.org has posted comments on this change. Change subject: netinfo: stop using getVlanID() in network.api .. Patch Set 5: * Update tracker::IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make su

Change in vdsm[master]: netinfo: stop using getVlanID() in network.api

2015-10-07 Thread osvoboda
Ondřej Svoboda has posted comments on this change. Change subject: netinfo: stop using getVlanID() in network.api .. Patch Set 4: (1 comment) Please see the reasoning on vdsm/network/api.py https://gerrit.ovirt.org/#/c/46741/

Change in vdsm[master]: netinfo: stop using getVlanID() in network.api

2015-10-06 Thread ibarkan
Ido Barkan has posted comments on this change. Change subject: netinfo: stop using getVlanID() in network.api .. Patch Set 4: Code-Review+1 why do you suspect that it is not necessary to determine the vlan id? -- To view, vis

Change in vdsm[master]: netinfo: stop using getVlanID() in network.api

2015-09-29 Thread phoracek
Petr Horáček has posted comments on this change. Change subject: netinfo: stop using getVlanID() in network.api .. Patch Set 4: Code-Review+1 -- To view, visit https://gerrit.ovirt.org/46741 To unsubscribe, visit https://gerri

Change in vdsm[master]: netinfo: stop using getVlanID() in network.api

2015-09-28 Thread osvoboda
Ondřej Svoboda has posted comments on this change. Change subject: netinfo: stop using getVlanID() in network.api .. Patch Set 4: Verified+1 21:49:15 MountError: (32, ';mount: /tmp/vdsm-mkimage-testssREsTe/images/vmId_iso.5a22

Change in vdsm[master]: netinfo: stop using getVlanID() in network.api

2015-09-28 Thread automation
automat...@ovirt.org has posted comments on this change. Change subject: netinfo: stop using getVlanID() in network.api .. Patch Set 4: * Update tracker::IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make su

Change in vdsm[master]: netinfo: stop using getVlanID() in network.api

2015-09-28 Thread osvoboda
Ondřej Svoboda has posted comments on this change. Change subject: netinfo: stop using getVlanID() in network.api .. Patch Set 3: Code-Review-1 (1 comment) A try-except is not necessary here. https://gerrit.ovirt.org/#/c/4674

Change in vdsm[master]: netinfo: stop using getVlanID() in network.api

2015-09-28 Thread automation
automat...@ovirt.org has posted comments on this change. Change subject: netinfo: stop using getVlanID() in network.api .. Patch Set 3: * Update tracker::IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make su

Change in vdsm[master]: netinfo: stop using getVlanID() in network.api

2015-09-27 Thread automation
automat...@ovirt.org has posted comments on this change. Change subject: netinfo: stop using getVlanID() in network.api .. Patch Set 2: * Update tracker::IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make su

Change in vdsm[master]: netinfo: stop using getVlanID() in network.api

2015-09-27 Thread automation
automat...@ovirt.org has posted comments on this change. Change subject: netinfo: stop using getVlanID() in network.api .. Patch Set 1: * Update tracker::IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make su

Change in vdsm[master]: netinfo: stop using getVlanID() in network.api

2015-09-27 Thread osvoboda
Ondřej Svoboda has uploaded a new change for review. Change subject: netinfo: stop using getVlanID() in network.api .. netinfo: stop using getVlanID() in network.api The same information is already present in _netinfo. Change-I