Change in vdsm[master]: profiling: Add an application wide profile

2014-05-04 Thread danken
Dan Kenigsberg has posted comments on this change. Change subject: profiling: Add an application wide profile .. Patch Set 9: Escalating score. -- To view, visit http://gerrit.ovirt.org/26113 To unsubscribe, visit

Change in vdsm[master]: profiling: Add an application wide profile

2014-05-04 Thread danken
Dan Kenigsberg has submitted this change and it was merged. Change subject: profiling: Add an application wide profile .. profiling: Add an application wide profile The built in Python profilers are good for single thread

Change in vdsm[master]: profiling: Add an application wide profile

2014-05-04 Thread danken
Dan Kenigsberg has posted comments on this change. Change subject: profiling: Add an application wide profile .. Patch Set 9: Code-Review+2 Escalating score. -- To view, visit http://gerrit.ovirt.org/26113 To unsubscribe,

Change in vdsm[master]: profiling: Add an application wide profile

2014-05-04 Thread oVirt Jenkins CI Server
oVirt Jenkins CI Server has posted comments on this change. Change subject: profiling: Add an application wide profile .. Patch Set 10: Build Successful http://jenkins.ovirt.org/job/vdsm_master_install_rpm_sanity_gerrit/547/

Change in vdsm[master]: profiling: Add an application wide profile

2014-05-02 Thread fromani
Francesco Romani has posted comments on this change. Change subject: profiling: Add an application wide profile .. Patch Set 9: (1 comment) http://gerrit.ovirt.org/#/c/26113/9/lib/vdsm/profile.py File lib/vdsm/profile.py:

Change in vdsm[master]: profiling: Add an application wide profile

2014-05-02 Thread nsoffer
Nir Soffer has posted comments on this change. Change subject: profiling: Add an application wide profile .. Patch Set 9: (1 comment) http://gerrit.ovirt.org/#/c/26113/9/lib/vdsm/profile.py File lib/vdsm/profile.py: Line 45:

Change in vdsm[master]: profiling: Add an application wide profile

2014-05-02 Thread oVirt Jenkins CI Server
oVirt Jenkins CI Server has posted comments on this change. Change subject: profiling: Add an application wide profile .. Patch Set 9: Build Failed http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/8476/ : SUCCESS

Change in vdsm[master]: profiling: Add an application wide profile

2014-05-02 Thread fromani
Francesco Romani has posted comments on this change. Change subject: profiling: Add an application wide profile .. Patch Set 9: Code-Review+1 I was thinking to avoid to the blowing up, by coercing an unexpected value, like

Change in vdsm[master]: profiling: Add an application wide profile

2014-05-02 Thread oVirt Jenkins CI Server
oVirt Jenkins CI Server has posted comments on this change. Change subject: profiling: Add an application wide profile .. Patch Set 9: Build Failed http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/8476/ : SUCCESS

Change in vdsm[master]: profiling: Add an application wide profile

2014-05-02 Thread Federico Simoncelli
Federico Simoncelli has posted comments on this change. Change subject: profiling: Add an application wide profile .. Patch Set 9: +1 for the initiative! I'll reviw this later. Thanks Nir. -- To view, visit

Change in vdsm[master]: profiling: Add an application wide profile

2014-05-02 Thread alitke
Adam Litke has posted comments on this change. Change subject: profiling: Add an application wide profile .. Patch Set 9: Code-Review+1 -- To view, visit http://gerrit.ovirt.org/26113 To unsubscribe, visit

Change in vdsm[master]: profiling: Add an application wide profile

2014-05-02 Thread dougsland
Douglas Schilling Landgraf has posted comments on this change. Change subject: profiling: Add an application wide profile .. Patch Set 9: (1 comment) http://gerrit.ovirt.org/#/c/26113/9/lib/vdsm/profile.py File

Change in vdsm[master]: profiling: Add an application wide profile

2014-05-02 Thread nsoffer
Nir Soffer has posted comments on this change. Change subject: profiling: Add an application wide profile .. Patch Set 9: (1 comment) http://gerrit.ovirt.org/#/c/26113/9/lib/vdsm/profile.py File lib/vdsm/profile.py: Line 35:

Change in vdsm[master]: profiling: Add an application wide profile

2014-05-02 Thread dougsland
Douglas Schilling Landgraf has posted comments on this change. Change subject: profiling: Add an application wide profile .. Patch Set 9: Code-Review+1 (1 comment) http://gerrit.ovirt.org/#/c/26113/9/lib/vdsm/profile.py File

Change in vdsm[master]: profiling: Add an application wide profile

2014-05-01 Thread nsoffer
Nir Soffer has posted comments on this change. Change subject: profiling: Add an application wide profile .. Patch Set 8: Changes: - Move profiling details to profile module - Address Saggi comments regarding stopping the

Change in vdsm[master]: profiling: Add an application wide profile

2014-05-01 Thread oVirt Jenkins CI Server
oVirt Jenkins CI Server has posted comments on this change. Change subject: profiling: Add an application wide profile .. Patch Set 7: Build Failed http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/8474/ : SUCCESS

Change in vdsm[master]: profiling: Add an application wide profile

2014-05-01 Thread oVirt Jenkins CI Server
oVirt Jenkins CI Server has posted comments on this change. Change subject: profiling: Add an application wide profile .. Patch Set 8: Build Successful http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/8475/ : SUCCESS

Change in vdsm[master]: profiling: Add an application wide profile

2014-05-01 Thread nsoffer
Nir Soffer has posted comments on this change. Change subject: profiling: Add an application wide profile .. Patch Set 9: Verified+1 This patch add the new profile module to the distribution and fix a missing import. I

Change in vdsm[master]: profiling: Add an application wide profile

2014-05-01 Thread oVirt Jenkins CI Server
oVirt Jenkins CI Server has posted comments on this change. Change subject: profiling: Add an application wide profile .. Patch Set 9: Build Failed http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/8476/ : SUCCESS

Change in vdsm[master]: profiling: Add an application wide profile

2014-05-01 Thread oVirt Jenkins CI Server
oVirt Jenkins CI Server has posted comments on this change. Change subject: profiling: Add an application wide profile .. Patch Set 9: Build Failed http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/8476/ : SUCCESS

Change in vdsm[master]: profiling: Add an application wide profile

2014-05-01 Thread oVirt Jenkins CI Server
oVirt Jenkins CI Server has posted comments on this change. Change subject: profiling: Add an application wide profile .. Patch Set 9: Build Failed http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/8476/ : SUCCESS

Change in vdsm[master]: profiling: Add an application wide profile

2014-05-01 Thread oVirt Jenkins CI Server
oVirt Jenkins CI Server has posted comments on this change. Change subject: profiling: Add an application wide profile .. Patch Set 9: Build Failed http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/8476/ : SUCCESS

Change in vdsm[master]: profiling: Add an application wide profile

2014-05-01 Thread nsoffer
Nir Soffer has posted comments on this change. Change subject: profiling: Add an application wide profile .. Patch Set 9: The tests failures are not relevant (segfault in Python while running libvirt test). -- To view,

Change in vdsm[master]: profiling: Add an application wide profile

2014-05-01 Thread oVirt Jenkins CI Server
oVirt Jenkins CI Server has posted comments on this change. Change subject: profiling: Add an application wide profile .. Patch Set 9: Build Failed http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/8476/ : SUCCESS

Change in vdsm[master]: profiling: Add an application wide profile

2014-04-08 Thread nsoffer
Nir Soffer has posted comments on this change. Change subject: profiling: Add an application wide profile .. Patch Set 6: After talking with Saggi, we agreed to: - Move profiling logic to separate module under

Change in vdsm[master]: profiling: Add an application wide profile

2014-04-01 Thread smizrahi
Saggi Mizrahi has posted comments on this change. Change subject: profiling: Add an application wide profile .. Patch Set 6: Code-Review-1 (2 comments) http://gerrit.ovirt.org/#/c/26113/6/vdsm/vdsm File vdsm/vdsm: Line 88:

Change in vdsm[master]: profiling: Add an application wide profile

2014-04-01 Thread nsoffer
Nir Soffer has posted comments on this change. Change subject: profiling: Add an application wide profile .. Patch Set 6: (2 comments) Thanks, will clean up. http://gerrit.ovirt.org/#/c/26113/6/vdsm/vdsm File vdsm/vdsm:

Change in vdsm[master]: profiling: Add an application wide profile

2014-04-01 Thread nsoffer
Nir Soffer has posted comments on this change. Change subject: profiling: Add an application wide profile .. Patch Set 6: (1 comment) http://gerrit.ovirt.org/#/c/26113/6/vdsm/vdsm File vdsm/vdsm: Line 84: try: Line 85:

Change in vdsm[master]: profiling: Add an application wide profile

2014-03-31 Thread nsoffer
Nir Soffer has posted comments on this change. Change subject: profiling: Add an application wide profile .. Patch Set 6: Rebase on dependent patch. -- To view, visit http://gerrit.ovirt.org/26113 To unsubscribe, visit

Change in vdsm[master]: profiling: Add an application wide profile

2014-03-31 Thread oVirt Jenkins CI Server
oVirt Jenkins CI Server has posted comments on this change. Change subject: profiling: Add an application wide profile .. Patch Set 6: Build Successful http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/6964/ : SUCCESS

Change in vdsm[master]: profiling: Add an application wide profile

2014-03-29 Thread oVirt Jenkins CI Server
oVirt Jenkins CI Server has posted comments on this change. Change subject: profiling: Add an application wide profile .. Patch Set 5: Build Successful http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/6934/ : SUCCESS

Change in vdsm[master]: profiling: Add an application wide profile

2014-03-29 Thread nsoffer
Nir Soffer has posted comments on this change. Change subject: profiling: Add an application wide profile .. Patch Set 5: Rebased over dependent patch. -- To view, visit http://gerrit.ovirt.org/26113 To unsubscribe, visit

Change in vdsm[master]: profiling: Add an application wide profile

2014-03-27 Thread ybronhei
Yaniv Bronhaim has posted comments on this change. Change subject: profiling: Add an application wide profile .. Patch Set 2: Code-Review+1 -- To view, visit http://gerrit.ovirt.org/26113 To unsubscribe, visit

Change in vdsm[master]: profiling: Add an application wide profile

2014-03-27 Thread ybronhei
Yaniv Bronhaim has posted comments on this change. Change subject: profiling: Add an application wide profile .. Patch Set 2: Code-Review-1 you must to have yappi package on your local setup when running vdsm, and then we

Change in vdsm[master]: profiling: Add an application wide profile

2014-03-27 Thread nsoffer
Nir Soffer has posted comments on this change. Change subject: profiling: Add an application wide profile .. Patch Set 2: There is no such package, and it will take ages until we can get it into Fedora/EL. So either we ship

Change in vdsm[master]: profiling: Add an application wide profile

2014-03-27 Thread ybronhei
Yaniv Bronhaim has posted comments on this change. Change subject: profiling: Add an application wide profile .. Patch Set 2: -Code-Review removing my score. i suggest to start the packaging procedure anyway -- To view,

Change in vdsm[master]: profiling: Add an application wide profile

2014-03-27 Thread oVirt Jenkins CI Server
oVirt Jenkins CI Server has posted comments on this change. Change subject: profiling: Add an application wide profile .. Patch Set 3: Build Successful http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/6892/ : SUCCESS

Change in vdsm[master]: profiling: Add an application wide profile

2014-03-27 Thread nsoffer
Nir Soffer has posted comments on this change. Change subject: profiling: Add an application wide profile .. Patch Set 3: Added profile_format option. -- To view, visit http://gerrit.ovirt.org/26113 To unsubscribe, visit

Change in vdsm[master]: profiling: Add an application wide profile

2014-03-27 Thread nsoffer
Nir Soffer has posted comments on this change. Change subject: profiling: Add an application wide profile .. Patch Set 3: Verified+1 Verified running with and without profiling. -- To view, visit

Change in vdsm[master]: profiling: Add an application wide profile

2014-03-27 Thread oVirt Jenkins CI Server
oVirt Jenkins CI Server has posted comments on this change. Change subject: profiling: Add an application wide profile .. Patch Set 4: Build Successful http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/6894/ : SUCCESS

Change in vdsm[master]: profiling: Add an application wide profile

2014-03-27 Thread nsoffer
Nir Soffer has posted comments on this change. Change subject: profiling: Add an application wide profile .. Patch Set 4: Rebased over dependent patch. Verified on RHEL 6.5 and Fedora 19. -- To view, visit

Change in vdsm[master]: profiling: Add an application wide profile

2014-03-26 Thread nsoffer
Nir Soffer has posted comments on this change. Change subject: profiling: Add an application wide profile .. Patch Set 2: Verified+1 Move profile to /var/run/vdsm, protecting from symlink attacks. Verified by running with and

Change in vdsm[master]: profiling: Add an application wide profile

2014-03-26 Thread oVirt Jenkins CI Server
oVirt Jenkins CI Server has posted comments on this change. Change subject: profiling: Add an application wide profile .. Patch Set 2: Build Successful http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/6876/ : SUCCESS