Change in vdsm[master]: resize-lun: Rescan fiber channel devices

2015-07-15 Thread danken
Dan Kenigsberg has submitted this change and it was merged. Change subject: resize-lun: Rescan fiber channel devices .. resize-lun: Rescan fiber channel devices The fc-scan utility currently scans in order to find new LUNs. In

Change in vdsm[master]: resize-lun: Rescan fiber channel devices

2015-07-15 Thread automation
automat...@ovirt.org has posted comments on this change. Change subject: resize-lun: Rescan fiber channel devices .. Patch Set 8: * Update tracker::#609689::OK * Set MODIFIED::bug 609689#609689IGNORE, not oVirt prod but

Change in vdsm[master]: resize-lun: Rescan fiber channel devices

2015-07-14 Thread alitke
Adam Litke has posted comments on this change. Change subject: resize-lun: Rescan fiber channel devices .. Patch Set 7: Code-Review+2 -- To view, visit https://gerrit.ovirt.org/43388 To unsubscribe, visit https://gerrit.ovirt.

Change in vdsm[master]: resize-lun: Rescan fiber channel devices

2015-07-14 Thread frolland
Freddy Rolland has posted comments on this change. Change subject: resize-lun: Rescan fiber channel devices .. Patch Set 7: I verified following scenarios on a host connected to FC: Via cli: - Check LUN size with "multipath -l

Change in vdsm[master]: resize-lun: Rescan fiber channel devices

2015-07-14 Thread frolland
Freddy Rolland has posted comments on this change. Change subject: resize-lun: Rescan fiber channel devices .. Patch Set 6: (3 comments) https://gerrit.ovirt.org/#/c/43388/6//COMMIT_MSG Commit Message: Line 6: Line 7: resize

Change in vdsm[master]: resize-lun: Rescan fiber channel devices

2015-07-14 Thread automation
automat...@ovirt.org has posted comments on this change. Change subject: resize-lun: Rescan fiber channel devices .. Patch Set 7: * Update tracker::#609689::OK * Check Bug-Url::OK * Check Public Bug::#609689::OK, public bug * C

Change in vdsm[master]: resize-lun: Rescan fiber channel devices

2015-07-14 Thread nsoffer
Nir Soffer has posted comments on this change. Change subject: resize-lun: Rescan fiber channel devices .. Patch Set 6: (1 comment) https://gerrit.ovirt.org/#/c/43388/6//COMMIT_MSG Commit Message: Line 6: Line 7: resize-lun:

Change in vdsm[master]: resize-lun: Rescan fiber channel devices

2015-07-14 Thread amureini
Allon Mureinik has posted comments on this change. Change subject: resize-lun: Rescan fiber channel devices .. Patch Set 6: Code-Review+1 (2 comments) +1 on the code, minor comments on the commit message. Also, please provide

Change in vdsm[master]: resize-lun: Rescan fiber channel devices

2015-07-14 Thread frolland
Freddy Rolland has posted comments on this change. Change subject: resize-lun: Rescan fiber channel devices .. Patch Set 6: Verified+1 -- To view, visit https://gerrit.ovirt.org/43388 To unsubscribe, visit https://gerrit.ovirt

Change in vdsm[master]: resize-lun: Rescan fiber channel devices

2015-07-13 Thread nsoffer
Nir Soffer has posted comments on this change. Change subject: resize-lun: Rescan fiber channel devices .. Patch Set 6: Code-Review+1 -- To view, visit https://gerrit.ovirt.org/43388 To unsubscribe, visit https://gerrit.ovirt.

Change in vdsm[master]: resize-lun: Rescan fiber channel devices

2015-07-13 Thread frolland
Freddy Rolland has posted comments on this change. Change subject: resize-lun: Rescan fiber channel devices .. Patch Set 5: (1 comment) https://gerrit.ovirt.org/#/c/43388/5/vdsm/storage/fc-scan File vdsm/storage/fc-scan: Line

Change in vdsm[master]: resize-lun: Rescan fiber channel devices

2015-07-13 Thread automation
automat...@ovirt.org has posted comments on this change. Change subject: resize-lun: Rescan fiber channel devices .. Patch Set 6: * Update tracker::IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure hea

Change in vdsm[master]: resize-lun: Rescan fiber channel devices

2015-07-13 Thread frolland
Freddy Rolland has posted comments on this change. Change subject: resize-lun: Rescan fiber channel devices .. Patch Set 5: Verified+1 -- To view, visit https://gerrit.ovirt.org/43388 To unsubscribe, visit https://gerrit.ovirt

Change in vdsm[master]: resize-lun: Rescan fiber channel devices

2015-07-13 Thread nsoffer
Nir Soffer has posted comments on this change. Change subject: resize-lun: Rescan fiber channel devices .. Patch Set 5: (1 comment) https://gerrit.ovirt.org/#/c/43388/5/vdsm/storage/fc-scan File vdsm/storage/fc-scan: Line 112

Change in vdsm[master]: resize-lun: Rescan fiber channel devices

2015-07-13 Thread automation
automat...@ovirt.org has posted comments on this change. Change subject: resize-lun: Rescan fiber channel devices .. Patch Set 5: * Update tracker::IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure hea

Change in vdsm[master]: resize-lun: Rescan fiber channel devices

2015-07-13 Thread frolland
Freddy Rolland has posted comments on this change. Change subject: resize-lun: Rescan fiber channel devices .. Patch Set 4: Verified+1 -- To view, visit https://gerrit.ovirt.org/43388 To unsubscribe, visit https://gerrit.ovirt

Change in vdsm[master]: resize-lun: Rescan fiber channel devices

2015-07-13 Thread frolland
Freddy Rolland has posted comments on this change. Change subject: resize-lun: Rescan fiber channel devices .. Patch Set 3: (1 comment) https://gerrit.ovirt.org/#/c/43388/3/vdsm/storage/fc-scan File vdsm/storage/fc-scan: Line

Change in vdsm[master]: resize-lun: Rescan fiber channel devices

2015-07-13 Thread automation
automat...@ovirt.org has posted comments on this change. Change subject: resize-lun: Rescan fiber channel devices .. Patch Set 4: * Update tracker::IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure hea

Change in vdsm[master]: resize-lun: Rescan fiber channel devices

2015-07-13 Thread nsoffer
Nir Soffer has posted comments on this change. Change subject: resize-lun: Rescan fiber channel devices .. Patch Set 3: -Code-Review (1 comment) The glob pattern is too fragile, we need to use more robust way to find devices.

Change in vdsm[master]: resize-lun: Rescan fiber channel devices

2015-07-13 Thread nsoffer
Nir Soffer has posted comments on this change. Change subject: resize-lun: Rescan fiber channel devices .. Patch Set 3: Code-Review+1 Looks great, can you verify? -- To view, visit https://gerrit.ovirt.org/43388 To unsubscrib

Change in vdsm[master]: resize-lun: Rescan fiber channel devices

2015-07-13 Thread frolland
Freddy Rolland has posted comments on this change. Change subject: resize-lun: Rescan fiber channel devices .. Patch Set 2: (7 comments) https://gerrit.ovirt.org/#/c/43388/2/vdsm/storage/fc-scan File vdsm/storage/fc-scan: Lin

Change in vdsm[master]: resize-lun: Rescan fiber channel devices

2015-07-13 Thread automation
automat...@ovirt.org has posted comments on this change. Change subject: resize-lun: Rescan fiber channel devices .. Patch Set 3: * Update tracker::IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure hea

Change in vdsm[master]: resize-lun: Rescan fiber channel devices

2015-07-13 Thread frolland
Freddy Rolland has posted comments on this change. Change subject: resize-lun: Rescan fiber channel devices .. Patch Set 1: (5 comments) https://gerrit.ovirt.org/#/c/43388/1/vdsm/storage/fc-scan File vdsm/storage/fc-scan: Lin

Change in vdsm[master]: resize-lun: Rescan fiber channel devices

2015-07-12 Thread nsoffer
Nir Soffer has posted comments on this change. Change subject: resize-lun: Rescan fiber channel devices .. Patch Set 2: (7 comments) https://gerrit.ovirt.org/#/c/43388/2/vdsm/storage/fc-scan File vdsm/storage/fc-scan: Line 22

Change in vdsm[master]: resize-lun: Rescan fiber channel devices

2015-07-12 Thread automation
automat...@ovirt.org has posted comments on this change. Change subject: resize-lun: Rescan fiber channel devices .. Patch Set 2: * Update tracker::IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure hea

Change in vdsm[master]: resize-lun: Rescan fiber channel devices

2015-07-09 Thread nsoffer
Nir Soffer has posted comments on this change. Change subject: resize-lun: Rescan fiber channel devices .. Patch Set 1: (6 comments) Looks nice, but I think we can simplify this and should break run() to smaller methods. htt

Change in vdsm[master]: resize-lun: Rescan fiber channel devices

2015-07-09 Thread frolland
Freddy Rolland has posted comments on this change. Change subject: resize-lun: Rescan fiber channel devices .. Patch Set 1: Verified+1 -- To view, visit https://gerrit.ovirt.org/43388 To unsubscribe, visit https://gerrit.ovirt

Change in vdsm[master]: resize-lun: Rescan fiber channel devices

2015-07-09 Thread frolland
Hello Fred Rolland, I'd like you to do a code review. Please visit https://gerrit.ovirt.org/43388 to review the following change. Change subject: resize-lun: Rescan fiber channel devices .. resize-lun: Rescan fiber channe

Change in vdsm[master]: resize-lun: Rescan fiber channel devices

2015-07-09 Thread automation
automat...@ovirt.org has posted comments on this change. Change subject: resize-lun: Rescan fiber channel devices .. Patch Set 1: * Update tracker::IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure hea