Francesco Romani has uploaded a new change for review.
Change subject: sampling: extract SampleWindow class
..
sampling: extract SampleWindow class
The existing AdvancedStatsFunction does actually
two different things: wraps a c
oVirt Jenkins CI Server has posted comments on this change.
Change subject: sampling: extract SampleWindow class
..
Patch Set 1:
Build Failed
http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit_el/11813/ : SUCCESS
htt
Francesco Romani has posted comments on this change.
Change subject: sampling: extract SampleWindow class
..
Patch Set 1: Verified+1
mostrly code moving patch.
Verified using unit tests (already in place) and checking the outpu
Nir Soffer has posted comments on this change.
Change subject: sampling: extract SampleWindow class
..
Patch Set 2:
(2 comments)
http://gerrit.ovirt.org/#/c/33783/2//COMMIT_MSG
Commit Message:
Line 7: sampling: extract Sample
Nir Soffer has posted comments on this change.
Change subject: sampling: extract SampleWindow class
..
Patch Set 2:
(6 comments)
Nice refactoring, added some naming suggestions.
http://gerrit.ovirt.org/#/c/33783/2/vdsm/virt/s
Francesco Romani has posted comments on this change.
Change subject: sampling: extract SampleWindow class
..
Patch Set 2:
(6 comments)
thanks for the review!
http://gerrit.ovirt.org/#/c/33783/2/vdsm/virt/sampling.py
File vdsm
Francesco Romani has posted comments on this change.
Change subject: sampling: extract SampleWindow class
..
Patch Set 2:
(2 comments)
http://gerrit.ovirt.org/#/c/33783/2//COMMIT_MSG
Commit Message:
Line 7: sampling: extract
Francesco Romani has posted comments on this change.
Change subject: sampling: extract SampleWindow class
..
Patch Set 3:
Addressed reviewer's comments.
--
To view, visit http://gerrit.ovirt.org/33783
To unsubscribe, visit ht
Francesco Romani has posted comments on this change.
Change subject: sampling: extract SampleWindow class
..
Patch Set 2:
(2 comments)
http://gerrit.ovirt.org/#/c/33783/2/vdsm/virt/sampling.py
File vdsm/virt/sampling.py:
Line
oVirt Jenkins CI Server has posted comments on this change.
Change subject: sampling: extract SampleWindow class
..
Patch Set 2:
Build Failed
http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created/13084/ : SUCCESS
http:
oVirt Jenkins CI Server has posted comments on this change.
Change subject: sampling: extract SampleWindow class
..
Patch Set 3:
Build Failed
http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created/13095/ : SUCCESS
http:
oVirt Jenkins CI Server has posted comments on this change.
Change subject: sampling: extract SampleWindow class
..
Patch Set 4:
Build Failed
http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created/13111/ : SUCCESS
http:
Francesco Romani has posted comments on this change.
Change subject: sampling: extract SampleWindow class
..
Patch Set 4: Verified+1
last changes after verification were about naming, anyway re-verified with
tests and running
Nir Soffer has posted comments on this change.
Change subject: sampling: extract SampleWindow class
..
Patch Set 4:
(4 comments)
New docstrings can be refined.
Also some comment that probably can be handled later, to keep the
Dan Kenigsberg has posted comments on this change.
Change subject: sampling: extract SampleWindow class
..
Patch Set 4:
(1 comment)
http://gerrit.ovirt.org/#/c/33783/4/vdsm/virt/sampling.py
File vdsm/virt/sampling.py:
Line 32
Francesco Romani has posted comments on this change.
Change subject: sampling: extract SampleWindow class
..
Patch Set 4:
(4 comments)
http://gerrit.ovirt.org/#/c/33783/4/vdsm/virt/sampling.py
File vdsm/virt/sampling.py:
Line
Francesco Romani has posted comments on this change.
Change subject: sampling: extract SampleWindow class
..
Patch Set 6:
rebased because git-review was complaining (?), should be of no harm for the
affected files.
Revision 5
oVirt Jenkins CI Server has posted comments on this change.
Change subject: sampling: extract SampleWindow class
..
Patch Set 5:
Build Failed
http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created/13204/ : SUCCESS
http:
oVirt Jenkins CI Server has posted comments on this change.
Change subject: sampling: extract SampleWindow class
..
Patch Set 6:
Build Failed
http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created/13207/ : SUCCESS
http:
Francesco Romani has posted comments on this change.
Change subject: sampling: extract SampleWindow class
..
Patch Set 6: Verified+1
Verified again (just in case)
by installing fedora 20 on a VM runned by a patched VDSM and obs
Dan Kenigsberg has posted comments on this change.
Change subject: sampling: extract SampleWindow class
..
Patch Set 6: Code-Review+2
(2 comments)
http://gerrit.ovirt.org/#/c/33783/6/vdsm/virt/sampling.py
File vdsm/virt/sampli
Dan Kenigsberg has submitted this change and it was merged.
Change subject: sampling: extract SampleWindow class
..
sampling: extract SampleWindow class
The existing AdvancedStatsFunction does actually
two different things: wra
oVirt Jenkins CI Server has posted comments on this change.
Change subject: sampling: extract SampleWindow class
..
Patch Set 7:
Build Failed
http://jenkins.ovirt.org/job/vdsm_master_unit-tests_merged/4211/ : FAILURE
http://
23 matches
Mail list logo
