automat...@ovirt.org has posted comments on this change.
Change subject: schema: rpm for jsonrpc schema files
..
Patch Set 9:
* Update tracker::IGNORE, no Bug-Url found
* Set MODIFIED::IGNORE, no Bug-Url found.
--
To view, vi
Dan Kenigsberg has posted comments on this change.
Change subject: schema: rpm for jsonrpc schema files
..
Patch Set 8: Code-Review+2
raising score
--
To view, visit https://gerrit.ovirt.org/45750
To unsubscribe, visit https:
Dan Kenigsberg has submitted this change and it was merged.
Change subject: schema: rpm for jsonrpc schema files
..
schema: rpm for jsonrpc schema files
We need to use schema files outside of vdsm for external clients and in
th
Yaniv Bronhaim has posted comments on this change.
Change subject: schema: rpm for jsonrpc schema files
..
Patch Set 8: Code-Review+1
looks OK to me - please ask Simone to verify over debian, unless you have
environment for th
Piotr Kliczewski has posted comments on this change.
Change subject: schema: rpm for jsonrpc schema files
..
Patch Set 8: Verified+1
No code changes. Rebased and split for have vdsm-jsonrpc package definition in
different patc
automat...@ovirt.org has posted comments on this change.
Change subject: schema: rpm for jsonrpc schema files
..
Patch Set 8:
* Update tracker::IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header
Piotr Kliczewski has posted comments on this change.
Change subject: schema: rpm for jsonrpc schema files
..
Patch Set 7:
(1 comment)
https://gerrit.ovirt.org/#/c/45750/7/debian/control
File debian/control:
Line 327: Depends:
Yaniv Bronhaim has posted comments on this change.
Change subject: schema: rpm for jsonrpc schema files
..
Patch Set 7: Code-Review-1
(1 comment)
https://gerrit.ovirt.org/#/c/45750/7/debian/control
File debian/control:
Line 3
Piotr Kliczewski has posted comments on this change.
Change subject: schema: rpm for jsonrpc schema files
..
Patch Set 7:
(1 comment)
https://gerrit.ovirt.org/#/c/45750/7/debian/control
File debian/control:
Line 327: Depends:
Piotr Kliczewski has posted comments on this change.
Change subject: schema: rpm for jsonrpc schema files
..
Patch Set 7: Verified+1
Added new deb for debian build. Not built on debian due to issue with pcopen.
--
To view, vi
automat...@ovirt.org has posted comments on this change.
Change subject: schema: rpm for jsonrpc schema files
..
Patch Set 7:
* Update tracker::IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header
Piotr Kliczewski has posted comments on this change.
Change subject: schema: rpm for jsonrpc schema files
..
Patch Set 6:
Good point. Will add debian support.
--
To view, visit https://gerrit.ovirt.org/45750
To unsubscribe, v
Yaniv Bronhaim has posted comments on this change.
Change subject: schema: rpm for jsonrpc schema files
..
Patch Set 6: Code-Review-1
oh, forgot about the debian part - don't you want it there as well?
--
To view, visit https
Yaniv Bronhaim has posted comments on this change.
Change subject: schema: rpm for jsonrpc schema files
..
Patch Set 6: Code-Review+1
--
To view, visit https://gerrit.ovirt.org/45750
To unsubscribe, visit https://gerrit.ovirt.
Yaniv Bronhaim has posted comments on this change.
Change subject: schema: rpm for jsonrpc schema files
..
Patch Set 6: Code-Review-1
don't you need it for debian as well? I still think that it should be installed
under site-p
Ondřej Svoboda has posted comments on this change.
Change subject: schema: rpm for jsonrpc schema files
..
Patch Set 6: Code-Review+1
--
To view, visit https://gerrit.ovirt.org/45750
To unsubscribe, visit https://gerrit.ovirt.
Yaniv Bronhaim has posted comments on this change.
Change subject: schema: rpm for jsonrpc schema files
..
Patch Set 3:
(1 comment)
https://gerrit.ovirt.org/#/c/45750/3/vdsm.spec.in
File vdsm.spec.in:
Line 1362: %files yajson
automat...@ovirt.org has posted comments on this change.
Change subject: schema: rpm for jsonrpc schema files
..
Patch Set 6:
* Update tracker::IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header
Yeela Kaplan has posted comments on this change.
Change subject: schema: rpm for jsonrpc schema files
..
Patch Set 5: Code-Review+1
--
To view, visit https://gerrit.ovirt.org/45750
To unsubscribe, visit https://gerrit.ovirt.or
Piotr Kliczewski has posted comments on this change.
Change subject: schema: rpm for jsonrpc schema files
..
Patch Set 5: Verified+1
Patch rebased. Verified by host deploying vdsm and seeing that communication
works between th
automat...@ovirt.org has posted comments on this change.
Change subject: schema: rpm for jsonrpc schema files
..
Patch Set 5:
* Update tracker::IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header
Piotr Kliczewski has posted comments on this change.
Change subject: schema: rpm for jsonrpc schema files
..
Patch Set 4:
I am ok with both approaches. I would like to get more opinions and leave or
change this patch.
--
To
Francesco Romani has posted comments on this change.
Change subject: schema: rpm for jsonrpc schema files
..
Patch Set 4:
I agree with the direction of this patch. I wonder if this belongs under lib/
or if we should just have
Ondřej Svoboda has posted comments on this change.
Change subject: schema: rpm for jsonrpc schema files
..
Patch Set 4: Code-Review+1
I like it this way.
--
To view, visit https://gerrit.ovirt.org/45750
To unsubscribe, visit
Piotr Kliczewski has posted comments on this change.
Change subject: schema: rpm for jsonrpc schema files
..
Patch Set 3:
(2 comments)
https://gerrit.ovirt.org/#/c/45750/3/vdsm.spec.in
File vdsm.spec.in:
Line 1353: %files api
Yaniv Bronhaim has posted comments on this change.
Change subject: schema: rpm for jsonrpc schema files
..
Patch Set 3:
(2 comments)
https://gerrit.ovirt.org/#/c/45750/3/vdsm.spec.in
File vdsm.spec.in:
Line 1353: %files api
L
automat...@ovirt.org has posted comments on this change.
Change subject: schema: rpm for jsonrpc schema files
..
Patch Set 4:
* Update tracker::IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header
Piotr Kliczewski has posted comments on this change.
Change subject: schema: rpm for jsonrpc schema files
..
Patch Set 3:
(2 comments)
https://gerrit.ovirt.org/#/c/45750/3/vdsm.spec.in
File vdsm.spec.in:
Line 1353: %files api
Ondřej Svoboda has posted comments on this change.
Change subject: schema: rpm for jsonrpc schema files
..
Patch Set 3:
Piotr, please note that I updated your https://gerrit.ovirt.org/#/c/45429/7 so
please cherry-pick it on to
Yaniv Bronhaim has posted comments on this change.
Change subject: schema: rpm for jsonrpc schema files
..
Patch Set 3:
(2 comments)
https://gerrit.ovirt.org/#/c/45750/3/vdsm.spec.in
File vdsm.spec.in:
Line 1353: %files api
L
Piotr Kliczewski has posted comments on this change.
Change subject: schema: rpm for jsonrpc schema files
..
Patch Set 3:
(9 comments)
https://gerrit.ovirt.org/#/c/45750/3//COMMIT_MSG
Commit Message:
Line 8:
Line 9: We need
Yaniv Bronhaim has posted comments on this change.
Change subject: schema: rpm for jsonrpc schema files
..
Patch Set 3: Code-Review-1
(9 comments)
https://gerrit.ovirt.org/#/c/45750/3//COMMIT_MSG
Commit Message:
Line 8:
Line
Yeela Kaplan has posted comments on this change.
Change subject: schema: rpm for jsonrpc schema files
..
Patch Set 3: Verified+1
--
To view, visit https://gerrit.ovirt.org/45750
To unsubscribe, visit https://gerrit.ovirt.org/s
Yeela Kaplan has posted comments on this change.
Change subject: schema: rpm for jsonrpc schema files
..
Patch Set 3: Code-Review+1
--
To view, visit https://gerrit.ovirt.org/45750
To unsubscribe, visit https://gerrit.ovirt.or
Piotr Kliczewski has posted comments on this change.
Change subject: schema: rpm for jsonrpc schema files
..
Patch Set 3: Verified+1
Removed generated file, no other changes. Copying verification flag from
previous patch set.
automat...@ovirt.org has posted comments on this change.
Change subject: schema: rpm for jsonrpc schema files
..
Patch Set 3:
* Update tracker::IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header
Piotr Kliczewski has posted comments on this change.
Change subject: schema: rpm for jsonrpc schema files
..
Patch Set 2:
Good catch will remove it.
--
To view, visit https://gerrit.ovirt.org/45750
To unsubscribe, visit https
Yeela Kaplan has posted comments on this change.
Change subject: schema: rpm for jsonrpc schema files
..
Patch Set 2:
If it is generated during the build, why is it added as a file to this patch?
--
To view, visit https://ger
Piotr Kliczewski has posted comments on this change.
Change subject: schema: rpm for jsonrpc schema files
..
Patch Set 2:
vdsm-api.html is generated during the build from schema file. From where do you
want me to remove it?
-
Yeela Kaplan has posted comments on this change.
Change subject: schema: rpm for jsonrpc schema files
..
Patch Set 2: Code-Review-1
I think you forgot to remove vdsm/rpc/vdsm-api.html
--
To view, visit https://gerrit.ovirt.or
Yeela Kaplan has posted comments on this change.
Change subject: schema: rpm for jsonrpc schema files
..
Patch Set 2:
Is vsdm-api.html on purpose?
--
To view, visit https://gerrit.ovirt.org/45750
To unsubscribe, visit https:/
Piotr Kliczewski has posted comments on this change.
Change subject: schema: rpm for jsonrpc schema files
..
Patch Set 2: Verified+1
Actually failure was related to this patch. I forgot to git add 2 files.
Verification flag co
automat...@ovirt.org has posted comments on this change.
Change subject: schema: rpm for jsonrpc schema files
..
Patch Set 2:
* Update tracker::IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header
Piotr Kliczewski has posted comments on this change.
Change subject: schema: rpm for jsonrpc schema files
..
Patch Set 1:
CI failure not related to this patch.
--
To view, visit https://gerrit.ovirt.org/45750
To unsubscribe,
Piotr Kliczewski has posted comments on this change.
Change subject: schema: rpm for jsonrpc schema files
..
Patch Set 1: Verified+1
Verified by updating existing vdsm with new rpm and seeing that communication
still works.
-
Piotr Kliczewski has uploaded a new change for review.
Change subject: schema: rpm for jsonrpc schema files
..
schema: rpm for jsonrpc schema files
We need to use schema files outside of vdsm for external clients and in
the futu
automat...@ovirt.org has posted comments on this change.
Change subject: schema: rpm for jsonrpc schema files
..
Patch Set 1:
* Update tracker::IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header
47 matches
Mail list logo
