automat...@ovirt.org has posted comments on this change.
Change subject: snapshot: Add Vm.freeze() and Vm.thaw() methods
..
Patch Set 10:
* Update tracker::IGNORE, no Bug-Url found
* Set MODIFIED::IGNORE, no Bug-Url found.
--
Dan Kenigsberg has posted comments on this change.
Change subject: snapshot: Add Vm.freeze() and Vm.thaw() methods
..
Patch Set 9: Code-Review+2
--
To view, visit https://gerrit.ovirt.org/43018
To unsubscribe, visit https://ge
Dan Kenigsberg has submitted this change and it was merged.
Change subject: snapshot: Add Vm.freeze() and Vm.thaw() methods
..
snapshot: Add Vm.freeze() and Vm.thaw() methods
When using vdsm images, we implement a snapshot usin
Daniel Erez has posted comments on this change.
Change subject: snapshot: Add Vm.freeze() and Vm.thaw() methods
..
Patch Set 9: Verified+1
--
To view, visit https://gerrit.ovirt.org/43018
To unsubscribe, visit https://gerrit.o
Vinzenz Feenstra has posted comments on this change.
Change subject: snapshot: Add Vm.freeze() and Vm.thaw() methods
..
Patch Set 9: Code-Review+1
--
To view, visit https://gerrit.ovirt.org/43018
To unsubscribe, visit https://
Francesco Romani has posted comments on this change.
Change subject: snapshot: Add Vm.freeze() and Vm.thaw() methods
..
Patch Set 9: Code-Review+1
--
To view, visit https://gerrit.ovirt.org/43018
To unsubscribe, visit https://
Martin Polednik has posted comments on this change.
Change subject: snapshot: Add Vm.freeze() and Vm.thaw() methods
..
Patch Set 9: Code-Review+1
--
To view, visit https://gerrit.ovirt.org/43018
To unsubscribe, visit https://g
Nir Soffer has posted comments on this change.
Change subject: snapshot: Add Vm.freeze() and Vm.thaw() methods
..
Patch Set 9: Verified+1
This version remove unneeded "agentUnresponsiveErr" and use the current
"nonresp" error
automat...@ovirt.org has posted comments on this change.
Change subject: snapshot: Add Vm.freeze() and Vm.thaw() methods
..
Patch Set 9:
* Update tracker::IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make s
Nir Soffer has posted comments on this change.
Change subject: snapshot: Add Vm.freeze() and Vm.thaw() methods
..
Patch Set 8:
(1 comment)
https://gerrit.ovirt.org/#/c/43018/8/lib/vdsm/define.py
File lib/vdsm/define.py:
Line
Francesco Romani has posted comments on this change.
Change subject: snapshot: Add Vm.freeze() and Vm.thaw() methods
..
Patch Set 8:
I'm fine with the patch once Martin's comment gets addressed.
--
To view, visit https://gerr
Francesco Romani has posted comments on this change.
Change subject: snapshot: Add Vm.freeze() and Vm.thaw() methods
..
Patch Set 7:
(2 comments)
https://gerrit.ovirt.org/#/c/43018/7/vdsm/virt/vm.py
File vdsm/virt/vm.py:
Line
Martin Polednik has posted comments on this change.
Change subject: snapshot: Add Vm.freeze() and Vm.thaw() methods
..
Patch Set 8: Code-Review-1
(1 comment)
Possible error message duplication - is there reason not to use alre
Nir Soffer has posted comments on this change.
Change subject: snapshot: Add Vm.freeze() and Vm.thaw() methods
..
Patch Set 8: Verified+1
No code change, copying verify flag.
--
To view, visit https://gerrit.ovirt.org/43018
T
Nir Soffer has posted comments on this change.
Change subject: snapshot: Add Vm.freeze() and Vm.thaw() methods
..
Patch Set 7:
This version address Francesco comments in vmfakelib.
--
To view, visit https://gerrit.ovirt.org/4
automat...@ovirt.org has posted comments on this change.
Change subject: snapshot: Add Vm.freeze() and Vm.thaw() methods
..
Patch Set 8:
* Update tracker::IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make s
Nir Soffer has posted comments on this change.
Change subject: snapshot: Add Vm.freeze() and Vm.thaw() methods
..
Patch Set 7:
(4 comments)
https://gerrit.ovirt.org/#/c/43018/7/tests/vmfakelib.py
File tests/vmfakelib.py:
Line
Francesco Romani has posted comments on this change.
Change subject: snapshot: Add Vm.freeze() and Vm.thaw() methods
..
Patch Set 7: Code-Review+1
(4 comments)
looks OK. Few minor comments inside for further improvements. I do
Nir Soffer has posted comments on this change.
Change subject: snapshot: Add Vm.freeze() and Vm.thaw() methods
..
Patch Set 7:
Michal, the logic is very similar, but not the same. The error handling is
almost the same, so we c
Michal Skrivanek has posted comments on this change.
Change subject: snapshot: Add Vm.freeze() and Vm.thaw() methods
..
Patch Set 7:
I can live with current solution. But when whole logic is the same I prefer to
have an argume
Nir Soffer has posted comments on this change.
Change subject: snapshot: Add Vm.freeze() and Vm.thaw() methods
..
Patch Set 7:
Michal, I will check using freeze() and thaw() in the next patch, handling the
case where vm was al
Michal Skrivanek has posted comments on this change.
Change subject: snapshot: Add Vm.freeze() and Vm.thaw() methods
..
Patch Set 7: Code-Review+1
Thanks. Just 2 things for consideration
- a single function taking freeze/thaw
Nir Soffer has posted comments on this change.
Change subject: snapshot: Add Vm.freeze() and Vm.thaw() methods
..
Patch Set 7: Verified+1
This version move freeze() and thaw() into Vm, since we did not have a
consensus about t
automat...@ovirt.org has posted comments on this change.
Change subject: snapshot: Add Vm.freeze() and Vm.thaw() methods
..
Patch Set 7:
* Update tracker::IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make s
24 matches
Mail list logo
