Change in vdsm[master]: sysctl: turn disable_ipv6 into toggle_ipv6 to simplify logic

2015-10-21 Thread osvoboda
Ondřej Svoboda has posted comments on this change. Change subject: sysctl: turn disable_ipv6 into toggle_ipv6 to simplify logic .. Patch Set 2: (1 comment) https://gerrit.ovirt.org/#/c/46983/2/lib/vdsm/sysctl.py File lib/vdsm/

Change in vdsm[master]: sysctl: turn disable_ipv6 into toggle_ipv6 to simplify logic

2015-10-21 Thread osvoboda
Ondřej Svoboda has posted comments on this change. Change subject: sysctl: turn disable_ipv6 into toggle_ipv6 to simplify logic .. Patch Set 2: (1 comment) https://gerrit.ovirt.org/#/c/46983/2/lib/vdsm/sysctl.py File lib/vdsm/

Change in vdsm[master]: sysctl: turn disable_ipv6 into toggle_ipv6 to simplify logic

2015-10-21 Thread danken
Dan Kenigsberg has posted comments on this change. Change subject: sysctl: turn disable_ipv6 into toggle_ipv6 to simplify logic .. Patch Set 2: Code-Review-1 (1 comment) https://gerrit.ovirt.org/#/c/46983/2/lib/vdsm/sysctl.py

Change in vdsm[master]: sysctl: turn disable_ipv6 into toggle_ipv6 to simplify logic

2015-10-20 Thread osvoboda
Ondřej Svoboda has posted comments on this change. Change subject: sysctl: turn disable_ipv6 into toggle_ipv6 to simplify logic .. Patch Set 2: Verified+1 Tried creating a network with no IPv6 functionality and the representing

Change in vdsm[master]: sysctl: turn disable_ipv6 into toggle_ipv6 to simplify logic

2015-10-19 Thread ibarkan
Ido Barkan has posted comments on this change. Change subject: sysctl: turn disable_ipv6 into toggle_ipv6 to simplify logic .. Patch Set 2: Code-Review+1 -- To view, visit https://gerrit.ovirt.org/46983 To unsubscribe, visit h

Change in vdsm[master]: sysctl: turn disable_ipv6 into toggle_ipv6 to simplify logic

2015-10-12 Thread automation
automat...@ovirt.org has posted comments on this change. Change subject: sysctl: turn disable_ipv6 into toggle_ipv6 to simplify logic .. Patch Set 2: * Update tracker::IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url

Change in vdsm[master]: sysctl: turn disable_ipv6 into toggle_ipv6 to simplify logic

2015-10-05 Thread osvoboda
Ondřej Svoboda has posted comments on this change. Change subject: sysctl: turn disable_ipv6 into toggle_ipv6 to simplify logic .. Patch Set 1: I see no reason for two functions turning the same switch on or off. "set_ipv6" is

Change in vdsm[master]: sysctl: turn disable_ipv6 into toggle_ipv6 to simplify logic

2015-10-05 Thread phoracek
Petr Horáček has posted comments on this change. Change subject: sysctl: turn disable_ipv6 into toggle_ipv6 to simplify logic .. Patch Set 1: i'd prefer to rename it to set_ipv6 or better create two functions enable and disabl

Change in vdsm[master]: sysctl: turn disable_ipv6 into toggle_ipv6 to simplify logic

2015-10-05 Thread osvoboda
Ondřej Svoboda has uploaded a new change for review. Change subject: sysctl: turn disable_ipv6 into toggle_ipv6 to simplify logic .. sysctl: turn disable_ipv6 into toggle_ipv6 to simplify logic Change-Id: I154f22a5f59174d0e33235

Change in vdsm[master]: sysctl: turn disable_ipv6 into toggle_ipv6 to simplify logic

2015-10-05 Thread automation
automat...@ovirt.org has posted comments on this change. Change subject: sysctl: turn disable_ipv6 into toggle_ipv6 to simplify logic .. Patch Set 1: * Update tracker::IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url