Ondřej Svoboda has posted comments on this change.
Change subject: sysctl: turn disable_ipv6 into toggle_ipv6 to simplify logic
..
Patch Set 2:
(1 comment)
https://gerrit.ovirt.org/#/c/46983/2/lib/vdsm/sysctl.py
File lib/vdsm/
Ondřej Svoboda has posted comments on this change.
Change subject: sysctl: turn disable_ipv6 into toggle_ipv6 to simplify logic
..
Patch Set 2:
(1 comment)
https://gerrit.ovirt.org/#/c/46983/2/lib/vdsm/sysctl.py
File lib/vdsm/
Dan Kenigsberg has posted comments on this change.
Change subject: sysctl: turn disable_ipv6 into toggle_ipv6 to simplify logic
..
Patch Set 2: Code-Review-1
(1 comment)
https://gerrit.ovirt.org/#/c/46983/2/lib/vdsm/sysctl.py
Ondřej Svoboda has posted comments on this change.
Change subject: sysctl: turn disable_ipv6 into toggle_ipv6 to simplify logic
..
Patch Set 2: Verified+1
Tried creating a network with no IPv6 functionality and the representing
Ido Barkan has posted comments on this change.
Change subject: sysctl: turn disable_ipv6 into toggle_ipv6 to simplify logic
..
Patch Set 2: Code-Review+1
--
To view, visit https://gerrit.ovirt.org/46983
To unsubscribe, visit h
automat...@ovirt.org has posted comments on this change.
Change subject: sysctl: turn disable_ipv6 into toggle_ipv6 to simplify logic
..
Patch Set 2:
* Update tracker::IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url
Ondřej Svoboda has posted comments on this change.
Change subject: sysctl: turn disable_ipv6 into toggle_ipv6 to simplify logic
..
Patch Set 1:
I see no reason for two functions turning the same switch on or off.
"set_ipv6" is
Petr Horáček has posted comments on this change.
Change subject: sysctl: turn disable_ipv6 into toggle_ipv6 to simplify logic
..
Patch Set 1:
i'd prefer to rename it to set_ipv6 or better create two functions enable and
disabl
Ondřej Svoboda has uploaded a new change for review.
Change subject: sysctl: turn disable_ipv6 into toggle_ipv6 to simplify logic
..
sysctl: turn disable_ipv6 into toggle_ipv6 to simplify logic
Change-Id: I154f22a5f59174d0e33235
automat...@ovirt.org has posted comments on this change.
Change subject: sysctl: turn disable_ipv6 into toggle_ipv6 to simplify logic
..
Patch Set 1:
* Update tracker::IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url
10 matches
Mail list logo