gerrit-hooks has posted comments on this change.
Change subject: testlib: use arch from lib
..
Patch Set 11:
* Update tracker: IGNORE, no Bug-Url found
--
To view, visit https://gerrit.ovirt.org/49973
To unsubscribe, visit ht
Jenkins CI RO has abandoned this change.
Change subject: testlib: use arch from lib
..
Abandoned
Abandoned due to no activity - please restore if still relevant
--
To view, visit https://gerrit.ovirt.org/49973
To unsubscribe,
Francesco Romani has posted comments on this change.
Change subject: testlib: use arch from lib
..
Patch Set 11:
please don't forget about the comments about the new code
--
To view, visit https://gerrit.ovirt.org/49973
To un
Francesco Romani has posted comments on this change.
Change subject: testlib: use arch from lib
..
Patch Set 11: -Code-Review
changed score after last comments.
--
To view, visit https://gerrit.ovirt.org/49973
To unsubscribe,
Nir Soffer has posted comments on this change.
Change subject: testlib: use arch from lib
..
Patch Set 11: -Code-Review
Lets add the removal of this hack to the todo list, and fix the duplication now.
--
To view, visit https:
Dan Kenigsberg has posted comments on this change.
Change subject: testlib: use arch from lib
..
Patch Set 11:
(2 comments)
https://gerrit.ovirt.org/#/c/49973/11/tests/testlib.py
File tests/testlib.py:
Line 170
Line 171
Line
Francesco Romani has posted comments on this change.
Change subject: testlib: use arch from lib
..
Patch Set 11: Code-Review-1
(1 comment)
changing score because a bug sneaked in
https://gerrit.ovirt.org/#/c/49973/11/tests/te
Francesco Romani has posted comments on this change.
Change subject: testlib: use arch from lib
..
Patch Set 11:
(1 comment)
https://gerrit.ovirt.org/#/c/49973/11/tests/testlib.py
File tests/testlib.py:
Line 170
Line 171
Line
Martin Polednik has posted comments on this change.
Change subject: testlib: use arch from lib
..
Patch Set 11:
That is something I'd keep out of this patch tree. I can skip this patch if
you'd rather not touch it at all.
--
Nir Soffer has posted comments on this change.
Change subject: testlib: use arch from lib
..
Patch Set 11: Code-Review-1
(1 comment)
The correct change is to remove _vdsm_machine and do the monkey patching in the
tests that n
Francesco Romani has posted comments on this change.
Change subject: testlib: use arch from lib
..
Patch Set 11:
(1 comment)
added a not in case you resubmit for whatever reason. Otherwise, looks good to
me.
https://gerrit.o
Francesco Romani has posted comments on this change.
Change subject: testlib: use arch from lib
..
Patch Set 11: Code-Review+2
--
To view, visit https://gerrit.ovirt.org/49973
To unsubscribe, visit https://gerrit.ovirt.org/set
Martin Polednik has posted comments on this change.
Change subject: testlib: use arch from lib
..
Patch Set 11: Verified+1
--
To view, visit https://gerrit.ovirt.org/49973
To unsubscribe, visit https://gerrit.ovirt.org/setting
gerrit-hooks has posted comments on this change.
Change subject: testlib: use arch from lib
..
Patch Set 11:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url:
gerrit-hooks has posted comments on this change.
Change subject: testlib: use arch from lib
..
Patch Set 10:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url:
gerrit-hooks has posted comments on this change.
Change subject: testlib: use arch from lib
..
Patch Set 9:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url:
gerrit-hooks has posted comments on this change.
Change subject: testlib: use arch from lib
..
Patch Set 8:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url:
Martin Polednik has posted comments on this change.
Change subject: testlib: use arch from lib
..
Patch Set 7: Verified-1
Fails as the patch isn't really patching function. Working on better (working)
version.
--
To view, vi
Francesco Romani has posted comments on this change.
Change subject: testlib: use arch from lib
..
Patch Set 7: Code-Review+2
--
To view, visit https://gerrit.ovirt.org/49973
To unsubscribe, visit https://gerrit.ovirt.org/sett
gerrit-hooks has posted comments on this change.
Change subject: testlib: use arch from lib
..
Patch Set 7:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url:
Martin Polednik has posted comments on this change.
Change subject: testlib: use arch from lib
..
Patch Set 5:
(1 comment)
https://gerrit.ovirt.org/#/c/49973/5/tests/testlib.py
File tests/testlib.py:
Line 165
Line 166
Line 16
Francesco Romani has posted comments on this change.
Change subject: testlib: use arch from lib
..
Patch Set 5:
(1 comment)
https://gerrit.ovirt.org/#/c/49973/5/tests/testlib.py
File tests/testlib.py:
Line 165
Line 166
Line 1
gerrit-hooks has posted comments on this change.
Change subject: testlib: use arch from lib
..
Patch Set 6:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url:
Nir Soffer has posted comments on this change.
Change subject: testlib: use arch from lib
..
Patch Set 4:
(1 comment)
https://gerrit.ovirt.org/#/c/49973/4/tests/testlib.py
File tests/testlib.py:
Line 165: _ARCH_REAL i
Nir Soffer has posted comments on this change.
Change subject: testlib: use arch from lib
..
Patch Set 5: Code-Review-1
(3 comments)
https://gerrit.ovirt.org/#/c/49973/5/tests/testlib.py
File tests/testlib.py:
Line 1
Line 2
U
Francesco Romani has posted comments on this change.
Change subject: testlib: use arch from lib
..
Patch Set 5:
please see my comment in v4
--
To view, visit https://gerrit.ovirt.org/49973
To unsubscribe, visit https://gerrit
gerrit-hooks has posted comments on this change.
Change subject: testlib: use arch from lib
..
Patch Set 5:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url:
Francesco Romani has posted comments on this change.
Change subject: testlib: use arch from lib
..
Patch Set 4: Code-Review-1
(1 comment)
please check the inline comment.
https://gerrit.ovirt.org/#/c/49973/4/tests/testlib.py
gerrit-hooks has posted comments on this change.
Change subject: testlib: use arch from lib
..
Patch Set 4:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url:
gerrit-hooks has posted comments on this change.
Change subject: testlib: use arch from lib
..
Patch Set 3:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url:
gerrit-hooks has posted comments on this change.
Change subject: testlib: use arch from lib
..
Patch Set 2:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url:
Francesco Romani has posted comments on this change.
Change subject: testlib: use arch from lib
..
Patch Set 1: Code-Review+1
--
To view, visit https://gerrit.ovirt.org/49973
To unsubscribe, visit https://gerrit.ovirt.org/sett
gerrit-hooks has posted comments on this change.
Change subject: testlib: use arch from lib
..
Patch Set 1:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url:
Martin Polednik has uploaded a new change for review.
Change subject: testlib: use arch from lib
..
testlib: use arch from lib
Previous code duplicated the architecture information as caps module
couldn't easily be imported. The
34 matches
Mail list logo
