Nir Soffer has posted comments on this change.
Change subject: utils: Making try block smaller in tobool()
..
Patch Set 1:
(1 comment)
https://gerrit.ovirt.org/#/c/57549/1/lib/vdsm/utils.py
File lib/vdsm/utils.py:
Line 417
Tomas Golembiovsky has posted comments on this change.
Change subject: utils: Making try block smaller in tobool()
..
Patch Set 1:
Based on the documentation I would say that 'type()' and 'isinstance()' is safe
in our case. I
Milan Zamazal has posted comments on this change.
Change subject: utils: Making try block smaller in tobool()
..
Patch Set 1: Code-Review-1
Martin is right, the additional restriction to ValueError is not safe.
--
To view,
Martin Polednik has posted comments on this change.
Change subject: utils: Making try block smaller in tobool()
..
Patch Set 1: -Code-Review
Actually not 100% sure: valueError can't be (at this point) raised by
a) basestring
Martin Polednik has posted comments on this change.
Change subject: utils: Making try block smaller in tobool()
..
Patch Set 1: Code-Review+1
--
To view, visit https://gerrit.ovirt.org/57549
To unsubscribe, visit
gerrit-hooks has posted comments on this change.
Change subject: utils: Making try block smaller in tobool()
..
Patch Set 1:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header
Tomas Golembiovsky has uploaded a new change for review.
Change subject: utils: Making try block smaller in tobool()
..
utils: Making try block smaller in tobool()
The try-except block was too broad and spanned unnecessarily
