Jenkins CI RO has abandoned this change.
Change subject: utils: Properly handle int argument in tobool().
..
Abandoned
Abandoned due to no activity - please restore if still relevant
--
To view, visit
gerrit-hooks has posted comments on this change.
Change subject: utils: Properly handle int argument in tobool().
..
Patch Set 4:
* update_tracker: OK
--
To view, visit https://gerrit.ovirt.org/57511
To unsubscribe, visit
Martin Polednik has posted comments on this change.
Change subject: utils: Properly handle int argument in tobool().
..
Patch Set 4:
My code does not use tobool on integers. Actually there seems to be no code
that does it,
Nir Soffer has posted comments on this change.
Change subject: utils: Properly handle int argument in tobool().
..
Patch Set 4:
Martin, fix your code, you should not use tobool on integers.
--
To view, visit
Nir Soffer has posted comments on this change.
Change subject: utils: Properly handle int argument in tobool().
..
Patch Set 4:
This utility is crap and should be fixed, but the fix is not supporting
integers, but supporting
Martin Polednik has posted comments on this change.
Change subject: utils: Properly handle int argument in tobool().
..
Patch Set 4: Code-Review+1
We use the function, it's broken. What we use must be fixed first, and it's
Michal Skrivanek has posted comments on this change.
Change subject: utils: Properly handle int argument in tobool().
..
Patch Set 4:
Nir - so, this is a method in utils, implying it's a generic method which
should work
Nir Soffer has posted comments on this change.
Change subject: utils: Properly handle int argument in tobool().
..
Patch Set 4:
No, I meant we don't need this "fix", we don't want to support integer input or
None or dicts,
Michal Skrivanek has posted comments on this change.
Change subject: utils: Properly handle int argument in tobool().
..
Patch Set 4: Code-Review+1
Nir, I suppose you've meant all your comments as an idea for followup
Nir Soffer has posted comments on this change.
Change subject: utils: Properly handle int argument in tobool().
..
Patch Set 4:
(1 comment)
https://gerrit.ovirt.org/#/c/57511/4/lib/vdsm/utils.py
File lib/vdsm/utils.py:
Line
Tomas Golembiovsky has posted comments on this change.
Change subject: utils: Properly handle int argument in tobool().
..
Patch Set 4:
(2 comments)
https://gerrit.ovirt.org/#/c/57511/4//COMMIT_MSG
Commit Message:
Line 8:
Nir Soffer has posted comments on this change.
Change subject: utils: Properly handle int argument in tobool().
..
Patch Set 4: Code-Review-1
(7 comments)
https://gerrit.ovirt.org/#/c/57511/4//COMMIT_MSG
Commit Message:
Line
Dan Kenigsberg has posted comments on this change.
Change subject: utils: Properly handle int argument in tobool().
..
Patch Set 4: Code-Review+2
--
To view, visit https://gerrit.ovirt.org/57511
To unsubscribe, visit
Francesco Romani has posted comments on this change.
Change subject: utils: Properly handle int argument in tobool().
..
Patch Set 4: Code-Review+1
--
To view, visit https://gerrit.ovirt.org/57511
To unsubscribe, visit
gerrit-hooks has posted comments on this change.
Change subject: utils: Properly handle int argument in tobool().
..
Patch Set 4:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure
Tomas Golembiovsky has posted comments on this change.
Change subject: utils: Properly handle int argument in tobool().
..
Patch Set 3:
(1 comment)
https://gerrit.ovirt.org/#/c/57511/3/lib/vdsm/utils.py
File
Dan Kenigsberg has posted comments on this change.
Change subject: utils: Properly handle int argument in tobool().
..
Patch Set 3: Code-Review-1
(2 comments)
https://gerrit.ovirt.org/#/c/57511/3/lib/vdsm/utils.py
File
Francesco Romani has posted comments on this change.
Change subject: utils: Properly handle int argument in tobool().
..
Patch Set 3: Code-Review+1
(1 comment)
https://gerrit.ovirt.org/#/c/57511/3/lib/vdsm/utils.py
File
Milan Zamazal has posted comments on this change.
Change subject: utils: Properly handle int argument in tobool().
..
Patch Set 3: Code-Review+1
--
To view, visit https://gerrit.ovirt.org/57511
To unsubscribe, visit
gerrit-hooks has posted comments on this change.
Change subject: utils: Properly handle int argument in tobool().
..
Patch Set 3:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure
gerrit-hooks has posted comments on this change.
Change subject: utils: Properly handle int argument in tobool().
..
Patch Set 2:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure
21 matches
Mail list logo
