Shahar Havivi has uploaded a new change for review.
Change subject: v2v: support for block devices
..
v2v: support for block devices
extended support for block devices for KVM and VMWare.
currently we do support block devices th
gerrit-hooks has posted comments on this change.
Change subject: v2v: support for block devices
..
Patch Set 1:
* #1378340::Update tracker: OK
* Check Bug-Url::OK
* Check Public Bug::#1378340::OK, public bug
* Check Product::#1
Shahar Havivi has posted comments on this change.
Change subject: v2v: support for block devices
..
Patch Set 1: Verified+1
--
To view, visit https://gerrit.ovirt.org/64272
To unsubscribe, visit https://gerrit.ovirt.org/settin
Tomas Golembiovsky has posted comments on this change.
Change subject: v2v: support for block devices
..
Patch Set 1: Code-Review+1
Adding +1, but it leaves me thinking whether we should do something for the
other types as wel
Francesco Romani has posted comments on this change.
Change subject: v2v: support for block devices
..
Patch Set 1: Code-Review+1
let's just add a test (this patch or a new one) and it's fine. Partial ACK
until the test is upl
gerrit-hooks has posted comments on this change.
Change subject: v2v: support for block devices
..
Patch Set 2:
* update_tracker: OK
* Check Bug-Url::OK
* Check Public Bug::#1378340::OK, public bug
* Check Product::#1378340::OK
Francesco Romani has posted comments on this change.
Change subject: v2v: support for block devices
..
Patch Set 2: Code-Review+1
(2 comments)
nice, thanks, few inline comments for clarity. Partial ACK.
https://gerrit.ovirt.o
Shahar Havivi has posted comments on this change.
Change subject: v2v: support for block devices
..
Patch Set 2:
(2 comments)
https://gerrit.ovirt.org/#/c/64272/2/tests/v2vTests.py
File tests/v2vTests.py:
PS2, Line 130: file
gerrit-hooks has posted comments on this change.
Change subject: v2v: support for block devices
..
Patch Set 3:
* update_tracker: OK
* Check Bug-Url::OK
* Check Public Bug::#1378340::OK, public bug
* Check Product::#1378340::OK
Francesco Romani has posted comments on this change.
Change subject: v2v: support for block devices
..
Patch Set 3: Code-Review+2
seems good enough. Please make jenkins happy, or add a comment why we shouldn't
care (and notify
gerrit-hooks has posted comments on this change.
Change subject: v2v: support for block devices
..
Patch Set 4:
* update_tracker: OK
* Check Bug-Url::OK
* Check Public Bug::#1378340::OK, public bug
* Check Product::#1378340::OK
Shahar Havivi has posted comments on this change.
Change subject: v2v: support for block devices
..
Patch Set 4: Verified+1
--
To view, visit https://gerrit.ovirt.org/64272
To unsubscribe, visit https://gerrit.ovirt.org/settin
Francesco Romani has posted comments on this change.
Change subject: v2v: support for block devices
..
Patch Set 4: Code-Review+2
--
To view, visit https://gerrit.ovirt.org/64272
To unsubscribe, visit https://gerrit.ovirt.org/
Tomas Golembiovsky has posted comments on this change.
Change subject: v2v: support for block devices
..
Patch Set 4: Code-Review-1
(1 comment)
As pointed out by a user on ML the change breaks engine. VDSM fails to fetch
disk
Francesco Romani has posted comments on this change.
Change subject: v2v: support for block devices
..
Patch Set 4: Code-Review-1
Ooops, good catch Tomas.
--
To view, visit https://gerrit.ovirt.org/64272
To unsubscribe, visit
Tomas Golembiovsky has posted comments on this change.
Change subject: v2v: support for block devices
..
Patch Set 4:
(1 comment)
I investigated this a little and we can get the device size with libvirt call
virDomainGetBlock
From Dan Kenigsberg :
Dan Kenigsberg has submitted this change and it was merged.
Change subject: v2v: support for block devices
..
v2v: support for block devices
extended support for block devices for KVM and VMWare.
currentl
17 matches
Mail list logo
