Dan Kenigsberg has submitted this change and it was merged.
Change subject: virt: Make Vm.devSpecMapFromConf() private
..
virt: Make Vm.devSpecMapFromConf() private
There is currently no reason to expose the method outside Vm.
gerrit-hooks has posted comments on this change.
Change subject: virt: Make Vm.devSpecMapFromConf() private
..
Patch Set 8:
* Update tracker: IGNORE, no Bug-Url found
* Set MODIFIED::IGNORE, no Bug-Url found.
--
To view,
Nir Soffer has posted comments on this change.
Change subject: virt: Make Vm.devSpecMapFromConf() private
..
Patch Set 7: Code-Review+1
--
To view, visit https://gerrit.ovirt.org/53483
To unsubscribe, visit
Milan Zamazal has posted comments on this change.
Change subject: virt: Make Vm.devSpecMapFromConf() private
..
Patch Set 7: Verified+1
Verified by running a VM from Engine, migrating it to another host and back and
shutting
gerrit-hooks has posted comments on this change.
Change subject: virt: Make Vm.devSpecMapFromConf() private
..
Patch Set 7:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header
gerrit-hooks has posted comments on this change.
Change subject: virt: Make Vm.devSpecMapFromConf() private
..
Patch Set 6:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header
gerrit-hooks has posted comments on this change.
Change subject: virt: Make Vm.devSpecMapFromConf() private
..
Patch Set 5:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header
Milan Zamazal has uploaded a new change for review.
Change subject: virt: Make Vm.devSpecMapFromConf() private
..
virt: Make Vm.devSpecMapFromConf() private
There is currently no reason to expose the method outside Vm.
Actually
gerrit-hooks has posted comments on this change.
Change subject: virt: Make Vm.devSpecMapFromConf() private
..
Patch Set 4:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header
Francesco Romani has posted comments on this change.
Change subject: virt: Make Vm.devSpecMapFromConf() private
..
Patch Set 3: Code-Review+1
I see nothing wrong here. Partial ACK.
Note to self/thinking aloud:
I don't really
gerrit-hooks has posted comments on this change.
Change subject: virt: Make Vm.devSpecMapFromConf() private
..
Patch Set 3:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header
gerrit-hooks has posted comments on this change.
Change subject: virt: Make Vm.devSpecMapFromConf() private
..
Patch Set 2:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header
gerrit-hooks has posted comments on this change.
Change subject: virt: Make Vm.devSpecMapFromConf() private
..
Patch Set 1:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header
13 matches
Mail list logo