gerrit-hooks has posted comments on this change.
Change subject: virt: add kernel cmdline reporting
..
Patch Set 17:
* #1301104::Update tracker: OK
* Set MODIFIED::bug 1301104#1301104IGNORE, not all related patches are
Dan Kenigsberg has submitted this change and it was merged.
Change subject: virt: add kernel cmdline reporting
..
virt: add kernel cmdline reporting
As we want to control kernel command line from ovirt, we need a way to
let
Martin Polednik has posted comments on this change.
Change subject: virt: add kernel cmdline reporting
..
Patch Set 16: Verified+1
--
To view, visit https://gerrit.ovirt.org/57084
To unsubscribe, visit
Piotr Kliczewski has posted comments on this change.
Change subject: virt: add kernel cmdline reporting
..
Patch Set 16: Code-Review+2
--
To view, visit https://gerrit.ovirt.org/57084
To unsubscribe, visit
Francesco Romani has posted comments on this change.
Change subject: virt: add kernel cmdline reporting
..
Patch Set 16: Code-Review+2
thanks for the updates, this should be ready now.
--
To view, visit
gerrit-hooks has posted comments on this change.
Change subject: virt: add kernel cmdline reporting
..
Patch Set 16:
* #1301104::Update tracker: OK
* Check Bug-Url::OK
* Check Public Bug::#1301104::OK, public bug
* Check
Dan Kenigsberg has posted comments on this change.
Change subject: virt: add kernel cmdline reporting
..
Patch Set 15: Code-Review-1
"until we drop schema.json, we need to keep .yml up to date as well (we more
days, I hope)"
Francesco Romani has posted comments on this change.
Change subject: virt: add kernel cmdline reporting
..
Patch Set 15: Code-Review+2
--
To view, visit https://gerrit.ovirt.org/57084
To unsubscribe, visit
Piotr Kliczewski has posted comments on this change.
Change subject: virt: add kernel cmdline reporting
..
Patch Set 15: Code-Review+2
Raising Francesco's score
--
To view, visit https://gerrit.ovirt.org/57084
To
Martin Polednik has posted comments on this change.
Change subject: virt: add kernel cmdline reporting
..
Patch Set 15: Verified+1
--
To view, visit https://gerrit.ovirt.org/57084
To unsubscribe, visit
Francesco Romani has posted comments on this change.
Change subject: virt: add kernel cmdline reporting
..
Patch Set 15: Code-Review+1
schema looks good now. Temprary lowering my score to let Piotr review.
--
To view, visit
gerrit-hooks has posted comments on this change.
Change subject: virt: add kernel cmdline reporting
..
Patch Set 15:
* #1301104::Update tracker: OK
* Check Bug-Url::OK
* Check Public Bug::#1301104::OK, public bug
* Check
Martin Polednik has posted comments on this change.
Change subject: virt: add kernel cmdline reporting
..
Patch Set 14:
(2 comments)
https://gerrit.ovirt.org/#/c/57084/14/lib/api/vdsm-api.yml
File lib/api/vdsm-api.yml:
PS14,
Francesco Romani has posted comments on this change.
Change subject: virt: add kernel cmdline reporting
..
Patch Set 14: Code-Review-1
(2 comments)
the YML schema needs some more (minor) fixes, otherwise looks ok
gerrit-hooks has posted comments on this change.
Change subject: virt: add kernel cmdline reporting
..
Patch Set 14:
* #1301104::Update tracker: OK
* Check Bug-Url::OK
* Check Public Bug::#1301104::OK, public bug
* Check
gerrit-hooks has posted comments on this change.
Change subject: virt: add kernel cmdline reporting
..
Patch Set 13:
* #1301104::Update tracker: OK
* Check Bug-Url::OK
* Check Public Bug::#1301104::OK, public bug
* Check
Dan Kenigsberg has posted comments on this change.
Change subject: virt: add kernel cmdline reporting
..
Patch Set 12: Code-Review-1
until we drop schema.json, we need to keep .yml up to date as well (we more
days, I hope)
gerrit-hooks has posted comments on this change.
Change subject: virt: add kernel cmdline reporting
..
Patch Set 12:
* #1301104::Update tracker: OK
* Check Bug-Url::OK
* Check Public Bug::#1301104::OK, public bug
* Check
gerrit-hooks has posted comments on this change.
Change subject: virt: add kernel cmdline reporting
..
Patch Set 11:
* #1301104::Update tracker: OK
* Check Bug-Url::OK
* Check Public Bug::#1301104::OK, public bug
* Check
gerrit-hooks has posted comments on this change.
Change subject: virt: add kernel cmdline reporting
..
Patch Set 10:
* #1301104::Update tracker: OK
* Check Bug-Url::OK
* Check Public Bug::#1301104::OK, public bug
* Check
gerrit-hooks has posted comments on this change.
Change subject: virt: add kernel cmdline reporting
..
Patch Set 9:
* #1301104::Update tracker: OK
* Check Bug-Url::OK
* Check Public Bug::#1301104::OK, public bug
* Check
Francesco Romani has posted comments on this change.
Change subject: virt: add kernel cmdline reporting
..
Patch Set 8:
please rebase on top of gerrit to make jenkins happy.
--
To view, visit https://gerrit.ovirt.org/57084
Francesco Romani has posted comments on this change.
Change subject: virt: add kernel cmdline reporting
..
Patch Set 8: Code-Review+2
--
To view, visit https://gerrit.ovirt.org/57084
To unsubscribe, visit
Martin Polednik has posted comments on this change.
Change subject: virt: add kernel cmdline reporting
..
Patch Set 7:
(1 comment)
https://gerrit.ovirt.org/#/c/57084/7/vdsm/caps.py
File vdsm/caps.py:
Line 175:
Line 176:
Martin Polednik has posted comments on this change.
Change subject: virt: add kernel cmdline reporting
..
Patch Set 8: Verified+1
--
To view, visit https://gerrit.ovirt.org/57084
To unsubscribe, visit
Francesco Romani has posted comments on this change.
Change subject: virt: add kernel cmdline reporting
..
Patch Set 7: Code-Review+2
(1 comment)
looks ok, tested and very low risk. Silly comment inside. Taking ownership (+2
Martin Polednik has posted comments on this change.
Change subject: virt: add kernel cmdline reporting
..
Patch Set 7: Verified+1
jenkins unrelated
--
To view, visit https://gerrit.ovirt.org/57084
To unsubscribe, visit
Michal Skrivanek has posted comments on this change.
Change subject: virt: add kernel cmdline reporting
..
Patch Set 6: Code-Review+1
--
To view, visit https://gerrit.ovirt.org/57084
To unsubscribe, visit
gerrit-hooks has posted comments on this change.
Change subject: virt: add kernel cmdline reporting
..
Patch Set 6:
* #1301104::Update tracker: OK
* Check Bug-Url::OK
* Check Public Bug::#1301104::OK, public bug
* Check
Francesco Romani has posted comments on this change.
Change subject: virt: add kernel cmdline reporting
..
Patch Set 5: Code-Review+2
--
To view, visit https://gerrit.ovirt.org/57084
To unsubscribe, visit
gerrit-hooks has posted comments on this change.
Change subject: virt: add kernel cmdline reporting
..
Patch Set 5:
* #1301104::Update tracker: OK
* Check Bug-Url::OK
* Check Public Bug::#1301104::OK, public bug
* Check
Francesco Romani has posted comments on this change.
Change subject: virt: add kernel cmdline reporting
..
Patch Set 4: Code-Review-1
codewise fine, but you seem to miss the schema updates
--
To view, visit
gerrit-hooks has posted comments on this change.
Change subject: virt: add kernel cmdline reporting
..
Patch Set 4:
* #1301104::Update tracker: OK
* Check Bug-Url::OK
* Check Public Bug::#1301104::OK, public bug
* Check
Francesco Romani has posted comments on this change.
Change subject: virt: add kernel cmdline reporting
..
Patch Set 3: Code-Review+1
(1 comment)
looks ok, but please check the inline comments
gerrit-hooks has posted comments on this change.
Change subject: virt: add kernel cmdline reporting
..
Patch Set 3:
* #1301104::Update tracker: OK
* Check Bug-Url::OK
* Check Public Bug::#1301104::OK, public bug
* Check
Martin Polednik has posted comments on this change.
Change subject: virt: add kernel cmdline reporting
..
Patch Set 2:
(1 comment)
https://gerrit.ovirt.org/#/c/57084/2/tests/capsTests.py
File tests/capsTests.py:
PS2, Line
gerrit-hooks has posted comments on this change.
Change subject: virt: add kernel cmdline reporting
..
Patch Set 2:
* #1301104::Update tracker: OK
* Check Bug-Url::OK
* Check Public Bug::#1301104::OK, public bug
* Check
gerrit-hooks has posted comments on this change.
Change subject: virt: add kernel cmdline reporting
..
Patch Set 1:
* #1301104::Update tracker: OK
* Check Bug-Url::OK
* Check Public Bug::#1301104::OK, public bug
* Check
Martin Polednik has uploaded a new change for review.
Change subject: virt: add kernel cmdline reporting
..
virt: add kernel cmdline reporting
As we want to control kernel command line from ovirt, we need a way to
let users
39 matches
Mail list logo
